Re: [PATCH v8 06/14] alpha: Align prototypes of IO memcpy/memset

2024-10-08 Thread Richard Henderson
--- Changes for v8: - Mask the argument with 0xff because now it's an int and not a u8 anymore Reviewed-by: Richard Henderson r~ --- arch/alpha/include/asm/io.h | 6 ++ arch/alpha/kernel/io.c | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/alpha/in

Re: [PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-03 Thread Richard Henderson
On 9/30/24 06:23, Julian Vetter wrote: +void memset_io(volatile void __iomem *dst, int c, size_t count) +{ + uintptr_t qc = (u8)c; Missed one change to 'long' + + qc |= qc << 8; + qc |= qc << 16; + +#ifdef CONFIG_64BIT + qc |= qc << 32; +#endif Could be 'qc *= -1ul /

Re: [PATCH v7 07/10] parisc: Align prototypes of IO memcpy/memset

2024-10-03 Thread Richard Henderson
On 9/30/24 06:23, Julian Vetter wrote: -void memset_io(volatile void __iomem *addr, unsigned char val, int count) +void memset_io(volatile void __iomem *addr, int val, size_t count) { u32 val32 = (val << 24) | (val << 16) | (val << 8) | val; Mask of val now required. r~

Re: [PATCH v7 06/10] alpha: Align prototypes of IO memcpy/memset

2024-10-03 Thread Richard Henderson
On 9/30/24 06:23, Julian Vetter wrote: Align the prototypes of the memcpy_{from,to}io and memset_io functions with the new ones from iomap_copy.c and remove function declarations, because they are now declared in asm-generic/io.h. Reviewed-by: Yann Sionneau Signed-off-by: Julian Vetter --- Cha

Re: [patch 11/17] init: Remove check_bugs() leftovers

2023-06-13 Thread Richard Henderson
On 6/14/23 01:39, Thomas Gleixner wrote: Everything is converted over to arch_cpu_finalize_init(). Remove the check_bugs() leftovers including the empty stubs in asm-generic, alpha, parisc, powerpc and xtensa. Signed-off-by: Thomas Gleixner Cc: Richard Henderson Cc: "James E.J. Bottomle