um: Remove CONFIG_REISERFS_FS from defconfig

2023-09-23 Thread Peter Lafreniere
Jan said, you're free to not accept a patch removing the config option until the filesystem is gone for good. I just feel like it's easier to remove ReiserFS from all defconfigs in one fell swoop. Cheers, Peter Lafreniere ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH v6] um: Enable preemption in UML

2023-09-22 Thread Peter Lafreniere
On Fri, Sept 22, 2023 at 06:56, anton.iva...@cambridgegreys.com wrote: > > From: Anton Ivanov anton.iva...@cambridgegreys.com > > > 1. Preemption requires saving/restoring FPU state. This patch > adds support for it using GCC intrinsics as well as appropriate > storage space in the thread struct

Re: [PATCH v4] um: Enable preemption in UML

2023-09-21 Thread Peter Lafreniere
um/kernel/irq.c b/arch/um/kernel/irq.c > index 635d44606bfe..c02525da45df 100644 > --- a/arch/um/kernel/irq.c > +++ b/arch/um/kernel/irq.c > @@ -195,7 +195,9 @@ static void _sigio_handler(struct uml_pt_regs *regs, > > void sigio_handler(int sig, struct siginfo *unused_si, struct uml_pt_regs > *regs) > { > + preempt_disable(); > _sigio_handler(regs, irqs_suspended); > + preempt_enable(); > } > > static struct irq_entry *get_irq_entry_by_fd(int fd) > -- > 2.30.2 I'm happy with this as it is. The issue with AVX registers being clobbered when xsave isn't supported is unlikely to matter in practice, and can be fixed with a patch afterwards. Reviewed-by: Peter Lafreniere Cheers, Peter ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH v3] um: Enable preemption in UML

2023-09-21 Thread Peter Lafreniere
_kernel_fpu, false); > + > + preempt_enable(); > +} > +EXPORT_SYMBOL_GPL(kernel_fpu_end); > + > diff --git a/arch/um/kernel/irq.c b/arch/um/kernel/irq.c > index 635d44606bfe..c02525da45df 100644 > --- a/arch/um/kernel/irq.c > +++ b/arch/um/kernel/irq.c > @@ -195,7 +195,9

Re: [PATCH] um: Fix naming clash between UML and scheduler

2023-09-21 Thread Peter Lafreniere
long stack, sp; > int pid, status, err; > > - stack = alloc_stack(0, __cant_sleep()); > + stack = alloc_stack(0, __uml_cant_sleep()); > if (stack == 0) > return -ENOMEM; > > -- > 2.30.2 LGTM. Now we get to deal with the errors coming from config.debug Reviewed-by: Peter Lafreniere Cheers, ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH v2] um: Enable preemption in UML

2023-09-21 Thread Peter Lafreniere
On Thu, Sep 21, 2023 at 05:28, anton.iva...@cambridgegreys.com wrote: > > From: Anton Ivanov anton.iva...@cambridgegreys.com > > > Preemption requires saving/restoring FPU state. This patch > adds support for it using GCC intrinsics. > > Signed-off-by: Anton Ivanov anton.iva...@cambridgegreys.c

Re: [PATCH] um: Enable preemption in UML

2023-09-20 Thread Peter Lafreniere
mask registers. Please make that explicit in your comment, or replace intrinsics with inline assembler to support those registers. Several x86 crypto routines use these larger registers which could overwrite userspace registers. These modules aren't built by default, and may not be availabl

Re: [PATCH] um: Enable preemption in UML

2023-09-20 Thread Peter Lafreniere
mask registers. Please make that explicit in your comment, or replace intrinsics with inline assembler to support those registers. Several x86 crypto routines use these larger registers which could overwrite userspace registers. These modules aren't built by default, and may not be available on UML. Even so, this issue is worth a comment, at the least. On my system, lscpu within uml shows all the feature flags that are available on the host system, which includes AVX extentions. Cheers, Peter Lafreniere ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig

2023-09-19 Thread Peter Lafreniere
Hi Geert, On Tue, Sep 19, 2023 at 12:02, Geert Uytterhoeven wrote: > > Hi Peter, > > On Tue, Sep 19, 2023 at 5:58 PM Peter Lafreniere pe...@n8pjl.ca wrote: > > > 2) Stops building an obsolete and largely-unused filesystem unnecessarily. > > Some hobbyist targets lik

Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig

2023-09-19 Thread Peter Lafreniere
On Tue, Sep 19, 2023 at 11:16, Segher Boessenkool wrote: > > On Tue, Sep 19, 2023 at 12:00:34AM +, Peter Lafreniere wrote: > > > On Monday, September 18th, 2023 at 19:41, Segher Boessenkool > > seg...@kernel.crashing.org wrote: > > > > > On Mon, Sep

Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig

2023-09-18 Thread Peter Lafreniere
On Monday, September 18th, 2023 at 19:41, Segher Boessenkool wrote: > On Mon, Sep 18, 2023 at 05:56:09PM +0000, Peter Lafreniere wrote: > > > ReiserFS has been considered deprecated for 19 months since commit > > eb103a51640e ("reiserfs: Deprecate reiserfs"). Ho

[PATCH 1/7] arch: um: remove ReiserFS from defconfig

2023-09-18 Thread Peter Lafreniere
eprecation process. Signed-off-by: Peter Lafreniere Acked-by: Richard Weinberger --- arch/um/configs/i386_defconfig | 1 - arch/um/configs/x86_64_defconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/um/configs/i386_defconfig b/arch/um/configs/i386_defconfig index e543cbac8792..9c

[PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig

2023-09-18 Thread Peter Lafreniere
defconfig files before the filesystem's removal. The series is intended to be approved/rejected on an arch-by-arch basis. No patch is dependant upon another in the series. See discussion originating in, Link: https://lore.kernel.org/linux-um/20230918125744.4342-1-pe...@n8pjl.ca/ Peter Lafreni

Re: [PATCH RESEND] um: Remove CONFIG_REISERFS_FS from defconfig

2023-09-18 Thread Peter Lafreniere
Hi Geert, On Monday, September 18th, 2023 at 10:58, Geert Uytterhoeven wrote: > Hi Jan, > > On Mon, Sep 18, 2023 at 3:26 PM Jan Kara j...@suse.cz wrote: > > > On Mon 18-09-23 12:58:26, Peter Lafreniere wrote: > > > > > ReiserFS has been deprecated for a ye

Re: [PATCH RESEND] um: Remove CONFIG_REISERFS_FS from defconfig

2023-09-18 Thread Peter Lafreniere
On Monday, September 18th, 2023 at 09:26, Jan Kara wrote: > On Mon 18-09-23 12:58:26, Peter Lafreniere wrote: > > > ReiserFS has been deprecated for a year and a half, yet is still built > > as part of a defconfig UML kernel. > > > > According to commit eb10

Re: [PATCH RESEND] um: Remove CONFIG_REISERFS_FS from defconfig

2023-09-18 Thread Peter Lafreniere
On Monday, September 18th, 2023 at 09:26, Jan Kara wrote: > On Mon 18-09-23 12:58:26, Peter Lafreniere wrote: > > > ReiserFS has been deprecated for a year and a half, yet is still built > > as part of a defconfig UML kernel. > > > > According to commit eb10

[PATCH RESEND] um: Remove CONFIG_REISERFS_FS from defconfig

2023-09-18 Thread Peter Lafreniere
on process. Signed-off-by: Peter Lafreniere --- Fixed invalid DKIM settings causing the previous patch to be rejected. arch/um/configs/i386_defconfig | 1 - arch/um/configs/x86_64_defconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/um/configs/i386_defconfig b/arch/

[PATCH] um: Remove CONFIG_REISERFS_FS from defconfig

2023-09-10 Thread Peter Lafreniere
on process. Signed-off-by: Peter Lafreniere --- arch/um/configs/i386_defconfig | 1 - arch/um/configs/x86_64_defconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/um/configs/i386_defconfig b/arch/um/configs/i386_defconfig index e543cbac8792..9c9c77f1255a 100644 --- a/arch/