Re: [PATCH v4] um: vector: Fix exception handling in vector_eth_configure()

2023-07-06 Thread Markus Elfring
> The resource cleanup was incomplete in the implementation > of the function "vector_eth_configure". … > PATCH v1-v3: Modify the patch format. … Such a version description should usually be put into a comment area (patch changelog) after a marker line. See also: https://git.kernel.org/pub/scm/li

Re: [PATCH v4] um: vector: Fix exception handling in vector_eth_configure()

2023-07-06 Thread Markus Elfring
> Thus replace the jump target > "out_undo_user_init" by "out_free_netdev". Such text should be combined into a single line. (71 characters fit still into known wording constraints.) > Delate the orphan function "out_undo_user_init" Please avoid typos in such a sentence. * How helpful is the a

Re: [PATCH v3] um: vector: Replace undo_user_init in old code with out_free_netdev

2023-07-04 Thread Markus Elfring
> Thanks for your response and suggestions, > I made some mistakes. This is a resubmitted patch. You present a need for further improvements. > I got some errors with my local repository, > so I lost the commit SHA-1 ID. I wonder about such information here. > Fixes: ("drivers: use free_netde

Re: [PATCH v2] drivers: use free_netdev before return in vector_eth_configure()

2023-07-03 Thread Markus Elfring
Would the information “um: vector: …” be more appropriate for the subsystem specification in the patch subject? > We will replace the old version of > undo_user_init and use out_free_netdev Please choose a better imperative change suggestion. See also: https://git.kernel.org/pub/scm/linux/kern