Re: [PATCH 3/3] x86: avoid copying dynamic FP state from init_task

2025-02-26 Thread Ingo Molnar
* Benjamin Berg wrote: > > Note that this patch, while it still applies cleanly, crashes/hangs > > the x86-64 defconfig kernel bootup in the early boot phase in a KVM > > guest bootup. > > Oh, outch. It seems that arch_task_struct_size can actually become > smaller than sizeof(init_task) if

Re: [PATCH 3/3] x86: avoid copying dynamic FP state from init_task

2025-02-26 Thread Ingo Molnar
* Benjamin Berg wrote: > From: Benjamin Berg > > The init_task instance of struct task_struct is statically allocated and > may not contain the full FP state for userspace. As such, limit the copy > to the valid area of init_task and fill the rest with zero. > > Note that the FP state is onl

Re: Arches that don't support PREEMPT

2023-09-20 Thread Ingo Molnar
* Steven Rostedt wrote: > On Tue, 19 Sep 2023 20:31:50 +0200 > Thomas Gleixner wrote: > > > The removal of cond_resched() might cause latencies, but then I doubt > > that these museus pieces are used for real work :) > > We could simply leave the cond_resched() around but defined as nops for

Re: Arches that don't support PREEMPT

2023-09-20 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Tue, Sep 19 2023 at 10:25, Linus Torvalds wrote: > > On Tue, 19 Sept 2023 at 06:48, John Paul Adrian Glaubitz > > wrote: > >> > >> As Geert poined out, I'm not seeing anything particular problematic with > >> the > >> architectures lacking CONFIG_PREEMPT at the m

Re: [PATCH v2] x86: Fix build of UML with KASAN

2023-09-15 Thread Ingo Molnar
* Vincent Whitchurch wrote: > Building UML with KASAN fails since commit 69d4c0d32186 ("entry, kasan, > x86: Disallow overriding mem*() functions") with the following errors: > > $ tools/testing/kunit/kunit.py run --kconfig_add CONFIG_KASAN=y > ... > ld: mm/kasan/shadow.o: in function `mems

Re: [PATCH v2] asm goto: eradicate CC_HAS_ASM_GOTO

2022-08-21 Thread Ingo Molnar
; Suggested-by: Alexei Starovoitov > Signed-off-by: Nick Desaulniers Reviewed-by: Ingo Molnar Good riddance. Thanks, Ingo ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-27 Thread Ingo Molnar
arch/x86/mm/fault.c | 4 ++++ Reviewed-by: Ingo Molnar Minor comment typo: > + /* > + * We should do the same as VM_FAULT_RETRY, but let's not > + * return -EBUSY since that's not reflecting the reality on > +