Re: [PATCH vhost v2 0/4] refactor the params of find_vqs()

2024-03-11 Thread Ilpo Järvinen
te_virtqueue: pass struct instead of multi > parameters > virtio: vring_new_virtqueue(): pass struct instead of multi parameters > virtio_ring: simplify the parameters of the funcs related to > vring_create/new_virtqueue() FWIW, Reviewed-by: Ilpo Järvinen -- i.

Re: [PATCH vhost v1 2/4] virtio: vring_create_virtqueue: pass struct instead of multi parameters

2024-03-08 Thread Ilpo Järvinen
On Wed, 6 Mar 2024, Xuan Zhuo wrote: > Now, we pass multi parameters to vring_create_virtqueue. These parameters > may from transport or from driver. > > vring_create_virtqueue is called by many places. > Every time, we try to add a new parameter, that is difficult. > > If parameters from the dr

Re: [PATCH vhost 3/4] virtio: vring_new_virtqueue(): pass struct instead of multi parameters

2024-03-05 Thread Ilpo Järvinen
On Mon, 4 Mar 2024, Xuan Zhuo wrote: > Just like find_vqs(), it is time to refactor the > vring_new_virtqueue(). We pass the similar struct to > vring_new_virtqueue. Please write a proper commit message here and do not just refer to some other commit to describe what's going on here. -- i.

Re: [PATCH vhost 1/4] virtio: find_vqs: pass struct instead of multi parameters

2024-03-05 Thread Ilpo Järvinen
On Mon, 4 Mar 2024, Xuan Zhuo wrote: > Now, we pass multi parameters to find_vqs. These parameters > may work for transport or work for vring. > > And find_vqs has multi implements in many places: > > arch/um/drivers/virtio_uml.c > drivers/platform/mellanox/mlxbf-tmfifo.c > drivers/remoteproc

Re: [PATCH vhost 08/17] virtio: vring_new_virtqueue(): pass struct instead of multi parameters

2024-01-31 Thread Ilpo Järvinen
On Tue, 30 Jan 2024, Xuan Zhuo wrote: > Just like find_vqs(), it is time to refactor the > vring_new_virtqueue(). We pass the similar struct to > vring_new_virtqueue. > > Signed-off-by: Xuan Zhuo > --- > diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c > index 98ff808d6f0c..