Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-16 Thread Halil Pasic
vqi->name, vqi->ctx, ccw); > if (IS_ERR(vqs[i])) { > ret = PTR_ERR(vqs[i]); Acked-by: Halil Pasic #s390

Re: [PATCH vhost v7 4/6] virtio: vring_create_virtqueue: pass struct instead of multi parameters

2024-04-02 Thread Halil Pasic
now, we fail if we can't get the requested size. */ > dev_warn(&vcdev->cdev->dev, "no vq\n"); For the virtio-ccw part: Acked-by: Halil Pasic

Re: [PATCH vhost v7 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-04-02 Thread Halil Pasic
gt; - names[i], ctx ? ctx[i] : false, > - ccw); > + vqs[i] = virtio_ccw_setup_vq(vdev, i, ccw, cfg); > if (IS_ERR(vqs[i])) { > ret = PTR_ERR(vqs[i]); > vqs[i] = NULL; For the virtio-ccw part: Acked-by: Halil Pasic

Re: [PATCH vhost v7 2/6] virtio: remove support for names array entries being null.

2024-04-02 Thread Halil Pasic
} > > - vqs[i] = virtio_ccw_setup_vq(vdev, queue_idx++, callbacks[i], > + vqs[i] = virtio_ccw_setup_vq(vdev, i, callbacks[i], >names[i], ctx ? ctx[i] : false, > ccw); > if (IS_ERR(vqs[i])) { For the virtio-ccw part: Acked-by: Halil Pasic

Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

2024-02-20 Thread Halil Pasic
On Thu, 1 Feb 2024 11:00:42 +0800 Xuan Zhuo wrote: > > > And squish the parameters from transport to a structure. > > > > The patch did more than what is described here, it also switch to use > > a structure for vring_create_virtqueue() etc. > > > > Is it better to split? > > Sure. I unde