On Mon, May 16, 2022 at 8:07 AM Guilherme G. Piccoli
wrote:
>
> Thanks for the review!
>
> I agree with the blinking stuff, I can rework and add all LED/blinking
> stuff into the loop list, it does make sense. I'll comment a bit in the
> others below...
>
> On 16/05/2022 11:01, Petr Mladek wrote:
Hi Guilherme,
On Tue, May 3, 2022 at 12:12 PM Guilherme G. Piccoli
wrote:
>
> On 03/05/2022 15:03, Evan Green wrote:
> > [...]
> > gsmi_shutdown_reason() is a common function called in other scenarios
> > as well, like reboot and thermal trip, where it may still make sens
afer approach.
>
> Fixes: 74c5b31c6618 ("driver: Google EFI SMI")
> Cc: Ard Biesheuvel
> Cc: David Gow
> Cc: Evan Green
> Cc: Julius Werner
> Signed-off-by: Guilherme G. Piccoli
> ---
> drivers/firmware/google/gsmi.c | 6 +-
> 1 file changed, 5