Re: [PATCH 00/13] arch, mm: reduce code duplication in mem_init()

2025-03-06 Thread Dave Hansen
On 3/6/25 10:51, Mike Rapoport wrote: > 53 files changed, 151 insertions(+), 618 deletions(-) > delete mode 100644 arch/x86/include/asm/numa_32.h > delete mode 100644 arch/x86/mm/highmem_32.c Holy cow, nice work. For the x86 bits: Acked-by: Dave Hansen

Re: [PATCH 4/7] x86: Remove custom definition of mk_pte()

2025-02-19 Thread Dave Hansen
al(pgprot) & (_PAGE_DIRTY | _PAGE_RW)) == > + _PAGE_DIRTY); Looks sane to me. Good riddance to unnecessary arch-specific code. Acked-by: Dave Hansen Just one note (in case anyone ever trips over that WARN_ON_ONCE()): This is a problem with the existing code and with y

Re: [PATCH 00/10] Account page tables at all levels

2024-12-20 Thread Dave Hansen
On 12/20/24 02:58, Kevin Brodsky wrote: >> One super tiny nit is that the PAE pgd _can_ be allocated using >> __get_free_pages(). It was originally there for Xen, but I think it's >> being used for PTI only at this point and the comments are wrong-ish. >> >> I kinda think we should just get rid of

Re: [PATCH 00/10] Account page tables at all levels

2024-12-20 Thread Dave Hansen
On 12/20/24 02:58, Kevin Brodsky wrote: >> Acked-by: Dave Hansen > Just to double-check, are your ack'ing the x86 changes specifically? If > so I'll add your Acked-by on patch 6, 7 and 9. Feel free to add it to each patch in the series.

Re: [PATCH 00/10] Account page tables at all levels

2024-12-19 Thread Dave Hansen
d just fine in the generic one: Acked-by: Dave Hansen One super tiny nit is that the PAE pgd _can_ be allocated using __get_free_pages(). It was originally there for Xen, but I think it's being used for PTI only at this point and the comments are wrong-ish. I kinda think we should just get rid o