On Sat, Apr 05, 2025 at 06:09:11PM +0100, Sam James wrote:
> Sam James writes:
>
> > Lovely cleanup and a great suggestion from Al.
> >
> > Reviewed-by: Sam James
> >
> > I'd suggest adding a:
> > Suggested-by: Al Viro
>
> Al, were yo
On Wed, Feb 26, 2025 at 02:18:01PM +1100, NeilBrown wrote:
> Thanks. I'll submit a patch through the VFS tree as I have other VFS
> patches in the works that will depend on that so having them together
> would be good.
Do it on top of mainline, please (say, -rc4) and let's put it into
a separate
On Mon, Feb 24, 2025 at 01:26:18PM +1100, NeilBrown wrote:
> Probably now. It would require S_IFDIR to be passed in the mode to
> vfs_mknod(). I don't think any current callers do that, but I don't see
> any code in vfs_mknod() to prevent it.
Not allowed (and that's caller's responsibility to e
On Mon, Feb 24, 2025 at 12:34:06PM +1100, NeilBrown wrote:
> On Sat, 22 Feb 2025, Al Viro wrote:
> > On Fri, Feb 21, 2025 at 10:36:30AM +1100, NeilBrown wrote:
> >
> > > +In general, filesystems which use d_instantiate_new() to install the new
> > > +inode can
On Fri, Feb 21, 2025 at 10:36:30AM +1100, NeilBrown wrote:
> Not all filesystems reliably result in a positive hashed dentry:
>
> - NFS, cifs, hostfs will sometimes need to perform a lookup of
> the name to get inode information. Races could result in this
> returning something different. No
On Fri, Feb 21, 2025 at 10:36:34AM +1100, NeilBrown wrote:
> nfs3_proc_mkdir(struct inode *dir, struct dentry *dentry, struct iattr
> *sattr)
> {
> struct posix_acl *default_acl, *acl;
> @@ -612,15 +612,18 @@ nfs3_proc_mkdir(struct inode *dir, struct dentry
> *dentry, struct iattr *sattr
On Fri, Feb 21, 2025 at 10:36:30AM +1100, NeilBrown wrote:
> +In general, filesystems which use d_instantiate_new() to install the new
> +inode can safely return NULL. Filesystems which may not have an I_NEW inode
> +should use d_drop();d_splice_alias() and return the result of the latter.
IMO t
On Fri, Feb 21, 2025 at 10:36:33AM +1100, NeilBrown wrote:
> @@ -871,7 +870,12 @@ static int fuse_mknod(struct mnt_idmap *idmap, struct
> inode *dir,
> args.in_args[0].value = &inarg;
> args.in_args[1].size = entry->d_name.len + 1;
> args.in_args[1].value = entry->d_name.name;
>
uot;hostfs: Remove open coded strcpy()"
Signed-off-by: Al Viro
---
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 7e51d2cec64b..bd6503b73142 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -95,32 +95,17 @@ __uml_setup("hostfs=", hostfs_args,
s
On Wed, Jul 05, 2023 at 02:58:11PM -0400, Jeff Layton wrote:
> + * POSIX mandates that the old and new parent directories have their ctime
> and
> + * mtime updated, and that inodes of @old_dentry and @new_dentry (if any),
> have
> + * their ctime updated.
APPLICATION USAGE
Some implementations
On Thu, Jun 08, 2023 at 01:02:29PM +0200, Christoph Hellwig wrote:
> --- a/block/bdev.c
> +++ b/block/bdev.c
> @@ -683,9 +683,6 @@ static int blkdev_get_part(struct block_device *part,
> fmode_t mode)
> struct gendisk *disk = part->bd_disk;
> int ret;
>
> - if (atomic_read(&part
11 matches
Mail list logo
