Re: [PATCH 4/7] x86: Remove custom definition of mk_pte()

2025-02-19 Thread Dave Hansen
On 2/17/25 11:08, Matthew Wilcox (Oracle) wrote: > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 593f10aabd45..9f480bdafd20 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -784,6 +784,9 @@ static inline pgprotval_t che

Re: [PATCH v6 3/6] syscall.h: introduce syscall_set_nr()

2025-02-19 Thread Maciej W. Rozycki
On Mon, 17 Feb 2025, Dmitry V. Levin wrote: > diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h > index ea050b23d428..b956b015641c 100644 > --- a/arch/mips/include/asm/syscall.h > +++ b/arch/mips/include/asm/syscall.h > @@ -41,6 +41,20 @@ static inline long syscall_get

Re: [PATCH v6 2/6] syscall.h: add syscall_set_arguments()

2025-02-19 Thread Maciej W. Rozycki
On Mon, 17 Feb 2025, Dmitry V. Levin wrote: > This function is going to be needed on all HAVE_ARCH_TRACEHOOK > architectures to implement PTRACE_SET_SYSCALL_INFO API. > > This partially reverts commit 7962c2eddbfe ("arch: remove unused > function syscall_set_arguments()") by reusing some of old >

Re: [PATCH v2 1/1] mm: pgtable: fix pte_swp_exclusive

2025-02-19 Thread Sam James
Lovely cleanup and a great suggestion from Al. Reviewed-by: Sam James I'd suggest adding a: Suggested-by: Al Viro thanks, sam

Re: [PATCH 2/7] mm: Introduce a common definition of mk_pte()

2025-02-19 Thread Alexander Gordeev
On Mon, Feb 17, 2025 at 07:08:29PM +, Matthew Wilcox (Oracle) wrote: > Most architectures simply call pfn_pte(). Centralise that as the normal > definition and remove the definition of mk_pte() from the architectures > which have either that exact definition or something similar. > > Signed-o

Re: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty

2025-02-19 Thread Alexander Gordeev
> Reviewed-by: Alexander Gordeev Sorry, I meant for s390. Can not judge the other archs impact.