Re: [PATCH v2 6/6] mm: Introduce ctor/dtor at PGD level

2025-01-22 Thread Alexander Gordeev
On Wed, Jan 22, 2025 at 03:06:05PM +0100, Alexander Gordeev wrote: Hi Kevin, > On Wed, Jan 22, 2025 at 08:49:54AM +0100, Heiko Carstens wrote: > > > > static inline pgd_t *pgd_alloc(struct mm_struct *mm) > > > > { > > > > - return (pgd_t *) crst_table_alloc(mm); > > > > + unsigned l

Re: [PATCH v2 6/6] mm: Introduce ctor/dtor at PGD level

2025-01-22 Thread Alexander Gordeev
On Wed, Jan 22, 2025 at 08:49:54AM +0100, Heiko Carstens wrote: > > > static inline pgd_t *pgd_alloc(struct mm_struct *mm) > > > { > > > - return (pgd_t *) crst_table_alloc(mm); > > > + unsigned long *table = crst_table_alloc(mm); > > > + > > > + if (!table) > > > + return NULL; > > > >

Re: [PATCH v2 00/10] x86/module: rework ROX cache to avoid writable copy

2025-01-22 Thread Peter Zijlstra
On Tue, Jan 21, 2025 at 01:36:47PM +0100, Peter Zijlstra wrote: > On Tue, Jan 21, 2025 at 11:57:29AM +0200, Mike Rapoport wrote: > > > Kirill A. Shutemov (1): > > x86/mm/pat: restore large ROX pages after fragmentation > > The duplication between pmd and pud collapse is a bit annoying, but so >