Re: [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table

2025-01-02 Thread Kevin Brodsky
On 03/01/2025 04:53, Qi Zheng wrote: > On 2025/1/3 00:53, Kevin Brodsky wrote: >> On 30/12/2024 10:07, Qi Zheng wrote: >>> diff --git a/arch/riscv/include/asm/pgalloc.h >>> b/arch/riscv/include/asm/pgalloc.h >>> index 551d614d3369c..3466fbe2e508d 100644 >>> --- a/arch/riscv/include/asm/pgalloc.h >>

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-02 Thread Jürgen Groß
On 03.01.25 03:06, Andrew Cooper wrote: Hi Mike, This commit is making my intel box not boot in mm-unstable :>) I bisected it to this commit. For what it's worth, we've found the same under Xen too. There's one concrete bug in the series, failing to cope with the absence of superpages (fix in

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-02 Thread Andrew Morton
On Fri, 3 Jan 2025 02:06:10 + Andrew Cooper wrote: > > Hi Mike, > > > > This commit is making my intel box not boot in mm-unstable :>) I bisected > > it to > > this commit. > > For what it's worth, we've found the same under Xen too. > > There's one concrete bug in the series, failing to

Re: [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table()

2025-01-02 Thread Qi Zheng
On 2025/1/3 01:00, Kevin Brodsky wrote: On 30/12/2024 10:07, Qi Zheng wrote: Qi Zheng (13): Revert "mm: pgtable: make ptlock be freed by RCU" mm: pgtable: add statistics for P4D level page table arm64: pgtable: use mmu gather to free p4d level page table s390: pgtable: add statist

Re: [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table

2025-01-02 Thread Qi Zheng
On 2025/1/3 00:53, Kevin Brodsky wrote: On 30/12/2024 10:07, Qi Zheng wrote: diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h index 551d614d3369c..3466fbe2e508d 100644 --- a/arch/riscv/include/asm/pgalloc.h +++ b/arch/riscv/include/asm/pgalloc.h @@ -108,8 +108,

Re: [PATCH v4 10/15] riscv: pgtable: move pagetable_dtor() to __tlb_remove_table()

2025-01-02 Thread Qi Zheng
Hi Kevin, On 2025/1/3 00:53, Kevin Brodsky wrote: On 30/12/2024 10:07, Qi Zheng wrote: static inline void riscv_tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) { - if (riscv_use_sbi_for_rfence()) + if (riscv_use_sbi_for_rfence()) { tlb_remove_ptdesc(tlb, pt);

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-02 Thread Andrew Cooper
> Hi Mike, > > This commit is making my intel box not boot in mm-unstable :>) I bisected it > to > this commit. For what it's worth, we've found the same under Xen too. There's one concrete bug in the series, failing to cope with the absence of superpages (fix in https://lore.kernel.org/xen-deve

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-02 Thread Lorenzo Stoakes
Hi Mike, This commit is making my intel box not boot in mm-unstable :>) I bisected it to this commit. It seems to be having an unhandled kernel page fault on exec, so I guess not actually making it exec somehow? It is a pretty standard intel machine (arch linux config, slightly scaled down via m

Re: [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table()

2025-01-02 Thread Kevin Brodsky
On 30/12/2024 10:07, Qi Zheng wrote: > Qi Zheng (13): > Revert "mm: pgtable: make ptlock be freed by RCU" > mm: pgtable: add statistics for P4D level page table > arm64: pgtable: use mmu gather to free p4d level page table > s390: pgtable: add statistics for PUD and P4D level page table >

Re: [PATCH v4 10/15] riscv: pgtable: move pagetable_dtor() to __tlb_remove_table()

2025-01-02 Thread Kevin Brodsky
On 30/12/2024 10:07, Qi Zheng wrote: > static inline void riscv_tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) > { > - if (riscv_use_sbi_for_rfence()) > + if (riscv_use_sbi_for_rfence()) { > tlb_remove_ptdesc(tlb, pt); > - else > + } else { > + paget

Re: [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table

2025-01-02 Thread Kevin Brodsky
On 30/12/2024 10:07, Qi Zheng wrote: > diff --git a/arch/riscv/include/asm/pgalloc.h > b/arch/riscv/include/asm/pgalloc.h > index 551d614d3369c..3466fbe2e508d 100644 > --- a/arch/riscv/include/asm/pgalloc.h > +++ b/arch/riscv/include/asm/pgalloc.h > @@ -108,8 +108,12 @@ static inline void __pud_fr