Re: [PATCH] mm/memblock: Add memblock_alloc_or_panic interface

2024-12-20 Thread Andrew Morton
On Fri, 20 Dec 2024 17:26:38 +0800 Guo Weikang wrote: > Before SLUB initialization, various subsystems used memblock_alloc to > allocate memory. In most cases, when memory allocation fails, an immediate > panic is required. To simplify this behavior and reduce repetitive checks, > introduce `mem

Re: [PATCH 00/10] Account page tables at all levels

2024-12-20 Thread Dave Hansen
this together yesterday: > https://git.kernel.org/pub/scm/linux/kernel/git/daveh/devel.git/log/?h=simplify-pae-20241220 It definitely needs some more work. I'm particularly still puzzling about why SHARED_KERNEL_PMD is used both as a trigger for 32b vs. PAGE_SIZE PAE pgd allocations _and

Re: [PATCH 00/10] Account page tables at all levels

2024-12-20 Thread Dave Hansen
On 12/20/24 02:58, Kevin Brodsky wrote: >> Acked-by: Dave Hansen > Just to double-check, are your ack'ing the x86 changes specifically? If > so I'll add your Acked-by on patch 6, 7 and 9. Feel free to add it to each patch in the series.

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Qi Zheng
On 2024/12/20 22:28, Kevin Brodsky wrote: On 20/12/2024 15:16, Qi Zheng wrote: Did I miss something? My patch series is not only for cleanup, but also for fixes of UAF issue [1], so is it possible to rebase your patch series onto mine? I can post v3 ASAP. I see, yours should be merged fir

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Kevin Brodsky
On 20/12/2024 15:16, Qi Zheng wrote: >>> >>> Did I miss something? >>> >>> My patch series is not only for cleanup, but also for fixes of >>> UAF issue [1], so is it possible to rebase your patch series onto >>> mine? I can post v3 ASAP. >> >> I see, yours should be merged first then. The issue is

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Qi Zheng
On 2024/12/20 21:50, Kevin Brodsky wrote: On 20/12/2024 12:46, Qi Zheng wrote: Hi Kevin, On 2024/12/20 18:49, Kevin Brodsky wrote: [...] Qi, shall we collaborate to make our series complementary? I believe my series covers patch 2 and 4 of your series, but it goes further by covering all l

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Kevin Brodsky
On 20/12/2024 12:46, Qi Zheng wrote: > Hi Kevin, > > On 2024/12/20 18:49, Kevin Brodsky wrote: >> [...] >> >> Qi, shall we collaborate to make our series complementary? I believe my >> series covers patch 2 and 4 of your series, but it goes further by >> covering all levels and all architectures, a

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Qi Zheng
Hi Kevin, On 2024/12/20 18:49, Kevin Brodsky wrote: Hi Peter, Qi, On 19/12/2024 18:19, Peter Zijlstra wrote: On Thu, Dec 19, 2024 at 04:44:16PM +, Kevin Brodsky wrote: Besides the ptlock management at PTE/PMD level, all the pagetable_*_[cd]tor have the same implementation. Introduce commo

Re: [PATCH 00/10] Account page tables at all levels

2024-12-20 Thread Kevin Brodsky
On 19/12/2024 18:13, Dave Hansen wrote: > On 12/19/24 08:44, Kevin Brodsky wrote: >> >> +---+-+---+--++ >> | x86 | Y | Y | Y/N >>

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Kevin Brodsky
Hi Peter, Qi, On 19/12/2024 18:19, Peter Zijlstra wrote: > On Thu, Dec 19, 2024 at 04:44:16PM +, Kevin Brodsky wrote: >> Besides the ptlock management at PTE/PMD level, all the >> pagetable_*_[cd]tor have the same implementation. Introduce common >> helpers for all levels to reduce the duplica

[PATCH] mm/memblock: Add memblock_alloc_or_panic interface

2024-12-20 Thread Guo Weikang
Before SLUB initialization, various subsystems used memblock_alloc to allocate memory. In most cases, when memory allocation fails, an immediate panic is required. To simplify this behavior and reduce repetitive checks, introduce `memblock_alloc_or_panic`. This function ensures that memory allocati