Re: [PATCH v7 6/8] x86/module: prepare module loading for ROX allocations of text

2024-11-04 Thread Mike Rapoport
nd I > did not notice I was not actually testing a -next kernel. > > Checking out the version of this change that is in next-20241104, commit > 7ca6ed09db62 ("x86/module: prepare module loading for ROX allocations of > text"), it boots with either 'cfi=off&#

Re: [PATCH] um: move thread info into task

2024-11-04 Thread Hajime Tazaki
On Mon, 04 Nov 2024 17:17:05 +0900, Berg, Benjamin wrote: > > with this include, I guess is now in a > > circular dependency. > > > > after only applying this patch onto uml/next, and make mrproper > > ARCH=um, I cannot build UML kernel with defconfig. > > Oh. Probably the easiest is to just

Re: [PATCH v7 6/8] x86/module: prepare module loading for ROX allocations of text

2024-11-04 Thread Nathan Chancellor
d reporting this earlier, as my machine was falling back to the default distribution kernel after the restart and I did not notice I was not actually testing a -next kernel. Checking out the version of this change that is in next-20241104, commit 7ca6ed09db62 ("x86/module: prepare module load

Re: [PATCH 4/4] um: vector: Do not use drvdata in release

2024-11-04 Thread Anton Ivanov
On 04/11/2024 16:32, Tiwei Bie wrote: The drvdata is not available in release. Let's just use container_of() to get the vector_device instance. Otherwise, removing a vector device will result in a crash: RIP: 0033:vector_device_release+0xf/0x50 RSP: e187bc40 EFLAGS: 00010202 RAX: 000

Re: [PATCH 2/4] um: ubd: Do not use drvdata in release

2024-11-04 Thread Anton Ivanov
On 04/11/2024 16:32, Tiwei Bie wrote: The drvdata is not available in release. Let's just use container_of() to get the ubd instance. Otherwise, removing a ubd device will result in a crash: RIP: 0033:blk_mq_free_tag_set+0x1f/0xba RSP: e2083bf0 EFLAGS: 00010246 RAX: 6021463a

Re: [PATCH 1/4] um: ubd: Initialize ubd's disk pointer in ubd_add

2024-11-04 Thread Anton Ivanov
On 04/11/2024 16:32, Tiwei Bie wrote: Currently, the initialization of the disk pointer in the ubd structure is missing. It should be initialized with the allocated gendisk pointer in ubd_add(). Fixes: 32621ad7a7ea ("ubd: remove the ubd_gendisk array") Signed-off-by: Tiwei Bie --- arch/um/

Re: [PATCH 3/4] um: net: Do not use drvdata in release

2024-11-04 Thread Anton Ivanov
On 04/11/2024 16:32, Tiwei Bie wrote: The drvdata is not available in release. Let's just use container_of() to get the uml_net instance. Otherwise, removing a network device will result in a crash: RIP: 0033:net_device_release+0x10/0x6f RSP: e20c7c40 EFLAGS: 00010206 RAX: 60

[PATCH 0/4] um: Some minor driver fixes

2024-11-04 Thread Tiwei Bie
Tiwei Bie (4): um: ubd: Initialize ubd's disk pointer in ubd_add um: ubd: Do not use drvdata in release um: net: Do not use drvdata in release um: vector: Do not use drvdata in release arch/um/drivers/net_kern.c| 2 +- arch/um/drivers/ubd_kern.c| 4 +++- arch/um/drivers/vector_ker

[PATCH 2/4] um: ubd: Do not use drvdata in release

2024-11-04 Thread Tiwei Bie
The drvdata is not available in release. Let's just use container_of() to get the ubd instance. Otherwise, removing a ubd device will result in a crash: RIP: 0033:blk_mq_free_tag_set+0x1f/0xba RSP: e2083bf0 EFLAGS: 00010246 RAX: 6021463a RBX: 0348 RCX: 62604d00

[PATCH 3/4] um: net: Do not use drvdata in release

2024-11-04 Thread Tiwei Bie
The drvdata is not available in release. Let's just use container_of() to get the uml_net instance. Otherwise, removing a network device will result in a crash: RIP: 0033:net_device_release+0x10/0x6f RSP: e20c7c40 EFLAGS: 00010206 RAX: 6002e4e7 RBX: 600f1baf RCX: 6

[PATCH 4/4] um: vector: Do not use drvdata in release

2024-11-04 Thread Tiwei Bie
The drvdata is not available in release. Let's just use container_of() to get the vector_device instance. Otherwise, removing a vector device will result in a crash: RIP: 0033:vector_device_release+0xf/0x50 RSP: e187bc40 EFLAGS: 00010202 RAX: 60028f61 RBX: 600f1baf RCX: 00

[PATCH 1/4] um: ubd: Initialize ubd's disk pointer in ubd_add

2024-11-04 Thread Tiwei Bie
Currently, the initialization of the disk pointer in the ubd structure is missing. It should be initialized with the allocated gendisk pointer in ubd_add(). Fixes: 32621ad7a7ea ("ubd: remove the ubd_gendisk array") Signed-off-by: Tiwei Bie --- arch/um/drivers/ubd_kern.c | 2 ++ 1 file changed, 2

[PATCH] hostfs: Fix the NULL vs IS_ERR() bug for __filemap_get_folio()

2024-11-04 Thread Peng Zhang
From: ZhangPeng The __filemap_get_folio() function returns error pointers. It never returns NULL. So use IS_ERR() to check it. Fixes: 1da86618bdce ("fs: Convert aops->write_begin to take a folio") Signed-off-by: ZhangPeng --- fs/hostfs/hostfs_kern.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] um: move thread info into task

2024-11-04 Thread Berg, Benjamin
Hi, On Mon, 2024-11-04 at 17:08 +0900, Hajime Tazaki wrote: > this is a great clean up I think. > I've also applied my tentative nommu patch and works fine with minor > modifications. > > On Mon, 04 Nov 2024 00:05:34 +0900, > Benjamin Berg wrote: > > > diff --git a/arch/um/include/asm/current.h

Re: [PATCH] um: move thread info into task

2024-11-04 Thread Hajime Tazaki
Hello, this is a great clean up I think. I've also applied my tentative nommu patch and works fine with minor modifications. On Mon, 04 Nov 2024 00:05:34 +0900, Benjamin Berg wrote: > diff --git a/arch/um/include/asm/current.h b/arch/um/include/asm/current.h > new file mode 100644 > index 000