On 2024-10-03 18:29, Nathan Chancellor wrote:
> ...
>>> I was able to successfully build that same configuration and setup with
>>> my primary workstation, which is much beefier. Unfortunately, the
>>> resulting kernel did not boot with my usual VM testing setup. I will see
>>> if I can narrow down
On 10/8/24 00:50, Julian Vetter wrote:
Align the prototypes of the memcpy_{from,to}io and memset_io functions
with the new ones from iomap_copy.c and remove function declarations,
because they are now declared in asm-generic/io.h.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Cha
On Tue, 2024-10-08 at 09:50 +0200, Julian Vetter wrote:
> Add wrapper functions around zpci_memcpy_{from,to}io and zpci_memset_io,
> which have aligned prototypes with the ones from iomap_copy.c. These
> wrappers are necessary because the prototypes of the zpci_ functions
> can't be changed. In s39
On Tue, Oct 8, 2024, at 11:46, Christoph Hellwig wrote:
> On Tue, Oct 08, 2024 at 09:50:09AM +0200, Julian Vetter wrote:
>> lib/iomap_copy.c | 127 +++
>
> On top of the previous comments: this really should be iomem_copy.c
> instead.
Right, I suggested
On Tue, Oct 08, 2024 at 09:50:09AM +0200, Julian Vetter wrote:
> lib/iomap_copy.c | 127 +++
On top of the previous comments: this really should be iomem_copy.c
instead.
On Tue, Oct 08, 2024 at 09:27:20AM +, Arnd Bergmann wrote:
> > #endif /* CONFIG_TRACE_MMIO_ACCESS */
> >
> > +extern void memcpy_fromio(void *to, const volatile void __iomem *from,
> > + size_t count);
> > +extern void memcpy_toio(volatile void __iomem *to, const void *fro
On Tue, Oct 8, 2024, at 07:50, Julian Vetter wrote:
> diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
> index 80de699bf6af..f14655ed4d9d 100644
> --- a/include/asm-generic/io.h
> +++ b/include/asm-generic/io.h
> @@ -102,6 +102,12 @@ static inline void log_post_read_mmio(u64 val, u8
Align the prototypes of the memcpy_{from,to}io and memset_io functions
with the new ones from iomap_copy.c and remove function declarations,
because they are now declared in asm-generic/io.h.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- Mask the argument with 0xf
The UM arch doesn't have HAS_IOMEM=y, so the build fails because the
functions memcpy_fromio and memcpy_toio are not defined anymore. These
functions are only build for targets which have HAS_IOMEM=y or
INDIRECT_IOMEM=y. So, depend on either of the two.
Reviewed-by: Yann Sionneau
Signed-off-by: J
When building for the UM arch and neither INDIRECT_IOMEM=y, nor
HAS_IOMEM=y is selected, the build fails because the memcpy_fromio and
memcpy_toio functions are not defined. Fix it here by depending on
HAS_IOMEM or INDIRECT_IOMEM.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Chang
Align the prototypes of the memcpy_{from,to}io and memset_io functions
with the new ones from iomap_copy.c.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- New patch
---
arch/powerpc/include/asm/io-defs.h | 6 +++---
arch/powerpc/include/asm/io.h | 6 +++---
a
The symbol MHI_BUS_EP neither depends on HAS_IOMEM, nor on
INDIRECT_IOMEM. But, the function mhi_ep_ring_num_elems in
drivers/bus/mhi/ep/ring.c is using a IO memcpy operation. So, when
building for UM which doesn't have CONFIG_HAS_IOMEM=y, the build fails.
Reviewed-by: Yann Sionneau
Signed-off-by
Add wrapper functions around zpci_memcpy_{from,to}io and zpci_memset_io,
which have aligned prototypes with the ones from iomap_copy.c. These
wrappers are necessary because the prototypes of the zpci_ functions
can't be changed. In s390 arch code they are directly being called and
the return value
Hi Julian,
jvet...@kalrayinc.com wrote on Tue, 8 Oct 2024 09:50:21 +0200:
> The UM arch doesn't have HAS_IOMEM=y, so the build fails because the
> functions memcpy_fromio and memcpy_toio are not defined anymore. These
> functions are only build for targets which have HAS_IOMEM=y or
> INDIRECT_IO
On Tue, 08 Oct 2024 09:50:22 +0200,
Julian Vetter wrote:
>
> When building for the UM arch and neither INDIRECT_IOMEM=y, nor
> HAS_IOMEM=y is selected, the build fails because the memcpy_fromio and
> memcpy_toio functions are not defined. Fix it here by depending on
> HAS_IOMEM or INDIRECT_IOMEM.
Align the prototypes of the memcpy_{from,to}io and memset_io functions
with the new ones from iomap_copy.c and remove function declarations,
because they are now declared in asm-generic/io.h.
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for
Align prototype of the memset_io function with the new one from
iomap_copy.c
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- No changes
---
arch/arm/include/asm/io.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Align the prototypes of the memcpy_{from,to}io and memset_io functions
with the new ones from iomap_copy.c and remove function declarations,
because they are now declared in asm-generic/io.h.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- Mask the argument with 0xf
Use the generic memcpy_{from,to}io and memset_io functions on the
loongarch processor architecture.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- No changes
---
arch/loongarch/include/asm/io.h | 10
arch/loongarch/kernel/Makefile | 2 +-
arch/loongarch/ker
Align the prototypes of the memcpy_{from,to}io and memset_io functions
with the new ones from iomap_copy.c.
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- No changes
---
arch/m68k/include/asm/kmap.h | 8
1 file changed, 4
Use the generic memcpy_{from,to}io and memset_io functions on the csky
processor architecture.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- No changes
---
arch/csky/include/asm/io.h | 11 -
arch/csky/kernel/Makefile | 2 +-
arch/csky/kernel/io.c | 91
Various architectures have almost the same implementations for
memcpy_{to,from}io and memset_io functions. So, consolidate them
into the existing lib/iomap_copy.c.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- Replaced shifts by 'qc *= ~0UL / 0xff'
- Modification
New patch set with all remarks taken into account.
Thank you Richard and David. I have masked the int with 0xff for alpha
and parisc, and I have replaced the shift operation by the
multiplication as you proposed.
Thank you Johannes for your remarks on the UM arch. Finally, I have
created an UM al
Use the generic memcpy_{from,to}io and memset_io functions on the
arm64 processor architecture.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Changes for v8:
- No changes
---
arch/arm64/include/asm/io.h | 11 -
arch/arm64/kernel/io.c | 87 -
24 matches
Mail list logo
