On 9/30/24 06:23, Julian Vetter wrote:
+void memset_io(volatile void __iomem *dst, int c, size_t count)
+{
+ uintptr_t qc = (u8)c;
Missed one change to 'long'
+
+ qc |= qc << 8;
+ qc |= qc << 16;
+
+#ifdef CONFIG_64BIT
+ qc |= qc << 32;
+#endif
Could be 'qc *= -1ul /
On 9/30/24 06:23, Julian Vetter wrote:
-void memset_io(volatile void __iomem *addr, unsigned char val, int count)
+void memset_io(volatile void __iomem *addr, int val, size_t count)
{
u32 val32 = (val << 24) | (val << 16) | (val << 8) | val;
Mask of val now required.
r~
On 9/30/24 06:23, Julian Vetter wrote:
Align the prototypes of the memcpy_{from,to}io and memset_io functions
with the new ones from iomap_copy.c and remove function declarations,
because they are now declared in asm-generic/io.h.
Reviewed-by: Yann Sionneau
Signed-off-by: Julian Vetter
---
Cha
