Re: [PATCH v2 0/4] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang

2024-10-01 Thread Wentao Zhang
Hi Nathan, Thanks for all the comments! On 2024-10-01 23:53, Nathan Chancellor wrote: > Hi Wentao, > > I took this series for a spin on next-20241001 with LLVM 19.1.0 using a > distribution configuration tailored for a local development VM using > QEMU. You'll notice on the

Re: [PATCH v2 0/4] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang

2024-10-01 Thread Nathan Chancellor
Hi Wentao, I took this series for a spin on next-20241001 with LLVM 19.1.0 using a distribution configuration tailored for a local development VM using QEMU. You'll notice on the rebase for 6.12-rc1 but there is a small conflict in kernel/Makefile due to commit 0e8b67982b48 ("mm: m

Re: [PATCH v2 2/4] llvm-cov: add Clang's MC/DC support

2024-10-01 Thread Nathan Chancellor
Hi Wentao, On Wed, Sep 04, 2024 at 11:32:43PM -0500, Wentao Zhang wrote: > Add infrastructure to enable Clang's Modified Condition/Decision Coverage > (MC/DC) [1]. > > Clang has added MC/DC support as of its 18.1.0 release. MC/DC is a fine- > grained coverage metric required by many automotive an

Re: [PATCH v2 4/4] x86: enable llvm-cov support

2024-10-01 Thread Nathan Chancellor
On Wed, Sep 04, 2024 at 11:32:45PM -0500, Wentao Zhang wrote: > Set ARCH_HAS_* options to "y" in kconfig and include section description in Is description the right word here? Maybe "include the compiler generated sections"? Open to other suggestions. > linker script. > > Signed-off-by: Wentao Z

Re: [PATCH v2 3/4] x86: disable llvm-cov instrumentation

2024-10-01 Thread Nathan Chancellor
On Wed, Sep 04, 2024 at 11:32:44PM -0500, Wentao Zhang wrote: > Disable instrumentation for arch/x86/crypto/curve25519-x86_64.c. Otherwise > compilation would fail with "error: inline assembly requires more registers > than available". > > Similar behavior was reported with gcov as well. See c390c

Re: [PATCH v2 1/4] llvm-cov: add Clang's Source-based Code Coverage support

2024-10-01 Thread Nathan Chancellor
Hi Wentao, On Wed, Sep 04, 2024 at 11:32:42PM -0500, Wentao Zhang wrote: > Add infrastructure to support Clang's source-based code coverage [1]. This > includes debugfs entries for serializing profiles and resetting > counters/bitmaps. Also adds coverage flags and kconfig options. Some superfici

Re: [PATCH v7 09/10] um: Add dummy implementation for IO memcpy/memset

2024-10-01 Thread Johannes Berg
On Mon, 2024-09-30 at 15:23 +0200, Julian Vetter wrote: > The um arch is the only architecture that sets the config 'NO_IOMEM', > yet drivers that use IO memory can be selected. In order to make these > drivers happy we add a dummy implementation for memcpy_{from,to}io and > memset_io functions. M

Re: [PATCH v7 00/10] Consolidate IO memcpy functions

2024-10-01 Thread Niklas Schnelle
On Mon, 2024-09-30 at 15:23 +0200, Julian Vetter wrote: > Thank you all for your remarks. I have addressed your feedback. I have > also added the full history of the patchset, because it now targets > additional architectures. > > Arnd: Unfortunately when adding the prototypes as 'extern ..' into