Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

Linus Torvalds writes: > On Mon, 19 Aug 2024 at 13:15, Linus Torvalds > wrote: >> >> Ok, I did a quick hack-job to remove that disgusting >> install_special_mapping() legacy case. >> >> With this [..] > > I forgot to actually attach that "this". Here it is. For real, this time. > >

[PATCH -next] hostfs: Convert hostfs_writepage to use folio

convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1]: https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Li Zetao --- fs/hostfs/hostfs_kern.c | 13 +++-- 1 file

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

On Mon, 19 Aug 2024 at 18:05, Andrew Morton wrote: > > > > > I forgot to actually attach that "this". Here it is. For real, this time. > > Thanks. Do you think your one-liner remains desirable with this fix in > place? That patch actually removes the whole 'legacy_special_mapping_vmops' that my

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

On Mon, 19 Aug 2024 13:16:32 -0700 Linus Torvalds wrote: > On Mon, 19 Aug 2024 at 13:15, Linus Torvalds > wrote: > > > > Ok, I did a quick hack-job to remove that disgusting > > install_special_mapping() legacy case. > > > > With this [..] > > I forgot to actually attach that "this". Here it i

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

On Mon, 19 Aug 2024 at 13:15, Linus Torvalds wrote: > > Ok, I did a quick hack-job to remove that disgusting > install_special_mapping() legacy case. > > With this [..] I forgot to actually attach that "this". Here it is. For real, this time. Linus arch/csky/kernel/vdso.c

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

On Mon, 19 Aug 2024 at 12:51, Nathan Chancellor wrote: > > Yes, that appears to fix it for me. I don't have much to say about the > rest but others might :) Ok, I did a quick hack-job to remove that disgusting install_special_mapping() legacy case. With this, the old "install_special_mapping()"

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

On Mon, Aug 19, 2024 at 12:29:34PM -0700, Linus Torvalds wrote: > On Mon, 19 Aug 2024 at 11:53, Nathan Chancellor wrote: > > > > > > Modules linked in: > > Pid: 24, comm: mount Not tainted 6.11.0-rc4-next-20240819 > > RIP: 0033:0x68006f6c > > RSP: 000

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

On Mon, 19 Aug 2024 at 11:53, Nathan Chancellor wrote: > > > Modules linked in: > Pid: 24, comm: mount Not tainted 6.11.0-rc4-next-20240819 > RIP: 0033:0x68006f6c > RSP: 6c8bfc68 EFLAGS: 00010206 > RAX: 68006f6c RBX: 68a0aa18 RCX: 600d8b09 &g

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

) > { > + const struct vm_special_mapping *sm = vma->vm_private_data; > + > + if (sm->close) > + sm->close(sm, vma); > } > > static const char *special_mapping_name(struct vm_area_struct *vma) > -- > 2.45.2 > This change is

Re: [PATCH] um: make personality(PER_LINUX32) work on x86_64

On Mon, Aug 19, 2024 at 5:23 AM Johannes Berg wrote: > > On Tue, 2024-08-13 at 16:47 -0700, Maciej Żenczykowski wrote: > > Without this patch: > > #!/usr/bin/python3 > > import ctypes > > import os > > personality = ctypes.CDLL(None).personality > > personality.restype = ctypes.c_int > >

Re: [PATCH] um: make personality(PER_LINUX32) work on x86_64

On Tue, 2024-08-13 at 16:47 -0700, Maciej Żenczykowski wrote: > Without this patch: > #!/usr/bin/python3 > import ctypes > import os > personality = ctypes.CDLL(None).personality > personality.restype = ctypes.c_int > personality.argtypes = [ctypes.c_ulong] > PER_LINUX32=8 > persona