Re: [PATCH v2 25/25] sound: virtio: drop owner assignment

2024-04-01 Thread Anton Yakovlev
Hi Krzysztof, On 31.03.2024 10:44, Krzysztof Kozlowski wrote: virtio core already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Anton Yakovlev --- Depends on the first patch. --- sound/virtio/virtio_card.c | 1 - 1 file changed, 1 deletion(

Re: [PATCH vhost v7 0/6] refactor the params of find_vqs()

2024-04-01 Thread Eric Farman
On Thu, 2024-03-28 at 16:03 +0800, Xuan Zhuo wrote: > This pathset is splited from the > > > http://lore.kernel.org/all/20240229072044.77388-1-xuanz...@linux.alibaba.com > > That may needs some cycles to discuss. But that notifies too many > people. This will need to be rebased to 6.9; ther

Re: [PATCH vhost v7 4/6] virtio: vring_create_virtqueue: pass struct instead of multi parameters

2024-04-01 Thread Eric Farman
On Thu, 2024-03-28 at 16:03 +0800, Xuan Zhuo wrote: > Now, we pass multi parameters to vring_create_virtqueue. These > parameters > may from transport or from driver. > > vring_create_virtqueue is called by many places. > Every time, we try to add a new parameter, that is difficult. > > If parame

Re: [PATCH vhost v7 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-04-01 Thread Eric Farman
On Thu, 2024-03-28 at 16:03 +0800, Xuan Zhuo wrote: > Now, we pass multi parameters to find_vqs. These parameters > may work for transport or work for vring. > > And find_vqs has multi implements in many places: > >  arch/um/drivers/virtio_uml.c >  drivers/platform/mellanox/mlxbf-tmfifo.c >  driv

Re: [PATCH vhost v7 2/6] virtio: remove support for names array entries being null.

2024-04-01 Thread Eric Farman
On Thu, 2024-03-28 at 16:03 +0800, Xuan Zhuo wrote: > commit 6457f126c888 ("virtio: support reserved vqs") introduced this > support. Multiqueue virtio-net use 2N as ctrl vq finally, so the > logic > doesn't apply. And not one uses this. > > On the other side, that makes some trouble for us to ref

Re: [PATCH v8] um: Enable preemption in UML

2024-04-01 Thread Anton Ivanov
On 01/04/2024 12:04, Tiwei Bie wrote: On 3/29/24 3:50 AM, anton.iva...@cambridgegreys.com wrote: [...] + +void kernel_fpu_begin(void) +{ + preempt_disable(); + + WARN_ON(this_cpu_read(in_kernel_fpu)); + + this_cpu_write(in_kernel_fpu, true); + +#ifdef CONFIG_64BIT + if (l

Re: [PATCH v8] um: Enable preemption in UML

2024-04-01 Thread Tiwei Bie
On 3/29/24 3:50 AM, anton.iva...@cambridgegreys.com wrote: [...] > + > +void kernel_fpu_begin(void) > +{ > + preempt_disable(); > + > + WARN_ON(this_cpu_read(in_kernel_fpu)); > + > + this_cpu_write(in_kernel_fpu, true); > + > +#ifdef CONFIG_64BIT > + if (likely(cpu_has(&boot_cpu_dat