Re: ubd cleanups

2024-02-27 Thread Jens Axboe
On Thu, 22 Feb 2024 08:24:10 +0100, Christoph Hellwig wrote: > this series cleans up the uml ubd drivers and gets rid of more blk_queue_* > calls. It is a against Jens' for-6.9/block branch. > > Diffstat: > ubd_kern.c | 127 > + > 1

Re: [PATCH 7/7] ubd: open the backing files in ubd_add

2024-02-27 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "hch" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "Jens Axboe" > CC: "linux-um" , "linux-block" > > Gesendet: Donnerstag, 22. Februar 2024 08:24:17 > Betreff: [PATCH 7/7] ubd: open the backing files in ubd_add > Opening the backing device onl

Re: [PATCH 6/7] ubd: remove the queue pointer in struct ubd

2024-02-27 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "hch" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "Jens Axboe" > CC: "linux-um" , "linux-block" > > Gesendet: Donnerstag, 22. Februar 2024 08:24:16 > Betreff: [PATCH 6/7] ubd: remove the queue pointer in struct ubd > No need for it now, every

Re: [PATCH 5/7] ubd: move set_disk_ro to ubd_add

2024-02-27 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "hch" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "Jens Axboe" > CC: "linux-um" , "linux-block" > > Gesendet: Donnerstag, 22. Februar 2024 08:24:15 > Betreff: [PATCH 5/7] ubd: move set_disk_ro to ubd_add > No need to delay this until open tim

Re: [PATCH 4/7] ubd: move setting the variable queue limits to ubd_add

2024-02-27 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "hch" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "Jens Axboe" > CC: "linux-um" , "linux-block" > > Gesendet: Donnerstag, 22. Februar 2024 08:24:14 > Betreff: [PATCH 4/7] ubd: move setting the variable queue limits to ubd_add > No reason to d

Re: [PATCH 3/7] ubd: move setting the nonrot flag to ubd_add

2024-02-27 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "hch" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "Jens Axboe" > CC: "linux-um" , "linux-block" > > Gesendet: Donnerstag, 22. Februar 2024 08:24:13 > Betreff: [PATCH 3/7] ubd: move setting the nonrot flag to ubd_add > No reason to delay this

Re: [PATCH 2/7] ubd: remove ubd_disk_register

2024-02-27 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "hch" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "Jens Axboe" > CC: "linux-um" , "linux-block" > > Gesendet: Donnerstag, 22. Februar 2024 08:24:12 > Betreff: [PATCH 2/7] ubd: remove ubd_disk_register > Fold it into the only caller to remove

Re: [PATCH 1/7] ubd: remove the ubd_gendisk array

2024-02-27 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "hch" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "Jens Axboe" > CC: "linux-um" , "linux-block" > > Gesendet: Donnerstag, 22. Februar 2024 08:24:11 > Betreff: [PATCH 1/7] ubd: remove the ubd_gendisk array > And add a disk pointer to the ubd s

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-27 Thread Mark Rutland
On Fri, Feb 23, 2024 at 11:17:02AM -0700, Rob Herring wrote: > On Fri, Feb 23, 2024 at 3:23 AM Will Deacon wrote: > > > > On Thu, Feb 22, 2024 at 05:03:17PM -0700, Rob Herring wrote: > > > On Fri, Feb 16, 2024 at 05:05:54PM -0800, Stephen Boyd wrote: > > > > Call this function unconditionally so t

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-27 Thread Oreoluwa Babatunde
On 2/16/2024 5:05 PM, Stephen Boyd wrote: > Call this function unconditionally so that we can populate an empty DTB > on platforms that don't boot with a firmware provided or builtin DTB. > When ACPI is in use, unflatten_device_tree() ignores the > 'initial_boot_params' pointer so the live DT on t

Re: [PATCH 1/4] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions

2024-02-27 Thread Arnd Bergmann
On Tue, Feb 27, 2024, at 16:44, Christophe Leroy wrote: > Le 27/02/2024 à 16:40, Arnd Bergmann a écrit : >> On Mon, Feb 26, 2024, at 17:55, Samuel Holland wrote: > > > For 256K pages, powerpc has the following help. I think you should have > it too: > > The kernel will only be able to run

Re: [PATCH 1/4] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions

2024-02-27 Thread Christophe Leroy
Le 27/02/2024 à 16:40, Arnd Bergmann a écrit : > On Mon, Feb 26, 2024, at 17:55, Samuel Holland wrote: >> On 2024-02-26 10:14 AM, Arnd Bergmann wrote: >>> >>> +config HAVE_PAGE_SIZE_4KB >>> + bool >>> + >>> +config HAVE_PAGE_SIZE_8KB >>> + bool >>> + >>> +config HAVE_PAGE_SIZE_16KB >>> +

Re: [PATCH 1/4] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions

2024-02-27 Thread Arnd Bergmann
On Tue, Feb 27, 2024, at 09:45, Geert Uytterhoeven wrote: > >> +config PAGE_SIZE_4KB >> + bool "4KB pages" > > Now you got rid of the 4000-byte ("4kB") pages and friends, please > do not replace these by Kelvin-bytes, and use the official binary > prefixes => "4 KiB". > Done, thanks. Ar

Re: [PATCH 1/4] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions

2024-02-27 Thread Arnd Bergmann
On Mon, Feb 26, 2024, at 20:02, Christophe Leroy wrote: > Le 26/02/2024 à 17:14, Arnd Bergmann a écrit : >> From: Arnd Bergmann > > That's a nice re-factor. > > The only drawback I see is that we are loosing several interesting > arch-specific comments/help text. Don't know if there could be an e

Re: [PATCH 1/4] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions

2024-02-27 Thread Arnd Bergmann
On Mon, Feb 26, 2024, at 17:55, Samuel Holland wrote: > On 2024-02-26 10:14 AM, Arnd Bergmann wrote: >> >> +config HAVE_PAGE_SIZE_4KB >> +bool >> + >> +config HAVE_PAGE_SIZE_8KB >> +bool >> + >> +config HAVE_PAGE_SIZE_16KB >> +bool >> + >> +config HAVE_PAGE_SIZE_32KB >> +bool >> +

Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-02-27 Thread Arnd Bergmann
On Tue, Feb 27, 2024, at 12:12, Geert Uytterhoeven wrote: > On Tue, Feb 27, 2024 at 11:59 AM Arnd Bergmann wrote: >> On Tue, Feb 27, 2024, at 09:54, Geert Uytterhoeven wrote: >> I was a bit unsure about how to best do this since there >> is not really a need for a fixed page size on nommu kernels,

Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-02-27 Thread Heiko Carstens
On Mon, Feb 26, 2024 at 05:14:13PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Most architectures only support a single hardcoded page size. In order > to ensure that each one of these sets the corresponding Kconfig symbols, > change over the PAGE_SHIFT definition to the common one and

Re: [PATCH 2/4] arch: simplify architecture specific page size configuration

2024-02-27 Thread Helge Deller
On 2/26/24 17:14, Arnd Bergmann wrote: From: Arnd Bergmann arc, arm64, parisc and powerpc all have their own Kconfig symbols in place of the common CONFIG_PAGE_SIZE_4KB symbols. Change these so the common symbols are the ones that are actually used, while leaving the arhcitecture specific ones

Re: [PATCH 4/4] vdso: avoid including asm/page.h

2024-02-27 Thread Catalin Marinas
On Mon, Feb 26, 2024 at 05:14:14PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The recent change to the vdso_data_store broke building compat VDSO > on at least arm64 because it includes headers outside of the include/vdso/ > namespace: > > In file included from arch/arm64/include/asm/

Re: [PATCH 2/4] arch: simplify architecture specific page size configuration

2024-02-27 Thread Catalin Marinas
On Mon, Feb 26, 2024 at 05:14:12PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > arc, arm64, parisc and powerpc all have their own Kconfig symbols > in place of the common CONFIG_PAGE_SIZE_4KB symbols. Change these > so the common symbols are the ones that are actually used, while > leavi

Re: [PATCH 4/4] vdso: avoid including asm/page.h

2024-02-27 Thread Michael Ellerman
Christophe Leroy writes: > Le 26/02/2024 à 17:14, Arnd Bergmann a écrit : >> From: Arnd Bergmann >> >> The recent change to the vdso_data_store broke building compat VDSO >> on at least arm64 because it includes headers outside of the include/vdso/ >> namespace: > > I understand that powerpc64 a

Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-02-27 Thread Geert Uytterhoeven
Hi Arnd, CC Greg On Tue, Feb 27, 2024 at 11:59 AM Arnd Bergmann wrote: > On Tue, Feb 27, 2024, at 09:54, Geert Uytterhoeven wrote: > >> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu > >> index 9dcf245c9cbf..c777a129768a 100644 > >> --- a/arch/m68k/Kconfig.cpu > >> +++ b/arch/m68k/Kc

Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-02-27 Thread Arnd Bergmann
On Tue, Feb 27, 2024, at 09:54, Geert Uytterhoeven wrote: > Hi Arnd, >> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu >> index 9dcf245c9cbf..c777a129768a 100644 >> --- a/arch/m68k/Kconfig.cpu >> +++ b/arch/m68k/Kconfig.cpu >> @@ -30,6 +30,7 @@ config COLDFIRE >> select GENERIC_

Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-02-27 Thread Geert Uytterhoeven
Hi Arnd, On Mon, Feb 26, 2024 at 5:15 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > Most architectures only support a single hardcoded page size. In order > to ensure that each one of these sets the corresponding Kconfig symbols, > change over the PAGE_SHIFT definition to the common one and

Re: [PATCH 1/4] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions

2024-02-27 Thread Geert Uytterhoeven
Hi Arnd, On Mon, Feb 26, 2024 at 5:14 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > These four architectures define the same Kconfig symbols for configuring > the page size. Move the logic into a common place where it can be shared > with all other architectures. > > Signed-off-by: Arnd Berg