在 2024/1/30 19:42, Xuan Zhuo 写道:
As discussed:
http://lore.kernel.org/all/cacgkmevq0no8qgc46u4mgsmtud44fd_cflcpavmj3rhyqrz...@mail.gmail.com
If the virtio is premapped mode, the driver should manage the dma info by self.
So the virtio core should not store the dma info.
So we can release the mem
On Wed, 31 Jan 2024 17:12:22 +0800, Jason Wang wrote:
> On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
> >
> > In the functions vring_unmap_one_split and
> > vring_unmap_one_split_indirect,
> > multiple checks are made whether unmap is performed and whether it is
> > INDIRECT.
> >
> > These two
On Wed, 31 Jan 2024 17:12:29 +0800, Jason Wang wrote:
> On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
> >
> > As discussed:
> > http://lore.kernel.org/all/CACGkMEug-=C+VQhkMYSgUKMC==04m7-uem_yc21bggkkzh8...@mail.gmail.com
> >
> > When the vq is premapped mode, the driver manages the dma
> > in
On Thu, 1 Feb 2024 13:36:46 +0800, Jason Wang wrote:
> On Thu, Feb 1, 2024 at 11:28 AM Xuan Zhuo wrote:
> >
> > On Wed, 31 Jan 2024 17:12:47 +0800, Jason Wang wrote:
> > > On Tue, Jan 30, 2024 at 7:43 PM Xuan Zhuo
> > > wrote:
> > > >
> > > > If the xsk is enabling, the xsk tx will share the s
On Wed, Jan 31, 2024 at 5:43 PM Michael S. Tsirkin wrote:
>
> On Wed, Jan 31, 2024 at 05:12:22PM +0800, Jason Wang wrote:
> > I post a patch to store flags unconditionally at:
> >
> > https://lore.kernel.org/all/20220224122655-mutt-send-email-...@kernel.org/
>
> what happened to it btw?
Haven't g
On Thu, Feb 1, 2024 at 11:28 AM Xuan Zhuo wrote:
>
> On Wed, 31 Jan 2024 17:12:47 +0800, Jason Wang wrote:
> > On Tue, Jan 30, 2024 at 7:43 PM Xuan Zhuo
> > wrote:
> > >
> > > If the xsk is enabling, the xsk tx will share the send queue.
> > > But the xsk requires that the send queue use the pr
On Wed, 31 Jan 2024 17:12:47 +0800, Jason Wang wrote:
> On Tue, Jan 30, 2024 at 7:43 PM Xuan Zhuo wrote:
> >
> > If the xsk is enabling, the xsk tx will share the send queue.
> > But the xsk requires that the send queue use the premapped mode.
> > So the send queue must support premapped mode.
>
On Wed, 31 Jan 2024 17:12:43 +0800, Jason Wang wrote:
> On Tue, Jan 30, 2024 at 7:43 PM Xuan Zhuo wrote:
> >
> > Export the premapped to drivers, then drivers can check
> > the vq premapped mode after the find_vqs().
>
> This looks odd, it's the charge of the driver to set premapped, so it
> sho
On Wed, 31 Jan 2024 17:12:34 +0800, Jason Wang wrote:
> On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
> >
> > Now, we pass multi parameters to find_vqs. These parameters
> > may work for transport or work for vring.
> >
> > And find_vqs has multi implements in many places:
> >
> > But every ti
On Wed, 31 Jan 2024 13:03:04 +0200 (EET), =?utf-8?q?Ilpo_J=C3=A4rvinen?=
wrote:
> On Tue, 30 Jan 2024, Xuan Zhuo wrote:
>
> > Just like find_vqs(), it is time to refactor the
> > vring_new_virtqueue(). We pass the similar struct to
> > vring_new_virtqueue.
> >
> > Signed-off-by: Xuan Zhuo
> > --
On Wed, Jan 31, 2024 at 6:01 PM Xuan Zhuo wrote:
>
> On Wed, 31 Jan 2024 17:12:10 +0800, Jason Wang wrote:
> > On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo
> > wrote:
> > >
> > > This commit structure the indirect desc table.
> > > Then we can get the desc num directly when doing unmap.
> > >
> >
Quoting Rob Herring (2024-01-31 12:54:05)
> On Mon, Jan 29, 2024 at 04:45:00PM -0800, Stephen Boyd wrote:
> > Call this function unconditionally so that we can populate an empty DTB
> > on platforms that don't boot with a firmware provided or builtin DTB.
> > Override 'initial_boot_params' to NULL
On Mon, Jan 29, 2024 at 04:45:00PM -0800, Stephen Boyd wrote:
> Call this function unconditionally so that we can populate an empty DTB
> on platforms that don't boot with a firmware provided or builtin DTB.
> Override 'initial_boot_params' to NULL when ACPI is in use but the
> bootloader has loade
On Tue, Jan 30, 2024 at 7:43 PM Xuan Zhuo wrote:
>
> Export the premapped to drivers, then drivers can check
> the vq premapped mode after the find_vqs().
This looks odd, it's the charge of the driver to set premapped, so it
should know it?
Thanks
On Tue, Jan 30, 2024 at 7:43 PM Xuan Zhuo wrote:
>
> If the xsk is enabling, the xsk tx will share the send queue.
> But the xsk requires that the send queue use the premapped mode.
> So the send queue must support premapped mode.
>
> Signed-off-by: Xuan Zhuo
> ---
> drivers/net/virtio_net.c | 1
On Wed, 31 Jan 2024 17:12:10 +0800, Jason Wang wrote:
> On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
> >
> > This commit structure the indirect desc table.
> > Then we can get the desc num directly when doing unmap.
> >
> > And save the dma info to the struct, then the indirect
> > will not u
On Tue, 30 Jan 2024, Xuan Zhuo wrote:
> Just like find_vqs(), it is time to refactor the
> vring_new_virtqueue(). We pass the similar struct to
> vring_new_virtqueue.
>
> Signed-off-by: Xuan Zhuo
> ---
> diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
> index 98ff808d6f0c..
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
>
> Now, we pass multi parameters to find_vqs. These parameters
> may work for transport or work for vring.
>
> And find_vqs has multi implements in many places:
>
> But every time,
> arch/um/drivers/virtio_uml.c
> drivers/platform/mellanox/mlxbf-
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
>
> This commit structure the indirect desc table.
> Then we can get the desc num directly when doing unmap.
>
> And save the dma info to the struct, then the indirect
> will not use the dma fields of the desc_extra. The subsequent
> commits will ma
On Wed, 31 Jan 2024 17:12:19 +0800, Jason Wang wrote:
> On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
> >
> > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed,
> > multiple checks are made whether unmap is performed and whether it is
> > INDIRECT.
> >
> > These two functio
On Wed, Jan 31, 2024 at 05:12:22PM +0800, Jason Wang wrote:
> I post a patch to store flags unconditionally at:
>
> https://lore.kernel.org/all/20220224122655-mutt-send-email-...@kernel.org/
what happened to it btw?
--
MST
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
>
> Just like find_vqs(), it is time to refactor the
> vring_new_virtqueue(). We pass the similar struct to
> vring_new_virtqueue.
>
Well, the vring_create_virtqueue() is converted with a structure.
We need to be consistent. And it seems better to
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
>
> In the functions vring_unmap_one_split and
> vring_unmap_one_split_indirect,
> multiple checks are made whether unmap is performed and whether it is
> INDIRECT.
>
> These two functions are usually called in a loop, and we should put the
> check
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
>
> This commit structure the indirect desc table.
> Then we can get the desc num directly when doing unmap.
>
> And save the dma info to the struct, then the indirect
> will not use the dma fields of the desc_extra. The subsequent
> commits will ma
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
>
> In the functions vring_unmap_extra_packed and vring_unmap_desc_packed,
> multiple checks are made whether unmap is performed and whether it is
> INDIRECT.
>
> These two functions are usually called in a loop, and we should put the
> check outsid
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
>
> As discussed:
> http://lore.kernel.org/all/CACGkMEug-=C+VQhkMYSgUKMC==04m7-uem_yc21bggkkzh8...@mail.gmail.com
>
> When the vq is premapped mode, the driver manages the dma
> info is a good way.
>
> So this commit make the virtio core not to stor
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote:
>
> To make the code readable, introduce vring_need_unmap_buffer() to
> replace do_unmap.
>
>use_dma_api premapped -> vring_need_unmap_buffer()
> 1. false falsefalse
> 2. truefalsetrue
> 3. truetrue
27 matches
Mail list logo
