Re: [PATCH 7/9] zram: use the default discard granularity

2024-01-05 Thread Sergey Senozhatsky
On (23/12/28 07:55), Christoph Hellwig wrote: > > The discard granularity now defaults to a single sector, so don't set > that value explicitly. > > Signed-off-by: Christoph Hellwig FWIW, Reviewed-by: Sergey Senozhatsky

Re: [PATCH v3 09/11] um: Rely on PTRACE_SETREGSET to set FS/GS base registers

2024-01-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Benjamin Berg" > On Fri, 2024-01-05 at 00:05 +0100, Richard Weinberger wrote: >> On Fri, Nov 10, 2023 at 12:03 PM wrote: >> > >> > From: Benjamin Berg >> > >> > These registers are saved/restored together with the other general >> > registers using ptrace

Re: [PATCH] um: vector: fix return value check in vector_legacy_rx

2024-01-05 Thread Anton Ivanov
On 05/01/2024 08:42, Johannes Berg wrote: On Thu, 2024-01-04 at 22:05 +0100, Richard Weinberger wrote: On Fri, Oct 6, 2023 at 2:28 PM Ma Ke wrote: In vector_legacy_rx, to avoid an unexpected result returned by pskb_trim, we should check the return value of pskb_trim(). Signed-off-by: Ma Ke

Re: [PATCH] um: hostfs: catch EINTR and partial read/write

2024-01-05 Thread Benjamin Berg
On Thu, 2024-01-04 at 23:27 +0100, Richard Weinberger wrote: > On Fri, Nov 10, 2023 at 10:44 AM wrote: > > > > From: Benjamin Berg > > > > The UM kernel uses signals for various purposes (SIGALRM for > > scheduling > > for example). These signals are interrupts for the UM kernel, which > > shou

Re: [PATCH v3 09/11] um: Rely on PTRACE_SETREGSET to set FS/GS base registers

2024-01-05 Thread Benjamin Berg
Hi, On Fri, 2024-01-05 at 00:05 +0100, Richard Weinberger wrote: > On Fri, Nov 10, 2023 at 12:03 PM wrote: > > > > From: Benjamin Berg > > > > These registers are saved/restored together with the other general > > registers using ptrace. In arch_set_tls we then just need to set > > the > > reg

Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Johannes Berg" > An: "Benjamin Berg" , "Richard Weinberger" > > CC: "linux-um" > Gesendet: Freitag, 5. Januar 2024 09:56:11 > Betreff: Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info() > On Fri, 2024-01-05 at 09:12 +0100, Benjamin Berg wrote: >>

Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-05 Thread Johannes Berg
On Fri, 2024-01-05 at 09:12 +0100, Benjamin Berg wrote: > > Another option is giving the helper threads more memory, we don't have > > that many. > > Did you explore this option already? > > I had not really considered that. > > One thing though is that userspace_tramp calls os_info while working

Re: [PATCH] um: vector: fix return value check in vector_legacy_rx

2024-01-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Johannes Berg" > An: "Richard Weinberger" , "Ma Ke" > > CC: "richard" , "anton ivanov" > , xiangya...@huawei.com, "linux-um" > , "linux-kernel" > Gesendet: Freitag, 5. Januar 2024 09:42:12 > Betreff: Re: [PATCH] um: vector: fix return value check in vecto

Re: [PATCH] um: vector: fix return value check in vector_legacy_rx

2024-01-05 Thread Johannes Berg
On Thu, 2024-01-04 at 22:05 +0100, Richard Weinberger wrote: > On Fri, Oct 6, 2023 at 2:28 PM Ma Ke wrote: > > > > In vector_legacy_rx, to avoid an unexpected result returned by > > pskb_trim, we should check the return value of pskb_trim(). > > > > Signed-off-by: Ma Ke > > --- > > arch/um/dri

Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-05 Thread Benjamin Berg
Hi, On Thu, 2024-01-04 at 23:37 +0100, Richard Weinberger wrote: > On Fri, Nov 10, 2023 at 12:03 PM wrote: > > > > From: Benjamin Berg > > > > The threads allocated inside the kernel have only a single page of > > stack. Unfortunately, the vfprintf function in standard glibc may use > > too mu