[PATCH v2] um: time-travel: fix time corruption

2023-10-25 Thread Johannes Berg
From: Johannes Berg In 'basic' time-travel mode (without =inf-cpu or =ext), we still get timer interrupts. These can happen at arbitrary points in time, i.e. while in timer_read(), which pushes time forward just a little bit. Then, if we happen to get the interrupt after calculating the new time

Re: [PATCH] um: time-travel: fix time going backwards

2023-10-25 Thread Johannes Berg
On Wed, 2023-10-25 at 22:02 +0200, Johannes Berg wrote: > On Wed, 2023-10-25 at 21:51 +0200, Johannes Berg wrote: > > On Wed, 2023-10-25 at 11:55 +, Vincent Whitchurch wrote: > > > On Mon, 2023-10-23 at 09:33 +0200, Johannes Berg wrote: > > > > Do you have a specific workload that tends to repr

[PATCH] um: time-travel: fix time corruption

2023-10-25 Thread Johannes Berg
From: Johannes Berg In 'basic' time-travel mode (without =inf-cpu or =ext), we still get timer interrupts. These can happen at arbitrary points in time, i.e. while in timer_read(), which pushes time forward just a little bit. Then, if we happen to get the interrupt after calculating the new time

Re: [PATCH] um: time-travel: fix time going backwards

2023-10-25 Thread Johannes Berg
On Wed, 2023-10-25 at 21:51 +0200, Johannes Berg wrote: > On Wed, 2023-10-25 at 11:55 +, Vincent Whitchurch wrote: > > On Mon, 2023-10-23 at 09:33 +0200, Johannes Berg wrote: > > > Do you have a specific workload that tends to reproduce this? > > > > I've been seeing it when running roadtest,

Re: [PATCH] um: time-travel: fix time going backwards

2023-10-25 Thread Johannes Berg
On Wed, 2023-10-25 at 11:55 +, Vincent Whitchurch wrote: > On Mon, 2023-10-23 at 09:33 +0200, Johannes Berg wrote: > > Do you have a specific workload that tends to reproduce this? > > I've been seeing it when running roadtest, but it's easily reproducible > without that by using the attached

Re: [PATCH] um: time-travel: fix time going backwards

2023-10-25 Thread Vincent Whitchurch
On Mon, 2023-10-23 at 09:33 +0200, Johannes Berg wrote: > Do you have a specific workload that tends to reproduce this? I've been seeing it when running roadtest, but it's easily reproducible without that by using the attached config and the following program as init. cp repro.config .config

Re: [PATCH 2/2] Documentation: kunit: Add clang UML coverage example

2023-10-25 Thread David Gow
On Fri, 20 Oct 2023 at 17:22, Michał Winiarski wrote: > > LLVM-based toolchain is using a different set of tools for coverage. > Add an example that produces output in lcov format. > > Signed-off-by: Michał Winiarski > --- This looks good to me, minus a couple of very, very minor typos, and the

Re: [PATCH 1/2] arch: um: Add Clang coverage support

2023-10-25 Thread David Gow
On Fri, 20 Oct 2023 at 17:22, Michał Winiarski wrote: > > Clang uses a different set of command line arguments for enabling > coverage. > > Signed-off-by: Michał Winiarski > --- This works brilliantly here -- I'm very glad to finally be able to use something newer than gcc 6! I assume this will