Re: [PATCH v7 03/11] kbuild: generate KSYMTAB entries by modpost

2023-06-09 Thread Nick Desaulniers
On Thu, Jun 8, 2023 at 7:24 AM Masahiro Yamada wrote: > > Commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing > CONFIG_MODULE_REL_CRCS") made modpost output CRCs in the same way > whether the EXPORT_SYMBOL() is placed in *.c or *.S. > > Signed-off-by: Masahiro Yamada Thanks fo

Re: [PATCH v7 11/11] linux/export.h: rename 'sec' argument to 'license'

2023-06-09 Thread Nick Desaulniers
On Thu, Jun 8, 2023 at 7:24 AM Masahiro Yamada wrote: > > Now, EXPORT_SYMBOL() is populated in two stages. In the first stage, > all of EXPORT_SYMBOL/EXPORT_SYMBOL_GPL go into the same section, > .export_symbol. > > 'sec' does not make sense any more. Rename it to 'license'. > > Signed-off-by: Mas

Re: [PATCH v7 10/11] modpost: show offset from symbol for section mismatch warnings

2023-06-09 Thread Nick Desaulniers
On Thu, Jun 8, 2023 at 7:24 AM Masahiro Yamada wrote: > > Currently, modpost only shows the symbol names and section names, so it > repeats the same message if there are multiple relocations in the same > symbol. It is common the relocation spans across multiple instructions. > > It is better to s

Re: [PATCH v7 01/11] Revert "[PATCH] uml: export symbols added by GCC hardened"

2023-06-09 Thread Nick Desaulniers
On Thu, Jun 8, 2023 at 7:24 AM Masahiro Yamada wrote: > > This reverts commit cead61a6717a9873426b08d73a34a325e3546f5d. > > It exported __stack_smash_handler and __guard, while they may not be > defined by anyone. > > The code *declares* __stack_smash_handler and __guard. It does not > create weak

Re: [PATCH 11/30] swsusp: don't pass a stack address to blkdev_get_by_path

2023-06-09 Thread Rafael J. Wysocki
On Thu, Jun 8, 2023 at 1:03 PM Christoph Hellwig wrote: > > holder is just an on-stack pointer that can easily be reused by other calls, > replace it with a static variable that doesn't change. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke Acked-by: Rafael J. Wysocki > -

Re: [PATCH 21/30] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool

2023-06-09 Thread Keith Busch
Looks good. Reviewed-by: Keith Busch ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

[PATCH] x86: Fix build of UML with KASAN

2023-06-09 Thread Vincent Whitchurch
) +#else +SYM_FUNC_ALIAS_WEAK(memset, __memset) +#endif EXPORT_SYMBOL(memset) SYM_FUNC_START_LOCAL(memset_orig) --- base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7 change-id: 20230609-uml-kasan-2392dd4c3858 Best regards, -- Vincent Whitchurch ___