Christoph,
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
__
Christoph,
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
__
Christoph,
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
__
On Tue, Jun 06, 2023 at 09:39:35AM +0200, Christoph Hellwig wrote:
> The current interface for exclusive opens is rather confusing as it
> requires both the FMODE_EXCL flag and a holder. Remove the need to pass
> FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
>
> For blkdev
On Tue, Jun 06, 2023 at 09:39:34AM +0200, Christoph Hellwig wrote:
> Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
> make sense, so pass NULL instead and remove the holder argument from the
> call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls.
Please
On 6/7/23 14:21, Christoph Hellwig wrote:
On Wed, Jun 07, 2023 at 02:19:00PM +0200, Hannes Reinecke wrote:
- return true;
+ return __disk_check_media_change(disk,
+ disk_clear_events(disk, DISK_EVENT_MEDIA_CHANGE |
+
On 6/6/23 09:39, Christoph Hellwig wrote:
FMODE_NDELAY, FMODE_EXCL and FMODE_WRITE_IOCTL were only used for
block internal purposed and are now entirely unused, so remove them.
Signed-off-by: Christoph Hellwig
---
include/linux/fs.h | 7 ---
1 file changed, 7 deletions(-)
Reviewed-by:
On 6/6/23 09:39, Christoph Hellwig wrote:
Store the file struct used as the holder in file->private_data as an
indicator that this file descriptor was opened exclusively to remove
the last use of FMODE_EXCL.
Signed-off-by: Christoph Hellwig
---
block/fops.c | 14 --
1 file chang
On 6/6/23 09:39, Christoph Hellwig wrote:
Always use I_BDEV(file->f_mapping->host) to find the bdev for a file to
free up file->private_data for other uses.
Signed-off-by: Christoph Hellwig
---
block/fops.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
Reviewed-
On 6/6/23 09:39, Christoph Hellwig wrote:
A few ioctl handlers have fmode_t arguments that are entirely unused,
remove them.
Signed-off-by: Christoph Hellwig
---
block/blk-zoned.c | 4 ++--
block/blk.h | 6 +++---
block/ioctl.c | 14 +++---
3 files changed, 12 insertion
On 6/6/23 09:39, Christoph Hellwig wrote:
All these helpers are only used in core block code, so move them out of
the public header.
Signed-off-by: Christoph Hellwig
---
block/blk.h| 23 +--
include/linux/blkdev.h | 27 ---
2 files cha
On 6/6/23 09:39, Christoph Hellwig wrote:
This code has been dead forever, make sure it doesn't show up in code
searches.
Signed-off-by: Christoph Hellwig
---
arch/um/drivers/ubd_kern.c | 7 ---
1 file changed, 7 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
___
On 6/6/23 09:39, Christoph Hellwig wrote:
Stop passing the fmode_t around and just use a simple bool to track if
an export is read-only.
Signed-off-by: Christoph Hellwig
---
drivers/block/rnbd/rnbd-srv-sysfs.c | 3 +--
drivers/block/rnbd/rnbd-srv.c | 15 +++
drivers/block
On 6/6/23 09:39, Christoph Hellwig wrote:
Instead of propagating the fmode_t, just use a bool to track if a mtd
block device was opened for writing.
Signed-off-by: Christoph Hellwig
---
drivers/mtd/mtd_blkdevs.c| 2 +-
drivers/mtd/mtdblock.c | 2 +-
include/linux/mtd/blktrans.h |
On 6/6/23 09:39, Christoph Hellwig wrote:
Instead of passing a fmode_t and only checking it fo0r FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.
Signed-off-by: Christoph Hellwig
---
drivers/nvme/host/ioctl.c | 62 +---
On 6/6/23 09:39, Christoph Hellwig wrote:
Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.
Signed-off-by: Christoph Hellwig
---
block/bsg-lib.c | 2 +-
block/bsg.c | 8 +--
On 6/6/23 09:39, Christoph Hellwig wrote:
Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/ch.c | 3 ++-
drivers/scsi/scsi_ioctl.c | 34
On 6/6/23 09:39, Christoph Hellwig wrote:
Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_bsg.c | 2 +-
drivers/scsi/scsi_ioctl.c | 8 +++
On 6/6/23 09:39, Christoph Hellwig wrote:
There is no real need to store the open mode in the super_block now.
It is only used by f2fs, which can easily recalculate it.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/super.c| 10 ++
fs/nilfs2/super.c | 1 -
fs/super.c |
On 6/6/23 09:39, Christoph Hellwig wrote:
Add a helper to return the open flags for blkdev_get_by* for passed in
super block flags instead of open coding the logic in many places.
Signed-off-by: Christoph Hellwig
---
fs/btrfs/super.c | 5 +
fs/nilfs2/super.c | 7 ++-
fs
On 6/6/23 09:39, Christoph Hellwig wrote:
The current interface for exclusive opens is rather confusing as it
requires both the FMODE_EXCL flag and a holder. Remove the need to pass
FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
For blkdev_put this requires adding the hol
On 6/6/23 09:39, Christoph Hellwig wrote:
Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
make sense, so pass NULL instead and remove the holder argument from the
call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls.
Signed-off-by: Christoph Hellwig
--
On 6/6/23 09:39, Christoph Hellwig wrote:
Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
make sense, so pass NULL instead.
Signed-off-by: Christoph Hellwig
---
drivers/block/rnbd/rnbd-srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Hannes
On 6/6/23 09:39, Christoph Hellwig wrote:
sb is just an on-stack pointer that can easily be reused by other calls.
Switch to use the bcache-wide bcache_kobj instead as there is no need to
claim per-bcache device anyway.
Signed-off-by: Christoph Hellwig
---
drivers/md/bcache/super.c | 2 +-
1
On 6/6/23 09:39, Christoph Hellwig wrote:
holder is just an on-stack pointer that can easily be reused by other calls,
replace it with a static variable that doesn't change.
Signed-off-by: Christoph Hellwig
---
kernel/power/swap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
On Wed, Jun 07, 2023 at 02:19:00PM +0200, Hannes Reinecke wrote:
>> -return true;
>> +return __disk_check_media_change(disk,
>> +disk_clear_events(disk, DISK_EVENT_MEDIA_CHANGE |
>> +DISK_EVENT_EJECT_REQUEST));
>
> Can you move
On 6/6/23 09:39, Christoph Hellwig wrote:
Make the function name match the method name.
Signed-off-by: Christoph Hellwig
---
block/fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
_
On 6/6/23 09:39, Christoph Hellwig wrote:
The mode argument to the ->release block_device_operation is never used,
so remove it.
Signed-off-by: Christoph Hellwig
---
arch/um/drivers/ubd_kern.c | 4 ++--
arch/xtensa/platforms/iss/simdisk.c | 2 +-
block/bdev.c
On Wed, Jun 07, 2023 at 02:13:33PM +0200, Hannes Reinecke wrote:
>> +++ b/include/linux/cdrom.h
>> @@ -64,6 +64,7 @@ struct cdrom_device_info {
>> int (*exit)(struct cdrom_device_info *);
>> int mrw_mode_page;
>> __s64 last_media_change_ms;
>> +bool opened_for_data;
>> };
>>
On 6/6/23 09:39, Christoph Hellwig wrote:
->open is only called on the whole device. Make that explicit by
passing a gendisk instead of the block_device.
Signed-off-by: Christoph Hellwig
---
arch/um/drivers/ubd_kern.c | 5 ++---
arch/xtensa/platforms/iss/simdisk.c | 4 ++--
bloc
On 6/6/23 09:39, Christoph Hellwig wrote:
Factor the common logic between disk_check_media_change and
disk_force_media_change into a helper.
Signed-off-by: Christoph Hellwig
---
block/disk-events.c | 37 -
1 file changed, 16 insertions(+), 21 deletions(-)
On Wed, Jun 07, 2023 at 11:24:55AM +0200, Christian Brauner wrote:
> On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote:
> > Store the file struct used as the holder in file->private_data as an
> > indicator that this file descriptor was opened exclusively to remove
> > the last use
On 6/6/23 09:39, Christoph Hellwig wrote:
bdev_check_media_change should only ever be called for the whole device.
Pass a gendisk to make that explicit and rename the function to
disk_check_media_change.
Signed-off-by: Christoph Hellwig
---
block/disk-events.c | 18 +-
dr
On 6/6/23 09:39, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig
---
drivers/cdrom/cdrom.c | 2 +-
drivers/cdrom/gdrom.c | 2 +-
drivers/scsi/sr.c | 2 +-
include/linux/cdrom.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
On 6/6/23 09:39, Christoph Hellwig wrote:
Set a flag when a cdrom_device_info is opened for writing, instead of
trying to figure out this at release time. This will allow to eventually
remove the mode argument to the ->release block_device_operation as
nothing but the CDROM drivers uses that arg
On 6/6/23 09:39, Christoph Hellwig wrote:
cdrom_close_write is empty, and the for_data flag it is keyed off is
never set. Remove all this clutter.
Signed-off-by: Christoph Hellwig
---
drivers/cdrom/cdrom.c | 15 ---
include/linux/cdrom.h | 1 -
2 files changed, 16 deletions(-)
On 6/6/23 09:39, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig
---
drivers/cdrom/cdrom.c | 2 +-
drivers/cdrom/gdrom.c | 2 +-
drivers/scsi/sr.c | 2 +-
include/linux/cdrom.h | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
On 6/6/23 09:39, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig
---
drivers/cdrom/cdrom.c | 3 +--
drivers/cdrom/gdrom.c | 2 +-
drivers/scsi/sr.c | 2 +-
include/linux/cdrom.h | 3 +--
4 files changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
On 6/6/23 09:39, Christoph Hellwig wrote:
For whole devices ->open is called for each open, but for partitions it
is only called on the first open of a partition. This is problematic
as various block drivers look at open flags and might not do all setup
for ioctl only or NDELAY opens.
Signed-of
On Wed, Jun 07, 2023 at 11:43:11AM +0200, Johannes Berg wrote:
> On Wed, 2023-06-07 at 17:39 +0800, Philip Li wrote:
> >
> > Is that ok we just take this phrase as a quick improvement for first step,
> > which
> > is
> >
> > "If you fix the issue in a separate patch/commit (i.e. not just a new
>
On Tue, Jun 6, 2023 at 9:41 AM Christoph Hellwig wrote:
>
> The only overlap between the block open flags mapped into the fmode_t and
> other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new
> blk_mode_t instead for use in blkdev_get_by_*, ->open and ->ioctl and
> stop abusing fmode_t
On Tue, Jun 6, 2023 at 9:41 AM Christoph Hellwig wrote:
>
> Stop passing the fmode_t around and just use a simple bool to track if
> an export is read-only.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jack Wang
> ---
> drivers/block/rnbd/rnbd-srv-sysfs.c | 3 +--
> drivers/block/rnbd/rnbd-s
On Wed, 2023-06-07 at 17:39 +0800, Philip Li wrote:
>
> Is that ok we just take this phrase as a quick improvement for first step,
> which
> is
>
> "If you fix the issue in a separate patch/commit (i.e. not just a new
> version of the same patch/commit), kindly add following tags:"
>
> This cou
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote:
>
> ->open is only called on the whole device. Make that explicit by
> passing a gendisk instead of the block_device.
>
> Signed-off-by: Christoph Hellwig
> ---
> arch/um/drivers/ubd_kern.c | 5 ++---
> arch/xtensa/platforms/iss/
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote:
>
> The mode argument to the ->release block_device_operation is never used,
> so remove it.
>
> Signed-off-by: Christoph Hellwig
> ---
> arch/um/drivers/ubd_kern.c | 4 ++--
> arch/xtensa/platforms/iss/simdisk.c | 2 +-
> block/
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote:
>
> The current interface for exclusive opens is rather confusing as it
> requires both the FMODE_EXCL flag and a holder. Remove the need to pass
> FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
>
> For blkdev_put this
On Wed, Jun 07, 2023 at 11:17:54AM +0200, Johannes Berg wrote:
> On Wed, 2023-06-07 at 17:10 +0800, Philip Li wrote:
> > > > So it seems we should ask the robot maintainers to just stop suggesting
> > > > those tags?
> > >
> > > Agreed.
> >
> > Thanks all for the feedback. We will carefully consi
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote:
>
> Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
> make sense, so pass NULL instead.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jack Wang
> ---
> drivers/block/rnbd/rnbd-srv.c | 2 +-
> 1 file changed, 1 ins
On Wed, Jun 07, 2023 at 11:21:24AM +0200, Christian Brauner wrote:
> On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> > The only overlap between the block open flags mapped into the fmode_t and
> > other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new
>
> and FMOD
On Tue, Jun 06, 2023 at 10:40:42AM +0200, Christoph Hellwig wrote:
> On Tue, Jun 06, 2023 at 10:27:14AM +0200, Christian Brauner wrote:
> > On Tue, Jun 06, 2023 at 09:39:19AM +0200, Christoph Hellwig wrote:
> > > Hi all,
> > >
> > > this series adds a new blk_mode_t for block open flags instead of
On Tue, Jun 06, 2023 at 09:39:50AM +0200, Christoph Hellwig wrote:
> FMODE_NDELAY, FMODE_EXCL and FMODE_WRITE_IOCTL were only used for
> block internal purposed and are now entirely unused, so remove them.
>
> Signed-off-by: Christoph Hellwig
> ---
Love it,
Reviewed-by: Christian Brauner
_
On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote:
> Store the file struct used as the holder in file->private_data as an
> indicator that this file descriptor was opened exclusively to remove
> the last use of FMODE_EXCL.
>
> Signed-off-by: Christoph Hellwig
> ---
Feels a bit o
On Tue, Jun 06, 2023 at 09:39:48AM +0200, Christoph Hellwig wrote:
> Always use I_BDEV(file->f_mapping->host) to find the bdev for a file to
> free up file->private_data for other uses.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> The only overlap between the block open flags mapped into the fmode_t and
> other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new
and FMODE_EXCL afaict
> blk_mode_t instead for use in blkdev_get_by_*, ->open and ->
On Wed, 2023-06-07 at 17:10 +0800, Philip Li wrote:
> > > So it seems we should ask the robot maintainers to just stop suggesting
> > > those tags?
> >
> > Agreed.
>
> Thanks all for the feedback. We will carefully consider how to present the
> suggestion clearly.
>
> For now, because the bot co
On Wed, Jun 07, 2023 at 10:34:55AM +0200, Richard Weinberger wrote:
> - Ursprüngliche Mail -
> > Von: "Johannes Berg"
> > On Tue, 2023-06-06 at 21:23 -0700, Eric Biggers wrote:
> >>
> >> > > > Reported-by: kernel test robot
> >> > > > Closes:
> >> > > > https://lore.kernel.org/oe-kbuild-
On Tue, Jun 06, 2023 at 09:39:46AM +0200, Christoph Hellwig wrote:
> A few ioctl handlers have fmode_t arguments that are entirely unused,
> remove them.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
lin
On Tue, Jun 06, 2023 at 09:39:45AM +0200, Christoph Hellwig wrote:
> All these helpers are only used in core block code, so move them out of
> the public header.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
On Tue, Jun 06, 2023 at 09:39:44AM +0200, Christoph Hellwig wrote:
> This code has been dead forever, make sure it doesn't show up in code
> searches.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
linux-
On Tue, Jun 06, 2023 at 09:39:43AM +0200, Christoph Hellwig wrote:
> Stop passing the fmode_t around and just use a simple bool to track if
> an export is read-only.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
On Tue, Jun 06, 2023 at 09:39:42AM +0200, Christoph Hellwig wrote:
> Instead of propagating the fmode_t, just use a bool to track if a mtd
> block device was opened for writing.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
On Tue, Jun 06, 2023 at 09:39:41AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it fo0r FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christi
On Tue, Jun 06, 2023 at 09:39:40AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christia
On Tue, Jun 06, 2023 at 09:39:39AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christia
On Tue, Jun 06, 2023 at 09:39:38AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christia
On Tue, Jun 06, 2023 at 09:39:37AM +0200, Christoph Hellwig wrote:
> There is no real need to store the open mode in the super_block now.
> It is only used by f2fs, which can easily recalculate it.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
On Tue, Jun 06, 2023 at 09:39:36AM +0200, Christoph Hellwig wrote:
> Add a helper to return the open flags for blkdev_get_by* for passed in
> super block flags instead of open coding the logic in many places.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Braune
On Tue, Jun 06, 2023 at 09:39:35AM +0200, Christoph Hellwig wrote:
> The current interface for exclusive opens is rather confusing as it
> requires both the FMODE_EXCL flag and a holder. Remove the need to pass
> FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
>
> For blkdev
On Tue, Jun 06, 2023 at 09:39:34AM +0200, Christoph Hellwig wrote:
> Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
> make sense, so pass NULL instead and remove the holder argument from the
> call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls.
>
> Sig
On Tue, Jun 06, 2023 at 09:39:33AM +0200, Christoph Hellwig wrote:
> Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
> make sense, so pass NULL instead.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
On Tue, Jun 06, 2023 at 09:39:30AM +0200, Christoph Hellwig wrote:
> Make the function name match the method name.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
linux-um mailing list
linux-um@lists.infra
On Tue, Jun 06, 2023 at 09:39:29AM +0200, Christoph Hellwig wrote:
> The mode argument to the ->release block_device_operation is never used,
> so remove it.
>
> Signed-off-by: Christoph Hellwig
> ---
Good cleanup. Looks good to me,
Acked-by: Christian Brauner
_
- Ursprüngliche Mail -
> Von: "Johannes Berg"
> On Tue, 2023-06-06 at 21:23 -0700, Eric Biggers wrote:
>>
>> > > > Reported-by: kernel test robot
>> > > > Closes:
>> > > > https://lore.kernel.org/oe-kbuild-all/202305311135.zgmt1gyr-...@intel.com/
>> > >
>> > > Are you sure Reported-by a
On Tue, Jun 06, 2023 at 09:39:28AM +0200, Christoph Hellwig wrote:
> ->open is only called on the whole device. Make that explicit by
Ok, that answers my question in
https://lore.kernel.org/all/20230607-chefsessel-angeordnet-269f0596f9b3@brauner
> passing a gendisk instead of the blo
On Wed, Jun 07, 2023 at 10:14:22AM +0200, Christian Brauner wrote:
> This assumes that all drivers deal with additional ->open() calls for
> each partition correctly which I assumed you checked so,
They have to, because they already get the additional open for
extra opens of the whole device. The
On Tue, 2023-06-06 at 21:23 -0700, Eric Biggers wrote:
>
> > > > Reported-by: kernel test robot
> > > > Closes:
> > > > https://lore.kernel.org/oe-kbuild-all/202305311135.zgmt1gyr-...@intel.com/
> > >
> > > Are you sure Reported-by and Closes make sense?
> > > AFAIK the report was only on your f
On Tue, Jun 06, 2023 at 09:39:27AM +0200, Christoph Hellwig wrote:
> Factor the common logic between disk_check_media_change and
> disk_force_media_change into a helper.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
On Tue, Jun 06, 2023 at 09:39:26AM +0200, Christoph Hellwig wrote:
> bdev_check_media_change should only ever be called for the whole device.
> Pass a gendisk to make that explicit and rename the function to
> disk_check_media_change.
>
> Signed-off-by: Christoph Hellwig
> ---
Under the assumpti
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinf
On Tue, Jun 06, 2023 at 09:39:24AM +0200, Christoph Hellwig wrote:
> Set a flag when a cdrom_device_info is opened for writing, instead of
> trying to figure out this at release time. This will allow to eventually
> remove the mode argument to the ->release block_device_operation as
> nothing but
On Tue, Jun 06, 2023 at 09:39:23AM +0200, Christoph Hellwig wrote:
> cdrom_close_write is empty, and the for_data flag it is keyed off is
> never set. Remove all this clutter.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
On Tue, Jun 06, 2023 at 09:39:22AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
___
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinf
On Tue, Jun 06, 2023 at 09:39:21AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
lgtm,
Acked-by: Christian Brauner
___
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
On Tue, Jun 06, 2023 at 09:39:20AM +0200, Christoph Hellwig wrote:
> For whole devices ->open is called for each open, but for partitions it
> is only called on the first open of a partition. This is problematic
> as various block drivers look at open flags and might not do all setup
> for ioctl o
84 matches
Mail list logo
