Re: [PATCH 2/8] of: Enable DTB loading on UML for KUnit tests

2023-03-10 Thread David Gow
On Sat, 11 Mar 2023 at 07:34, Stephen Boyd wrote: > > Quoting David Gow (2023-03-10 00:09:48) > > On Fri, 10 Mar 2023 at 07:19, Stephen Boyd wrote: > > > > > > > > > Hmm. I think you're suggesting that the unit test data be loaded > > > whenever CONFIG_OF=y and CONFIG_KUNIT=y. Then tests can chec

Re: [PATCH 4/8] clk: Add test managed clk provider/consumer APIs

2023-03-10 Thread David Gow
On Sat, 11 Mar 2023 at 07:21, Stephen Boyd wrote: > > Quoting David Gow (2023-03-02 23:15:35) > > On Thu, 2 Mar 2023 at 09:38, Stephen Boyd wrote: > > > > > > Unit tests are more ergonomic and simpler to understand if they don't > > > have to hoist a bunch of code into the test harness init and e

Re: [PATCH 2/8] of: Enable DTB loading on UML for KUnit tests

2023-03-10 Thread Stephen Boyd
Quoting David Gow (2023-03-10 00:09:48) > On Fri, 10 Mar 2023 at 07:19, Stephen Boyd wrote: > > > > > > Hmm. I think you're suggesting that the unit test data be loaded > > whenever CONFIG_OF=y and CONFIG_KUNIT=y. Then tests can check for > > CONFIG_OF and skip if it isn't enabled? > > > > More o

Re: [PATCH 4/8] clk: Add test managed clk provider/consumer APIs

2023-03-10 Thread Stephen Boyd
Quoting David Gow (2023-03-02 23:15:35) > On Thu, 2 Mar 2023 at 09:38, Stephen Boyd wrote: > > > > Unit tests are more ergonomic and simpler to understand if they don't > > have to hoist a bunch of code into the test harness init and exit > > functions. Add some test managed wrappers for the clk A

Re: [PATCH 3/8] kunit: Add test managed platform_device/driver APIs

2023-03-10 Thread David Gow
On Fri, 10 Mar 2023 at 07:25, Stephen Boyd wrote: > > Quoting David Gow (2023-03-02 23:15:31) > > On Thu, 2 Mar 2023 at 09:38, Stephen Boyd wrote: > > > > > > Introduce KUnit resource wrappers around platform_driver_register(), > > > platform_device_alloc(), and platform_device_add() so that test

Re: [PATCH 2/8] of: Enable DTB loading on UML for KUnit tests

2023-03-10 Thread David Gow
On Fri, 10 Mar 2023 at 07:19, Stephen Boyd wrote: > > Quoting David Gow (2023-03-02 23:15:04) > > On Thu, 2 Mar 2023 at 09:38, Stephen Boyd wrote: > > > > > > To fully exercise common clk framework code in KUnit we need to > > > associate 'struct device' pointers with 'struct device_node' pointer