Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

Andrew, On Sun, Feb 12, 2023 at 10:37:15PM -0800, Guenter Roeck wrote: > On 2/12/23 17:26, Mike Rapoport wrote: > > On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: > > > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > > > From: "Mike Rapoport (IBM)" > > > > > >

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

On 2/12/23 17:26, Mike Rapoport wrote: On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" Every architecture that supports FLATMEM memory model defines its own version of pfn_valid() that es

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

On 2/12/23 17:15, Mike Rapoport wrote: Hi, On Sun, Feb 12, 2023 at 09:35:13AM -0800, Guenter Roeck wrote: Hi, On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" The MMU variant uses generic definitions of page_to_pfn() and pfn_to_page(), but !MMU defi

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > Every architecture that supports FLATMEM memory model defines its own > > version of pfn_valid() that essentially compares a pfn

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

Hi, On Sun, Feb 12, 2023 at 09:35:13AM -0800, Guenter Roeck wrote: > Hi, > > On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > The MMU variant uses generic definitions of page_to_pfn() and > > pfn_to_page(), but !MMU defines them in include/a

Re: [PATCH] um: add __weak for exported functions

On 2/12/23 11:32, Johannes Berg wrote: > From: Johannes Berg > > If the exported glibc functions don't exist, we get link > failures. Avoid that by adding __weak so they're allowed > to not exist. > > Reported-by: Randy Dunlap > Signed-off-by: Johannes Berg Acked-by: Randy Dunlap Tested-by

[PATCH] um: add __weak for exported functions

From: Johannes Berg If the exported glibc functions don't exist, we get link failures. Avoid that by adding __weak so they're allowed to not exist. Reported-by: Randy Dunlap Signed-off-by: Johannes Berg --- arch/um/os-Linux/user_syms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

On 2/12/23 08:26, Mike Rapoport wrote: Hi Guenter, On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" Every architecture that supports FLATMEM memory model defines its own version of pfn_va

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

Hi, On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The MMU variant uses generic definitions of page_to_pfn() and > pfn_to_page(), but !MMU defines them in include/asm/page_no.h for no > good reason. > > Include asm-generic/memory_model.h in the

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

Hi Guenter, On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > Every architecture that supports FLATMEM memory model defines its own > > version of pfn_valid() that essentially co

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Every architecture that supports FLATMEM memory model defines its own > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > Use mips/powerpc version implemented as static inline