Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

2022-12-01 Thread Leon Romanovsky
On Thu, Dec 01, 2022 at 09:15:31AM -0800, Christoph Hellwig wrote: > On Thu, Dec 01, 2022 at 11:22:04AM +0200, Leon Romanovsky wrote: > > I would advocate to add this line to whole drivers/infiniband. > > None of RDMA code makes sense for UML. > > software iWarp and RoCE absolutely make sense on U

Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

2022-12-01 Thread Christoph Hellwig
On Thu, Dec 01, 2022 at 11:22:04AM +0200, Leon Romanovsky wrote: > I would advocate to add this line to whole drivers/infiniband. > None of RDMA code makes sense for UML. software iWarp and RoCE absolutely make sense on UML. ___ linux-um mailing list li

Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

2022-12-01 Thread Leon Romanovsky
On Thu, Dec 01, 2022 at 10:28:18AM +0100, Johannes Berg wrote: > On Thu, 2022-12-01 at 11:22 +0200, Leon Romanovsky wrote: > > > > > +++ b/drivers/infiniband/hw/qib/Kconfig > > > @@ -3,6 +3,7 @@ config INFINIBAND_QIB > > > tristate "Intel PCIe HCA support" > > > depends on 64BIT && INFINIBAND_

Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

2022-12-01 Thread Johannes Berg
On Thu, 2022-12-01 at 11:22 +0200, Leon Romanovsky wrote: > > > +++ b/drivers/infiniband/hw/qib/Kconfig > > @@ -3,6 +3,7 @@ config INFINIBAND_QIB > > tristate "Intel PCIe HCA support" > > depends on 64BIT && INFINIBAND_RDMAVT > > depends on PCI > > + depends on !UML > > I would advo

Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

2022-12-01 Thread Richard Weinberger
- Ursprüngliche Mail - > I would advocate to add this line to whole drivers/infiniband. > None of RDMA code makes sense for UML. Yes. Makes sense. Thanks, //richard ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.o

Re: [PATCH 2/2] IB/rdmavt: don't use rdmavt for UML

2022-12-01 Thread Leon Romanovsky
On Wed, Nov 30, 2022 at 12:09:58PM -0800, Randy Dunlap wrote: > When building rdmavt for ARCH=um, qp.c has a build error on a reference > to the x86-specific cpuinfo field 'x86_cache_size'. > > Fix the build errors by making this driver depend on !UML. > > Prevents these build errors: > > ../dri

Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

2022-12-01 Thread Leon Romanovsky
On Wed, Nov 30, 2022 at 12:09:45PM -0800, Randy Dunlap wrote: > When building qib_wc_x86_64.c on ARCH=um, references to some cpuinfo > fields cause build errors since cpuinfo does not contain x86-specific > fields. > > Fix the build errors by making this driver depend on !UML. > > Prevents these