Re: [PATCH 2/2] um: Cleanup compiler warning in arch/x86/um/tls_32.c

2022-08-26 Thread Randy Dunlap
On 8/26/22 08:29, Lukas Straub wrote: > arch.tls_array is statically allocated so checking for NULL doesn't > make sense. This causes the compiler warning below. > > Remove the checks to silence these warnings. > > ../arch/x86/um/tls_32.c: In function 'get_free_idx': > ../arch/x86/um/tls_32.c:

Re: [PATCH 1/2] um: Cleanup syscall_handler_t cast in syscalls_32.h

2022-08-26 Thread Randy Dunlap
On 8/26/22 08:29, Lukas Straub wrote: > Like in f4f03f299a56ce4d73c5431e0327b3b6cb55ebb9 > "um: Cleanup syscall_handler_t definition/cast, fix warning", > remove the cast to to fix the compiler warning. > > Signed-off-by: Lukas Straub Acked-by: Randy Dunlap # build-tested Thanks. > --- >

Re: [PATCH] arch: um: Mark the stack non-executable to fix a binutils warning

2022-08-26 Thread Randy Dunlap
On 8/22/22 18:08, David Gow wrote: > Since binutils 2.39, ld will print a warning if any stack section is > executable, which is the default for stack sections on files without a > .note.GNU-stack section. > > This was fixed for x86 in commit ffcf9c5700e4 ("x86: link vdso and boot with > -z no

Re: [PATCH] arch: um: Mark the stack non-executable to fix a binutils warning

2022-08-26 Thread Lukas Straub
Looks good to me: Reviewed-by: Lukas Straub Tested-by: Lukas Straub Regards, Lukas Straub -- pgp8NxzokbqHD.pgp Description: OpenPGP digital signature ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinf

[PATCH 2/2] um: Cleanup compiler warning in arch/x86/um/tls_32.c

2022-08-26 Thread Lukas Straub
arch.tls_array is statically allocated so checking for NULL doesn't make sense. This causes the compiler warning below. Remove the checks to silence these warnings. ../arch/x86/um/tls_32.c: In function 'get_free_idx': ../arch/x86/um/tls_32.c:68:13: warning: the comparison will always evaluate as

[PATCH 1/2] um: Cleanup syscall_handler_t cast in syscalls_32.h

2022-08-26 Thread Lukas Straub
Like in f4f03f299a56ce4d73c5431e0327b3b6cb55ebb9 "um: Cleanup syscall_handler_t definition/cast, fix warning", remove the cast to to fix the compiler warning. Signed-off-by: Lukas Straub --- arch/x86/um/shared/sysdep/syscalls_32.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 0/2] um: Fix compiler warnings on x86

2022-08-26 Thread Lukas Straub
Hello Everyone, These patches fix some compiler errors on x86. I tested quickly without any userspace and it booted fine. Regards, Lukas Straub Lukas Straub (2): um: Cleanup syscall_handler_t cast in syscalls_32.h um: Cleanup compiler warning in arch/x86/um/tls_32.c arch/x86/um/shared/sysde