Re: [PATCH 03/16] kdb: Use real_parent when displaying a list of processes

2022-05-20 Thread Doug Anderson
Hi, On Thu, May 19, 2022 at 4:49 PM Eric W. Biederman wrote: > > Doug Anderson writes: > > > Hi, > > > > On Wed, May 18, 2022 at 3:54 PM Eric W. Biederman > > wrote: > >> > >> kdb has a bug that when using the ps command to display a list of > >> processes, if a process is being debugged the d

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-20 Thread Peter Zijlstra
On Fri, May 20, 2022 at 02:32:24PM -0500, Eric W. Biederman wrote: > Sebastian Andrzej Siewior writes: > > > On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > >> > >> For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once > >> ptrace_freeze_traced has completed successfully

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-20 Thread Eric W. Biederman
Sebastian Andrzej Siewior writes: > On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: >> >> For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once >> ptrace_freeze_traced has completed successfully. Which fundamentally >> means the lock dance of dropping siglock and grabbing

[PATCH] um: chan_user: fix winch_tramp() return value

2022-05-20 Thread Johannes Berg
From: Johannes Berg The previous fix here was only partially correct, it did result in returning a proper error value in case of error, but it also clobbered the pid that we need to return from this function (not just zero for success). As a result, it returned 0 here, but later this is treated

Re: [PATCH 1/1] um: fix error return code in winch_tramp()

2022-05-20 Thread Nathan Chancellor
On Fri, May 20, 2022 at 07:18:28PM +0200, Johannes Berg wrote: > On Fri, 2022-05-20 at 08:55 -0700, Nathan Chancellor wrote: > > On Fri, May 20, 2022 at 08:08:01AM +0200, Thorsten Leemhuis wrote: > > > On 11.04.22 20:45, Richard Weinberger wrote: > > > > - Ursprüngliche Mail - > > > > > Von

Re: [PATCH 1/1] um: fix error return code in winch_tramp()

2022-05-20 Thread Johannes Berg
On Fri, 2022-05-20 at 08:55 -0700, Nathan Chancellor wrote: > On Fri, May 20, 2022 at 08:08:01AM +0200, Thorsten Leemhuis wrote: > > On 11.04.22 20:45, Richard Weinberger wrote: > > > - Ursprüngliche Mail - > > > > Von: "Nathan Chancellor" > > > > I attempted to print out the error code bu

Re: [PATCH 16/16] signal: Always call do_notify_parent_cldstop with siglock held

2022-05-20 Thread kernel test robot
Hi "Eric, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20220518] [cannot apply to linux/master powerpc/next wireless-next/main wireless/main linus/master v5.18-rc7 v5.18-rc6 v5.18-rc5 v5.18-rc7] [If your patch is applied to the wrong git tree, kindly dr

Re: [PATCH 1/1] um: fix error return code in winch_tramp()

2022-05-20 Thread Nathan Chancellor
On Fri, May 20, 2022 at 08:08:01AM +0200, Thorsten Leemhuis wrote: > On 11.04.22 20:45, Richard Weinberger wrote: > > - Ursprüngliche Mail - > >> Von: "Nathan Chancellor" > >> I attempted to print out the error code but it seems like there is no > >> output in the console after "reboot: Sy

Re: [PATCH 24/30] panic: Refactor the panic path

2022-05-20 Thread Guilherme G. Piccoli
On 19/05/2022 20:45, Baoquan He wrote: > [...] >> I really appreciate the summary skill you have, to convert complex >> problems in very clear and concise ideas. Thanks for that, very useful! >> I agree with what was summarized above. > > I want to say the similar words to Petr's reviewing comment

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-20 Thread Sebastian Andrzej Siewior
On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > After this set of changes only cgroup_enter_frozen should remain a > stumbling block for PREEMPT_RT in the ptrace_stop path. Yes, I can confirm that. I have no systemd-less system at hand which means I can't boot a kernel without CGROUP su

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-20 Thread Sebastian Andrzej Siewior
On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > > For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once > ptrace_freeze_traced has completed successfully. Which fundamentally > means the lock dance of dropping siglock and grabbing tasklist_lock does > not work on PREEMPT_