Re: [PATCH v2 1/4] ftrace: Add print_function_args()

2025-01-08 Thread Steven Rostedt
On Wed, 8 Jan 2025 11:19:11 + Alan Maguire wrote: > >>> + trace_seq_printf(s, "("); > >>> + > >>> + if (!args) > >>> + goto out; > >>> + if (lookup_symbol_name(func, name)) > >>> + goto out; > >>> + > >>> + btf = bpf_get_btf_vmlinux(); > >>>

Re: [PATCH v2 1/4] ftrace: Add print_function_args()

2025-01-08 Thread Alan Maguire
On 08/01/2025 15:24, Steven Rostedt wrote: > On Wed, 8 Jan 2025 11:19:11 + > Alan Maguire wrote: > > + trace_seq_printf(s, "("); > + > + if (!args) > + goto out; > + if (lookup_symbol_name(func, name)) > + goto out; > +

Re: [PATCH v2 1/4] ftrace: Add print_function_args()

2025-01-08 Thread Alan Maguire
On 08/01/2025 04:52, Masami Hiramatsu (Google) wrote: > On Wed, 8 Jan 2025 10:30:08 +0800 > Donglin Peng wrote: > >> Steven Rostedt 于2024年12月24日 周二04:14写道: >> >>> From: Sven Schnelle >>> >>> Add a function to decode argument types with the help of BTF. Will >>> be used to display arguments in th

Re: [PATCH v2 1/4] ftrace: Add print_function_args()

2025-01-07 Thread Google
On Wed, 8 Jan 2025 10:30:08 +0800 Donglin Peng wrote: > Steven Rostedt 于2024年12月24日 周二04:14写道: > > > From: Sven Schnelle > > > > Add a function to decode argument types with the help of BTF. Will > > be used to display arguments in the function and function graph > > tracer. > > > > It can only

Re: [PATCH v2 1/4] ftrace: Add print_function_args()

2024-12-25 Thread Steven Rostedt
On Wed, 25 Dec 2024 22:15:55 +0900 Masami Hiramatsu (Google) wrote: > > > > +config FUNCTION_TRACE_ARGS > > + bool > > + depends on HAVE_FUNCTION_ARG_ACCESS_API > > + depends on DEBUG_INFO_BTF > > For using the BTF APIs, we also needs BPF_SYSCALL (DEBUG_INFO_BTF just > compiles the

Re: [PATCH v2 1/4] ftrace: Add print_function_args()

2024-12-25 Thread Google
On Mon, 23 Dec 2024 15:13:48 -0500 Steven Rostedt wrote: > From: Sven Schnelle > > Add a function to decode argument types with the help of BTF. Will > be used to display arguments in the function and function graph > tracer. > > It can only handle simply arguments and up to FTRACE_REGS_MAX_AR

Re: [PATCH v2 1/4] ftrace: Add print_function_args()

2024-12-23 Thread Steven Rostedt
On Mon, 23 Dec 2024 15:13:48 -0500 Steven Rostedt wrote: > +#ifdef CONFIG_FUNCTION_TRACE_ARGS > +void print_function_args(struct trace_seq *s, unsigned long *args, > + unsigned long func) > +{ > + const struct btf_param *param; > + const struct btf_type *t; > + co

[PATCH v2 1/4] ftrace: Add print_function_args()

2024-12-23 Thread Steven Rostedt
From: Sven Schnelle Add a function to decode argument types with the help of BTF. Will be used to display arguments in the function and function graph tracer. It can only handle simply arguments and up to FTRACE_REGS_MAX_ARGS number of arguments. When it hits a max, it will print ", ...": pa