Re: [PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-09-09 Thread Vineet Gupta
On 9/9/20 11:36 AM, Adhemerval Zanella via Libc-alpha wrote: > > > On 08/09/2020 23:48, Vineet Gupta via Libc-alpha wrote: >> From: Vineet Gupta >> >> This seems to be dead code, so remove it. > > It could be useful for a possible statfs/statfs64 consolidation, but indeed > it is dead code now.

Re: [PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-09-09 Thread Adhemerval Zanella
On 08/09/2020 23:48, Vineet Gupta via Libc-alpha wrote: > From: Vineet Gupta > > This seems to be dead code, so remove it. It could be useful for a possible statfs/statfs64 consolidation, but indeed it is dead code now. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/unix

Re: [PATCH] support: user more portable atomic wrappers

2020-09-09 Thread Vineet Gupta
On 9/9/20 3:19 AM, Florian Weimer via Libc-alpha wrote: > * Vineet Gupta via Libc-alpha: > >> This came up in a nascent arc64 port, lacking gcc atomics for now > > Can you please change the GCC port to provide atomics instead? Sure, they are added now. > It does not make sense to maintain those

Re: [PATCH v4 00/13] mm/debug_vm_pgtable fixes

2020-09-09 Thread Gerald Schaefer
On Wed, 9 Sep 2020 13:38:25 +0530 Anshuman Khandual wrote: > > > On 09/04/2020 08:56 PM, Gerald Schaefer wrote: > > On Fri, 4 Sep 2020 12:18:05 +0530 > > Anshuman Khandual wrote: > > > >> > >> > >> On 09/02/2020 05:12 PM, Aneesh Kumar K.V wrote: > >>> This patch series includes fixes for debu

Re: [PATCH v4 00/13] mm/debug_vm_pgtable fixes

2020-09-09 Thread Gerald Schaefer
On Wed, 09 Sep 2020 11:38:39 +0530 "Aneesh Kumar K.V" wrote: > Gerald Schaefer writes: > > > On Fri, 4 Sep 2020 18:01:15 +0200 > > Gerald Schaefer wrote: > > > > [...] > >> > >> BTW2, a quick test with this change (so far) made the issues on s390 > >> go away: > >> > >> @@ -1069,7 +1074,7 @@

Re: [PATCH v4 00/13] mm/debug_vm_pgtable fixes

2020-09-09 Thread Gerald Schaefer
On Wed, 9 Sep 2020 13:45:48 +0530 Anshuman Khandual wrote: [...] > > > > That would more match the "pte_t pointer" usage for hugetlb code, > > i.e. just cast a pmd_t pointer to it. Also changed to pmd_aligned, > > but I think the root cause is the pte_t pointer. > > Ideally, the pte_t pointer u

Re: Flushing transparent hugepages

2020-09-09 Thread Aneesh Kumar K.V
Matthew Wilcox writes: > PowerPC has special handling of hugetlbfs pages. Well, that's what > the config option says, but actually it handles THP as well. If > the config option is enabled. > > #ifdef CONFIG_HUGETLB_PAGE > if (PageCompound(page)) { > flush_dcache_icache_

Re: [PATCH] support: user more portable atomic wrappers

2020-09-09 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > This came up in a nascent arc64 port, lacking gcc atomics for now Can you please change the GCC port to provide atomics instead? It does not make sense to maintain those atomics in many projects separately. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com

Re: [PATCH v4 00/13] mm/debug_vm_pgtable fixes

2020-09-09 Thread Anshuman Khandual
On 09/04/2020 11:23 PM, Gerald Schaefer wrote: > On Fri, 4 Sep 2020 18:01:15 +0200 > Gerald Schaefer wrote: > >> On Fri, 4 Sep 2020 17:26:47 +0200 >> Gerald Schaefer wrote: >> >>> On Fri, 4 Sep 2020 12:18:05 +0530 >>> Anshuman Khandual wrote: >>> On 09/02/2020 05:12 PM, Aneesh Ku

[kbuild] Re: [PATCH] ARC: [plat-eznps]: Drop support for EZChip NPS platform

2020-09-09 Thread Dan Carpenter
Hi Vineet, I love your patch! Yet something to improve: url: https://github.com/0day-ci/linux/commits/Vineet-Gupta/ARC-plat-eznps-Drop-support-for-EZChip-NPS-platform/20200909-121133 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Re: [PATCH v4 00/13] mm/debug_vm_pgtable fixes

2020-09-09 Thread Anshuman Khandual
On 09/04/2020 09:31 PM, Gerald Schaefer wrote: > On Fri, 4 Sep 2020 17:26:47 +0200 > Gerald Schaefer wrote: > >> On Fri, 4 Sep 2020 12:18:05 +0530 >> Anshuman Khandual wrote: >> >>> >>> >>> On 09/02/2020 05:12 PM, Aneesh Kumar K.V wrote: This patch series includes fixes for debug_vm_pgta

Re: [PATCH v4 00/13] mm/debug_vm_pgtable fixes

2020-09-09 Thread Anshuman Khandual
On 09/04/2020 08:56 PM, Gerald Schaefer wrote: > On Fri, 4 Sep 2020 12:18:05 +0530 > Anshuman Khandual wrote: > >> >> >> On 09/02/2020 05:12 PM, Aneesh Kumar K.V wrote: >>> This patch series includes fixes for debug_vm_pgtable test code so that >>> they follow page table updates rules correctl