Re: [PATCH 1/4] drivers: target: Move prototype declaration of function to header file target_core_pr.h

2013-12-18 Thread josh
wing warning in target_core_spc.c: > drivers/target/target_core_spc.c:138:6: warning: no previous prototype for > ‘spc_parse_naa_6h_vendor_specific’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/target/target_core_pr.h

Re: [PATCH 2/4] drivers: target: Mark function as static in target_core_iblock.c

2013-12-18 Thread josh
_iblock.c:766:6: warning: no previous prototype for > ‘iblock_get_write_cache’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/target/target_core_iblock.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &g

Re: [PATCH 3/4] drivers: target: Mark functions as static in tcm_loop.c

2013-12-18 Thread josh
pes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/target/loopback/tcm_loop.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/target/loopback/tcm_loop.c > b/drivers/target/loopback/tcm_loop.c > index 1b4

Re: [PATCH 4/4] drivers: target: Mark functions and structures as static in tfc_conf.c

2013-12-18 Thread josh
ivers/target/tcm_fc/tfc_conf.c:602:6: warning: no previous prototype for > ‘ft_deregister_configfs’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/target/tcm_fc/tfc_conf.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletio

Re: [PATCH] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-06-11 Thread Josh Boyer
change fixes the issue > and makes pvscsi_map_buffers() function more robust. > > Signed-off-by: Arvind Kumar > Cc: Josh Boyer This patch has been sent and pinged for 3 months now. It's gotten no comments at all. Should we send it to Linus so it actually gets picked up? josh

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-30 Thread Josh Boyer
minimise > > exchange wreckage on mailinglists, but I should acknowledge Parallels as > > supporting the work I do. > > Thanks, I've update the author, added a Cc to ћtable and pushed it out to > the core-for-3.17 branch. This fixes a bug in the 3.16 kernel. Why wouldn't it

Re: [PATCH v2 6/8] tools rpmb: add RPBM access tool

2016-04-11 Thread Josh Poimboeuf
_install firewire_install hv_install lguest_install perf_install > usb_install virtio_install vm_install net_install objtool_install: > +cgroup_install firewire_install hv_install lguest_install perf_install > rpmb_install usb_install virtio_install vm_install net_install > objtool_install: > +cgr

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-13 Thread Josh Poimboeuf
On Wed, Apr 13, 2016 at 09:55:09AM -0700, James Bottomley wrote: > On Wed, 2016-04-13 at 10:15 -0500, Josh Poimboeuf wrote: > > On Wed, Apr 13, 2016 at 07:36:07AM -0500, Josh Poimboeuf wrote: > > > On Wed, Apr 13, 2016 at 02:12:25PM +0200, Denys Vlasenko wrote: > > > >

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-14 Thread Josh Poimboeuf
On Thu, Apr 14, 2016 at 05:29:06PM +0200, Denys Vlasenko wrote: > On 04/13/2016 07:10 PM, Josh Poimboeuf wrote: > >>>>>> From the disassembly of drivers/scsi/qla2xxx/qla_attr.o: > >>>>>> > >>>>>> 2f53 : > >>

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-15 Thread Josh Poimboeuf
on't be able to detect all cases of the bug and some function calls may just silently disappear! There's a lot of activity in the bug now, so hopefully they'll be able to tell us soon if there's a reliable way to avoid it and/or detect it. BTW, Denys posted a workaroun

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

2016-04-15 Thread Josh Poimboeuf
fff. uint8_t node_name[WWN_SIZE] = { 0xFF, 0xFF, 0xFF, 0xFF, \ 0xFF, 0xFF, 0xFF, 0xFF}; u64 fabric_name = wwn_to_u64(node_name); Similar to what Denys suggested, it can just be: u64 fabric_name = -1; or u64 fabric_name = 0x; Wouldn&#x

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-15 Thread Josh Poimboeuf
On Fri, Apr 15, 2016 at 08:47:45AM -0500, Josh Poimboeuf wrote: > On Fri, Apr 15, 2016 at 07:45:19AM +0200, Ingo Molnar wrote: > > > > * Denys Vlasenko wrote: > > > > > > In fact, the following patch seems to fix it: > > > > > > > >

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-18 Thread Josh Poimboeuf
ain > CPU instructions that require aligned data when we tell it that unaligned > data is not). > > It changes the code enough that the gcc bug might not be triggered any more, > aside from generating far superior code in some cases. I tried this patch, but unfortunately it doesn't make the gcc bug go away. -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-18 Thread Josh Poimboeuf
On Sat, Apr 16, 2016 at 11:03:32AM +0200, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > > I don't think we know yet if there's a reliable way to turn the bug off. > > > > > > Also, according to the gcc guys, this bug won't always resu

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-18 Thread Josh Poimboeuf
On Mon, Apr 18, 2016 at 04:07:51PM +0200, Arnd Bergmann wrote: > On Monday 18 April 2016 08:39:32 Josh Poimboeuf wrote: > > > > I agree. So how should we work around the bug in this case? There have > > been several suggestions: > > > > - chang

[PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-19 Thread Josh Poimboeuf
functions to be inlined. [1] https://lists.01.org/pipermail/kbuild-all/2016-April/019579.html [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 Reported-by: kbuild test robot Signed-off-by: Josh Poimboeuf --- include/scsi/scsi_transport_fc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-25 Thread Josh Poimboeuf
James, Can you merge this patch for 4.6? On Tue, Apr 19, 2016 at 08:56:00AM -0500, Josh Poimboeuf wrote: > objtool reports [1] the following warning: > > drivers/scsi/qla2xxx/qla_attr.o: warning: objtool: > qla2x00_get_host_fabric_name() falls through to n

Re: [PATCH, RFT] byteswap: try to avoid __builtin_constant_p gcc bug

2016-04-27 Thread Josh Poimboeuf
ast there should be no downsides. > > Please test. > > Signed-off-by: Arnd Bergmann Nice patch. I can confirm it fixes the issue with gcc 5.3.1. Tested-by: Josh Poimboeuf Reviewed-by: Josh Poimboeuf > diff --git a/include/uapi/linux/swab.h b/include/uapi/linux/swab.h > index

Re: [PATCH 1/3] scsi: ufs: Allow vendor specific initialization

2013-08-13 Thread Josh Cartwright
On Tue, Aug 13, 2013 at 04:30:18PM +0530, Sujit Reddy Thumma wrote: [..] > diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c > index a823cf4..829f7a4 100644 > --- a/drivers/scsi/ufs/ufshcd-pci.c > +++ b/drivers/scsi/ufs/ufshcd-pci.c > @@ -191,7 +191,13 @@ ufshcd_pci_probe(s

Re: scsi: Implement per-cpu logging buffer

2015-02-12 Thread Josh Triplett
coming in from > various CPUs overwriting each other and _not_ introduce additional > latency by locking a single buffer, then yes. > > We can possibly reduce it to, say, 1KiB or even lower by imposing > stricter rules on the logging functions. > But I don't see a way aroun

Re: scsi: Implement per-cpu logging buffer

2015-02-13 Thread Josh Triplett
On Fri, Feb 13, 2015 at 09:48:36AM +0100, Hannes Reinecke wrote: > On 02/12/2015 06:18 PM, Josh Triplett wrote: > > On Thu, Feb 12, 2015 at 02:29:35PM +0100, Hannes Reinecke wrote: > >> On 02/12/2015 01:36 PM, Geert Uytterhoeven wrote: > >>> On Wed, Feb 11, 2015 at

Re: scsi: Implement per-cpu logging buffer

2015-02-15 Thread Josh Triplett
On Sat, Feb 14, 2015 at 03:29:37PM +0100, Hannes Reinecke wrote: > On 02/13/2015 04:45 PM, Josh Triplett wrote: > > On Fri, Feb 13, 2015 at 09:48:36AM +0100, Hannes Reinecke wrote: > >> On 02/12/2015 06:18 PM, Josh Triplett wrote: > >>> On Thu, Feb 12, 2015 at 02:

[PATCH Resend] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-12-01 Thread Josh Boyer
obust. Signed-off-by: Arvind Kumar Cc: Josh Boyer Reviewed-by: Thomas Hellstrom Signed-off-by: Josh Boyer --- - Resend of patch that was never committed for some reason drivers/scsi/vmw_pvscsi.c | 45 +++-- drivers/scsi/vmw_pvscsi.h | 2 +- 2 files change

Re: [PATCH Resend] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-12-02 Thread Josh Boyer
On Wed, Dec 2, 2015 at 3:42 AM, Johannes Thumshirn wrote: > Hi Josh, > > On Tue, 2015-12-01 at 11:34 -0500, Josh Boyer wrote: >> The driver is missing calls to pci_dma_mapping_error() after >> performing the DMA mapping, which caused DMA-API warning to >> show up in

[PATCH v2] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-12-03 Thread Josh Boyer
obust. Signed-off-by: Arvind Kumar Cc: Josh Boyer Reviewed-by: Thomas Hellstrom Signed-off-by: Josh Boyer --- v2: Use -ENOMEM instead of -1 for the error return code as suggested by Johannes Thumshirn drivers/scsi/vmw_pvscsi.c | 45 +++-- drivers

Re: [PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread Josh Boyer
On Fri, 26 Oct 2007 05:40:22 -0400 (EDT) Jeff Garzik <[EMAIL PROTECTED]> wrote: > mostly in and around irq handlers. > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > --- > drivers/serial/uartlite.c |2 +- Acked-by: Josh Boyer <[EMAIL PR

Re: [PATCH] scsi: BusLogic: Fix an oops when intializing multimaster adapter

2013-10-17 Thread Josh Boyer
Logic with the 3.11 kernel in Fedora. They tested a kernel build based on 3.11.5 plus this patch and it fixes their issue. Details here: https://bugzilla.redhat.com/show_bug.cgi?id=1015558 You can add a Tested-by: Bojan Smojver if you'd like. josh > --- > drivers/scsi/BusLogic.

Re: [3.12-rc] sg_open: leaving the kernel with locks still held!

2013-10-23 Thread Josh Boyer
if there is enough time, a fix will (or at least should) >> go in before the release of lk 3.12 . > > I think you've got about a week to prove you can fix it (before 3.12 > goes final). I'll send my current set of fixes to Linus without doing > anything about sg. In the event that a suitable fix isn't found, are you going to revert the commit(s) that caused the issue? josh -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] drivers: message: Mark function mpt_SoftResetHandler() as static in mptbase.c

2013-12-13 Thread Josh Triplett
/mptbase.c:7011:1: warning: no previous prototype for > ‘mpt_SoftResetHandler’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/message/fusion/mptbase.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [PATCH 2/3] drivers: message: Mark function mptscsih_quiesce_raid() as static in mptspi.c

2013-12-13 Thread Josh Triplett
/message/fusion/mptspi.c:624:1: warning: no previous prototype for > ‘mptscsih_quiesce_raid’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/message/fusion/mptspi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c

2013-12-13 Thread Josh Triplett
_add’ [-Wmissing-prototypes] > drivers/message/fusion/mptsas.c:5327:1: warning: no previous prototype for > ‘mptsas_shutdown’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/message/fusion/mptsas.c |6 +++--- > 1 file changed, 3 in

DMA-API mapping errors in vmw_pvscsi

2014-03-17 Thread Josh Boyer
Even if it did, I'm not sure what the proper response to an error should be. Thoughts? josh [2.962772] [ cut here ] [2.963764] WARNING: CPU: 1 PID: 6 at lib/dma-debug.c:1140 check_unmap+0x4ee/0x9e0() [2.965382] vmw_pvscsi :03:00.0: DMA-API: device dr

Re: [PATCH 19/55] scsi: Mark function as static in isci/phy.c

2014-03-31 Thread Josh Triplett
ning in isci/phy.c: > > drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for > > ‘scu_link_layer_set_txcomsas_timeout’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett > > Acked-by: Lukasz Dorau Since

3.15 drivers/net/ethernet/broadcom/cnic.c:576 suspicious rcu_dereference_check() usage!

2014-04-15 Thread Josh Boyer
Hi All, We've had a report [1] of the bnx2i/cnic driver(s) throwing suspicious RCU usage with 3.15 merge window kernels on an i686 machine. This corresponds to Linux v3.14-12812-g321d03c86732. I've included the dump below. Has anyone seen this issue before? josh

Re: [PATCH 1/1] bnx2x: Add FW 7.13.11.0.

2019-02-12 Thread Josh Boyer
after sending inner IP fragmented traffic. > - Issues in the following FW flows: > SD VLAN update, TX packet drop, packet padding flow, vlan add/remove. > > Signed-off-by: Sudarsana Reddy Kalluru > Signed-off-by: Ariel Elior > Signed-off-by: Rahul Verma Applied and pushed out. josh

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-09 Thread Josh Poimboeuf
Jann Horn's paper, it would seem > > like PTI doesn't really lock it down fully, right? > > Here is the latest (v3) bpf fix: > > https://patchwork.ozlabs.org/patch/856645/ > > I currently have v2 on my 'nospec' branch and will move that to v3 for > the next update, unless it goes upstream before then. That patch seems specific to CONFIG_BPF_SYSCALL. Is the bpf() syscall the only attack vector? Or are there other ways to run bpf programs that we should be worried about? -- Josh

Re: [PATCH 1/1] qed: Add firmware 8.33.11.0

2018-03-12 Thread Josh Boyer
_zipped-8.33.11.0.bin I had to fixup a small conflict in WHENCE, but no big deal. Applied and pushed out. josh

Re: [PATCH linux-firmware] bnx2x: Add FW 7.13.15.0.

2019-10-23 Thread Josh Boyer
in 0 -> 178608 bytes > bnx2x/bnx2x-e2-7.13.15.0.fw | Bin 0 -> 323360 bytes > 4 files changed, 3 insertions(+) > create mode 100644 bnx2x/bnx2x-e1-7.13.15.0.fw > create mode 100644 bnx2x/bnx2x-e1h-7.13.15.0.fw > create mode 100644 bnx2x/bnx2x-e2-7.13.15.0.fw Applied and pushed out. josh

[PATCH] scsi: ufs: use PTR_ERR_OR_ZERO in ufs_hisi_get_resource()

2018-09-12 Thread Josh Abraham
Use PTR_ERR_OR_ZERO instead of IF_ERR() return PTR_ERR(). Signed-off-by: Joshua Abraham --- drivers/scsi/ufs/ufs-hisi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c index 46df707e6f2c..e79499469cb3 100644 --- a/d

[PATCH] scsi: ufs: use PTR_ERR_OR_ZERO in ufs_hisi_get_resource()

2018-09-23 Thread Josh Abraham
This patch uses PTR_ERR_OR_ZERO instead of IF_ERR() return PTR_ERR(). Signed-off-by: Joshua Abraham --- drivers/scsi/ufs/ufs-hisi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c index 46df707e6f2c..e79499469cb3 10

Re: [PATCH 5/9] powerpc: PCI_MSI needs PCI

2018-10-19 Thread Josh Triplett
On Fri, Oct 19, 2018 at 02:09:48PM +0200, Christoph Hellwig wrote: > Various powerpc boards select the PCI_MSI config option without selecting > PCI, resulting in potentially not compilable configurations if the by > default enabled PCI option is disabled. Explicitly select PCI to ensure > we alwa

[PATCH] Scsi: Fixed white space and tab errors.

2012-09-26 Thread Josh Taylor
Signed-off-by: Josh Taylor --- drivers/scsi/scsi.c | 66 +-- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..00aded9 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi

Re: [PATCH v2 1/1] qed: Add firmware 8.37.2.0

2018-05-25 Thread Josh Boyer
WHENCE | 1 + > qed/qed_init_values_zipped-8.37.2.0.bin | Bin 0 -> 867472 bytes > 2 files changed, 1 insertion(+) > create mode 100755 qed/qed_init_values_zipped-8.37.2.0.bin Applied and pushed out. josh