On Mon, Dec 19, 2016 at 03:33:27PM +, Bart Van Assche wrote:
> Please consider removing the sess_cmd_list loop. Any lookups in
> sess_cmd_list should be performed by the target core and not by a
> target driver. Are you aware that core_tmr_abort_task() performs a very
> similar lookup to the on
On Mon, Dec 19, 2016 at 04:29:57PM +, Bart Van Assche wrote:
> The SCSI Architecture Manual (SAM-6) specifies that the SCSI transport
> protocol defines whether the scope of the ABORT TASK task management
> function is I_T_L or I_T. In the Fibre Channel Protocol for SCSI (FCP)
> document I read
On Wed, Jan 11, 2017 at 04:08:31PM +, Bart Van Assche wrote:
> A typical Ethernet network adapter delays the generation of an interrupt
> after it has received a packet. A typical block device or HBA does not delay
> the generation of an interrupt that reports an I/O completion.
NVMe allows fo
On Thu, Feb 16, 2017 at 01:21:29PM -0500, Mike Snitzer wrote:
> multipath-tools has tables that specify all the defaults for a given
> target backend. NVMe will just be yet another.
No, if we get things right it won't. ALUA already got rid of most
of the parameter people would have to set under
On Fri, Jul 18, 2014 at 04:57:13PM +, James Bottomley wrote:
> Actually, no you didn't. The difference is in the derivation of the
> timeout. Christoph's patch is absolute in terms of SD_TIMEOUT; yours is
> relative to the queue timeout setting ... I thought there was a reason
> for preferrin
This is what I plan to put in after it passes basic testing:
---
>From bb617c9465b839d70ecbbc69002a20ccf5f935bd Mon Sep 17 00:00:00 2001
From: "K. Y. Srinivasan"
Date: Fri, 18 Jul 2014 19:12:58 +0200
Subject: sd: fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O
timeout
Commit ID: 7e66
On Fri, Jul 18, 2014 at 10:12:38AM -0700, h...@infradead.org wrote:
> This is what I plan to put in after it passes basic testing:
And that one was on top of my previous version. One that applies
against core-for-3.17 below:
---
>From 8a79783e5f72ec034a724e16c1f46604bd97bf68 Mon Sep 17 00
On Tue, Aug 05, 2014 at 06:04:07PM +, Handzik, Joe wrote:
> Hey Christoph,
>
> Using the scsi-mq.4 branch from git://git.infradead.org/users/hch/scsi.git,
> I'm getting a -1 returned from from scsi_cmnd->request->tag...very unsure why
> that would be. It happens without any drives attached t
On Tue, Aug 05, 2014 at 07:47:12PM +, Handzik, Joe wrote:
> Yeah, we thought about that one. We call scsi_activate_tcq if our scsi_device
> has tagged_supported set within hpsa_change_queue_type (our
> .change_queue_type entry into the scsi_host_template). Also made sure I was
> booting with
FYI: I won't read your mails until you actually make them readable
by trimming the quotes back to provide just enough context.
Consider this mail (and the one you replied to) unread.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vge
On Thu, Apr 23, 2015 at 07:50:41AM +0200, Hannes Reinecke wrote:
> Yes, that's okay with me.
>
> Personally I would be using mempools when you need lots of small,
> frequently changed allocations (like sg elements), and kzalloc() for
> large or infrequently changed bits of memory.
The array looku
On Mon, Mar 10, 2014 at 09:52:03PM +0100, Hannes Reinecke wrote:
> Yes, I thought of that, too.
> I thought to remember that binary attributes are reserved for
> firmware/hardware-dependent interfaces.
That's what we're dealing with here, aren't we?
> What should happen with the first patch in th
On Tue, May 27, 2014 at 09:49:48AM +0200, Bart Van Assche wrote:
> > I don't see the value of patches 2,3 they're checking for an impossible
> > condition ... why might it be possible?
>
> When reading the source code in scsi_error.c it's easy to overlook that
> scmd_eh_abort_handler(), scsi_abort
On Mon, Jun 02, 2014 at 07:22:07PM +, James Bottomley wrote:
> Actually, can you really pull it out, not just revert it? Reverts cause
> problems with bisection and are unnecessary before the tree goes to
> Linus.
>
> If preserving history becomes a real goal, we'd have to move to a tip
> lik
On Mon, Jun 02, 2014 at 01:05:38PM -0700, Linus Torvalds wrote:
> I would indeed prefer to avoid rebases, _unless_ the tree is a real
> mess without it.
>
> Now, what constitues "real mess" can vary. It can be just really ugly
> history, and part of that can be "it doesn't build or work at all
> p
On Mon, Jun 02, 2014 at 01:24:22PM -0700, Linus Torvalds wrote:
> If it isn't a particularly large patch and doesn't have any other
> issues, I'd suggest just reverting it.
>
> Particularly large patches can be worth undoing just to avoid
> unnecessary noise in "git blame" etc, but that's an issue
On Fri, Jun 13, 2014 at 04:52:52PM +, James Bottomley wrote:
> If you're seeing double completions it's either because we have a bug in
> SCSI and are doing something with the command before we know block has
> relinquished it. That's actually why this bug was so serious:
Note that drivers or
On Wed, Jul 09, 2014 at 10:36:26PM +, KY Srinivasan wrote:
> Ok; I am concerned about older kernels that do not have no_write_same flag.
> I suppose I can work directly with these Distros and give them a choice:
> either implement
> the no_write_same flag or filter the command in our driver. I
On Wed, Jul 09, 2014 at 10:27:24PM +, James Bottomley wrote:
> If we fix it at source, why would there be any need to filter? That's
> the reason the no_write_same flag was introduced. If we can find and
> fix the bug, it can go back into the stable trees as a bug fix, hence
> nothing should
On Sun, Jul 13, 2014 at 08:58:34AM -0400, Martin K. Petersen wrote:
> > "KY" == KY Srinivasan writes:
>
> KY> Windows hosts do support UNMAP and set the field in the
> KY> EVPD. However, since the host advertises SPC-2 compliance, Linux
> KY> does not even query the VPD page.
>
> >> If we w
On Wed, Jul 16, 2014 at 11:44:18AM -0400, Martin K. Petersen wrote:
> There are lots of devices out there that support WRITE SAME(10) or (16)
> without the UNMAP bit. And there are devices that support WRITE SAME w/
> UNMAP functionality but not "regular" WRITE SAME.
Oh, we actually have devices t
On Wed, Jul 16, 2014 at 01:47:35PM -0400, Martin K. Petersen wrote:
> There were several SSDs that did not want to support wearing out flash
> by writing gobs of zeroes and only support the UNMAP case.
Given that SSDs usually aren't hard provisioned anyway that seems like
an odd decision. But SAS
On Wed, Jul 16, 2014 at 03:20:00PM -0400, Martin K. Petersen wrote:
> The block layer can only describe one contiguous block range in a
> request. My copy offload patches introduces the bi_special field that
> allows us to attach additional information to an I/O. I have
> experimented with doing th
On Thu, Aug 03, 2017 at 05:33:13PM +, Bart Van Assche wrote:
> Are you aware that the SCSI core already keeps track of the number of busy
> requests
> per LUN? See also the device_busy member of struct scsi_device. How about
> giving the
> block layer core access in some way to that counter?
On Fri, Oct 17, 2014 at 07:43:34PM +, Anish Bhatt wrote:
> I actually wanted to get some clarification on how the branches on scsi-queue
> work. The core/drivers separation is easy enough, but the current branches
> are confusing. If say I am submitting a bug fix for the next 3.17 release,
>
On Sat, Oct 18, 2014 at 08:12:03AM -0700, h...@infradead.org wrote:
> Anything that is an urgent and/or very small fix should just be against
> Linus' current tree and will go into the drivers branch for that tree.
>
> Anything bigger and/or less urgent should be sent against the
On Sun, Oct 19, 2014 at 04:07:59AM +, Anish Bhatt wrote:
> Aah, thanks for the clarification. I have made mistakenly made this patch
> against drivers-for-3.18 then, but it applies cleanly to drivers-for-3.17 as
> well, please apply this to drivers-for-3.17.
Linux 3.17 has been released. Th
On Sat, Oct 25, 2014 at 12:06:32AM +, Anish Bhatt wrote:
> Pinging for visibility.
I've queued this up for 3.18, but I'm still waiting for review on
the other patches I'd like to throw into that tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a mes
On Wed, Dec 24, 2014 at 05:51:27PM +, Praveen Madhavan wrote:
> Hi Christoph,
> Can u please pull the csiostor changes from net-next ?. I need these changes
> to submit next fixes in scsi tree.
How much do you plan to send for the 3.20 window? I'd rather avoid
having to pull in the net-next
[fixing the netdev address]
On Sat, Dec 27, 2014 at 06:59:56AM -0800, h...@infradead.org wrote:
> On Wed, Dec 24, 2014 at 05:51:27PM +, Praveen Madhavan wrote:
> > Hi Christoph,
> > Can u please pull the csiostor changes from net-next ?. I need these
> > changes to subm
On Mon, Dec 29, 2014 at 09:07:59PM +, KY Srinivasan wrote:
> Should I be resending these patches.
I don't need a resend, I need a review for the patches. Note that for
driver patches I'm also fine with a review from a co worker, as long as
it's a real review not just a rubber stamp.
Talking
On Sun, Dec 28, 2014 at 03:13:14PM +, Praveen Madhavan wrote:
> > How much do you plan to send for the 3.20 window? I'd rather avoid
> > having to pull in the net-next tree and merge everything through Dave
> > if that seems feasible.
> I hv couple of patches fixes for 3.20 window. Can you ple
On Wed, Dec 17, 2014 at 08:10:15AM -0800, James Bottomley wrote:
> The usual way to do this is to make the common hardware function a base
> module and make all drivers that use it depend on it. Like iwldvm ->
> iwlwifi -> mac80211 etc.
>
> We really wouldn't want to do the link and build because
On Thu, Jul 17, 2014 at 11:53:33PM +, KY Srinivasan wrote:
> I still see this problem. There was talk of fixing it elsewhere.
Well, what we have right not is entirely broken, given that the
block layer doesn't initialize ->timeout on TYPE_FS requeuests.
We either need to revert that initial c
On Fri, Jul 18, 2014 at 12:51:06AM +, Elliott, Robert (Server Storage)
wrote:
> SYNCHRONIZE CACHE (16) should be favored over SYNCHRONIZE
> CACHE (10) unless SYNCHRONIZE CACHE (10) is not supported.
I gues you mean (16) for the last occurance? What's the benefit of
using SYNCHRONIZE CACHE (
35 matches
Mail list logo
