Re: [PATCH 00/20, v4] Make ib_srp better suited for H.A. purposes

Hi Bart, while testing ib_srp based on your srp-ha, we sometimes hit kernel crashes with the call trace below. How to reproduce: 0. Kernel 3.2.15 with SCST v4193 on the target, Kernel 3.2.8 with ib_srp-ha on the initiator. 1. Configure 500+ vdisks on target, and get initiator connected. 2. Ex

Re: [PATCH 00/20, v4] Make ib_srp better suited for H.A. purposes

Hi Bart, On 28.08.2012 10:04, Bart Van Assche wrote: > On 08/27/12 18:37, Dongsu Park wrote: > > while testing ib_srp based on your srp-ha, > > we sometimes hit kernel crashes with the call trace below. > > > > How to reproduce: > > > > 0. Kern

[PATCH 3/5] ib_srp: hold a mutex when adding a new target port

From: Dongsu Park Unter circumstances, srp_rport_add() can make conflicts with srp_rport_delete(), dumping the call trace written below. That does not always occur. But its possible reason is adding sysfs entries for the SRP target too fast, even before the deletion hasn't finished yet.

[PATCH 5/5] ib_srp: fix an error accessing invalid memory in rport_dev_loss_timedout

From: Bart Van Assche In rport_dev_loss_timedout(), rport must be obtained by accessing the member entry dev_loss_work, not fast_io_fail_work. Signed-off-By: Bart Van Assche --- drivers/scsi/scsi_transport_srp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/s

[PATCH 4/5] ib_srp: check if rport->lld_data is NULL before removing rport

From: Dongsu Park After removing rport_delete(), rport->lld_data has to be set to NULL. In addition to that, both srp_rport_delete() and rport_dev_loss_timedout() must check if rport->lld_data is NULL, before accessing to rport->lld_data or any rport's target area. Without t

[PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes

From: Dongsu Park Hi Bart, This patchset aims at fixing bugs that have been discovered in our own SRP test environment so far. These patches are based on your patchset v4, "Make ib_srp better suited for H.A. purposes",(09 Aug 2012). The 5th patch, "fix an error accessing in

[PATCH 2/5] ib_srp: removed superfluous warning in send timeout case

From: Dongsu Park Signed-off-By: Sebastian Riemer --- drivers/infiniband/ulp/srp/ib_srp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index a0d0ca2..1b274484 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b

[PATCH 1/5] ib_srp: free memory correctly in srp_free_iu()

From: Dongsu Park As a potential fix for a race condition in srp_free_iu(), hold a mutex in srp_free_target_ib() before calling srp_free_iu(). In addition, also clear rx/tx ring after freeing memory. Both rx_ring[] and tx_ring[] should be reinitialized to NULL, to prevent other tasks from