Re: [PATCH net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-03 Thread David Miller
From: Hariprasad Shenai Date: Mon, 3 Nov 2014 17:46:51 +0530 > This series moves the debugfs code to a new file debugfs.c, Cleans up macros > so > that they match the hardware generated one. How does "hardware generate the macros"? I don't understand what this means at all. Whatever your bet

Re: [PATCH v2 00/36] Fixes, cleanups and modernization for NCR5380 drivers

2014-11-04 Thread David Gálvez
2014-11-05 0:36 GMT+01:00 Michael Schmitz : > Hi Finn, > > >> Thanks for testing. >> >> "No regressions over v1" means "no regressions", right? >> >> >> >> Well, what would I compare the driver performance to? With your patches to >> sort out locking races, the driver is more stable than I've ever

Re: [PATCHv2 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-05 Thread David Miller
From: Hariprasad Shenai Date: Tue, 4 Nov 2014 08:20:54 +0530 > It's not really the "hardware" which generates these hardware constant > symbolic > macros/register defines of course, it's scripts developed by the hardware > team. > Various patches have ended up changing the style of the symboli

RE: Large disk drives

2014-11-06 Thread David Laight
But if the media is new/erased then all the sectors will be 0xff and you'd have to do a write to ensure there was no sector aliasing. David

Re: [PATCHv2 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-06 Thread David Miller
From: Hariprasad S Date: Thu, 6 Nov 2014 21:45:10 +0530 > On Wed, Nov 05, 2014 at 14:54:43 -0500, David Miller wrote: >> From: Hariprasad Shenai >> Date: Tue, 4 Nov 2014 08:20:54 +0530 >> >> > It's not really the "hardware" which generates these

RE: Large disk drives

2014-11-07 Thread David Laight
ces answering ATA IDENTIFY correctly either. I had some CF cards from one of the main 'labels' that reported an incorrectly layed out identify response, and 2 others (almost identical) that locked solid when the request was issued. We tried to send them back, but they were returned with a nic

Re: blk_mq: suspicious RCU usage, rcu_read_lock() used illegally while idle!

2014-11-07 Thread David Miller
From: "Paul E. McKenney" Date: Fri, 7 Nov 2014 07:06:28 -0800 > On Fri, Nov 07, 2014 at 12:50:02PM +0200, Meelis Roos wrote: >> Perhaps DaveM can tell which one is coreect or if there is any related >> problem. > > Happy to push either of them along, if appropriate. We should use irq_enter()/i

Re: [PATCHv3 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-10 Thread David Miller
know in case of any review comments. ... > V3: Use suffix instead of prefix for macros/register defines > V2: Changes the description and cover-letter content to answer David Miller's > question Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net-next] cxgb4i/cxgb4 : Refactor macros to conform to uniform standards

2014-11-13 Thread David Miller
From: Anish Bhatt Date: Wed, 12 Nov 2014 17:15:57 -0800 > Refactored all macros used in cxgb4i as part of previously started cxgb4 macro > names cleanup. Makes them more uniform and avoids namespace collision. > Minor changes in other drivers where required as some of these macros are used > by

PROBLEM: Adaptec AAC Raid out-of-bounds array index in query_disk()

2014-11-18 Thread David Ramos
checked) as an array index on lines 2585...2595. Any of these lines may trigger a segfault or leak private kernel data back to the user on line 2597. Please let me know if you have any questions about this bug. Thanks, -David -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH net] cxgb4i : Don't block unload/cxgb4 unload when remote closes TCP connection

2014-11-19 Thread David Miller
From: Anish Bhatt Date: Tue, 18 Nov 2014 19:09:51 -0800 > cxgb4i was returning wrong error and not releasing module reference if remote > end abruptly closed TCP connection. This prevents the cxgb4 network module > from > being unloaded, further affecting other network drivers dependent on cxgb4

Re: [PATCH 06/12] esp_scsi: use FIFO for command submission

2014-11-21 Thread David Miller
sing it > to generate spurious interrupts even though DMA completion > interrupts are not enabled. > This can be avoided by using the FIFO for command submission. > > Signed-off-by: Hannes Reinecke Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 01/12] esp_scsi: spellcheck 'driver'

2014-11-21 Thread David Miller
From: Hannes Reinecke Date: Fri, 21 Nov 2014 13:41:45 +0100 > Reviewed-by: Paolo Bonzini > Signed-off-by: Hannes Reinecke Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.or

Re: [PATCH 02/12] esp_scsi: make number of tags configurable

2014-11-21 Thread David Miller
From: Hannes Reinecke Date: Fri, 21 Nov 2014 13:41:46 +0100 > Add a field 'num_tags' to the esp structure to allow drivers > to overwrite the number of avialable tags if required. > Default is ESP_DEFAULT_TAGS. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Hannes

Re: [PATCH 03/12] esp_scsi: convert to dev_printk

2014-11-21 Thread David Miller
From: Hannes Reinecke Date: Fri, 21 Nov 2014 13:41:47 +0100 > Use dev_printk functions for correct device annotations. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Hannes Reinecke Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH 05/12] esp_scsi: read status registers

2014-11-21 Thread David Miller
From: Hannes Reinecke Date: Fri, 21 Nov 2014 13:41:49 +0100 > A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read > all status registers in one go to avoid losing information. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Hannes Reinecke Acked-by: David S

Re: [PATCH 04/12] esp_scsi: debug event and command

2014-11-21 Thread David Miller
From: Hannes Reinecke Date: Fri, 21 Nov 2014 13:41:48 +0100 > Add new debug definitions for event and command logging. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Hannes Reinecke Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH 08/12] am53c974: BLAST residual handling

2014-11-21 Thread David Miller
einecke Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/12] esp: correctly detect am53c974

2014-11-21 Thread David Miller
From: Hannes Reinecke Date: Fri, 21 Nov 2014 13:41:53 +0100 > + if ((config4 & ESP_CONFIG4_GE1) == ESP_CONFIG4_GE1) { Please condense this down to the more simple and straightforward: if (x & BIT(N)) because this is always equivalent to the expression you have used:

Re: [PATCH 10/12] esp_scsi: let DMA driver provide a config2 value

2014-11-21 Thread David Miller
. > > Check if the caller of scsi_esp_register provided a value for esp->config2. > If this is the case, assume this is not an ESP100, skip the detection > phase and leave esp->config2 untouched. It will be used in esp_reset_esp. > > Reviewed-by: Hannes Reinecke > Signed

Re: [PATCH 11/12] esp: enable CONFIG2_FENAB for am53c974

2014-11-21 Thread David Miller
only enable it for am53c974 where we know what it's doing. > > Signed-off-by: Hannes Reinecke Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-21 Thread David Miller
From: Christoph Hellwig Date: Wed, 19 Nov 2014 22:01:35 -0800 > On Sat, Nov 15, 2014 at 08:31:00AM -0700, Jens Axboe wrote: >> My next move would be to add more debug to the CPU map setup and teardown, >> so that we can verify that the map that is being used above has indeed been >> setup. Unless

Re: [PATCH net-next 0/5] RDMA/cxgb4,cxgb4vf,csiostor: Cleanup macros

2014-11-22 Thread David Miller
From: Hariprasad Shenai Date: Fri, 21 Nov 2014 12:52:00 +0530 > This series continues to cleanup all the macros/register defines related to > filter, port, VI, queue, RSS, LDST, firmware, etc that are defined in > t4fw_api.h > and the affected files. > > Will post few more series so that we can

Re: [PATCH 12/12] Replace tmscsim by am53c974

2014-11-23 Thread David Miller
Please do not _EVER_ quote an entire huge patch just to add a signoff or ACK. This wastes tons of mailing list resources because it means that the entire huge patch is sent once again to every single recipient on the mailing list. Instead, just at most quote the commit message, then add your ACK

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-24 Thread David Miller
From: Jens Axboe Date: Mon, 24 Nov 2014 10:16:15 -0700 > How about this one? The "num" in num_possible_cpus() means a count, as in how many are there. It doesn't mean largest ID of members of set X, which is what you are asking for. Even worse, having num_online_cpus() and num_possible_cpus()

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-24 Thread David Miller
From: Jens Axboe Date: Mon, 24 Nov 2014 15:01:55 -0700 > I'll just updated blk-mq to use nr_cpu_ids and be done with it. Wow, a grep on nr_cpu_ids gets a lot of hits on people allocating just these kinds of tables :) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-24 Thread David Miller
From: mr...@linux.ee Date: Tue, 25 Nov 2014 00:23:20 +0200 (EET) >> > > > Yes, that does look like the case. Do you have a good trick on how >> > > > to allocate a map for the highest possible cpu number without first >> > > > iterating the cpu map? I couldn't find something that looks like a >>

Re: [PATCH net-next] cxgb4/cxgb4vf/csiostor: Add T4/T5 PCI ID Table

2014-11-25 Thread David Miller
From: Hariprasad Shenai Date: Tue, 25 Nov 2014 08:33:58 +0530 > Add a new file t4_pci_id_tbl.h that contains T4/T5 PCI ID Table so that for > all > drivers that uses T4/T5 PCI functions changes can be done in one place. > > checkpatch.pl script reports following error, which if tried to fix end

Re: [hch-scsi-queue:drivers-for-3.19 174/180] drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync'

2014-11-26 Thread David Miller
From: Christoph Hellwig Date: Wed, 26 Nov 2014 20:13:09 +0100 > On Wed, Nov 26, 2014 at 06:32:48PM +0100, Ondrej Zary wrote: >> wd819x should probably depend on VIRT_TO_BUS? But that means it will not >> work >> on sparc. Is there a way to make it work? I have a sparc machine but haven't >> te

Re: [PATCH net v7 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware

2014-12-10 Thread David Miller
From: Karen Xie Date: Wed, 10 Dec 2014 12:24:09 -0800 > [PATCH net v7 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware. Please listen to the feedback you have been given. Again, you should not duplicate the Subject line in your message body, that makes more work for the people integrating

Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints

2014-12-10 Thread David Miller
From: Karen Xie Date: Wed, 10 Dec 2014 20:26:59 + > Thanks, v7 has been submitted to address your comment. Please review. Sorry, you did not actually address his comments. He said to not duplicate your Subject lines in your message bodies, and you did not fix that. -- To unsubscribe from th

Re: [PATCH net v7 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware

2014-12-10 Thread David Miller
From: James Bottomley Date: Wed, 10 Dec 2014 23:41:29 +0300 > On Wed, 2014-12-10 at 15:31 -0500, David Miller wrote: >> From: Karen Xie >> Date: Wed, 10 Dec 2014 12:24:09 -0800 >> >> > [PATCH net v7 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware. >&g

Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints

2014-12-10 Thread David Miller
From: Karen Xie Date: Wed, 10 Dec 2014 21:02:34 + > Sorry, misread the comment, will resubmit. Thanks. Please do not top-post. Quote the relevant material, then provide your own content after the quoted material, not before. -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH net v8 1/7] cxgb4i: fix tx immediate data credit check

2014-12-10 Thread David Miller
From: Karen Xie Date: Wed, 10 Dec 2014 13:11:06 -0800 > From: Karen Xie > > Only data skbs need the wr header added while control skbs do not. Make sure > they are treated differently. > > Signed-off-by: Karen Xie Please text format your commit messages to 80 characters or less per line. P

Re: [PATCH] cxgb4/csiostor: Don't use MASTER_MUST for fw_hello call

2014-12-11 Thread David Miller
From: Hariprasad Shenai Date: Thu, 11 Dec 2014 11:11:43 +0530 > Remove use of calls into t4_fw_hello() with MASTER_MUST, which results in > FW_HELLO_CMD_MASTERFORCE being set. The firmware doesn't support this and of > course any existing PF Drivers will totally go for a toss. > > Signed-off-by:

Re: [PATCH net v9 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread David Miller
From: Karen Xie Date: Thu, 11 Dec 2014 07:25:37 -0800 > This patch set fixes cxgb4i's tx credit calculation and adds handling of > additional rx message and negative advice types. It also removes the duplicate > code in cxgb4i to set the outgoing queues of a packet. This series does not apply c

Re: [PATCH net v9 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread David Miller
From: Anish Bhatt Date: Thu, 11 Dec 2014 20:24:48 + >> This series does not apply cleanly at all to net-next, it gets many >> rejects. > > Hey Dave, this patchset was mostly bugfixes and hence meant for net where it > applies cleanly. not net-next. We can rebase to net-next and send if you'r

Re: [PATCH net-next v10 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-12 Thread David Miller
From: Karen Xie Date: Thu, 11 Dec 2014 19:13:26 -0800 > This patch set fixes cxgb4i's tx credit calculation and adds handling of > additional rx message and negative advice types. It also removes the duplicate > code in cxgb4i to set the outgoing queues of a packet. Series applied, thanks. -- T

scsi_debug.c:1626: possible bad test ?

2014-12-22 Thread David Binderman
Hello there, drivers/scsi/scsi_debug.c:1626:20: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op] Source code is     if (alloc_len < 4 && alloc_len> 0x) { Suggest swap && for ||. Adding -Wlogical-op to the build might also help Re

RE: [PATCH] [RESEND] scsi_debug: fix sanity check in resp_rsup_opcodes

2015-01-02 Thread David Binderman
Hello there, > David Binderman pointed out in this post: > > http://marc.info/?l=linux-scsi&m=141924469523474&w=2 > > a sanity check that was flawed. See attached fix. Should > be applied to lk 3.19.0-rc2 and Christoph'

Re: [PATCH net-next 0/5] RDMA/cxgb4/cxgb4vf/csiostor: Cleanup register defines

2015-01-05 Thread David Miller
From: Hariprasad Shenai Date: Mon, 5 Jan 2015 16:30:42 +0530 > This series continues to cleanup all the macros/register defines related to > SGE, PCIE, MC, MA, TCAM, MAC, etc that are defined in t4_regs.h and the > affected files. > > Will post another 1 or 2 series so that we can cover all the

Re: [PATCH] csiostor:firmware upgrade fix

2015-01-08 Thread David Miller
From: Praveen Madhavan Date: Wed, 7 Jan 2015 19:16:28 +0530 > This patch fixes removes older means of upgrading Firmware using MAJOR version > and adds newer interface version checking mechanism. > > Please apply this patch on net-next since it depends on previous commits. > > Signed-off-by: P

Re: [PATCH v3 4/4] scsi: esp_scsi: adjust module reference for scsi host

2015-01-11 Thread David Miller
> Signed-off-by: Akinobu Mita Looks fine to me, thanks for fixing this: Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] csiostor:fix sparse warnings

2015-01-11 Thread David Miller
From: Praveen Madhavan Date: Fri, 9 Jan 2015 21:25:16 +0530 > This patch fixes sparse warning reported by kbuild. > Apply this on net-next since it depends on previous commit. > > drivers/scsi/csiostor/csio_hw.c:259:17: sparse: cast to restricted __le32 > drivers/scsi/csiostor/csio_hw.c:536:31:

Re: [PATCH net-next 0/2] All Chelsio drivers : Cleanup CPL messages macros

2015-01-12 Thread David Miller
From: Anish Bhatt Date: Thu, 8 Jan 2015 21:38:14 -0800 > This patch series cleans up all register defines/MACROS defined in t4_msg.h > and > affected files as part of the continuing cleanup effort > > The patches series is created against 'net-next' tree and includes patches > to the cxgb4,

RE: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-07-07 Thread David Carroll
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Pengfei Wang > Sent: Thursday, July 07, 2016 7:00 AM > To: linux-scsi@vger.kernel.org > Subject: Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c > Hi, >

2% lånetilbud

2016-07-11 Thread David Rogers
oppmerksomhet; Dette er for å informere deg gjorde som et privat selskap, Utlån selskap basert i Storbritannia (til økonomisk Ltd). Vi gir ut lån til melodi av $ 10 000 til $ 300 millioner ved 2% rente til alle som er interessert. Country er ikke en barriere, så ta gjerne kontakt med oss på den

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread David Vrabel
l spotted. There is another instance of this problem in > scsifront_action_handler(). Would you mind correcting this one, too? Would it make more sense to advance req_prod_pvt only if the request has been successfully created? David >> Signed-off-by: Bin Wu >> --- >> drivers/

2% DARLEHEN

2016-07-11 Thread David Rogers
Aufmerksamkeit; Hiermit teilen wir Ihnen mit, dass als privates Unternehmen, Kredite Unternehmen mit Sitz in Großbritannien (Um Financial Ltd). Wir geben Kredite in Höhe von $ 10.000 bis $ 300.000.000 bei 2% Zinssatz für alle Interessierten. Land ist kein Hindernis, so fühlen sich frei, mit uns

Re: [net-next 0/6] common library for Chelsio drivers

2016-07-11 Thread David Miller
From: Varun Prakash Date: Fri, 8 Jul 2016 23:03:53 +0530 > Hi, > > This patch series adds common library module(libcxgb.ko) > for Chelsio drivers to remove duplicate code. > > This series moves common iSCSI DDP Page Pod manager > code from cxgb4.ko to libcxgb.ko, earlier this code > was used

Re: [net-next v2 1/6] libcxgb: add library module for Chelsio drivers

2016-07-19 Thread David Miller
From: Varun Prakash Date: Sat, 16 Jul 2016 22:49:15 +0530 > } > + > +static int __init libcxgb_init(void) > +{ > + return 0; > +} > + > +static void __exit libcxgb_exit(void) > +{ > +} > + > +module_init(libcxgb_init); > +module_exit(libcxgb_exit); If these functions don't have to do anythi

Re: [net-next v2 0/6] common library for Chelsio drivers

2016-07-20 Thread David Miller
From: "Nicholas A. Bellinger" Date: Wed, 20 Jul 2016 14:13:55 -0700 > DaveM, if you'd prefer to pick it up, I'm happy to drop it. There were review comments and changes requested. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.

Re: [net-next v3 0/6] common library for Chelsio drivers.

2016-07-25 Thread David Miller
From: Varun Prakash Date: Thu, 21 Jul 2016 22:57:13 +0530 > Hi, > > This patch series adds common library module(libcxgb.ko) > for Chelsio drivers to remove duplicate code. > > This series moves common iSCSI DDP Page Pod manager > code from cxgb4.ko to libcxgb.ko, earlier this code > was u

RE: [PATCH] aacraid: prevent out-of-bounds access due to changing fip header sizes

2016-08-04 Thread David Carroll
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Johannes Thumshirn > Sent: Thursday, August 04, 2016 2:36 AM > To: Martin K . Petersen; James Bottomley > Cc: Linux SCSI Mailinglist; Pengfei Wang; Johannes Thumshirn; > s

RE: [PATCH] aacraid: prevent out-of-bounds access due to changing fip header sizes

2016-08-05 Thread David Carroll
[snip] > > > goto cleanup; > > > } > > > > > > + if (size != le16_to_cpu(kfib->header.Size) > > > + + sizeof(struct aac_fibhdr)) { > > > + retval = -EINVAL; > > > + goto cleanup; > > > + } > > > + > > > if

linux-4.8-rc1/drivers/scsi/sd.c:317: pointless test ?

2016-08-08 Thread David Binderman
D_DIF_TYPE3_PROTECTION) Regards David Binderman -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: aacraid / Adaptec 3805 - AAC: Host adapter dead -1

2016-08-08 Thread David Carroll
> On Mon, Aug 01, 2016 at 11:42:24AM +0200, Piotr Szymaniak wrote: > > Hi, > > (Sorry, for almost-topposting. Leaving below for reference.) > > As a followup to this thread - looking for answers here and there I've added > intel_iommu=igfx_off (found at some thread with some other hardware > ment

Re: Regarding AHCI_MAX_SG and (ATA_HORKAGE_MAX_SEC_1024)

2016-08-10 Thread David Milburn
On 08/10/2016 12:19 PM, Tom Yan wrote: On 10 August 2016 at 15:41, David Milburn wrote: Hi, The 168 makes AHCI_CMD_TBL_SZ equal to 2816 AHCI_CMD_TBL_SZ = AHCI_CMD_TBL_HDR_SZ + (AHCI_MAX_SG * 16) AHCI_CMD_TBL_SZ = 128 + (168 * 16) I think if you add in AHCI_CMD_SLOT_SZ (1024) and

Re: Regarding AHCI_MAX_SG and (ATA_HORKAGE_MAX_SEC_1024)

2016-08-10 Thread David Milburn
n't seem to align to anything meaningful. No idea. The 168 makes AHCI_CMD_TBL_SZ equal to 2816 AHCI_CMD_TBL_SZ = AHCI_CMD_TBL_HDR_SZ + (AHCI_MAX_SG * 16) AHCI_CMD_TBL_SZ = 128 + (168 * 16) I think if you add in AHCI_CMD_SLOT_SZ (1024) and AHCI_RX_FIS_SZ (256) the DMA is 4K aligned, I think th

RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

2016-08-22 Thread David Carroll
> From: Markus Elfring > Date: Sat, 20 Aug 2016 20:05:24 +0200 > > Reuse existing functionality from memdup_user() instead of keeping duplicate > source code. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/aacraid/commctrl.

RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

2016-08-25 Thread David Carroll
> > > > Hi Markus, > > > > Patch 2/7 should precede Patch 1/7, as falling into kfree() would not look > pretty. > > Do you eventually prefer that this source code adjustment should be combined > with the update suggestion "[2/7] aacraid: One function call less in > aac_send_raw_srb() after error d

RE: [PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

2016-09-07 Thread David Carroll
> > We get 1 warning when building kernel with W=1: > drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype for > 'aac_src_select_comm' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared and > don't need > a declaration, but can be made

RE: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

2016-09-09 Thread David Carroll
> > > > > > > "Don" == Don Brace writes: > > > > Don, > > > > Don> Depends on smartpqi driver adoption > > > > -{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC > > Series 9 */ > > > > How are people that load aacraid in their initrd going to boot after > > this? > > >

Re: [PATCH net-next] chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dynamically for all cxgb4 ULD's

2016-09-18 Thread David Miller
From: Hariprasad Shenai Date: Sat, 17 Sep 2016 08:12:39 +0530 > Allocate resources dynamically to cxgb4's Upper layer driver's(ULD) like > cxgbit, iw_cxgb4 and cxgb4i. Allocate resources when they register with > cxgb4 driver and free them while unregistering. All the queues and the > interrupts

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread David Miller
From: Yuval Mintz Date: Sat, 11 Mar 2017 18:39:18 +0200 > This patch advances the qed* drivers into using the newer firmware - > This solves several firmware bugs, mostly related [but not limited to] > various init/deinit issues in various offloaded protocols. > > It also introduces a major 4-Ca

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread David Miller
From: Christoph Hellwig Date: Mon, 13 Mar 2017 16:19:47 -0700 > On Mon, Mar 13, 2017 at 03:33:47PM -0700, David Miller wrote: >> Applied, thanks. > > So everyone who doesn't have the very latests linux-firmware will now > have a non-working card after upgrading the kernel

Re: [PATCH] qedf: fix wrong le16 conversion

2017-03-23 Thread David Miller
From: "Martin K. Petersen" Date: Thu, 23 Mar 2017 10:19:03 -0400 > Arnd Bergmann writes: > >> gcc points out that we are converting a 16-bit integer into a 32-bit >> little-endian type and assigning that to 16-bit little-endian >> will end up with a zero: >> >> drivers/scsi/qedf/drv_fcoe_fw_fun

problem with discard granularity in sd

2017-03-31 Thread David Buckley
ility of a partial block discard or advantage to sending the discard requests in 512 blocks? Any help is greatly appreciated. Thanks, -David

Re: [PATCH 27/39] Annotate hardware config module parameters in drivers/scsi/

2017-04-05 Thread David Howells
currently preventing the changing of any hardware parameters. If a driver refuses to share an irq, you could use it to deprive another driver of the ability to get an irq at all. David

Re: problem with discard granularity in sd

2017-04-05 Thread David Buckley
sly in previous kernels. Let me know if there's any additional information I can provide. This has resulted in a 2-3x increase in raw disk requirements for some workloads (unfortunately on SSD too), and I'd love to find a solution that doesn't require rolling back to a 3.10 kernel.

[PATCH 27/38] Annotate hardware config module parameters in drivers/scsi/

2017-04-05 Thread David Howells
some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/scsi/. Suggested-by: Alan Cox Signed-off-by: David Howells cc: "Juergen E. Fischer" cc: "James E.J. Bottomley" cc: "

[PATCH 21/24] scsi: Lock down the eata driver

2017-04-05 Thread David Howells
device to access or modify the kernel image. The eata driver takes a single string parameter that contains a slew of settings, including hardware resource configuration. Prohibit use of the parameter if the kernel is locked down. Suggested-by: Alan Cox Signed-off-by: David Howells cc: Dario

[no subject]

2017-04-06 Thread David Buckley
n for your help with this! -David On Thu, Apr 6, 2017 at 10:34 AM, Martin K. Petersen wrote: > David Buckley writes: > > David, > >> As I mentioned previously, I'm fairly certain that the issue I'm >> seeing is due to the fact that while NetApp LUNs are prese

Re: problem with discard granularity in sd

2017-04-11 Thread David Buckley
lts in the LUN growing to its max size. Thank you again for your help with this! -David On Thu, Apr 6, 2017 at 10:34 AM, Martin K. Petersen wrote: > David Buckley writes: > > David, > >> As I mentioned previously, I'm fairly certain that the issue I'm >> seeing

Re: problem with discard granularity in sd

2017-04-12 Thread David Buckley
max_blocks = min_not_zero(sdkp->max_ws_blocks, + max_blocks = min_not_zero(max_ws_unmap_blocks, (u32)SD_MAX_WS16_BLOCKS); q->limits.discard_zeroes_data = sdkp->lbprz; break; Thanks yet again for all your help.

[PATCH] virtio_scsi: Always try to read VPD pages

2017-04-12 Thread David Gibson
nd for the storvsc (Hyper-V) SCSI controller, although that exists for slightly different reasons. A specific case which causes this is a volume from IBM's IPR RAID controller (which presents as an SPC-2 device, although it does support VPD) passed through with qemu's 'scsi-block'

Re: problem with discard granularity in sd

2017-04-14 Thread David Buckley
aking the time to respond, especially as this didn't turn out to be an issue with kernel code at all. -David

RE: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

2017-04-18 Thread David Laight
* questionable error path out of here, > + * we WARN. > + */ > + WARN(1, "Non-mappable memory used in sg!"); > + return 1; > + } ... Perhaps add a flag to mark failure as 'unexpected' and trace (and panic?) inside sg_map(). David

Re: [PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all

2017-04-26 Thread David Miller
> Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: [PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset

2017-04-26 Thread David Miller
From: Christoph Hellwig Date: Wed, 26 Apr 2017 09:34:22 +0200 > The caller only looks at the scsi_request result field anyway. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Sun, 2017-05-07 at 22:40 +0200, Pavel Machek wrote: > > > NOTE: unclean SSD power-offs are dangerous and may brick the device in > > > the worst case, or otherwise harm it (reduce longevity, damage flash > > > blocks).  It is also not impossible to get data corruption. > > > I get that the incre

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 09:38 +0200, Ricard Wanderlof wrote: > On Mon, 8 May 2017, David Woodhouse wrote: > > > > > > > > > [Issue is, if you powerdown during erase, you get "weakly erased" > > > page, which will contain expected 0xff's, but

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 10:36 +0200, Ricard Wanderlof wrote: > On Mon, 8 May 2017, David Woodhouse wrote: > > Our empirical testing trumps your "can never happen" theory :) > > I'm sure it does. But what is the explanation then? Has anyone analyzed  > what is going o

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 11:28 +0200, Pavel Machek wrote: > > Are you sure you have it right in JFFS2? Do you journal block erases? > Apparently, that was pretty much non-issue on older flashes. It isn't necessary in JFFS2. It is a *purely* log-structured file system (which is why it doesn't scale w

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 11:09 +0200, Hans de Goede wrote: > You're forgetting that the SSD itself (this thread is about SSDs) also has > a major software component which is doing housekeeping all the time, so even > if the main CPU gets reset the SSD's controller may still happily be erasing > blocks

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 11:06 +0200, Ricard Wanderlof wrote: > > My point is really that say that the problem is in fact not that the erase  > is cut short due to the power fail, but that the software issues a second  > command before the first erase command has completed, for instance, or  > some o

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 12:49 +0200, Pavel Machek wrote: > On Mon 2017-05-08 10:34:08, David Woodhouse wrote: > > > > On Mon, 2017-05-08 at 11:28 +0200, Pavel Machek wrote: > > > > > > > > > Are you sure you have it right in JFFS2? Do you journal block

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 13:50 +0200, Boris Brezillon wrote: > On Mon, 08 May 2017 11:13:10 +0100 > David Woodhouse wrote: > > > > > On Mon, 2017-05-08 at 11:09 +0200, Hans de Goede wrote: > > > > > > You're forgetting that the SSD itself (this

Re: [PATCH net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread David Miller
From: Yuval Mintz Date: Wed, 17 May 2017 22:38:40 +0300 > This pushes qed [and as result, all qed* drivers] into using 8.20.0.0 > firmware. The changes are mostly contained in qed with minor changes > to qedi due to some HSI changes. > > Content-wise, the firmware contains fixes to various issue

Re: [PATCH net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread David Miller
From: David Miller Date: Thu, 18 May 2017 10:34:28 -0400 (EDT) > From: Yuval Mintz > Date: Wed, 17 May 2017 22:38:40 +0300 > >> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0 >> firmware. The changes are mostly contained in qed with minor changes &

Re: [PATCH v2 net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread David Miller
From: Yuval Mintz Date: Thu, 18 May 2017 19:41:04 +0300 > This pushes qed [and as result, all qed* drivers] into using 8.20.0.0 > firmware. The changes are mostly contained in qed with minor changes > to qedi due to some HSI changes. > > Content-wise, the firmware contains fixes to various issue

Re: [PATCH v9 06/15] mlx5: Replace PCI pool old API

2017-05-23 Thread David Miller
From: Romain Perier Date: Tue, 23 May 2017 10:53:36 +0200 > Hello, > > > Le 23/05/2017 à 09:27, Leon Romanovsky a écrit : >> On Mon, May 22, 2017 at 06:48:58PM +0200, Romain Perier wrote: >>> The PCI pool API is deprecated. This commit replaces the PCI pool old >>> API by the appropriate functi

Re: [PATCH 1/1] target:separate tx/rx cmd_puds

2018-04-05 Thread David Disseldorp
s); > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds); I don't think the in_cmds metric should be deleted here. It could be calculated on the fly via tx_cmds + rx_cmds + nodata_cmds. Cheers, David

Re: [PATCH 1/1] target:separate tx/rx cmd_puds

2018-04-06 Thread David Disseldorp
On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote: > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds); > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds); > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds); > > I don't think the in_cmds metric sho

Re: [PATCH 20/39] afs: simplify procfs code

2018-04-19 Thread David Howells
e the network namespace over automount using the new fs_context to do it. David

Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data}

2018-04-30 Thread David Howells
ase add documentation comments to exported functions when you add them. David

Re: simplify procfs code for seq_file instances V2

2018-04-30 Thread David Howells
ere: https://groups.google.com/forum/#!msg/syzkaller-bugs/sJC3Y3hOM08/aO3z9JXoAgAJ David

Re: [PATCH net-next 2/2] cxgb4: do L1 config when module is inserted

2018-05-23 Thread David Miller
From: Ganesh Goudar Date: Wed, 23 May 2018 20:03:33 +0530 > trigger an L1 configure operation when a transceiver module > is inserted in order to cause current "sticky" options like > Requested Forward Error Correction to be reapplied. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Gou

Re: [PATCH net-next 1/2] cxgb4: change the port capability bits definition

2018-05-23 Thread David Miller
From: Ganesh Goudar Date: Wed, 23 May 2018 20:02:58 +0530 > MDI Port Capabilities bit definitions were inconsistent with > regard to the MDI enum values. 2 bits used to define MDI in > the port capabilities are not really separable, it's a 2-bit > field with 4 different values. Change the port ca

Hello.

2018-05-26 Thread David Keller
My Greetings, Did you receive the letter i sent to you. Please answer me. Best Regard, Mr.David Keller.

<    1   2   3   4   5   6   7   >