() - use a new fabric_ops.fabric_alias
member to handle the iscsi_target_mod special case.
Cheers, David
David Disseldorp (3):
target: drop unused pi_prot_format attribute storage
target: drop unnecessary get_fabric_name() accessor from fabric_ops
target: replace fabric_ops.name
x27;t initialised.
iscsi_target_mod is the only fabric module to set .fabric_alias . All
other fabric modules rely on .fabric_name matching and can drop the
duplicate string.
Signed-off-by: David Disseldorp
---
drivers/infiniband/ulp/srpt/ib_srpt.c| 1 -
drivers/scsi/ibmvscsi_tgt/ibmvscsi_
-by: David Disseldorp
---
drivers/target/target_core_configfs.c | 3 +--
include/target/target_core_base.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/target/target_core_configfs.c
b/drivers/target/target_core_configfs.c
index 70b9f6755c36..62427acdf503 100644
unfortunately need to keep both strings
around for now.
Replace the useless .get_fabric_name() accessor function with a const
string fabric_name member variable.
Signed-off-by: David Disseldorp
---
drivers/infiniband/ulp/srpt/ib_srpt.c| 7 +--
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 7
On Fri, 23 Nov 2018 11:22:08 +0100, David Disseldorp wrote:
> > > Both fabric_ops.get_fabric_name() and fabric_ops.name are user facing,
> > > with the former being used for PR/ALUA state and the latter for configFS
> > > (config/target/$name), so we unfortunatel
On Tue, 20 Nov 2018 19:00:57 +0100, David Disseldorp wrote:
> > > + strncpy(buf, page, sizeof(buf));
> >
> > Isn't strncpy() deprecated? How about using strlcpy() instead?
>
> Will change to use strlcpy in the next round.
Just a follow up here. I think i
t
just thought I'd mention that the zeroing of unused bytes is still
required due to the scsi_dump_inquiry() + target_stat_lu_vend_show()
behaviour.
Cheers, David
?
Your patch looks good to me. Mind if I tack it on to the end of my
t10_wwn.vendor/model/revision[size+1] patchset, with your authorship?
Cheers, David
the standard INQUIRY data as well as the
T10 VENDOR IDENTIFICATION field in the INQUIRY Device Identification VPD
Page are zero-terminated/zero-padded.
Fix this inconsistency by using space-padding for all of the above
fields.
Signed-off-by: David Disseldorp
Reviewed-by: Christoph Hellwig
://www.spinics.net/lists/target-devel/msg10545.html
- Rebase against nab's for-next branch, which includes Christoph's
configfs API changes.
Bart Van Assche (1):
target: use printf width specifier for t10_wwn field dumps
David Disseldorp (6):
target: use consistent left-aligned ASCII IN
t when the backstore
device is enabled.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_configfs.c | 48 +++
1 file changed, 48 insertions(+)
diff --git a/drivers/target/target_core_configfs.c
b/drivers/target/target_core_configfs.c
index 9f
In preparation for supporting user provided vendor strings, add an extra
byte to t10_wwn.vendor which will ensure null string termination when an
eight byte vendor string is provided by the user.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_device.c | 6 --
drivers/target
The pscsi_set_inquiry_info() codepath doesn't currently explicitly
null-terminate t10_wwn.revision.
Add an extra byte to the t10_wwn.model buffer and perform null string
termination in all cases.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_device.c | 6 --
drivers/t
th
to avoid changing the model string for existing deployments.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_configfs.c | 8 +---
drivers/target/target_core_device.c | 8 +---
drivers/target/target_core_pscsi.c| 6 --
drivers/target/target_core_spc.c
From: Bart Van Assche
The existing for loops step over null-terminators for right-padding.
Padding can be achieved in a much simpler way using printf width
specifiers.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_device.c | 35 ---
drivers
Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
can be reconfigured via the vendor_id ConfigFS attribute.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_spc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/driv
On Thu, 29 Nov 2018 08:24:38 -0800, Bart Van Assche wrote:
> On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
> > diff --git a/drivers/target/target_core_configfs.c
> > b/drivers/target/target_core_configfs.c
> > index f6b1549f4142..9f49b1afd685 100644
>
gt; INQUIRY_VENDOR_LEN bytes long?
It does. As mentioned in v3, this follows the convention used in
target_wwn_vpd_unit_serial_store(). I don't feel too strongly about it,
but it does make buf allocation a little less error prone IMO.
Cheers, David
>
> I dislike that you are using 0x20 here (and below) instead of ' '.
Given that this patch already has a couple of reviewed-bys, I'd prefer
to avoid respinning it for this. Besides, I think the comment above
makes it pretty clear.
Thanks for your feedback.
Cheers, David
of which it is guaranteed that its length is less than or equal to
> the second strnlen() argument?
Belt and braces :) Actually, I think it's a little more readable this
way.
Cheers, David
On Fri, 30 Nov 2018 14:17:49 +0100, David Disseldorp wrote:
> > Where is the code that initializes dev->t10_wwn.vendor to "LIO-ORG"? Did I
> > perhaps overlook something?
>
> This is done in target_configure_device() .
Hmm, continuing to do it there may cause
the standard INQUIRY data as well as the
T10 VENDOR IDENTIFICATION field in the INQUIRY Device Identification VPD
Page are zero-terminated/zero-padded.
Fix this inconsistency by using space-padding for all of the above
fields.
Signed-off-by: David Disseldorp
Reviewed-by: Christoph Hellwig
Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
can be reconfigured via the vendor_id ConfigFS attribute.
Signed-off-by: David Disseldorp
Reviewed-by: Bryant G. Ly
Reviewed-by: Lee Duncan
---
drivers/target/target_core_spc.c | 8 +---
1 file changed, 5
nfigfs API changes.
David Disseldorp (5):
target: use consistent left-aligned ASCII INQUIRY data
target: consistently null-terminate t10_wwn strings
target: add device vendor_id configfs attribute
target: remove hardcoded T10 Vendor ID in INQUIRY response
target: perfo
Initialise the t10_wwn vendor, model and revision defaults when a
device is allocated instead of when it's enabled. This ensures that
custom vendor or model strings set prior to enablement are not later
overwritten with default values.
Signed-off-by: David Disseldorp
---
drivers/t
fiers instead.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_configfs.c | 14 +++---
drivers/target/target_core_device.c | 49 ---
drivers/target/target_core_pscsi.c| 18 -
drivers/target/target_core_spc.c | 7 ++---
dr
t when the backstore
device is enabled.
Signed-off-by: David Disseldorp
Reviewed-by: Bryant G. Ly
Reviewed-by: Lee Duncan
---
drivers/target/target_core_configfs.c | 48 +++
1 file changed, 48 insertions(+)
diff --git a/drivers/target/target_core_configfs.c
b/driv
Hi Hannes,
Thanks for the feedback...
On Sat, 1 Dec 2018 15:59:25 +0100, Hannes Reinecke wrote:
> On 12/1/18 12:34 AM, David Disseldorp wrote:
...
> > @@ -810,6 +810,23 @@ struct se_device *target_alloc_device(struct se_hba
> > *hba, const char *name)
> >
On Sun, 2 Dec 2018 23:22:23 +0100, David Disseldorp wrote:
> > > + if (!(dev->transport->transport_flags & TRANSPORT_FLAG_PASSTHROUGH)) {
> > > + strlcpy(dev->t10_wwn.vendor, "LIO-ORG",
> > > + sizeof(dev->t10_wwn.vend
Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
can be reconfigured via the vendor_id ConfigFS attribute.
Signed-off-by: David Disseldorp
Reviewed-by: Bryant G. Ly
Reviewed-by: Lee Duncan
Reviewed-by: Hannes Reinecke
---
drivers/target/target_core
y used for
anything outside of ConfigFS.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_device.c | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/drivers/target/target_core_device.c
b/drivers/target/target_core_device.c
index 55
This patch-set allows for the modification of the T10 Vendor
Identification string returned in the SCSI INQUIRY response, via the
target/core/$backstore/$name/wwn/vendor_id ConfigFS path.
Changes since v5:
- remove unnecessary TRANSPORT_FLAG_PASSTHROUGH conditional from t10_wwn
ID defaults initi
t when the backstore
device is enabled.
Signed-off-by: David Disseldorp
Reviewed-by: Bryant G. Ly
Reviewed-by: Lee Duncan
Reviewed-by: Hannes Reinecke
---
drivers/target/target_core_configfs.c | 48 +++
1 file changed, 48 insertions(+)
diff --git a/driv
the standard INQUIRY data as well as the
T10 VENDOR IDENTIFICATION field in the INQUIRY Device Identification VPD
Page are zero-terminated/zero-padded.
Fix this inconsistency by using space-padding for all of the above
fields.
Signed-off-by: David Disseldorp
Reviewed-by: Christoph Hellwig
fiers instead.
Signed-off-by: David Disseldorp
Reviewed-by: Hannes Reinecke
---
drivers/target/target_core_configfs.c | 14 +++---
drivers/target/target_core_device.c | 49 ---
drivers/target/target_core_pscsi.c| 18 -
drivers/t
up. That means in the actual INQUIRY commands it
> will still return vendor_id of the underlying storage. If that's that's
> true, this means an attempt to set vendor_id will be succesful but it
> won't do what's intended for.
That's correct.
Cheers, David
On Tue, 4 Dec 2018 14:31:57 +0300, Roman Bolshakov wrote:
> On Sat, Dec 01, 2018 at 12:34:20AM +0100, David Disseldorp wrote:
...
> > diff --git a/drivers/target/target_core_configfs.c
> > b/drivers/target/target_core_configfs.c
> > index f6b1549f4142..34872f24e8bf 100
t; > + sizeof(dev->t10_wwn.vendor));
> > +
>
> Should we allow non-ASCII characters?
No :)
> It's okay to strip final newline
> for convenience. A simple loop would ensure the rest is conformant to
> SPC. EINVAL can be returned otherwise.
I'll add an isascii() loop in the next round.
Cheers, David
Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
can be reconfigured via the vendor_id ConfigFS attribute.
Signed-off-by: David Disseldorp
Reviewed-by: Bryant G. Ly
Reviewed-by: Lee Duncan
Reviewed-by: Hannes Reinecke
Reviewed-by: Roman Bolshakov
---
driv
consistent INQUIRY data padding as a separate patch
- Drop t10_wwn.model buffer print fix, already upstream
Changes since v1:
- https://www.spinics.net/lists/target-devel/msg10545.html
- Rebase against nab's for-next branch, which includes Christoph's
configfs API changes.
David Disseld
the standard INQUIRY data as well as the
T10 VENDOR IDENTIFICATION field in the INQUIRY Device Identification VPD
Page are zero-terminated/zero-padded.
Fix this inconsistency by using space-padding for all of the above
fields.
Signed-off-by: David Disseldorp
Reviewed-by: Christoph Hellwig
fiers instead.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_configfs.c | 16 +++
drivers/target/target_core_device.c | 46 ++--
drivers/target/target_core_pscsi.c| 50 +++
drivers/target/target_core_
outside of ConfigFS.
Signed-off-by: David Disseldorp
Reviewed-by: Roman Bolshakov
---
drivers/target/target_core_device.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/target/target_core_device.c
b/drivers/target/target_core_device.c
index eb
t when the backstore
device is enabled.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_configfs.c | 70 +++
1 file changed, 70 insertions(+)
diff --git a/drivers/target/target_core_configfs.c
b/drivers/target/target_core_configfs.c
index 82
d, the comment should refer to page 0x83.
@Martin: all patches in this series have now been reviewed+acked. Can
you fix the above comment (s/0x80/0x83) if/when you merge, or
should I resend the series with this fixed?
Cheers, David
double-checked all these drivers to ensure that all ioctl arguments
> are used as pointers or are ignored, but are not interpreted as integer
> values.
>
> Signed-off-by: Arnd Bergmann
> ---
> fs/btrfs/super.c| 2 +-
Acked-by: David Sterba
undefined (signed integer
overflow can do anything it likes).
By far the best fix is to change the return type of ahc_inb() to
be 'unsigned int'.
On systems without byte sized registers (about everything except x86)
this will almost certainly generate better code.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
s, but if you cast it to a non-pointer type (which this is doing)
> the compiler will complain if there is no explicit cast.
The real question is why is this code using 'unsigned long'
to hold pointers?
Never mind why it is allocating a large memory block then setting
up another array
From: Jason Gunthorpe
Date: Wed, 21 Nov 2018 19:46:24 -0700
> On Wed, Nov 21, 2018 at 01:40:24PM +0530, Ganesh Goudar wrote:
>> From: Santosh Rastapur
>>
>> If the fw supports returning VIN/VIVLD in FW_VI_CMD save it
>> in port_info structure else retrieve these from viid and save
>> them in p
From: Ganesh Goudar
Date: Wed, 21 Nov 2018 13:40:24 +0530
> From: Santosh Rastapur
>
> If the fw supports returning VIN/VIVLD in FW_VI_CMD save it
> in port_info structure else retrieve these from viid and save
> them in port_info structure. Do the same for smt_idx from
> FW_VI_MAC_CMD
>
> Si
From: Davidlohr Bueso
Date: Fri, 30 Nov 2018 11:56:52 -0800
> I hope this is some kind of joke.
Whether or not it is a joke, it is censorship.
And because of that I have no intention to apply any patches like this
to any code I am in charge of.
From: Jens Axboe
Date: Fri, 30 Nov 2018 13:12:26 -0700
> On 11/30/18 12:56 PM, Davidlohr Bueso wrote:
>> On Fri, 30 Nov 2018, Kees Cook wrote:
>>
>>> On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen
>>> wrote:
In order to comply with the CoC, replace with a hug.
>>
>> I hope thi
From: Abuse
Date: Fri, 30 Nov 2018 20:39:01 +
> I assume I will now be barred.
Perhaps, but not because you said fuck. It would be because you're
intentionally creating a disturbance on the list and making it more
difficult for developers to get their work done and intentionally
creating a
From: Jarkko Sakkinen
Date: Fri, 30 Nov 2018 13:42:33 -0800
> Can you tell how the CoC should be interpreted then?
Regardless of what I think, as others have showen the CoC explicitly
does not apply to existing code.
From: Jarkko Sakkinen
Date: Fri, 30 Nov 2018 13:44:05 -0800
> On Fri, Nov 30, 2018 at 01:01:02PM -0800, James Bottomley wrote:
>> No because use of what some people consider to be bad language isn't
>> necessarily abusive, offensive or degrading. Our most heavily censored
>> medium is TV and "fu
Ping - any feedback on this change?
On Thu, 22 Nov 2018 14:38:00 +0100, David Disseldorp wrote:
> Block ALUA and PR state storage if any of the dynamic subdirectory
> components include a path separator.
>
> Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6&
e code.
Sounds reasonable, although that would leave us with the task of
migrating consumers of the existing unit-serial-number derived paths
to use the new state file locations.
> Regarding testing ALUA code: I use sg_rtpg and sg_stpg to test SCSI target
> ALUA code.
Thanks, I'll have a play with them.
Cheers, David
From: James Bottomley <[EMAIL PROTECTED]>
Date: Wed, 13 Feb 2008 19:11:53 -0600
>
> On Wed, 2008-02-13 at 16:16 -0800, Andrew Morton wrote:
> > kill-warnings-in-mptbaseh-on-parisc64.patch
>
> > Warning fixes.
>
> Not sure ... LSI is supposed to be processing this.
James, please don't push bu
in drivers.
To be clear: I never thought that API restriction was a good idea.
(Although this discussion now seems moot for the gdth driver.)
>
>
> Actually I think David might have been wrong about mips. afaict its
> dma_free_coherent() is callable under local_irq_disable(), so
e FCP_RSP frame (not so
> in iSCSI, where it's just the SCSI-status) and the residual check
> in qla_isr.c::qla2x00_status_entry() looks like:
>
> if (!lscsi_status &&
> ((unsigned)(scsi_bufflen(cp) - resid) <
> cp->underflow)) {
> ..
From: "Michael Chan"
Date: Mon, 2 Jul 2012 08:13:38 -0700
> This came from the net-next tree, so David is the right persion to apply
> this. Thanks.
>
> Acked-by: Michael Chan
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-scs
On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote:
> On 01/14/2012 05:56 AM, Bart Van Assche wrote:
> > Add the necessary functions in the SRP transport module to allow
> > an SRP initiator driver to implement transport layer recovery.
>
> I was updating my iscsi dev loss patch when I saw this
On Mon, 2012-07-16 at 18:38 -0400, Mike Christie wrote:
> On 07/16/2012 04:28 PM, David Dillow wrote:
> > On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote:
> >> For the ping code, does it use TUR because there is not a transport way
> >> to test the path/
On Sat, 2012-08-18 at 10:50 +, Bart Van Assche wrote:
> On 07/16/12 22:28, David Dillow wrote:
> > On Mon, 2012-07-16 at 18:07 -0400, Mike Christie wrote:
> >> Not sure about the ping code, but I think the dev loss tmo and fast io
> >> fail related stuff should go
From: Naresh Kumar Inna
Date: Fri, 24 Aug 2012 03:57:45 +0530
> This is the initial submission of the Chelsio FCoE offload driver (csiostor)
> to the upstream kernel. This driver currently supports FCoE offload
> functionality over Chelsio T4-based 10Gb Converged Network Adapters.
>
> The follow
From: Naresh Kumar Inna
Date: Sat, 25 Aug 2012 00:34:35 +0530
> Thanks for reviewing. Is your comment with respect to any particular
> module parameter[s] in this driver or all of them?
All of them.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message
From: Naresh Kumar Inna
Date: Tue, 4 Sep 2012 10:43:24 +0530
> Removing all the module parameters from the driver would put us at a
> disadvantage with respect to tuning the driver and hardware. I have not
> not been able to find alternatives, considering every other driver uses
> module paramete
From: ebied...@xmission.com (Eric W. Biederman)
Date: Fri, 07 Sep 2012 15:39:21 -0700
>
> The scsi netlink code confuses the netlink port id with a process id,
> going so far as to read NETLINK_CREDS(skb)->pid instead of the correct
> NETLINK_CB(skb).pid. Fortunately it does not matter because n
From: Naresh Kumar Inna
Date: Tue, 11 Sep 2012 20:09:07 +0530
> This patch contains minor fixes to make cxgb4vf driver work with the updates
> to
> shared firmware/hardware header files.
>
> Signed-off-by: Naresh Kumar Inna
You cannot submit a patch set that isn't bisectable, and in particula
From: Naresh Kumar Inna
Date: Tue, 11 Sep 2012 20:09:03 +0530
> +#include
This header include is not necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
From: ebied...@xmission.com (Eric W. Biederman)
Date: Tue, 11 Sep 2012 15:40:08 -0700
> So just for curiosity I searched the entire git history for scsi_nl_add_
> and the only commit that I found was the addition of that code to the
> tree in August of 2008.
>
> Does anyone have any reason to kee
From: Naresh Kumar Inna
Date: Wed, 12 Sep 2012 11:05:22 +0530
> On 9/11/2012 11:03 PM, David Miller wrote:
>> From: Naresh Kumar Inna
>> Date: Tue, 11 Sep 2012 20:09:07 +0530
>>
>>> This patch contains minor fixes to make cxgb4vf driver work with the
>
From: David Miller
Date: Tue, 11 Sep 2012 18:48:46 -0400 (EDT)
> From: ebied...@xmission.com (Eric W. Biederman)
> Date: Tue, 11 Sep 2012 15:40:08 -0700
>
>> So just for curiosity I searched the entire git history for scsi_nl_add_
>> and the only commit that I found was
x27;s done with an ACPI call. I suspect we'll see
that kind of manual setup on a few embedded platforms too.
If we're working on hooking this up through the device layers, perhaps
that's worth taking into consideration?
--
David WoodhouseO
On Tue, 2012-09-25 at 17:05 +0200, Bart Van Assche wrote:
> On 08/09/12 17:41, Bart Van Assche wrote:
> > [ ... ]
>
> Hello Dave,
>
> More than six weeks have elapsed since I posted version four of this
> patch series. It would be appreciated if you could tell me when review
> comments for this
for the strictly kernel internal stuff.
This patch can be pulled from:
git://git.infradead.org/users/dhowells/linux-headers.git
tags/disintegrate-scsi-20121009
Signed-off-by: David Howells
Acked-by: Arnd Bergmann
Acked-by: Thomas Gleixner
Acked-by: Michael Kerrisk
Acked-by: Paul E
for the strictly kernel internal stuff.
This patch can be pulled from:
git://git.infradead.org/users/dhowells/linux-headers.git
tags/disintegrate-fc-20121009
Signed-off-by: David Howells
Acked-by: Arnd Bergmann
Acked-by: Thomas Gleixner
Acked-by: Michael Kerrisk
Acked-by: Paul E
On Sun, Nov 04, 2012 at 09:25:53PM +0100, Julia Lawall wrote:
> It looks like these patches were not a good idea, because in each case the
> printk provides an error level, and WARN then provides another one.
I think this is not a problem within btrfs at the place where this has
changed.
Hi James, Robert, David,
I have patches still outstanding for the UAPI header disintegration of
linux/scsi/, linux/scsi/fs/ and linux/rdma. I have updated them from the
original pull requests and they can be found at tags:
disintegrate-scsi-20121116
disintegrate-fc-20121116
Signed-off-by: David Howells
Acked-by: Arnd Bergmann
Acked-by: Thomas Gleixner
Acked-by: Michael Kerrisk
Acked-by: Paul E. McKenney
Acked-by: Dave Jones
---
include/scsi/Kbuild |3 ---
include/uapi/scsi/Kbuild|3 +++
include/uapi/scsi/scsi_bsg_fc.h
Signed-off-by: David Howells
Acked-by: Arnd Bergmann
Acked-by: Thomas Gleixner
Acked-by: Michael Kerrisk
Acked-by: Paul E. McKenney
Acked-by: Dave Jones
---
include/scsi/fc/Kbuild|4
include/uapi/scsi/fc/Kbuild |4
include/uapi/scsi/fc/fc_els.h |0
include
Signed-off-by: David Howells
Acked-by: Arnd Bergmann
Acked-by: Thomas Gleixner
Acked-by: Michael Kerrisk
Acked-by: Paul E. McKenney
Acked-by: Dave Jones
---
include/rdma/Kbuild |6 --
include/rdma/rdma_netlink.h | 36
On Fri, 2012-11-23 at 16:07 +0100, Bart Van Assche wrote:
> On 09/27/12 02:31, David Dillow wrote:
> > On Tue, 2012-09-25 at 17:05 +0200, Bart Van Assche wrote:
> >> On 08/09/12 17:41, Bart Van Assche wrote:
> >>> [ ... ]
> >>
> >> Hello Dave,
&g
tracking ]
Signed-off-by: David Dillow
---
drivers/infiniband/ulp/srp/ib_srp.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/drivers/infiniband/ulp/srp/ib_srp.c
index 2951e1c..f7d7e6a 100644
--- a/drivers/infiniband/ulp/srp
From: Vu Pham
From: Vu Pham
Now that SRP recreates the CM id, QP, and CQ for each connection,
there is no need to wait for the timewait state to complete.
Signed-off-by: Vu Pham
Signed-off-by: David Dillow
---
drivers/infiniband/ulp/srp/ib_srp.c |3 ---
1 files changed, 0 insertions
Once we know we have an issue with the QP, there is no point trying to
send anything else down the pipe. This also allows us to consolidate
code in the SCSI EH path.
Needs-to-be-signed-off-by: Bart Van Assche
[ adapted to new state tracking code ]
Signed-off-by: David Dillow
---
drivers
.
Signed-off-by: Ishai Rabinovitz
Signed-off-by: Michael S. Tsirkin
[ updated to current code from OFED, cleaned up commit message ]
Signed-off-by: David Dillow
---
drivers/infiniband/ulp/srp/ib_srp.c | 66 ++
1 files changed, 35 insertions(+), 31 deletions(-)
diff
rp_transport: Fix attribute registration
srp_transport: Simplify attribute initialization code
srp_transport: Document sysfs attributes
IB/srp: Allow SRP disconnect through sysfs
David Dillow (2):
IB/srp: simplify state tracking
IB/srp: don't send anything on a bad QP
Ishai Rabinovitz (
From: David Dillow
Eliminate the private_rport_attrs[] array and the SETUP_*() macros
used to set up that array since the information in that array
duplicates the information in the static device attributes. Also,
verify whether SRP_RPORT_ATTRS is large enough since it is easy
to forget to
gs
Signed-off-by: Bart Van Assche
Signed-off-by: David Dillow
---
Documentation/ABI/stable/sysfs-transport-srp |7 +++
drivers/infiniband/ulp/srp/ib_srp.c | 10 ++
drivers/scsi/scsi_transport_srp.c| 22 +-
include/scsi/scsi_trans
From: Bart Van Assche
Enlarge the block layer timeout for disks such that it is above
the InfiniBand transport layer timeout.
Signed-off-by: Bart Van Assche
Signed-off-by: David Dillow
---
drivers/infiniband/ulp/srp/ib_srp.c | 45 +++
drivers/infiniband/ulp
reading the attribute array will see all
values written into that array.
Cc: FUJITA Tomonori
Cc: Robert Jennings
Signed-off-by: Bart Van Assche
Signed-off-by: David Dillow
---
drivers/scsi/scsi_transport_srp.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers
From: Bart Van Assche
Document the sysfs attributes of the SRP initiator according
to the rules specified in Documentation/ABI/README.
Signed-off-by: Bart Van Assche
Signed-off-by: David Dillow
---
Documentation/ABI/stable/sysfs-driver-ib_srp | 156 ++
1 files
state space.
Needs-to-be-signed-off-by: Bart Van Assche
Signed-off-by: David Dillow
---
drivers/infiniband/ulp/srp/ib_srp.c | 146 +--
drivers/infiniband/ulp/srp/ib_srp.h | 11 +--
2 files changed, 76 insertions(+), 81 deletions(-)
diff --git a/drivers
From: Bart Van Assche
Cc: FUJITA Tomonori
Cc: Robert Jennings
Signed-off-by: Bart Van Assche
Signed-off-by: David Dillow
---
Documentation/ABI/stable/sysfs-transport-srp | 12
1 files changed, 12 insertions(+), 0 deletions(-)
create mode 100644 Documentation/ABI/stable/sysfs
On Sun, 2012-11-25 at 23:44 -0500, David Dillow wrote:
> From: David Dillow
> From: Bart Van Assche
>
> Eliminate the private_rport_attrs[] array and the SETUP_*() macros
> used to set up that array since the information in that array
> duplicates the information in
From: Anish Bhatt
Date: Tue, 14 Oct 2014 20:07:20 -0700
> This patch set removes some duplicated/extraneous code from cxgb4i, guards
> cxgb4 against compilation failure based on ipv6 tristate, make ipv6 related
> code no longer be enabled by default irrespective of ipv6 tristate and fixes
> a ref
From: Christoph Hellwig
Date: Wed, 15 Oct 2014 06:35:51 -0700
> On Tue, Oct 14, 2014 at 08:38:18AM -0600, Jens Axboe wrote:
>> Christoph, any idea on this? The command just times out, for some reason.
>> Only thing I could think of was related to perhaps missing bouncing or
>> similar, but I don'
From: mr...@linux.ee
Date: Thu, 16 Oct 2014 09:43:34 +0300 (EEST)
> [ 158.730919] ESP: tgt[6] lun[0] scsi_cmd [ 12 00 00 00 24 00 ]
> [ 158.799397] ESP: intr sreg[87] seqreg[00] sreg2[00] ireg[18]
Target 6 responds, Bus Service + Function Done interrupt.
Status register 1 indicates interrupt p
Christoph, I don't see how the new tagging code with blk-mq can
be providing compatible behavior for existing SCSI drivers.
Do you know that scsi_populate_tag_msg() is always going to provide a
tag? Unconditionally, every time, when using blk-mq?
This is because the test:
if (blk_rq_ta
401 - 500 of 697 matches
Mail list logo
