Christoph Hellwig wrote:
On Thu, Apr 19, 2007 at 12:10:24PM -0500, David Milburn wrote:
Update the driver version reported by MEGAIOC_QDRVRVER to
match LSI_COMMON_MOD_VERSION.
Why does this matter?
It is needed so that the correct driver version is reported
by user-space tools that use
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Tue, 24 Apr 2007 13:45:27 +0100
> Oh, btw - there is a problem with the generic code beeing esp.ko -
> we already have drivers/char/esp.c which buids into esp.ko for
> ISA platforms, which have a bit of overlap with ESP-using platforms.
> Maybe the
From: Jan Engelhardt <[EMAIL PROTECTED]>
Date: Fri, 27 Apr 2007 09:57:34 +0200 (MEST)
>
> On Apr 27 2007 00:28, David Miller wrote:
>
> >This is the patch I intend to send to Linus via my
> >sparc-2.6 tree.
> >
> >Thanks to everyone fo
From: Jan Engelhardt <[EMAIL PROTECTED]>
Date: Fri, 27 Apr 2007 10:33:30 +0200 (MEST)
> Well the patch looks like it's done in one commit (rather than two -
> delete+add), but that's probably just because it's the diff over both commits.
I didn't do it in multiple commits, I did it in one.
If I
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Fri, 27 Apr 2007 16:16:58 +0100
> aic7xxx might not be the best driver to look at either :) In practice
> a softirq has short enough latency so this doesn't matter, but you
> should probably benchmark it on your hardware. 53x700.c which is
> the
From: Alexey Dobriyan <[EMAIL PROTECTED]>
Date: Sat, 28 Apr 2007 02:09:01 +0400
> irqreturn.h for irqreturn_t and dma_addr_t being u128 warnings ;-)
>
> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
I'll apply this, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-s
From: James Bottomley <[EMAIL PROTECTED]>
Date: Sun, 29 Apr 2007 16:18:19 -0500
> On Sun, 2007-04-29 at 22:56 +0200, Guennadi Liakhovetski wrote:
> > 2. are they ever sent apart from when accompanying the DISCONNECT /
> > RESELECT?
>
> I've never seen an occasion, no.
I have.
> > 3. if "yes" t
From: James Bottomley <[EMAIL PROTECTED]>
Date: Mon, 30 Apr 2007 13:24:07 -0500
> On Mon, 2007-04-30 at 20:15 +0200, Guennadi Liakhovetski wrote:
> > Ok, looking through t10 docs there seem to be quite a few functions for
> > the SAVE DATA POINTERS / MODIFY DATA POINTER / RESTORE POINTERS (btw, e
> From: Mike Christie [mailto:[EMAIL PROTECTED]
> Sent: Monday, May 07, 2007 11:31 AM
> David C Somayajulu wrote:
> > Signed-off-by: David Somayajulu <[EMAIL PROTECTED]>
> >
> > ---
> > drivers/scsi/qla4xxx/ql4_mbx.c | 190 ++--
> >
&g
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Tue, 8 May 2007 13:11:52 -0700
> On Tue, 08 May 2007 14:24:32 -0500
> James Bottomley <[EMAIL PROTECTED]> wrote:
>
> > However, could we compromise and just add TRUE = true, FALSE = false to
> > the enum?
>
> That sounds sane. But I don't recall all
From: James Bottomley <[EMAIL PROTECTED]>
Date: Fri, 11 May 2007 13:33:41 -0500
> Right at the moment, we're planning to clean up the way SCSI drivers
> process commands. The proposals are essentially:
>
> 1. Get rid of the now unnecessary map_single path (every command is
> either
From: James Bottomley <[EMAIL PROTECTED]>
Date: Fri, 11 May 2007 16:12:47 -0500
> I could probably cook up a patch for you, if you like? ... I've already
> done it for several other architectures.
I don't want to use that "if (bus == &sbus_bus_type)" scheme so
if that's what your patch will do do
From: James Bottomley <[EMAIL PROTECTED]>
Date: Fri, 11 May 2007 16:36:56 -0500
> On PARISC, we actually use a table of function pointers, but then we
> also have several other oddities including having to walk up the bus
> tree to find our IOMMU (having several) which can actually be on a
> diffe
From: James Bottomley <[EMAIL PROTECTED]>
Date: Tue, 15 May 2007 12:57:25 -0400
> It might make sense to put it in lib ... however, I don't think many
> architectures have the problems we have ... specifically certain boxes
> can have >1 IOMMU, then you really have to know *which* iommu you're
> p
> Mike Christie wrote:
> David C Somayajulu wrote:
> > This patch OBSOLETES previous patches 0/5 thru 5/5 titled qla4xxx:
Add IPv6 support and misc. It
> incorporates the feedback received from Mike Christie and others, and
encapsulates everything into a
> single patch.
> >
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 21 May 2007 19:45:22 -0400
> David Miller wrote:
> > I disagree, I want people to be able to do test builds
> > even if their platform lacks a front-end driver. And
> > for platforms with multiple front ends it'
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Tue, 22 May 2007 00:00:41 +0100
> > --- a/drivers/scsi/Makefile
> > +++ b/drivers/scsi/Makefile
> > @@ -121,7 +121,7 @@ obj-$(CONFIG_BLK_DEV_3W__RAID) += 3w-.o
> > obj-$(CONFIG_SCSI_3W_9XXX) += 3w-9xxx.o
> > obj-$(CONFIG_SCSI_PPA)
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Wed, 23 May 2007 18:07:35 -0400
> hrm. This appears to have been sent to linux-scsi at least three times.
>
> If it doesn't stick, I'll go ahead and send it up myself.
The latency on linux-scsi review and integration of patches is not so
hot lately, o
From: Olaf Hering <[EMAIL PROTECTED]>
Date: Fri, 25 May 2007 10:22:38 +0200
> Current Linus tree does not compile on s390 because esp_scsi references
> unavailable functions.
I have a fix for this pending in my sparc-2.6 tree which I'll
send to Linus tomorrow, thanks for the report.
-
To unsubscr
From: Hannes Reinecke <[EMAIL PROTECTED]>
Date: Fri, 25 May 2007 11:08:08 +0200
> James, please apply. ESP cards simply don't fit in a mainframe :-)
No James, please don't, I have a patch in my sparc-2.6 queue which
will fix this already, and in a different way.
-
To unsubscribe from this list: s
From: Hannes Reinecke <[EMAIL PROTECTED]>
Date: Fri, 25 May 2007 11:08:08 +0200
> - depends on SCSI
> + depends on SCSI && !S390
And for the record, the correct test would be HAS_DMA not
!S390.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a me
From: James Bottomley <[EMAIL PROTECTED]>
Date: Fri, 25 May 2007 08:47:38 -0500
> OK, I won't ... but we're growing users of this base driver now, like
> this one:
>
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=352e921f0dd42f79652cdb50dd91122d068d7209
>
> Could y
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Thu, 31 May 2007 20:12:32 +0200
>
> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Looks great, thanks for doing this Christoph.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROT
Reported by Meelis Roos.
Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 572034c..e2b2838 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1532,6 +1532,7 @@ source "drivers/scsi/arm/Kconfig"
From: Randy Dunlap <[EMAIL PROTECTED]>
Date: Sun, 3 Jun 2007 17:56:04 -0700
> On Sun, 03 Jun 2007 17:36:25 -0700 (PDT) David Miller wrote:
>
> >
> > Reported by Meelis Roos.
> >
> > Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
> >
>
Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index ec71061..71caf2d 100644
--- a/drivers/scsi/esp_scsi.c
+++ b/drivers/scsi/esp_scsi.c
@@ -2033,6 +2033,7 @@ static void esp_reset_cleanu
On Fri, 2007-06-15 at 13:39 +0200, Geert Uytterhoeven wrote:
> Add a Disk Storage Driver for the PS3:
> - Implemented as a block device driver with a dynamic major
> - Disk names (and partitions) are of the format ps3d%c(%u)
> - Uses software scatter-gather with a 64 KiB bounce buffer as the
From: Geert Uytterhoeven <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 16:43:05 +0200 (CEST)
> On Fri, 15 Jun 2007, David Woodhouse wrote:
> > On Fri, 2007-06-15 at 13:39 +0200, Geert Uytterhoeven wrote:
> > > Add a Disk Storage Driver for the PS3:
> > > - Implemen
From: Alan Cox <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 17:15:45 +0100
> > > Any particular reason why this is done as a separate block device driver
> > > rather than as SCSI?
> >
> > Because no new fake SCSI drivers are accepted anymore.
>
> Where did drivers/ata come from ;)
>
> How about
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 17:28:31 -0400
> David Miller wrote:
> > If the SCSI guys were smart, there would be a totally generic helper
> > layer that allows anyone to hook into the SCSI layer as a virtual SCSI
> > disk provid
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 17:50:50 -0400
> FWIW that's why libata followed the path it did: faking SCSI required
> the least amount of code for the maximal amount of existing storage
> driver and platform installer support.
>
> Well, that and the fact that AT
From: James Bottomley <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 15:40:42 -0700
> On Fri, 2007-06-15 at 14:19 -0700, David Miller wrote:
> > Another quirk I have to deal with is that under LDOMs you
> > can export full disks and also just slices. So I'll have
> >
From: James Bottomley <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 16:28:03 -0700
> On Fri, 2007-06-15 at 16:08 -0700, David Miller wrote:
> > From: James Bottomley <[EMAIL PROTECTED]>
> > Date: Fri, 15 Jun 2007 15:40:42 -0700
> >
> > > On Fri, 200
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Tue, 19 Jun 2007 07:53:58 +0200
> On Fri, Jun 15, 2007 at 02:19:17PM -0700, David Miller wrote:
> > Another quirk I have to deal with is that under LDOMs you
> > can export full disks and also just slices. So I'll hav
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Tue, 19 Jun 2007 07:56:29 +0200
> A SCSI pass through is of course perfectly fine. If you have a separate
> block passthrough that has additional magic a separate block driver is
> the way to go because it actually is simpler than a scsi driver de
with open(path, 'r') as file_fd:
> > PermissionError: [Errno 13] Permission denied:
> > '/sys/kernel/config/target/core/fileio_28/xxx/attrib/pi_prot_format'
>
> This looks like an intentional behavior change with
>
> commit 6baca7601bdee2e57f20
From: Jakub Kicinski
Date: Tue, 19 Dec 2017 15:46:51 -0800
> On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote:
>> Sorry for the very long patch.
>> The firmware changes are spread all over w/o a good modularity.
>
> Rings false. Significant portion of this patch is just whitespace
> and c
This says "0/3" and then a 4 patch series shows up...
From: Tomer Tayar
Date: Wed, 27 Dec 2017 19:30:04 +0200
> This series advances all qed* drivers to use firmware 8.33.1.0 which brings
> new capabilities and initial support of new HW. The changes are mostly in
> qed, and include changes in the FW interface files, as well as updating the
> FW init
s 'rep movsb' relying
on the hardware to DTRT.
For uncached accesses (typical for io) the 'RT' has to be byte transfers.
So instead of the 8 byte transfers (on 64 bit) you get single bytes.
This won't be what is intended!
memcpy_toio() should probably use 'rep movsd' for the bulk of the transfer.
David
From: Andy Shevchenko
> Sent: 23 February 2018 16:51
> On Fri, Feb 23, 2018 at 6:41 PM, David Laight wrote:
> > From: Arnd Bergmann
> >> Sent: 23 February 2018 15:37
> >>
> >> 32-bit architectures generally cannot use writeq(), so we now get a
From: Andy Shevchenko
> Sent: 23 February 2018 17:13
> To: David Laight
> Cc: Arnd Bergmann; James Smart; Dick Kennedy; James E.J. Bottomley; Martin K.
> Petersen; Hannes
> Reinecke; Johannes Thumshirn; linux-scsi@vger.kernel.org;
> linux-ker...@vger.kernel.org
> Subject: R
<< 12 + 6 << 8 + 6 << 4 + 10).
> + * Command group 3 is reserved and should never be used.
> + */
> +#define COMMAND_SIZE(opcode) \
> + (16 - (15 & (1715488362 >> (4 * (((opcode) >> 5) & 7)
Why not:
(6 + (15 & (0x446a6440u
Specifying the constant in hex makes it more obvious.
It is a shame about the 16, but an offset is easier than the negate.
David
TUS_OK) {
is easier to focus on :-)
David
From: Michal Kalderon
Date: Wed, 28 Mar 2018 11:42:16 +0300
> This FW contains several fixes and features
>
> RDMA Features
> - SRQ support
> - XRC support
> - Memory window support
> - RDMA low latency queue support
> - RDMA bonding support
>
> RDMA bug fixes
> - RDMA remote invalidate during
Please feel free put it in via the scsi tree:
Acked-by: David S. Miller
[replying to an old thread]
On Sun, 8 Apr 2018 11:57:18 +0800, Zhang Zhuoyu wrote:
> > On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote:
> >
> > > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds);
> > > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_,
From: Michal Kalderon
Date: Sun, 26 May 2019 15:22:19 +0300
> This patch series modifies the current implementation of PF selection.
> The refactoring of the llh code enables setting additional filters
> (mac / protocol) per PF, and improves performance for offload protocols
> (RoCE, iWARP, iSCSI
return 2;
- else if (strstr("SPKM2", authtype))
- return 2;
- else if (strstr("KRB5", authtype))
- return 2;
- else
- return 2;
+ /* SRP, SPKM1, SPKM2 and KRB5 are unsupported */
+ return 2;
}
Cheers, David
nges in v2: treat SRP as unsupported authtype.
>Remove unnecessary else
>return 2 in all unsupported cases
Reviewed-by: David Disseldorp
Cheers, David
From: Varun Prakash
Date: Tue, 4 Jun 2019 15:41:49 +0530
> +static int setup_ppod_edram(struct adapter *adap)
> +{
> + int ret;
> + unsigned int param, val;
Reverse christmas tree please.
From: Christoph Hellwig
Date: Wed, 5 Jun 2019 12:07:23 -0700
> On Wed, Jun 05, 2019 at 12:06:40PM -0700, Stephen Hemminger wrote:
>> > Which is true for every device, and why we use UUIDs or label for
>> > mounts that are supposed to be stable.
>>
>> Not everyone is smart enough to do that.
>
>
From: Varun Prakash
Date: Mon, 10 Jun 2019 18:36:34 +0530
> Page pods are used for direct data placement, this patch
> enables eDRAM page pods if firmware supports this feature.
>
> Signed-off-by: Varun Prakash
> ---
> v3: reordered local variable declarations in reverse christmas tree format
number of the people who will be involved in ensuring that the
proverbial "right thing" happens, e.g., the Transport Area Directors.
Thanks, --David
> -Original Message-
> From: Christoph Hellwig
> Sent: Tuesday, September 3, 2019 3:00 AM
> To: Maurizio Lombardi
> C
ly counted.
I'm not even sure that is needed if you are printing 32bit words.
OTOH 32bit words makes 64bit values really stupid on LE systems.
Bytes with extra spaces every 4 bytes is the format I prefer
even for long lines.
Oh, and if you are using hexdump() a lot you want a version
th
t bytes.
In that case you may want hexdump to return the flags for the
next call when a large buffer is being dumped in fragments.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
The function shouldn't dictate what the
> caller can and can't do beyond the technical limits of it's implementation.
Why powers of two?
You may want the length to match sizeof (struct foo).
You might even want the address increment to be larger
that the number of lines dumped.
uppressing lines of zeros and dumping a buffer in several blocks
then subsequent calls need to know that the last line of the previous call
was suppressed zeros - and carry on with the same suppressed block.
I've not looked to see if it does support suppressing lines of zeros/0xff.
From: Michal Kalderon
Date: Wed, 1 May 2019 12:57:19 +0300
> diff --git a/drivers/infiniband/hw/qedr/main.c
> b/drivers/infiniband/hw/qedr/main.c
> index d93c8a893a89..8bc6775abb79 100644
> --- a/drivers/infiniband/hw/qedr/main.c
> +++ b/drivers/infiniband/hw/qedr/main.c
> @@ -52,6 +52,10 @@ MOD
de which is dominated by its tracing!)
then you don't want all the function calls and conditionals
even if you want some of the functionality.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
From: Yuval Mintz
Date: Fri, 2 Jun 2017 08:58:29 +0300
> This series is intended to add additional information and features
> to the API between qed and its storage protocol drivers [qedi, qedf].
>
> Patch #2 adds some information stored on device such as wwpn & wwnn
> to allow qedf utilize it;
From: Ganesh Goudar
Date: Wed, 7 Jun 2017 15:04:51 +0530
> the adapter consumes two tids for every ipv6 offload
> connection be it active or passive, calculate tid usage
> count accordingly.
>
> Also change the signatures of relevant functions to get
> the address family.
>
> Signed-off-by: Ri
27;noncoherent'.
Grepping the source for other uses is easier if the wrapper is left.
David
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:04 +0200
> gcc-7 notices that "-event-%d" could be more than 11 characters long
> if we had larger 'vector' numbers:
>
> drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev':
> drivers/net/vmxnet3/vmxnet3_drv.c:2095:40: error: 'sp
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:05 +0200
> gcc reports that the temporary buffer for computing the
> string length may be too small here:
>
> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function
> 'lio_get_eeprom_len':
> /drivers/net/ethernet/cavium/liquidio/lio_etht
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:03 +0200
> gcc warns that the temporary buffer might be too small here:
>
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe':
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d'
> directive writing b
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:02 +0200
> gcc notices that large queue numbers would overflow the queue name
> string:
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c: In function
> 'bnx2x_get_strings':
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:25: err
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:01 +0200
> We get a warning for the port_name string that might be longer than
> six characters if we had more than 10 ports:
>
> drivers/net/ethernet/sun/niu.c: In function 'niu_put_parent':
> drivers/net/ethernet/sun/niu.c:9563:21: error: '%d' d
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:00 +0200
> One string we pass into the cs->info buffer might be too long,
> as pointed out by gcc:
>
> drivers/isdn/divert/isdn_divert.c: In function 'll_callback':
> drivers/isdn/divert/isdn_divert.c:488:22: error: '%d' directive writing
> betwe
ize 32
>
> We can simply double the size of the local buffer here to be on the
> safe side.
I think I'd change it to snprintf() as well.
Saves any worries if ioc->name isn't '\0' terminated.
David
Move the ISCSI_IQN_LEN definition up, so that it can be used in more
places instead of a hardcoded value.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_stat.c | 4 ++--
include/target/iscsi/iscsi_target_core.h | 6 +++---
include/target/iscsi/iscsi_target_stat.h | 4
Events resulting in connection outages like this should be logged as
errors. Include the I_T Nexus in the message to aid path identification.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_util.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a
-lio-trigger-dataout-timeout
https://github.com/ddiss/libiscsi/tree/hack-lio-trigger-nop-timeout
Cheers, David
---
Changes since v1
- split out and use a helper function for cxn timeout error stashing
- add I_T Nexus to error messages
drivers/target/iscsi/iscsi_target_erl0.c | 15
sess_err_stats are currently filled on NOP ping timeout, but not
Data-Out timeout. Stash details of Data-Out timeouts using a
ISCSI_SESS_ERR_CXN_TIMEOUT value for last_sess_failure_type.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_erl1.c | 1 +
1 file changed, 1
Data-Out timeouts resulting in connection outages should be logged as
errors. Include the I_T Nexus in the message to aid path identification.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_erl1.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions
Replace existing nested code blocks with helper function calls.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_erl0.c | 15 +-
drivers/target/iscsi/iscsi_target_util.c | 35 +---
drivers/target/iscsi/iscsi_target_util.h | 1 +
3
. If that
> not's the case, how about using strlcpy() to make it easy for anyone who
> reads the source code that no output buffer overflow will occur?
Both arrays are the same size (ISCSI_IQN_LEN). I'll change this over to
use strlcpy(), as I agree that it helps readability.
Cheers, David
Replace existing nested code blocks with helper function calls.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_erl0.c | 15 +
drivers/target/iscsi/iscsi_target_util.c | 36 ++--
drivers/target/iscsi/iscsi_target_util.h | 1 +
3
)
This patch is a v3 respin of an individual patch within the series:
[PATCH v2 0/5] target: improve Data-Out and NOP timeout error reporting
The sess declaration is provided in [PATCH v2 3/5].
I guess I'll resend entire series in future to avoid false kbuild
reports.
Cheers, David
to 4.20/scsi-queue.
Thanks Martin.
Cheers, David
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_stat.c | 14 +-
include/target/iscsi/iscsi_target_stat.h | 2 --
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_stat.c
b/drivers/target/iscsi/iscsi_target_stat.c
The cumulative session errors metric matches cxn_timeout_errors, so drop
the duplicate.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_stat.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_stat.c
b/drivers/target
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_stat.c | 14 +-
include/target/iscsi/iscsi_target_stat.h | 2 --
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_stat.c
b/drivers/target/iscsi/iscsi_target_stat.c
This patchset removes a couple of unused error stat counters and a
redundant cumulative counter.
I've tagged this patchset RFC, as it may be considered a kernel<->user
(configfs) API change.
Cheers, David
---
drivers/target/iscsi/iscsi_target_
On Wed, 17 Oct 2018 17:48:17 +0200, David Disseldorp wrote:
> This patchset removes a couple of unused error stat counters and a
> redundant cumulative counter.
> I've tagged this patchset RFC, as it may be considered a kernel<->user
> (configfs) API change.
Ping, any th
s to block such requests,
avoiding the need for multi-node reservation state propagation.
When explicitly disabled, PR and RESERVE/RELEASE requests receive
Invalid Command Operation Code response sense data.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_configfs.c
d
> TRANSPORT_FLAG_PASSTHROUGH_PGR is set, userspace cannot detect what the
> backend supports. We would have to temporarily set emaulate_pr sow e can
> read the file then clear it.
Agreed, that'd be awkward and is unnecessary given the presence of both
configfs attributes. I'll send a new version which drops this hunk.
Cheers, David
s to block such requests,
avoiding the multi-node reservation state propagation.
When explicitly disabled, PR and RESERVE/RELEASE requests receive
Invalid Command Operation Code response sense data.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_configfs.c
anything stopping us from plumbing them into
the corresponding error paths, so I'll withdraw this patchset.
Cheers, David
Ping, did anyone get a chance to look at this one?
Cheers, David
Signed-off-by: David Disseldorp
---
drivers/target/target_core_stat.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_stat.c
b/drivers/target/target_core_stat.c
index f0db91ebd735..89f35167f036 100644
--- a/drivers/target
Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
can be reconfigured via the vendor_id ConfigFS attribute.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_spc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/driv
PI changes.
David Disseldorp (4):
target: use consistent left-aligned ASCII INQUIRY data
target: don't assume t10_wwn.vendor is null terminated
target: add device vendor_id configfs attribute
target: remove hardcoded T10 Vendor ID in INQUIRY response
drivers/target/target_
t when the backstore
device is enabled.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_configfs.c | 55 +++
include/target/target_core_base.h | 3 +-
2 files changed, 57 insertions(+), 1 deletion(-)
diff --git a/drivers/target/target_core_con
the standard INQUIRY data as well as the
T10 VENDOR IDENTIFICATION field in the INQUIRY Device Identification VPD
Page are zero-terminated/zero-padded.
Fix this inconsistency by using space-padding for all of the above
fields.
Signed-off-by: David Disseldorp
---
drivers/target/target_core_spc.c
On Tue, 20 Nov 2018 08:49:24 -0800, Christoph Hellwig wrote:
> This could use a little more explanation, the code doesn't just
> add a little if but also changes the existing case. Also where
> can't it be null currently?
I'll add an explanation in the next round. This patch shouldn't cause
any
On Tue, 20 Nov 2018 09:24:39 -0800, Bart Van Assche wrote:
> On Mon, 2018-11-19 at 22:06 +0100, David Disseldorp wrote:
> > /*
> > + * STANDARD and VPD page 0x80 T10 Vendor Identification
> > + */
> > +static ssize_t target_wwn_vendor_id_show(struct config_item *item,
Block ALUA and PR state storage if any of the dynamic subdirectory
components include a path separator.
Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
Signed-off-by: David Disseldorp
Signed-off-by: Lee Duncan
---
Note:
Submitted as an RFC, as I've not prop
unfortunately need to keep both strings
around for now.
Replace the useless .get_fabric_name() accessor function with a const
string fabric_name member variable.
Signed-off-by: David Disseldorp
---
Note: This conflicts with:
[RFC PATCH] target: sanitize ALUA and PR state file paths before use
I&#x
On Thu, 22 Nov 2018 23:19:10 -0800, Christoph Hellwig wrote:
> On Thu, Nov 22, 2018 at 03:16:23PM +0100, David Disseldorp wrote:
> > All fabrics return a const string. In all cases *except* iSCSI the
> > get_fabric_name() string matches fabric_ops.name.
> >
> > Both
301 - 400 of 697 matches
Mail list logo
