[PATCH 04/20] smartpqi: correct host serial num for ssa

2018-12-07 Thread Don Brace
From: Mahesh Rajashekhara Reviewed-by: Scott Benesh Reviewed-by: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Mahesh Rajashekhara Signed-off-by: Don Brace --- drivers

[PATCH 01/20] smartpqi: add support for PQI Config Table handshake

2018-12-07 Thread Don Brace
by: Mahesh Rajashekhara Reviewed-by: Murthy Bhat Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h | 43 ++ drivers/scsi/smartpqi/smartpqi_init.c | 254 - 2 fil

[PATCH 02/20] Add retries for device reset

2018-12-07 Thread Don Brace
From: Mahesh Rajashekhara Reviewed-by: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Justin Lindley Reviewed-by: Scott Benesh Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Mahesh Rajashekhara Signed-off-by: Don Brace --- drivers/scsi

[PATCH 07/20] smartpqi: add sysfs attributes

2018-12-07 Thread Don Brace
From: Dave Carroll - add sysfs device attributes, unique_id, lunid and path_info. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |3 drivers/scsi/smartpqi/smartpqi_init.c | 232

[PATCH 08/20] smartpqi: add h3c ssid

2018-12-07 Thread Don Brace
From: Murthy Bhat Reviewed-by: Scott Benesh Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Murthy Bhat Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |8 1 file changed, 8

[PATCH 11/20] smartpqi: enhance numa node detection

2018-12-07 Thread Don Brace
dar Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index acde0abbbf43..a98b3de40c74 100644 --- a/drivers/scsi/smart

[PATCH 14/20] smartpqi: allow for larger raid maps

2018-12-07 Thread Don Brace
From: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Ajish Koshy Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 59

[PATCH 12/20] smartpqi: add support for huawei controllers

2018-12-07 Thread Don Brace
From: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Ajish Koshy Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 24 1 file

[PATCH 13/20] smartpqi: check for null device pointers

2018-12-07 Thread Don Brace
Rajashekhara Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |2 + drivers/scsi/smartpqi/smartpqi_init.c | 65 +++-- 2 files changed, 64 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi

[PATCH 15/20] smartpqi: do not offline disks for transient did no connect conditions

2018-12-07 Thread Don Brace
From: Dave Carroll Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 16/20] smartpqi: correct volume status

2018-12-07 Thread Don Brace
ask for LV_STATUS, insure we get LV_STATUS Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |3 +++ 1 file changed, 3 insertions

[PATCH 10/20] smartpqi: wake up drives after os resumes from suspend

2018-12-07 Thread Don Brace
-off-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 6716d30dc5ef..acde0abbbf43 100644 --- a/drivers/scsi/smartpqi

[PATCH 09/20] smartpqi: fix disk name mount point

2018-12-07 Thread Don Brace
From: Murthy Bhat - fix a formatting issue. Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Dave Carroll Reviewed-by: Kevin Barnett Signed-off-by: Murthy Bhat Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |7 ++- 1 file changed, 6

[PATCH 17/20] smartpqi: correct lun reset issues

2018-12-07 Thread Don Brace
ield is left untouched. But in this case, the kernel changes the result field behind the driver’s back and then expects the field to be changed by the driver as the commands that timed-out complete. Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by

[PATCH 20/20] smartpqi: bump driver version

2018-12-07 Thread Don Brace
Reviewed-by: Gerry Morong Reviewed-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 8d94028d0a9d

[PATCH 19/20] smartpqi: add smp_utils support

2018-12-07 Thread Don Brace
Reviewed-by: Scott Benesh Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Dave Carroll Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h | 89 + drivers/scsi/smartpqi/smartpqi_init.c | 131

[PATCH 18/20] smartpqi: add module param to disable irq affinity

2018-12-07 Thread Don Brace
: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 2f2a07a38dad..f9812281988c 100644 --- a

[PATCH] MAINTAINERS: Change hpsa and cciss maintainer

2014-10-15 Thread Don Brace
Change ownership of the hpsa driver from Stephen M. Cameron (Hewlett-Packard) to Don Brace (PMC-Sierra). Change ownership of the cciss driver from Mike Miller (Hewlett-Packard) to Don Brace (PMC-Sierra). Reviewed-by: Robert Elliott Signed-off-by: Don Brace --- MAINTAINERS |8 ++-- 1

Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-30 Thread Don Brace
patches for 3.19 or ack this now, What would you prefer? --- Don Brace don.br...@pmcs.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 02/13] hpsa: remove dev_warn prints from RAID-1ADM

2014-11-14 Thread Don Brace
From: Robert Elliott RAID-1ADM is unusable with dev_warn called on every command. Signed-off-by: Robert Elliott Signed-off-by: Don Brace Reviewed-by: Stephen M. Cameron Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi

[PATCH 01/13] hpsa: Clean up warnings from sparse.

2014-11-14 Thread Don Brace
Clean up issues reported when running sparse. Signed-off-by: Don Brace Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 29 - drivers/scsi/hpsa.h |6 +++--- 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH 00/13] hpsa update

2014-11-14 Thread Don Brace
This patch set is based on Linus's tree. The changes are: - correct warnings from sparse - updates for some error handling issues - general code cleanup - performance enhancements based on removing spin_locks --- Don Brace (1): hpsa: Clean up warnings from sparse. Nicholas Bell

[PATCH 08/13] hpsa: get rid of type/attribute/direction bit field where possible

2014-11-14 Thread Don Brace
he userland ABI. Signed-off-by: Don Brace Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 58 --- drivers/scsi/hpsa_cmd.h | 18 +++ 2 files changed, 42 insertions(+), 34 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/sc

[PATCH 11/13] hpsa: Convert SCSI LLD ->queuecommand() for host_lock less operation

2014-11-14 Thread Don Brace
From: Nicholas Bellinger There isn't anything in hpsa that requires the host lock to be held during queuecommand. Signed-off-by: Don Brace Signed-off-by: Nicholas Bellinger Reviewed-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 16 +++- 1 file changed, 7 insertions(

[PATCH 07/13] hpsa: fix endianness issue with scatter gather elements

2014-11-14 Thread Don Brace
From: Stephen M. Cameron The hardware needs little endian scatter gather addresses and lengths but we were not bothering to convert from cpu byte order as we should have been. On Intel, this is all just a bunch of no-ops macros, but it makes the code endian-clean(er). Signed-off-by: Don Brace

[PATCH 04/13] hpsa: correct off-by-one sizing of chained SG block

2014-11-14 Thread Don Brace
From: Webb Scales Correct the size calculation of the chained SG block Signed-off-by: Don Brace Signed-off-by: Webb Scales Reviewed-by: Stephen M. Cameron Reviewed-by: Don Brace --- drivers/scsi/hpsa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH 06/13] hpsa: fix allocation sizes for CISS_REPORT_LUNs commands

2014-11-14 Thread Don Brace
. Allocate the memory based on the specific data structure sizes. Signed-off-by: Don Brace Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 14 +++--- drivers/scsi/hpsa_cmd.h |2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH 10/13] hpsa: do not be so noisy about check conditions

2014-11-14 Thread Don Brace
From: Stephen M. Cameron We were printing a lot of useless information before ultimately just passing things up to the SCSI mid layer. Just let the midlayer handle it without LLD chatter. Signed-off-by: Don Brace Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik Reviewed-by: Scott

[PATCH 12/13] hpsa: always call pci_set_master after pci_enable_device

2014-11-14 Thread Don Brace
pci_request_regions both in the kdump code and the normal pci_init code. Remove the comment summarizing what pci_set_master does, with the incomplete commentary on the impact of pci_disable_device. Signed-off-by: Robert Elliott Signed-off-by: Don Brace Reviewed-by: Don Brace --- drivers/scsi

[PATCH 09/13] hpsa: use atomics for commands_outstanding

2014-11-14 Thread Don Brace
From: Stephen M. Cameron Use atomics for commands_outstanding instead of protecting with spin locks. Signed-off-by: Don Brace Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c | 26 +- drivers/scsi/hpsa.h | 27

[PATCH 05/13] hpsa: remove 'action required' phrasing

2014-11-14 Thread Don Brace
From: Stephen M. Cameron In the case of LUN data changing, the driver will auto rescan and so it's not even true that "action" is "required". Remove "action required" phrases from warning messages and replace with description phrases. Signed-off-by: Don Bra

[PATCH 13/13] hpsa: remove spin lock around command allocation

2014-11-14 Thread Don Brace
From: Stephen M. Cameron It is already using atomic test_and_set_bit to do the allocation. There is some microscopic chance of starvation, but it is so microscopic that it should never happen in reality. Signed-off-by: Don Brace Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 36

[PATCH 03/13] hpsa: fix a couple pci id table mistakes

2014-11-14 Thread Don Brace
From: Stephen M. Cameron Fix a couple of pci id table mistakes: Subdevice ID 0x3323 missing from product[] table (another name for HP Smart Storage 1210m) Bogus 0x1925 subdevice id removed from hpsa_pci_device_id[] (no such thing.) Signed-off-by: Don Brace Reviewed-by: Webb Scales

[PATCH 00/48] hpsa driver updates

2015-01-14 Thread Don Brace
oring - performance enhancements. - removal of command queueing in driver - elimination of race conditions around aborts - change to internal driver workqueues --- Don Brace (11): hpsa: correct endian sparse warnings hpsa: change how SA controllers are reset hpsa: co

[PATCH 01/48] hpsa: correct endian sparse warnings

2015-01-14 Thread Don Brace
Correct endiness issues reported by sparse. SA controllers are little endian. This patch ensures endiness correctness. Signed-off-by: Don Brace Reviewed-by: Scott Teel Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 275 +++ drivers/scsi

[PATCH 02/48] hpsa: fix memory leak in kdump hard reset

2015-01-14 Thread Don Brace
From: Tomas Henzl There is a potential memory leak in hpsa_kdump_hard_reset_controller. Reviewed-by: Don Brace Reviewed-by: Scott Teel Signed-off-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 03/48] hpsa: turn off interrupts when kdump starts

2015-01-14 Thread Don Brace
ard_reset_controller fixes it. At this point we can't know in which state the card is, so using SA5_INTR_OFF + SA5_REPLY_INTR_MASK_OFFSET defines directly, instead of the function the drivers provides, seems to be apropriate. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- d

[PATCH 04/48] hpsa: change how SA controllers are reset

2015-01-14 Thread Don Brace
Brace Reviewed-by: Scott Teel Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9edacff..371d0a8 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH 05/48] hpsa: correct change_queue_depth

2015-01-14 Thread Don Brace
scsi_adjust_queue_depth was changed to scsi_change_queue_depth Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 371d0a8..7dfe829 100644

[PATCH 06/48] hpsa: adjust RAID-1, RAID-1ADM, and RAID-6 names

2015-01-14 Thread Don Brace
[] Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 7dfe829..4252b63 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH 09/48] hpsa: notice all request_irq errors

2015-01-14 Thread Don Brace
[ 10.711623] scsi host1: Error handler scsi_eh_1 exiting [ 10.739170] hpsa: probe of :02:00.0 failed with error -38 Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 ++- 1 file changed, 18 insertions(+), 1

[PATCH 10/48] hpsa: remove 0x from queue depth print which is in decimal

2015-01-14 Thread Don Brace
From: Robert Elliott The queue depth printed at startup is in decimal, so shouldn't have a 0x prefix. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 11/48] hpsa: propagate hard_reset failures in reset_devices mode

2015-01-14 Thread Don Brace
From: Robert Elliott Return the real reason for kdump_hard_reset failure rather than change them all to -ENODEV. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a

[PATCH 12/48] hpsa: propagate return value from board ID lookup

2015-01-14 Thread Don Brace
: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 92ac76a..85b3d73 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -5812,8 +5812,12 @@ static

[PATCH 13/48] hpsa: downgrade the Waiting for no-op print to dev_info

2015-01-14 Thread Don Brace
From: Robert Elliott There is nothing worrisome about the "Waiting for controller to respond to no-op" print, so use dev_info rather than dev_warn. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1

[PATCH 14/48] hpsa: refactor hpsa_find_board_params() to encapsulate legacy test

2015-01-14 Thread Don Brace
From: Webb Scales Encapsulate the conditional predicate which tests for legacy controllers in a separate function and rework the code comments. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 30 +- 1 file

[PATCH 08/48] hpsa: Fix -Wunused-but-set-variable warning

2015-01-14 Thread Don Brace
From: Fabian Frederick Remove unused variable in hpsa_free_cmd_pool. Reviewed-by: Scott Teel Signed-off-by: Fabian Frederick Acked-by: Don Brace Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 07/48] hpsa: rename free_irqs to hpsa_free_irqs

2015-01-14 Thread Don Brace
From: Robert Elliott Change the function names to have hpsa prefix. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 43 ++- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a

[PATCH 15/48] hpsa: trivial message and comment clean ups

2015-01-14 Thread Don Brace
From: Stephen Cameron Cleanup comments to be more specific. Make messages more informational. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a

[PATCH 17/48] hpsa: rename hpsa_request_irq to hpsa_request_irqs

2015-01-14 Thread Don Brace
From: Robert Elliott Make the function name more descriptive. We use more than one interrupt. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/scsi

[PATCH 16/48] hpsa: report failure to ioremap config table

2015-01-14 Thread Don Brace
From: Robert Elliott Enhance error reporting. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5973018..354e7f8

[PATCH 18/48] hpsa: pass error from pci_set_consistent_dma_mask from hpsa_message

2015-01-14 Thread Don Brace
From: Robert Elliott Return the actual error code instead of a generic error code. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH 20/48] hpsa: fix memory leak in hpsa_alloc_cmd_pool

2015-01-14 Thread Don Brace
From: Robert Elliott Partial allocation failure wasn't handled correctly Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 19/48] hpsa: report allocation failures while allocating SG chain blocks

2015-01-14 Thread Don Brace
From: Robert Elliott Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 64d17d1..dc328ce 100644 --- a/drivers

[PATCH 25/48] hpsa: do not request device rescan on every ioaccel path error

2015-01-14 Thread Don Brace
would get retried down the RAID path. However, something needs to turn ioaccellerator mode back on, and this rescan request was what did that. However, it was racy, and extremely bad for performance to rescan all devices, so, don't do that. Reviewed-by: Scott Teel Signed-off-by: Don

[PATCH 23/48] hpsa: get rid of cmd_special_alloc and cmd_special_free

2015-01-14 Thread Don Brace
From: Stephen Cameron We have commands reserved for internal use. This is laying the groundwork for removing the internal queue of commands from the driver so that the locks that protect that queue may be removed. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

[PATCH 22/48] hpsa: reserve some commands for use by driver

2015-01-14 Thread Don Brace
the driver so that we can remove the locks thta protect the queue that we will no longer have. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |7 +-- drivers/scsi/hpsa.h |2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c

[PATCH 26/48] hpsa: factor out hpsa_ciss_submit function

2015-01-14 Thread Don Brace
llerated" paths but which have some sort of error condition are retried down the "normal" path. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 126 +++ 1 file changed, 67 insertions(+), 59 deletions

[PATCH 27/48] hpsa: use workqueue to resubmit failed ioaccel commands

2015-01-14 Thread Don Brace
accel path, and prevent excessive rescanning of devices. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 60 --- drivers/scsi/hpsa_cmd.h |1 + 2 files changed, 42 insertions(+), 19 deletions(-) diff --git a/dr

[PATCH 28/48] hpsa: use per-controller work queue

2015-01-14 Thread Don Brace
, per-controller work queue avoids this. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 16 +--- drivers/scsi/hpsa.h |1 + 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH 24/48] hpsa: do not queue commands internally in driver

2015-01-14 Thread Don Brace
liott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 306 +-- drivers/scsi/hpsa.h | 17 --- drivers/scsi/hpsa_cmd.h | 10 -- 3 files changed, 38 insertions(+), 295 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 26

[PATCH 29/48] hpsa: honor queue depth of physical devices

2015-01-14 Thread Don Brace
parity drives. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 318 +-- drivers/scsi/hpsa.h | 14 ++ drivers/scsi/hpsa_cmd.h | 148 ++ 3 files changed, 412 insertions

[PATCH 21/48] hpsa: avoid unneccesary calls to resource freeing functions

2015-01-14 Thread Don Brace
t pointers would be NULL) but it is potentially confusing. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a66a50

[PATCH 34/48] hpsa: do not check for msi(x) in interrupt_pending

2015-01-14 Thread Don Brace
From: Stephen Cameron No need to check whether interrupt pending for MSI(X) and conversely, no need to check whether MSI(X) interrupts are being used when checking if interrupts are pending. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.h |3 --- 1 file changed

[PATCH 31/48] hpsa: optimize cmd_alloc function by remembering last allocation

2015-01-14 Thread Don Brace
-off-by: Don Brace --- drivers/scsi/hpsa.c |7 +-- drivers/scsi/hpsa.h |1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c95a20c..72abcf3 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -4649,9 +4649,10

[PATCH 35/48] hpsa: remove incorrect BUG_ONs checking for raid offload enable

2015-01-14 Thread Don Brace
at means accel commands could still be in flight, ie. perhaps having just been submitted into hpsa_scsi_ioaccel_raid_map concurrent with ->offload_enabled having just been set to zero. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 1 file changed, 4 de

[PATCH 33/48] hpsa: slightly optimize SA5_performant_completed

2015-01-14 Thread Don Brace
Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index 1856445..aa6cb0b 100644 --- a/drivers/scsi/hpsa.h +++ b/drivers/scsi/hpsa.h @@ -412,19 +412,19

[PATCH 32/48] hpsa: count passthru cmds with atomics, not a spin locked int

2015-01-14 Thread Don Brace
Performance enhancement. Remove spin_locks from the driver. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 39 +-- drivers/scsi/hpsa.h |3 +-- 2 files changed, 6 insertions(+), 36 deletions(-) diff --git a/drivers/scsi

[PATCH 30/48] hpsa: fix race between abort handler and main i/o path

2015-01-14 Thread Don Brace
mmands to use the reference count as the authoritative indicator of whether a command is allocated instead of the h->cmd_pool_bits bitmap. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 109 +++ drivers/scsi/hpsa.h

[PATCH 39/48] hpsa: return failed from device reset/abort handlers

2015-01-14 Thread Don Brace
Returning failed from the device reset handler will get the device kicked offline, which is fine if the controller is locked up anyhow. Cannot abort a command from a failed controller. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |7

[PATCH 37/48] hpsa: guard against overflowing raid map array

2015-01-14 Thread Don Brace
-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index afd192d..03fae8a 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -3921,6 +3921,9 @@ static int hpsa_scsi_ioaccel_raid_map(struct

[PATCH 40/48] hpsa: do not use a void pointer for scsi_cmd field of struct CommandList

2015-01-14 Thread Don Brace
From: Stephen Cameron There's no reason for it to be a void *, it should be a struct scsi_cmnd * Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +++--- drivers/scsi/hpsa_cmd.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --

[PATCH 41/48] hpsa: print CDBs instead of kernel virtual addresses for uncommon errors

2015-01-14 Thread Don Brace
From: Stephen Cameron Printing the address of the command pointer is of little value, change to print the CDB. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a

[PATCH 38/48] hpsa: check for ctlr lockup after command allocation in main io path

2015-01-14 Thread Don Brace
From: Stephen Cameron Command allocation is the thing that takes the longest in the main i/o path, so check for controller lockup immediately after this to prevent submitting commands to locked up controller as much as possible. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers

[PATCH 36/48] hpsa: do not ack controller events on controllers that do not support it

2015-01-14 Thread Don Brace
From: Stephen Cameron Acking controller events on controllers that do not support it can cause such controllers to lock up. Reviewed-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH 42/48] hpsa: do not use function pointers in fast path command submission

2015-01-14 Thread Don Brace
From: Stephen Cameron Performance tweak, avoid unnecessary function calls. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |8 +--- drivers/scsi/hpsa.h |5 + 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 46/48] hpsa: detect and report failures changing controller transport modes

2015-01-14 Thread Don Brace
and all their callers check/propagate the result. More consistency in printing errors and whether dev_err is used. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 40 +--- 1 file changed, 29

[PATCH 47/48] hpsa: add in gen9 controller model names

2015-01-14 Thread Don Brace
Add in gen9 controller model names Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c1f4a95..6568da5 100644 --- a/drivers

[PATCH 45/48] hpsa: shorten the wait for the CISS doorbell mode change ack

2015-01-14 Thread Don Brace
usleep_range(), which triggers rt_sched timeout errors if the wait is long. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH 43/48] hpsa: move SG descriptor set-up out of hpsa_scatter_gather()

2015-01-14 Thread Don Brace
operation from inside the loop. The case for which the conditional formerly tested is now executed (unconditionally) after the loop is exited. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 21 ++--- 1 file changed, 14

[PATCH 44/48] hpsa: refactor duplicated scan completion code into a new routine

2015-01-14 Thread Don Brace
hpsa_scan_start() as well. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 48/48] hpsa: add in P840ar controller model name

2015-01-14 Thread Don Brace
Add in P840ar model name for gen9 Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6568da5..15ef65c 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

RE: [PATCH V2 0/2] initial submit of Microsemi smartpqi driver

2016-06-16 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, June 10, 2016 4:57 AM > To: Don Brace; j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh; > elli...@h

[PATCH V3 2/2] aacraid: remove wildcard for series 9 controllers

2016-06-16 Thread Don Brace
Depends on smartpqi driver adoption Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/aacraid/linit.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 79871f3..d5b26fa 100644

[PATCH V3 0/2] initial submit of Microsemi smarpqi driver

2016-06-16 Thread Don Brace
Answers to Hannes's Review posted in a separate reply Changes since V1 - Corrected make ARCH=i386 kbuild test robot issue. Changes since initial upload - Forgot to give correct ownership to the author. --- Don Brace (1): aacraid: remove wildcard for series 9 controllers K

RE: [PATCH V3 1/2] smartpqi: initial commit of Microsemi smartpqi driver

2016-06-27 Thread Don Brace
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Friday, June 17, 2016 4:57 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh;

[PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

2016-06-27 Thread Don Brace
d make ARCH=s390 kbuild test robot issue. - Answers to Hannes's Review posted in a separate reply Changes since V1 - Corrected make ARCH=i386 kbuild test robot issue. Changes since initial upload - Forgot to give correct ownership to the author. --- Don Brace (1): aacraid: remove wildca

[PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

2016-06-27 Thread Don Brace
Depends on smartpqi driver adoption Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/aacraid/linit.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c

RE: [PATCH V3 1/2] smartpqi: initial commit of Microsemi smartpqi driver

2016-06-30 Thread Don Brace
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Tuesday, June 28, 2016 2:54 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh;

[PATCH 0/2] hpsa update

2016-07-01 Thread Don Brace
These patches are based on Linus's tree The changes are: - enhanced check for skipping masked devices - corrected hpsa_passthru_ioctl timeouts for fw flash --- Don Brace (2): hpsa: correct skipping masked peripherals hpsa: change hpsa_passthru_ioctl timeout drivers/scsi/h

[PATCH 1/2] hpsa: correct skipping masked peripherals

2016-07-01 Thread Don Brace
Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 79 --- 1 file changed, 74 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index ff8dcd5..375a396 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers

[PATCH 2/2] hpsa: change hpsa_passthru_ioctl timeout

2016-07-01 Thread Don Brace
Was not alloting for FW Flash times. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 375a396..030d002 100644 --- a

RE: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

2016-08-05 Thread Don Brace
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Thursday, August 04, 2016 8:25 PM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Sc

RE: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

2016-08-09 Thread Don Brace
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Monday, August 08, 2016 8:05 PM > To: Don Brace > Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh > Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barne

RE: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

2016-08-11 Thread Don Brace
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Wednesday, August 10, 2016 9:26 PM > To: Don Brace > Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh > Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barne

RE: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

2016-08-15 Thread Don Brace
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Friday, August 12, 2016 3:10 PM > To: Don Brace > Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh > Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barne

[PATCH 07/17] smartpqi: add kdump support

2016-08-26 Thread Don Brace
From: Kevin Barnett Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h | 13 +--- drivers/scsi/smartpqi/smartpqi_init.c | 35 + drivers/scsi/smartpqi

[PATCH 12/17] smartpqi: scsi queuecommand cleanup

2016-08-26 Thread Don Brace
From: Kevin Barnett minor cleanup of scsi queue command function Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a

[PATCH 10/17] smartpqi: minor function reformating

2016-08-26 Thread Don Brace
From: Kevin Barnett reformatted pqi_num_elements_free() to match the rest of the driver Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH 05/17] smartpqi: enhance reset logic

2016-08-26 Thread Don Brace
From: Kevin Barnett Eliminated timeout from LUN reset logic. Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |2 - drivers/scsi/smartpqi/smartpqi_init.c | 101

<    2   3   4   5   6   7   8   9   10   >