From: Mahesh Rajashekhara
Reviewed-by: Scott Benesh
Reviewed-by: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Mahesh Rajashekhara
Signed-off-by: Don Brace
---
drivers
by: Mahesh Rajashekhara
Reviewed-by: Murthy Bhat
Reviewed-by: Justin Lindley
Reviewed-by: Scott Teel
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h | 43 ++
drivers/scsi/smartpqi/smartpqi_init.c | 254 -
2 fil
From: Mahesh Rajashekhara
Reviewed-by: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Justin Lindley
Reviewed-by: Scott Benesh
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Mahesh Rajashekhara
Signed-off-by: Don Brace
---
drivers/scsi
From: Dave Carroll
- add sysfs device attributes, unique_id, lunid
and path_info.
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Dave Carroll
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h |3
drivers/scsi/smartpqi/smartpqi_init.c | 232
From: Murthy Bhat
Reviewed-by: Scott Benesh
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Murthy Bhat
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |8
1 file changed, 8
dar
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/scsi/smartpqi/smartpqi_init.c
index acde0abbbf43..a98b3de40c74 100644
--- a/drivers/scsi/smart
From: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Ajish Koshy
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 59
From: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Ajish Koshy
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 24
1 file
Rajashekhara
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h |2 +
drivers/scsi/smartpqi/smartpqi_init.c | 65 +++--
2 files changed, 64 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi
From: Dave Carroll
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Dave Carroll
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
ask for LV_STATUS, insure we get LV_STATUS
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Dave Carroll
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |3 +++
1 file changed, 3 insertions
-off-by: Dave Carroll
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/scsi/smartpqi/smartpqi_init.c
index 6716d30dc5ef..acde0abbbf43 100644
--- a/drivers/scsi/smartpqi
From: Murthy Bhat
- fix a formatting issue.
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Scott Teel
Reviewed-by: Dave Carroll
Reviewed-by: Kevin Barnett
Signed-off-by: Murthy Bhat
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |7 ++-
1 file changed, 6
ield is left untouched. But in this case,
the kernel changes the result field behind the driver’s back and
then expects the field to be changed by the driver as the
commands that timed-out complete.
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Signed-off-by: Kevin Barnett
Signed-off-by
Reviewed-by: Gerry Morong
Reviewed-by: Dave Carroll
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/scsi/smartpqi/smartpqi_init.c
index 8d94028d0a9d
Reviewed-by: Scott Benesh
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Scott Teel
Reviewed-by: Dave Carroll
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h | 89 +
drivers/scsi/smartpqi/smartpqi_init.c | 131
: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/scsi/smartpqi/smartpqi_init.c
index 2f2a07a38dad..f9812281988c 100644
--- a
Change ownership of the hpsa driver
from Stephen M. Cameron (Hewlett-Packard)
to Don Brace (PMC-Sierra).
Change ownership of the cciss driver
from Mike Miller (Hewlett-Packard)
to Don Brace (PMC-Sierra).
Reviewed-by: Robert Elliott
Signed-off-by: Don Brace
---
MAINTAINERS |8 ++--
1
patches for 3.19 or ack this
now, What would you prefer?
---
Don Brace
don.br...@pmcs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Robert Elliott
RAID-1ADM is unusable with dev_warn called on every command.
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
Reviewed-by: Stephen M. Cameron
Reviewed-by: Webb Scales
---
drivers/scsi/hpsa.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/scsi
Clean up issues reported when running sparse.
Signed-off-by: Don Brace
Reviewed-by: Webb Scales
---
drivers/scsi/hpsa.c | 29 -
drivers/scsi/hpsa.h |6 +++---
2 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi
This patch set is based on Linus's tree.
The changes are:
- correct warnings from sparse
- updates for some error handling issues
- general code cleanup
- performance enhancements based on removing spin_locks
---
Don Brace (1):
hpsa: Clean up warnings from sparse.
Nicholas Bell
he
userland ABI.
Signed-off-by: Don Brace
Reviewed-by: Webb Scales
---
drivers/scsi/hpsa.c | 58 ---
drivers/scsi/hpsa_cmd.h | 18 +++
2 files changed, 42 insertions(+), 34 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/sc
From: Nicholas Bellinger
There isn't anything in hpsa that requires the host lock to be held
during queuecommand.
Signed-off-by: Don Brace
Signed-off-by: Nicholas Bellinger
Reviewed-by: Stephen M. Cameron
---
drivers/scsi/hpsa.c | 16 +++-
1 file changed, 7 insertions(
From: Stephen M. Cameron
The hardware needs little endian scatter gather addresses and
lengths but we were not bothering to convert from cpu byte
order as we should have been. On Intel, this is all just
a bunch of no-ops macros, but it makes the code endian-clean(er).
Signed-off-by: Don Brace
From: Webb Scales
Correct the size calculation of the chained SG block
Signed-off-by: Don Brace
Signed-off-by: Webb Scales
Reviewed-by: Stephen M. Cameron
Reviewed-by: Don Brace
---
drivers/scsi/hpsa.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi
.
Allocate the memory based on the specific data
structure sizes.
Signed-off-by: Don Brace
Reviewed-by: Webb Scales
---
drivers/scsi/hpsa.c | 14 +++---
drivers/scsi/hpsa_cmd.h |2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi
From: Stephen M. Cameron
We were printing a lot of useless information before ultimately
just passing things up to the SCSI mid layer. Just let the
midlayer handle it without LLD chatter.
Signed-off-by: Don Brace
Signed-off-by: Stephen M. Cameron
Reviewed-by: Joe Handzik
Reviewed-by: Scott
pci_request_regions both in the
kdump code and the normal pci_init code.
Remove the comment summarizing what pci_set_master
does, with the incomplete commentary on the impact of
pci_disable_device.
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
Reviewed-by: Don Brace
---
drivers/scsi
From: Stephen M. Cameron
Use atomics for commands_outstanding instead of protecting with spin locks.
Signed-off-by: Don Brace
Signed-off-by: Stephen M. Cameron
Reviewed-by: Joe Handzik
---
drivers/scsi/hpsa.c | 26 +-
drivers/scsi/hpsa.h | 27
From: Stephen M. Cameron
In the case of LUN data changing, the driver will
auto rescan and so it's not even true that "action" is
"required".
Remove "action required" phrases from warning messages and
replace with description phrases.
Signed-off-by: Don Bra
From: Stephen M. Cameron
It is already using atomic test_and_set_bit to do the
allocation.
There is some microscopic chance of starvation, but it is
so microscopic that it should never happen in reality.
Signed-off-by: Don Brace
Reviewed-by: Webb Scales
---
drivers/scsi/hpsa.c | 36
From: Stephen M. Cameron
Fix a couple of pci id table mistakes:
Subdevice ID 0x3323 missing from product[] table
(another name for HP Smart Storage 1210m)
Bogus 0x1925 subdevice id removed from hpsa_pci_device_id[] (no such thing.)
Signed-off-by: Don Brace
Reviewed-by: Webb Scales
oring
- performance enhancements.
- removal of command queueing in driver
- elimination of race conditions around aborts
- change to internal driver workqueues
---
Don Brace (11):
hpsa: correct endian sparse warnings
hpsa: change how SA controllers are reset
hpsa: co
Correct endiness issues reported by sparse. SA controllers are
little endian. This patch ensures endiness correctness.
Signed-off-by: Don Brace
Reviewed-by: Scott Teel
Reviewed-by: Webb Scales
---
drivers/scsi/hpsa.c | 275 +++
drivers/scsi
From: Tomas Henzl
There is a potential memory leak in hpsa_kdump_hard_reset_controller.
Reviewed-by: Don Brace
Reviewed-by: Scott Teel
Signed-off-by: Tomas Henzl
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
ard_reset_controller fixes it.
At this point we can't know in which state the card is,
so using SA5_INTR_OFF + SA5_REPLY_INTR_MASK_OFFSET defines directly,
instead of the function the drivers provides, seems to be apropriate.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
d
Brace
Reviewed-by: Scott Teel
Reviewed-by: Webb Scales
---
drivers/scsi/hpsa.c | 28 ++--
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9edacff..371d0a8 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi
scsi_adjust_queue_depth was changed to scsi_change_queue_depth
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 371d0a8..7dfe829 100644
[]
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 7dfe829..4252b63 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi
[ 10.711623] scsi host1: Error handler scsi_eh_1 exiting
[ 10.739170] hpsa: probe of :02:00.0 failed with error -38
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 19 ++-
1 file changed, 18 insertions(+), 1
From: Robert Elliott
The queue depth printed at startup is in decimal, so
shouldn't have a 0x prefix.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
From: Robert Elliott
Return the real reason for kdump_hard_reset failure rather
than change them all to -ENODEV.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a
: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 92ac76a..85b3d73 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5812,8 +5812,12 @@ static
From: Robert Elliott
There is nothing worrisome about the "Waiting for controller to
respond to no-op" print, so use dev_info rather than dev_warn.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1
From: Webb Scales
Encapsulate the conditional predicate which tests for legacy controllers
in a separate function and rework the code comments.
Reviewed-by: Scott Teel
Signed-off-by: Webb Scales
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 30 +-
1 file
From: Fabian Frederick
Remove unused variable in hpsa_free_cmd_pool.
Reviewed-by: Scott Teel
Signed-off-by: Fabian Frederick
Acked-by: Don Brace
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b
From: Robert Elliott
Change the function names to have hpsa prefix.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 43 ++-
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a
From: Stephen Cameron
Cleanup comments to be more specific. Make messages more
informational.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a
From: Robert Elliott
Make the function name more descriptive. We use more than
one interrupt.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi
From: Robert Elliott
Enhance error reporting.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 5973018..354e7f8
From: Robert Elliott
Return the actual error code instead of a generic error code.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi
From: Robert Elliott
Partial allocation failure wasn't handled correctly
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers
From: Robert Elliott
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 64d17d1..dc328ce 100644
--- a/drivers
would get retried down the RAID path.
However, something needs to turn ioaccellerator mode back on,
and this rescan request was what did that. However, it was racy,
and extremely bad for performance to rescan all devices, so,
don't do that.
Reviewed-by: Scott Teel
Signed-off-by: Don
From: Stephen Cameron
We have commands reserved for internal use.
This is laying the groundwork for removing the internal
queue of commands from the driver so that the locks that
protect that queue may be removed.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c
the driver so that we can remove the locks thta protect the
queue that we will no longer have.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |7 +--
drivers/scsi/hpsa.h |2 ++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c
llerated"
paths but which have some sort of error condition are
retried down the "normal" path.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 126 +++
1 file changed, 67 insertions(+), 59 deletions
accel path, and
prevent excessive rescanning of devices.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 60 ---
drivers/scsi/hpsa_cmd.h |1 +
2 files changed, 42 insertions(+), 19 deletions(-)
diff --git a/dr
, per-controller work queue avoids this.
Reviewed-by: Scott Teel
Signed-off-by: Webb Scales
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 16 +---
drivers/scsi/hpsa.h |1 +
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi
liott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 306 +--
drivers/scsi/hpsa.h | 17 ---
drivers/scsi/hpsa_cmd.h | 10 --
3 files changed, 38 insertions(+), 295 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 26
parity drives.
Reviewed-by: Scott Teel
Signed-off-by: Webb Scales
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 318 +--
drivers/scsi/hpsa.h | 14 ++
drivers/scsi/hpsa_cmd.h | 148 ++
3 files changed, 412 insertions
t pointers would be NULL)
but it is potentially confusing.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index a66a50
From: Stephen Cameron
No need to check whether interrupt pending for MSI(X) and
conversely, no need to check whether MSI(X) interrupts are
being used when checking if interrupts are pending.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.h |3 ---
1 file changed
-off-by: Don Brace
---
drivers/scsi/hpsa.c |7 +--
drivers/scsi/hpsa.h |1 +
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index c95a20c..72abcf3 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -4649,9 +4649,10
at means accel commands could still
be in flight, ie. perhaps having just been submitted into
hpsa_scsi_ioaccel_raid_map concurrent with ->offload_enabled
having just been set to zero.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |4
1 file changed, 4 de
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index 1856445..aa6cb0b 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -412,19 +412,19
Performance enhancement. Remove spin_locks from the driver.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 39 +--
drivers/scsi/hpsa.h |3 +--
2 files changed, 6 insertions(+), 36 deletions(-)
diff --git a/drivers/scsi
mmands to use the reference count as the
authoritative indicator of whether a command is allocated instead of
the h->cmd_pool_bits bitmap.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 109 +++
drivers/scsi/hpsa.h
Returning failed from the device reset handler will get the device
kicked offline, which is fine if the controller is locked up anyhow.
Cannot abort a command from a failed controller.
Reviewed-by: Scott Teel
Reviewed-by: Justin Lindley
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |7
-off-by: Don Brace
---
drivers/scsi/hpsa.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index afd192d..03fae8a 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3921,6 +3921,9 @@ static int hpsa_scsi_ioaccel_raid_map(struct
From: Stephen Cameron
There's no reason for it to be a void *, it should be a struct scsi_cmnd *
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |6 +++---
drivers/scsi/hpsa_cmd.h |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --
From: Stephen Cameron
Printing the address of the command pointer is of little value, change
to print the CDB.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a
From: Stephen Cameron
Command allocation is the thing that takes the longest in the main i/o
path, so check for controller lockup immediately after this to prevent
submitting commands to locked up controller as much as possible.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers
From: Stephen Cameron
Acking controller events on controllers that do not support
it can cause such controllers to lock up.
Reviewed-by: Scott Teel
Signed-off-by: Joe Handzik
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
From: Stephen Cameron
Performance tweak, avoid unnecessary function calls.
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |8 +---
drivers/scsi/hpsa.h |5 +
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers
and all their callers check/propagate the result.
More consistency in printing errors and whether
dev_err is used.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 40 +---
1 file changed, 29
Add in gen9 controller model names
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index c1f4a95..6568da5 100644
--- a/drivers
usleep_range(), which triggers rt_sched timeout errors if the
wait is long.
Reviewed-by: Scott Teel
Signed-off-by: Robert Elliott
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi
operation from inside the
loop. The case for which the conditional formerly tested is now executed
(unconditionally) after the loop is exited.
Reviewed-by: Scott Teel
Signed-off-by: Webb Scales
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 21 ++---
1 file changed, 14
hpsa_scan_start() as well.
Reviewed-by: Scott Teel
Signed-off-by: Webb Scales
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 40
1 file changed, 16 insertions(+), 24 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index
Add in P840ar model name for gen9
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 6568da5..15ef65c 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, June 10, 2016 4:57 AM
> To: Don Brace; j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara;
> h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh;
> elli...@h
Depends on smartpqi driver adoption
Reviewed-by: Kevin Barnett
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/aacraid/linit.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 79871f3..d5b26fa 100644
Answers to Hannes's Review posted in a separate reply
Changes since V1
- Corrected make ARCH=i386 kbuild test robot issue.
Changes since initial upload
- Forgot to give correct ownership to the author.
---
Don Brace (1):
aacraid: remove wildcard for series 9 controllers
K
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Friday, June 17, 2016 4:57 AM
> To: Don Brace
> Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara;
> h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh;
d make ARCH=s390 kbuild test robot issue.
- Answers to Hannes's Review posted in a separate reply
Changes since V1
- Corrected make ARCH=i386 kbuild test robot issue.
Changes since initial upload
- Forgot to give correct ownership to the author.
---
Don Brace (1):
aacraid: remove wildca
Depends on smartpqi driver adoption
Reviewed-by: Kevin Barnett
Reviewed-by: Scott Teel
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/aacraid/linit.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Tuesday, June 28, 2016 2:54 AM
> To: Don Brace
> Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara;
> h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh;
These patches are based on Linus's tree
The changes are:
- enhanced check for skipping masked devices
- corrected hpsa_passthru_ioctl timeouts for fw flash
---
Don Brace (2):
hpsa: correct skipping masked peripherals
hpsa: change hpsa_passthru_ioctl timeout
drivers/scsi/h
Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 79 ---
1 file changed, 74 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index ff8dcd5..375a396 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers
Was not alloting for FW Flash times.
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 375a396..030d002 100644
--- a
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Thursday, August 04, 2016 8:25 PM
> To: Don Brace
> Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara;
> h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Sc
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Monday, August 08, 2016 8:05 PM
> To: Don Brace
> Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh
> Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barne
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Wednesday, August 10, 2016 9:26 PM
> To: Don Brace
> Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh
> Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barne
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Friday, August 12, 2016 3:10 PM
> To: Don Brace
> Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh
> Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barne
From: Kevin Barnett
Reviewed-by: Scott Teel
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h | 13 +---
drivers/scsi/smartpqi/smartpqi_init.c | 35 +
drivers/scsi/smartpqi
From: Kevin Barnett
minor cleanup of scsi queue command function
Reviewed-by: Scott Teel
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a
From: Kevin Barnett
reformatted pqi_num_elements_free() to match the rest of the driver
Reviewed-by: Scott Teel
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |3 +--
1 file changed, 1 insertion(+), 2 deletions
From: Kevin Barnett
Eliminated timeout from LUN reset logic.
Reviewed-by: Scott Teel
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h |2 -
drivers/scsi/smartpqi/smartpqi_init.c | 101
601 - 700 of 939 matches
Mail list logo