[PATCH v2 08/48] hpsa: Fix -Wunused-but-set-variable warning

From: Fabian Frederick Remove unused variable in hpsa_free_cmd_pool. Reviewed-by: Scott Teel Signed-off-by: Fabian Frederick Acked-by: Don Brace Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH v2 02/48] hpsa: fix memory leak in kdump hard reset

From: Tomas Henzl There is a potential memory leak in hpsa_kdump_hard_reset_controller. Reviewed-by: Don Brace Reviewed-by: Scott Teel Signed-off-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 12/48] hpsa: propagate return value from board ID lookup

: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 92ac76a..85b3d73 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -5812,8 +5812,12 @@ static

[PATCH v2 09/48] hpsa: notice all request_irq errors

[ 10.711623] scsi host1: Error handler scsi_eh_1 exiting [ 10.739170] hpsa: probe of :02:00.0 failed with error -38 Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 ++- 1 file changed, 18 insertions(+), 1

[PATCH v2 07/48] hpsa: rename free_irqs to hpsa_free_irqs

From: Robert Elliott Change the function names to have hpsa prefix. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 43 ++- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a

[PATCH v2 03/48] hpsa: turn off interrupts when kdump starts

ard_reset_controller fixes it. At this point we can't know in which state the card is, so using SA5_INTR_OFF + SA5_REPLY_INTR_MASK_OFFSET defines directly, instead of the function the drivers provides, seems to be apropriate. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- d

[PATCH v2 04/48] hpsa: change how SA controllers are reset

Brace Reviewed-by: Scott Teel Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9edacff..371d0a8 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH v2 19/48] hpsa: report allocation failures while allocating SG chain blocks

From: Robert Elliott Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 64d17d1..dc328ce 100644 --- a/drivers

[PATCH v2 22/48] hpsa: reserve some commands for use by driver

the driver so that we can remove the locks thta protect the queue that we will no longer have. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |7 +-- drivers/scsi/hpsa.h |2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c

[PATCH v2 14/48] hpsa: refactor hpsa_find_board_params() to encapsulate legacy test

From: Webb Scales Encapsulate the conditional predicate which tests for legacy controllers in a separate function and rework the code comments. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 30 +- 1 file

[PATCH v2 17/48] hpsa: rename hpsa_request_irq to hpsa_request_irqs

From: Robert Elliott Make the function name more descriptive. We use more than one interrupt. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/scsi

[PATCH v2 20/48] hpsa: fix memory leak in hpsa_alloc_cmd_pool

From: Robert Elliott Partial allocation failure wasn't handled correctly Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH v2 15/48] hpsa: trivial message and comment clean ups

From: Stephen Cameron Cleanup comments to be more specific. Make messages more informational. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a

[PATCH v2 18/48] hpsa: pass error from pci_set_consistent_dma_mask from hpsa_message

From: Robert Elliott Return the actual error code instead of a generic error code. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH v2 16/48] hpsa: report failure to ioremap config table

From: Robert Elliott Enhance error reporting. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5973018..354e7f8

[PATCH v2 25/48] hpsa: do not request device rescan on every ioaccel path error

would get retried down the RAID path. However, something needs to turn ioaccellerator mode back on, and this rescan request was what did that. However, it was racy, and extremely bad for performance to rescan all devices, so, don't do that. Reviewed-by: Scott Teel Signed-off-by: Don

[PATCH v2 24/48] hpsa: do not queue commands internally in driver

liott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 306 +-- drivers/scsi/hpsa.h | 17 --- drivers/scsi/hpsa_cmd.h | 10 -- 3 files changed, 38 insertions(+), 295 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 26

[PATCH v2 23/48] hpsa: get rid of cmd_special_alloc and cmd_special_free

From: Stephen Cameron We have commands reserved for internal use. This is laying the groundwork for removing the internal queue of commands from the driver so that the locks that protect that queue may be removed. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

[PATCH v2 21/48] hpsa: avoid unneccesary calls to resource freeing functions

t pointers would be NULL) but it is potentially confusing. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a66a50

[PATCH v2 30/48] hpsa: optimize cmd_alloc function by remembering last allocation

-off-by: Don Brace --- drivers/scsi/hpsa.c |7 +-- drivers/scsi/hpsa.h |1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c95a20c..72abcf3 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -4649,9 +4649,10

[PATCH v2 26/48] hpsa: factor out hpsa_ciss_submit function

llerated" paths but which have some sort of error condition are retried down the "normal" path. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 126 +++ 1 file changed, 67 insertions(+), 59 deletions

[PATCH v2 29/48] hpsa: fix race between abort handler and main i/o path

mmands to use the reference count as the authoritative indicator of whether a command is allocated instead of the h->cmd_pool_bits bitmap. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 109 +++ drivers/scsi/hpsa.h

[PATCH v2 31/48] hpsa: count passthru cmds with atomics, not a spin locked int

Performance enhancement. Remove spin_locks from the driver. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 39 +-- drivers/scsi/hpsa.h |3 +-- 2 files changed, 6 insertions(+), 36 deletions(-) diff --git a/drivers/scsi

[PATCH v2 33/48] hpsa: do not check for msi(x) in interrupt_pending

From: Stephen Cameron No need to check whether interrupt pending for MSI(X) and conversely, no need to check whether MSI(X) interrupts are being used when checking if interrupts are pending. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.h |3 --- 1 file changed

[PATCH v2 28/48] hpsa: honor queue depth of physical devices

parity drives. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 318 +-- drivers/scsi/hpsa.h | 14 ++ drivers/scsi/hpsa_cmd.h | 148 ++ 3 files changed, 412 insertions

[PATCH v2 32/48] hpsa: slightly optimize SA5_performant_completed

Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index 1856445..aa6cb0b 100644 --- a/drivers/scsi/hpsa.h +++ b/drivers/scsi/hpsa.h @@ -412,19 +412,19

[PATCH v2 27/48] hpsa: use workqueue to resubmit failed ioaccel commands

accel path, and prevent excessive rescanning of devices. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 72 ++- drivers/scsi/hpsa.h |1 + drivers/scsi/hpsa_cmd.h |1 + 3 files changed, 54 insertions(+), 20

[PATCH v2 35/48] hpsa: do not ack controller events on controllers that do not support it

From: Stephen Cameron Acking controller events on controllers that do not support it can cause such controllers to lock up. Reviewed-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH v2 34/48] hpsa: remove incorrect BUG_ONs checking for raid offload enable

at means accel commands could still be in flight, ie. perhaps having just been submitted into hpsa_scsi_ioaccel_raid_map concurrent with ->offload_enabled having just been set to zero. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 1 file changed, 4 de

[PATCH v2 36/48] hpsa: guard against overflowing raid map array

-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index afd192d..03fae8a 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -3921,6 +3921,9 @@ static int hpsa_scsi_ioaccel_raid_map(struct

[PATCH v2 37/48] hpsa: check for ctlr lockup after command allocation in main io path

From: Stephen Cameron Command allocation is the thing that takes the longest in the main i/o path, so check for controller lockup immediately after this to prevent submitting commands to locked up controller as much as possible. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers

[PATCH v2 40/48] hpsa: print CDBs instead of kernel virtual addresses for uncommon errors

From: Stephen Cameron Printing the address of the command pointer is of little value, change to print the CDB. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a

[PATCH v2 42/48] hpsa: move SG descriptor set-up out of hpsa_scatter_gather()

operation from inside the loop. The case for which the conditional formerly tested is now executed (unconditionally) after the loop is exited. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 21 ++--- 1 file changed, 14

[PATCH v2 44/48] hpsa: shorten the wait for the CISS doorbell mode change ack

usleep_range(), which triggers rt_sched timeout errors if the wait is long. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH v2 43/48] hpsa: refactor duplicated scan completion code into a new routine

hpsa_scan_start() as well. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH v2 45/48] hpsa: detect and report failures changing controller transport modes

and all their callers check/propagate the result. More consistency in printing errors and whether dev_err is used. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 40 +--- 1 file changed, 29

[PATCH v2 41/48] hpsa: do not use function pointers in fast path command submission

From: Stephen Cameron Performance tweak, avoid unnecessary function calls. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |8 +--- drivers/scsi/hpsa.h |5 + 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH v2 47/48] hpsa: add in P840ar controller model name

Add in P840ar model name for gen9 Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6568da5..15ef65c 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH v2 46/48] hpsa: add in gen9 controller model names

Add in gen9 controller model names Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c1f4a95..6568da5 100644 --- a/drivers

[PATCH v2 39/48] hpsa: do not use a void pointer for scsi_cmd field of struct CommandList

From: Stephen Cameron There's no reason for it to be a void *, it should be a struct scsi_cmnd * Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +++--- drivers/scsi/hpsa_cmd.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --

[PATCH v2 38/48] hpsa: return failed from device reset/abort handlers

Returning failed from the device reset handler will get the device kicked offline, which is fine if the controller is locked up anyhow. Cannot abort a command from a failed controller. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |7

[PATCH v2 48/48] hpsa: Use local workqueues instead of system workqueues

Suggested-by: Tomas Henzl Reviewed-by: Webb Scales Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 68 +-- drivers/scsi/hpsa.h |2 ++ 2 files changed, 56 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH] hpsa: correct compiler warnings introduced by hpsa-add-local-workqueue patch

Correct compiler warning introduced by hpsa-add-local-workqueue patch 6636e7f455b33b957c5ee016daa6de46148026ab hpsa: Use local workqueues instead of system workqueues Suggested-by: Kees Cook Reviewed-by: Scott Teel Reviewed-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

Re: [hpsa] regression, does not recognise tape robot changer

ned-off-by: Scott Teel Signed-off-by: Mike Miller Signed-off-by: Don Brace Signed-off-by: Joe Handzik Signed-off-by: James Bottomley :04 04 2883c53c791ca8add0c8fd743027bb3c65a293b7 224b5b082268720c62f0da340017111fe6b03eb2 M drivers it there any more information I

[PATCH 00/43] hpsa updates

pport - clean up resets --- Don Brace (2): hpsa: cleanup initialization code. hpsa: change driver version Joe Handzik (3): hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode. hpsa: Get queue depth from identify physical bmic for physical disks. hpsa

[PATCH 07/43] hpsa: allow lockup detected to be viewed via sysfs

From: Stephen Cameron expose a detected lockup via sysfs Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index bae8df8

[PATCH 03/43] hpsa: rework controller command submission

t_controller_lockup() to return the result, to remove the need for a separate check. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 326 --- drivers/scsi/hpsa_c

[PATCH 08/43] hpsa: make function names consistent

From: Robert Elliott make function names more consistent and meaningful Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a

[PATCH 06/43] hpsa: hpsa decode sense data for io and tmf

r example. The "ScsiStatus" field of the errinfo field will contain the TMF function status value. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 150 --- drivers/scsi/hpsa_cmd.h |9

[PATCH 01/43] hpsa: add masked physical devices into h->dev[] array

ical disk in hpsa_get_pdisk_of_ioaccel2(), just get it out of h->dev[] where we already have it cached. do not touch phys_disk[] for ioaccel enabled logical drives during rescan Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hp

[PATCH 02/43] hpsa: clean up host, channel, target, lun prints

Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 94 --- 1 file changed, 67 insertions(+), 27 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5f12f32..9a82ede 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 05/43] hpsa: decrement h->commands_outstanding in fail_all_outstanding_cmds

From: Stephen Cameron make tracking of outstanding commands more robust Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 12/43] hpsa: factor out hpsa_ioaccel_submit function

From: Webb Scales clean up command submission Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 91 +-- 1 file changed, 66 insertions(+), 25 deletions(-) diff

[PATCH 04/43] hpsa: clean up aborts

commands. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 176 +-- drivers/scsi/hpsa.h |4 + 2 files changed, 147 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 10/43] hpsa: do not ignore return value of hpsa_register_scsi

From: Stephen Cameron add error handling for failure when registering with SCSI subsystem. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 09/43] hpsa: factor out hpsa_init_cmd function

submitting down the RAID stack path after ioaccel command completion. This saves time when submitting commands. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 77 --- drivers/scsi/hpsa_cmd.h

[PATCH 11/43] hpsa: try resubmitting down raid path on task set full

From: Stephen Cameron allow the controller firmware to queue up commands when the ioaccel device queue is full. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

[PATCH 13/43] hpsa: print accurate SSD Smart Path Enabled status

: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index accfede..e151662 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -1065,7 +1065,7 @@ lun_assigned

[PATCH 14/43] hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode.

From: Joe Handzik use ioaccel2 path to submit I/O to physical drives in HBA mode Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +- drivers/scsi/hpsa.h |1 + 2 files changed, 10 insertions

[PATCH 23/43] hpsa: clean up driver init

hpsa_free_performant_mode Prevent inadvertent use of null pointers by nulling out the parent structures and zeroing out associated size variables. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 244

[PATCH 15/43] hpsa: Get queue depth from identify physical bmic for physical disks.

From: Joe Handzik get drive queue depth to help avoid task set full conditions. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 31 --- 1 file changed, 12 insertions(+), 19

[PATCH 25/43] hpsa: do not print ioaccel2 warning messages about unusual completions.

Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 4641cc8..bbbc309 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -1922,9 +1922,6

[PATCH 28/43] hpsa: don't return abort request until target is complete

he abort handler check that the scsi_cmd pointer in the CommadList struct matches the scsi_cmnd that it has been asked to abort. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

[PATCH 16/43] hpsa: break hpsa_free_irqs_and_disable_msix into two functions

From: Robert Elliott replace calls to hpsa_free_irqs_and_disable_msix with hpsa_free_irqs and hpsa_disable_interrupt_mode Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 37

[PATCH 18/43] hpsa: refactor freeing of resources into more logical functions

From: Robert Elliott refactor freeing of resources into more logical functions Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 104 +++ 1 file changed, 56

[PATCH 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path

, which does not call another hpsa_allocate function and only has -ENOMEM to return from some kmalloc calls. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 125

[PATCH 27/43] hpsa: use helper routines for finishing commands

From: Webb Scales cleanup command completions Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 78 --- 1 file changed, 31 insertions(+), 47 deletions(-) diff

[PATCH 24/43] hpsa: clean up some error reporting output in abort handler

From: Robert Elliott report more useful information on aborts Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git

[PATCH 17/43] hpsa: clean up error handling

From: Robert Elliott refactor error cleanup and shutdown disable interrupts and pci_disable_device on critical failures add hpsa_free_cfgtables function Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 92

[PATCH 22/43] hpsa: correct return values from driver functions.

From: Robert Elliott correct return codes for error conditions Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi

[PATCH 21/43] hpsa: do not check cmd_alloc return value - it cannnot return NULL

From: Robert Elliott cmd_alloc can no longer return NULL, so don't check for NULL any more (which is unreachable code). Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |

[PATCH 20/43] hpsa: add more ioaccel2 error handling, including underrun statuses.

From: Joe Handzik improve ioaccel2 error handling, including better handling of underrun statuses Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 33 - drivers/scsi

[PATCH 38/43] hpsa: clean up new block layer tag error handling

From: Robert Elliott clean up new block layer tag error handling Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 33/43] hpsa: cleanup for init_one step 2 in kdump

off-by: Don Brace --- drivers/scsi/hpsa.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 35fdf1f..3071089 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -7438,6 +7438,16 @@ stati

[PATCH 40/43] hpsa: cleanup initialization code.

- remove goto clean_X labels - avoid duplication of cleanup code Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 188 +++ drivers/scsi/hpsa.h |1 2 files changed, 70 insertions(+), 119

[PATCH 41/43] hpsa: propagate the error code in hpsa_kdump_soft_reset

From: Robert Elliott If hpsa_wait_for_board_state fails, hpsa_kdump_soft_reset should propagate its return value (e.g., -ENODEV) rather than just returning -1. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

[PATCH 35/43] hpsa: create workqueue after the driver is ready for use

right order in hpsa_undo_allocations_after_kdump_soft_reset too. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 60 ++- 1 file changed, 31 insertions(+), 29 dele

[PATCH 43/43] hpsa: change driver version

update driver version Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 3531ed8..0b78963 100644 --- a/drivers/scsi/hpsa.c

[PATCH 26/43] hpsa: add support sending aborts to physical devices via the ioaccel2 path

From: Stephen Cameron add support for tmf when in ioaccel2 mode Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 136 +-- drivers/scsi/hpsa.h |1

[PATCH 39/43] hpsa: use scsi host_no as hpsa controller number

Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 137 --- 1 file changed, 75 insertions(+), 62 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c491bed..ffdfa55 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH 30/43] hpsa: performance tweak for hpsa_scatter_gather()

iteration inside the loop. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH 32/43] hpsa: skip free_irq calls if irqs are not allocated

: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index b66a7cd..35fdf1f 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 31/43] hpsa: call pci_release_regions after pci_disable_device

er to print anything. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace < don.br...@pmcs.com> --- drivers/scsi/hpsa.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/hpsa.c b/dr

[PATCH 42/43] hpsa: cleanup reset

both types of waits. Also, don't complete commands which are terminated due to a reset operation. fix for controller lockup during reset Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

[PATCH 34/43] hpsa: fix try_soft_reset error handling

From: Robert Elliott If registering the special interrupt handlers in hpsa_init_one before a soft reset fails, the error exit needs to deallocate everything that was allocated before. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace

[PATCH 29/43] hpsa: refactor and rework support for sending TEST_UNIT_READY

-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 117 ++- 1 file changed, 87 insertions(+), 30 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6676517..ae3789b 100644 --- a/drivers/scsi/hpsa.c +++ b

[PATCH 37/43] hpsa: use block layer tag for command allocation

attached. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 166 +++ drivers/scsi/hpsa.h |1 2 files changed, 141 insertions(+), 26 deletions(-) diff --git a/drivers

[PATCH 36/43] hpsa: add interrupt number to /proc/interrupts interrupt name

PCI bus went from 32 to 64 bits wide. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 20 ++-- drivers/scsi/hpsa.h |1 + 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a

[PATCH v2 03/41] hpsa: rework controller command submission

t_controller_lockup() to return the result, to remove the need for a separate check. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 326 --- drivers/scsi/hpsa_c

[PATCH v2 05/41] hpsa: decrement h->commands_outstanding in fail_all_outstanding_cmds

From: Stephen Cameron make tracking of outstanding commands more robust Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH v2 02/41] hpsa: clean up host, channel, target, lun prints

Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 103 +++ 1 file changed, 71 insertions(+), 32 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c95e1af..52711fd 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH v2 06/41] hpsa: hpsa decode sense data for io and tmf

r example. The "ScsiStatus" field of the errinfo field will contain the TMF function status value. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 143 +++ drivers/scsi/hpsa_cmd.h |9

[PATCH v2 01/41] hpsa: add masked physical devices into h->dev[] array

ical disk in hpsa_get_pdisk_of_ioaccel2(), just get it out of h->dev[] where we already have it cached. do not touch phys_disk[] for ioaccel enabled logical drives during rescan Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hp

[PATCH v2 00/41] hpsa updates

pport - clean up resets --- Don Brace (1): hpsa: change driver version Joe Handzik (3): hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode. hpsa: Get queue depth from identify physical bmic for physical disks. hpsa: add more ioaccel2 error handling, incl

[PATCH v2 08/41] hpsa: make function names consistent

From: Robert Elliott make function names more consistent and meaningful Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a

[PATCH v2 10/41] hpsa: do not ignore return value of hpsa_register_scsi

From: Stephen Cameron add error handling for failure when registering with SCSI subsystem. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH v2 07/41] hpsa: allow lockup detected to be viewed via sysfs

From: Stephen Cameron expose a detected lockup via sysfs Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5e18ee5

[PATCH v2 04/41] hpsa: clean up aborts

commands. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 176 +-- drivers/scsi/hpsa.h |4 + 2 files changed, 147 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH v2 09/41] hpsa: factor out hpsa_init_cmd function

submitting down the RAID stack path after ioaccel command completion. This saves time when submitting commands. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 77 --- drivers/scsi/hpsa_cmd.h

[PATCH v2 12/41] hpsa: factor out hpsa_ioaccel_submit function

From: Webb Scales clean up command submission Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 91 +-- 1 file changed, 66 insertions(+), 25 deletions(-) diff

<    1   2   3   4   5   6   7   8   9   10   >