Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-09 Thread Tom Gundersen
On Tue, Sep 9, 2014 at 3:26 AM, Luis R. Rodriguez wrote: > On Mon, Sep 8, 2014 at 6:22 PM, Tejun Heo wrote: >> On Tue, Sep 09, 2014 at 10:10:59AM +0900, Tejun Heo wrote: >>> I'm not too convinced this is such a difficult problem to figure out. >>> We already have most of logic in place and the on

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-09 Thread Tom Gundersen
On Tue, Sep 9, 2014 at 10:45 PM, Luis R. Rodriguez wrote: > On Tue, Sep 9, 2014 at 12:35 PM, James Bottomley > wrote: >> On Tue, 2014-09-09 at 12:16 -0700, Luis R. Rodriguez wrote: >>> On Mon, Sep 8, 2014 at 10:38 PM, James Bottomley >>> wrote: >>> > If we want to sort out some sync/async mechan

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Tom Gundersen
On Wed, Sep 10, 2014 at 11:10 PM, Luis R. Rodriguez wrote: >>> More than two years >>> have gone by on growing design and assumptions on top of that original >>> commit. I'm not sure if *systemd folks* yet believe its was a design >>> regression? >> >> I don't think so. udev should not allow its w

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Tom Gundersen
On Fri, Sep 12, 2014 at 12:26 AM, Luis R. Rodriguez wrote: > On Thu, Sep 11, 2014 at 2:43 PM, Tom Gundersen wrote: >> How about simply introducing a new flag to finit_module() to indicate >> that the caller does not care about asynchronicity. We could then pass >> this fr

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-28 Thread Tom Gundersen
Hi Luis, Thanks for the patches and the detailed analysis. Feel free to add Acked-by: Tom Gundersen Minor comments on the commit message below. On Fri, Sep 26, 2014 at 11:57 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Some init systems may wish to ex

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-30 Thread Tom Gundersen
On Tue, Sep 30, 2014 at 4:27 AM, Luis R. Rodriguez wrote: > On Sun, Sep 28, 2014 at 07:07:24PM +0200, Tom Gundersen wrote: >> On Fri, Sep 26, 2014 at 11:57 PM, Luis R. Rodriguez >> wrote: >> > From: "Luis R. Rodriguez" >> > Systemd has a general t

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-10-01 Thread Tom Gundersen
On Tue, Sep 30, 2014 at 5:24 PM, Luis R. Rodriguez wrote: >> > commit e64fae5573e566ce4fd9b23c68ac8f3096603314 >> > Author: Kay Sievers >> > Date: Wed Jan 18 05:06:18 2012 +0100 >> > >> > udevd: kill hanging event processes after 30 seconds >> > >> > Some broken kernel drivers load firm

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-10-03 Thread Tom Gundersen
On Thu, Oct 2, 2014 at 10:06 PM, Luis R. Rodriguez wrote: > On Thu, Oct 02, 2014 at 08:12:37AM +0200, Tom Gundersen wrote: >> Making kmod a special case is of course possible. However, as long as >> there is no fundamental reason why kmod should get this special >> treatment,

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-10-10 Thread Tom Gundersen
On Fri, Oct 10, 2014 at 11:54 PM, Anatol Pomozov wrote: > 1) Why not to make the timeout configurable through config file? There > is already udev.conf you can put config option there. Thus people with > modprobe issues can easily "fix" the problem. And then decrease > default timeout back to 30 s