Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-26 Thread Theodore Y. Ts'o
On Fri, Oct 26, 2018 at 03:07:39PM -0700, Nick Desaulniers wrote: > > That's not completely correct. The standard approach to check whether or not > > a driver is still being used is to check its git history. If the number of > > contributors is low and it was several years ago that a new feature w

Re: [PATCH 0/3] SG_IO command filtering via sysfs

2018-11-10 Thread Theodore Y. Ts'o
I wonder if a better way of adding SG_IO command filtering is via eBPF? We are currently carrying a inside Google a patch which allows a specific of SCSI commands to non-root processes --- if the process belonged to a particular Unix group id. It's pretty specific to our use case, in terms of the

Re: [PATCH 0/3] SG_IO command filtering via sysfs

2018-11-11 Thread Theodore Y. Ts'o
On Sun, Nov 11, 2018 at 05:14:45AM -0800, Christoph Hellwig wrote: > I think this goes in the wrong way. There isn't really any point > in filtering at all if we have access to the whole device by the > file persmissions, and we generally should not allow any access for > partitions. It really de

Re: [PATCH 0/3] SG_IO command filtering via sysfs

2018-11-11 Thread Theodore Y. Ts'o
On Sun, Nov 11, 2018 at 02:26:45PM +0100, Paolo Bonzini wrote: > > I'm not very eBPF savvy, the question I have is: what kind of > information about the running process is available in an eBPF program? > For example, even considering only the examples you make, would it be > able to access the CDB

Re: [PATCH 0/3] SG_IO command filtering via sysfs

2018-11-16 Thread Theodore Y. Ts'o
On Fri, Nov 16, 2018 at 08:01:29AM +0100, Paolo Bonzini wrote: > On 16/11/18 01:37, Bart Van Assche wrote: > > All user space interfaces in the Linux kernel for storage that I'm familiar > > with not only allow configuration of parameters but also make it easy to > > query which parameters have bee

Re: [PATCH 0/3] SG_IO command filtering via sysfs

2018-11-16 Thread Theodore Y. Ts'o
On Fri, Nov 16, 2018 at 10:45:11AM +0100, Paolo Bonzini wrote: > On 16/11/18 10:32, Christoph Hellwig wrote: > > On Mon, Nov 12, 2018 at 11:17:29AM +0100, Paolo Bonzini wrote: > >>> Well, that's what we have the security_file_ioctl() LSM hook for so that > >>> your security model can arbitrate acce

Re: [PATCH V2] SCSI: fix queue cleanup race before queue initialization is done

2018-11-21 Thread Theodore Y. Ts'o
On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote: > > Thanks applied, this bug was elusive but ever present in recent > > testing that we did internally, it's been a huge pain in the butt. > > The symptoms were usually a crash in blk_mq_get_driver_tag() with > > hctx->tags == NULL, or a c

Re: [PATCH V2] SCSI: fix queue cleanup race before queue initialization is done

2018-11-21 Thread Theodore Y. Ts'o
On Wed, Nov 21, 2018 at 05:02:13PM -0500, Theodore Y. Ts'o wrote: > On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote: > > > Thanks applied, this bug was elusive but ever present in recent > > > testing that we did internally, it's been a huge pain in th