On 9/9/2013 5:03 PM, Seungwon Jeon wrote:
> Hi Sujit,
>
> On Tue, August 27, 2013, Sujit Reddy Thumma wrote:
>> Some vendor specific controller versions might need to configure
>> vendor specific - registers, clocks, voltage regulators etc. to
>> initialize the host c
resource_size(mem_res);
+ release_mem_region(mem_res->start, mem_size);
+ }
+ platform_set_drvdata(pdev, NULL);
+ return 0;
+}
+
+static const struct of_device_id ufs_of_match[] = {
+ { .compatible = "jedec,ufs-1.1"},
+};
+
+static struct platform_dri
On 1/9/2013 5:41 PM, vinayak holikatti wrote:
On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma
wrote:
Hi Vinayak,
I have few comments below:
+#ifdef CONFIG_PM
+/**
+ * ufshcd_pltfrm_suspend - suspend power management function
+ * @pdev: pointer to Platform device handle
+ * @mesg: power
at a time.
Further, the command completion for DME_LINKSTARTUP is modified
and the command completes in the context of the caller instead
of a separate work.
Signed-off-by: Sujit Reddy Thumma
---
drivers/scsi/ufs/ufshcd.c | 257 +
drivers/scs
device connection path and test whether the UTP layer on the
device side is functional during initialization.
Signed-off-by: Sujit Reddy Thumma
---
drivers/scsi/ufs/ufshcd.c | 167 ++---
drivers/scsi/ufs/ufshcd.h |4 +
2 files changed, 162 insertions
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
Simplify operations with hiding mmio_base.
Signed-off-by: Seungwon Jeon
---
drivers/scsi/ufs/ufshcd.c | 106 +++--
drivers/scsi/ufs/ufshcd.h |5 ++
2 files changed, 49 insertions(+), 62 deletions(-)
dif
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
Link start-up requires long time with multiphase handshakes
between UFS host and device. This affects driver's probe time.
This patch let link start-up run asynchronously.
And completion time of uic command is defined to avoid a
permanent wait.
I have
On 4/26/2013 10:44 AM, Seungwon Jeon wrote:
On Thursday, April 25, 2013 , Sujit Reddy Thumma wrote:
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
Link start-up requires long time with multiphase handshakes
between UFS host and device. This affects driver's probe time.
This patch let link sta
On 4/29/2013 3:54 PM, Seungwon Jeon wrote:
On Monday, April 29, 2013, Sujit Reddy Thumma wrote:
On 4/26/2013 10:44 AM, Seungwon Jeon wrote:
On Thursday, April 25, 2013 , Sujit Reddy Thumma wrote:
On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
Link start-up requires long time with multiphase
On 4/30/2013 12:03 PM, Seungwon Jeon wrote:
On Monday, April 29, 2013, Sujit Reddy Thumma wrote:
On 4/29/2013 3:54 PM, Seungwon Jeon wrote:
On Monday, April 29, 2013, Sujit Reddy Thumma wrote:
On 4/26/2013 10:44 AM, Seungwon Jeon wrote:
On Thursday, April 25, 2013 , Sujit Reddy Thumma wrote
On 5/2/2013 12:57 PM, Santosh Y wrote:
+
+/**
+ * ufshcd_validate_dev_connection() - Check device connection status
+ * @hba: per-adapter instance
+ *
+ * Send NOP OUT UPIU and wait for NOP IN response to check whether the
+ * device Transport Protocol (UTP) layer is ready after a reset.
+ * If t
On 5/2/2013 12:49 PM, Santosh Y wrote:
-static inline void
-ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd)
+static int ufshcd_send_uic_command(struct ufs_hba *hba,
+ struct uic_command *uic_cmnd, int retries)
{
+ int err = 0;
+ unsigned long
specific power management
Signed-off-by: Sujit Reddy Thumma
---
The patch is not complete and does not handle some of the points
mentioned above. This is just for review on design part.
---
drivers/scsi/ufs/Makefile |2 +-
drivers/scsi/ufs/ufs.c| 341
On 5/4/2013 2:15 PM, Seungwon Jeon wrote:
Implements to support the following operations.
Currently, this patch doesn't introduce DME_ENABLE and DME_RESET
because host controller's HCE enable contains these roles.
DME_POWERON{OFF}, DME_HIBERNATE_ENTER{EXIT}, DME_ENDPOINTRESET.
Signed-off-by: Se
device connection path and test whether the UTP layer on the
device side is functional during initialization.
Signed-off-by: Sujit Reddy Thumma
---
v2:
- fixed INTERNAL_CMD_TAG check in readl_poll_timeout
- minor cleanup from v1
- rebased on Seungwon Jeon's UFS V3 patchset
---
dr
> Added mutex to guarantee of uic command at a time.
> Adapted some sequence of controller initialization after link statup
> according to HCI standard.
>
> Signed-off-by: Seungwon Jeon
> Signed-off-by: Sujit Reddy Thumma
> ---
> drivers/scsi/ufs/ufshcd.c | 287
>
device connection path and test whether the UTP layer on the
device side is functional during initialization.
Signed-off-by: Sujit Reddy Thumma
---
v3:
- minor bug fix in error path
v2:
- fixed INTERNAL_CMD_TAG check in readl_poll_timeout
- minor cleanup from v1
- rebased on Seungwon
device initialization completion.
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
---
drivers/scsi/ufs/ufs.h| 10 -
drivers/scsi/ufs/ufshcd.c | 102 +
drivers/scsi/ufs/ufshcd.h |7 +++
3 files changed, 118 insertions(+), 1
On 5/7/2013 2:57 PM, Seungwon Jeon wrote:
> On Monday, May 06, 2013, Sujit Reddy Thumma wrote:
>> As part of device initialization sequence, sending NOP OUT UPIU and
>> waiting for NOP IN UPIU response is mandatory. This confirms that the
>> device UFS Transport (UTP) layer
device connection path and test whether the UTP layer on the
device side is functional during initialization.
Signed-off-by: Sujit Reddy Thumma
---
v4:
- Removed readl_poll_timeout and replaced with wait logic
- additional checks for completion
v3:
- minor bug fix in error path
v2
device connection path and test whether the UTP layer on the
device side is functional during initialization.
Signed-off-by: Sujit Reddy Thumma
Acked-by: Santosh Y
---
v5:
- rebase on top of Seungwon Jeon's UFS V4 patchset
v4:
- Removed readl_poll_timeout and replaced with wait
Compatible list is used in commit 03b1781 but is not documented.
Add necessary device tree bindings to describe on-chip UFS host
controllers.
Signed-off-by: Sujit Reddy Thumma
---
.../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 16
1 files changed, 16 insertions(+), 0
The response UPIU length should be in DWORD and not in bytes.
Signed-off-by: Maya Erez
Signed-off-by: Sujit Reddy Thumma
---
drivers/scsi/ufs/ufshcd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index f244812
On 1/6/2014 7:44 AM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 12/16/2013 06:30 PM, Phillip Susi wrote:
For some reason, the system hangs on resume if I issue the REQUEST
SENSE command after blk_pre_runtime_suspend. My understanding is
that the REQ_PM flag should m
Make undeclared functions static and declare exported symbols
to suppress warnings from sparse tool.
Signed-off-by: Sujit Reddy Thumma
Acked-by: Vinayak Holikatti
---
drivers/scsi/ufs/ufshcd.c | 4 ++--
drivers/scsi/ufs/ufshcd.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff
TIBLE
set.
Signed-off-by: Sujit Reddy Thumma
Reviewed-by: Yaniv Gardi
Tested-by: Dolev Raviv
Acked-by: Vinayak Holikatti
---
drivers/scsi/ufs/ufshcd.c | 169 +++---
drivers/scsi/ufs/ufshcd.h | 8 ++-
2 files changed, 122 insertions(+), 55 dele
separate error handling work.
o SCSI is informed about the expected Unit-Attention exception from the
device for the immediate command after a reset so that the SCSI layer
take necessary steps to establish communication with the device.
Signed-off-by: Sujit Reddy Thumma
Reviewed-by: Yaniv
-existent in both controller and the device.
Signed-off-by: Sujit Reddy Thumma
Reviewed-by: Yaniv Gardi
Tested-by: Dolev Raviv
Acked-by: Vinayak Holikatti
---
drivers/scsi/ufs/ufshcd.c | 70 +--
1 file changed, 55 insertions(+), 15 deletions(-)
diff
tting the
device and host and re-initializing them in proper manner.
Signed-off-by: Sujit Reddy Thumma
Reviewed-by: Yaniv Gardi
Tested-by: Dolev Raviv
Acked-by: Vinayak Holikatti
---
drivers/scsi/ufs/ufshcd.c | 240 --
drivers/scsi/ufs/ufshcd.h | 2
or cleanup and rebase
- [PATCH V2 4/4]: Fix a bug - sleeping in atomic context
Sujit Reddy Thumma (6):
scsi: ufs: fix endianness sparse warnings
scsi: ufs: make undeclared functions static
scsi: ufs: Fix broken task management command implementation
scsi: ufs: Fix hardware race condit
Fix many warnings with incorrect endian assumptions
which makes the code unportable to new architectures.
The UFS specification defines the byte order as big-endian
for UPIU structure and little-endian for the host controller
transfer/task management descriptors.
Signed-off-by: Sujit Reddy
On 11/18/2013 2:34 PM, vinayak holikatti wrote:
On Mon, Sep 23, 2013 at 5:44 PM, vinayak holikatti
wrote:
On Thu, Sep 19, 2013 at 4:44 PM, Sujit Reddy Thumma
wrote:
Fix many warnings with incorrect endian assumptions
which makes the code unportable to new architectures.
The UFS
On 5/28/2014 4:24 PM, Christoph Hellwig wrote:
I've pushed the following changes to the drivers-for-3.16 tree. I've
there's anyting matching the rules that I did forget please resend
and/or ping me.
Benoit Taine (2):
qla4x
101 - 133 of 133 matches
Mail list logo
