[PATCH 06/35] hpsa: add ioaccell mode 1 RAID offload support.

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron This enables sending i/o's destined for RAID logical drives which can be serviced by a single physical disk down a different, faster i/o path directly to physical drives for certain logical volumes on SSDs bypassing the Smart Array RAID stack for a perfor

[PATCH 08/35] hpsa: poll controller to detect device change event

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron For shared SAS configurations, hosts need to poll Smart Arrays periodically in order to be able to detect configuration changes such as logical drives being added or removed from remote hosts. A register on the controller indicates when such events have occurred, and the

[PATCH 20/35] hpsa: make device update copy the raid map also

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Otherwise we could wind up using incorrect raid map data, and then very bad things would likely happen. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 21/35] hpsa: complete the ioaccel raidmap code

2014-02-18 Thread Stephen M. Cameron
From: Scott Teel Load balance across members of a N-way mirror set, and handle the meta-RAID levels: R10, R50, R60. Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 174 +-- 1 files changed, 168 insertions(+), 6

[PATCH 23/35] hpsa: rescan devices on ioaccel2 error

2014-02-18 Thread Stephen M. Cameron
standard path, so the driver could get stuck in non-ioaccel mode. To avoid that, we allow driver to request a rescan during the next run of the rescan thread. Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 12 ++-- drivers/scsi/hpsa.h |1 + 2 files

[PATCH 26/35] hpsa: retry certain ioaccel error cases on the RAID path

2014-02-18 Thread Stephen M. Cameron
From: Scott Teel Change the handling of HP SSD Smart Path errors with status: 0x02 CHECK CONDITION 0x08 BUSY 0x18 RESERVATION CONFLICT 0x40 TASK ABORTED So that they get retried on the RAID Path. Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 45

[PATCH 16/35] hpsa: initialize controller to perform io accelerator mode 2

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Signed-off-by: Scott Teel --- drivers/scsi/hpsa.c | 111 --- drivers/scsi/hpsa.h |1 drivers/scsi/hpsa_cmd.h |2 - 3 files changed, 78 insertions(+), 36 deletions(-) diff

[PATCH 15/35] hpsa: get physical device handles for io accel mode 2 as well as mode 1

2014-02-18 Thread Stephen M. Cameron
From: Mike MIller Signed-off-by: Mike MIller Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 80acb23..5da13f0 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH 32/35] hpsa add sysfs debug switch for raid map debugging messages

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 64 +++ drivers/scsi/hpsa.h |1 + 2 files changed, 65 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH 24/35] hpsa: allow VPD page zero to be queried

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Code was confused and assumed that page zero was not VPD page and all non-zero pages were VPD pages. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/hpsa.c

[PATCH 30/35] hpsa: only do device rescan for certain events

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Do no rescan on every events -- way too many rescans are triggered if we don't filter the events. Limit rescans to be triggered by the following set of events: * controller state change * enclosure hot plug * physical drive state change * logical drive state c

[PATCH 25/35] hpsa: do not inquire for unsupported ioaccel status vpd page

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 45 + drivers/scsi/hpsa_cmd.h |2 ++ 2 files changed, 47 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 18/35] hpsa: teach hpsa_device_reset to do either target or lun reset

2014-02-18 Thread Stephen M. Cameron
From: Scott Teel Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index e40d94d..021d077 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers

[PATCH 22/35] hpsa: allow user to disable accelerated i/o path

2014-02-18 Thread Stephen M. Cameron
tus To check state: cat /sys/class/scsi_host/host/acciopath_status Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- Documentation/ABI/testing/sysfs-class-scsi_host | 16 drivers/scsi/hpsa.c | 45 ++- drivers/scsi/

[PATCH 13/35] hpsa: Acknowledge controller events in ioaccell mode 2 as well as mode 1

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |3 ++- drivers/scsi/hpsa_cmd.h |1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index b80ba1e..ba51b1e 100644 --- a/drivers/scsi/hpsa.c

[PATCH 27/35] hpsa: update source file copyrights

2014-02-18 Thread Stephen M. Cameron
From: Scott Teel Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 +- drivers/scsi/hpsa.h |2 +- drivers/scsi/hpsa_cmd.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 29/35] hpsa: when switching out of accel mode await only accel command completions

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Don't wait for *all* commands to complete, only for accelerated mode commands. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 31/35] hpsa: improve error messages for driver initiated commands

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron On encountering unexpected error conditions from driver initiated commands, print something useful like CDB and sense data rather than something useless like the kernel virtual address of the command buffer. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c

[PATCH 28/35] hpsa: add controller base data-at-rest encryption compatibility ioaccel2

2014-02-18 Thread Stephen M. Cameron
flag, data encryption key index, and calculate tweak value from request's logical block address. Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 179 +-- drivers/scsi/hpsa_cmd.h | 19 - 2 files ch

[PATCH 34/35] hpsa: Add support for a few HP Storage controllers

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9410482..c8de330 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 35/35] hpsa: fixup MSI-X registration

2014-02-18 Thread Stephen M. Cameron
initialisation will become confused and cause the machine to stall during boot. This patch fixes up the MSI-X registration to re-issue the pci_enable_msix() call with the correct number of MSI-X vectors. With that the hpsa driver continues to works on older controllers like the P200. Cc: Stephen M

[PATCH 33/35] pci: add HP/3PAR vendor id to pci_ids.h

2014-02-18 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- include/linux/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 97fbecd..0154d9b 100644 --- a/include/linux/pci_ids.h +++ b/include/linux

[PATCH 1/6] hpsa: remove unused kthread.h header

2014-02-21 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9f593b9..cb984c2 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -47,7 +47,6

[PATCH 6/6] hpsa: Do not zero fields of ioaccel2 command structure twice

2014-02-21 Thread Stephen M. Cameron
From: Stephen M. Cameron Structure was already memset to zero at the top of hpsa_scsi_ioaccel2_queue_command Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 0/6] hpsa: supplemental February 2014 driver updates

2014-02-21 Thread Stephen M. Cameron
come ready, and adding support for "hba mode" for controllers which support this feature, to expose physical disks to the OS. --- Stephen M. Cameron (5): hpsa: remove unused kthread.h header hpsa: bring format-in-progress drives online when ready hpsa: remove unused

[PATCH 5/6] hpsa: Add hba mode to the hpsa driver

2014-02-21 Thread Stephen M. Cameron
From: Stephen M. Cameron This allows exposing physical disks behind Smart Array controllers to the OS (if the controller has the right firmware and is in "hba" mode) Signed-off-by: Joe Handzik --- drivers/scsi/hpsa.c | 93 +-- dr

[PATCH 2/6] hpsa: bring format-in-progress drives online when ready

2014-02-21 Thread Stephen M. Cameron
From: Stephen M. Cameron Do not expose drives that are undergoing a format immediately to the OS, instead wait until they are ready before bringing them online. This is so that logical drives created with "rapid parity initialization" do not get immediately kicked off the system

[PATCH 4/6] hpsa: remove unused struct request from CommandList

2014-02-21 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa_cmd.h |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h index 8026d2e..50388f1 100644 --- a/drivers/scsi/hpsa_cmd.h +++ b/drivers/scsi

[PATCH 3/6] hpsa: increase the probability of a reported success after a device reset

2014-02-21 Thread Stephen M. Cameron
From: Tomas Henzl rc is set in the loop, and it isn't set back to zero anywhere this patch fixes it Signed-off-by: Tomas Henzl --- drivers/scsi/hpsa.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a0fcaa6..23110a8 100

[PATCH] hpsa: update driver version to 3.4.4-1

2014-03-13 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index eb9af2f..9a6e4a2 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -53,7

[PATCH] hpsa: fix bad endif placement in RAID 5 mapper code

2014-03-13 Thread Stephen M. Cameron
From: Stephen M. Cameron It caused the i/o request to always be counted as ineligible for the accelerated i/o path on 32 bit systems and negatively affected performance. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH] hpsa: fix bug in figure_lunaddrbytes()

2014-03-20 Thread Stephen M. Cameron
From: Stephen M. Cameron Depending on whether we use "extended" or "normal" CISS_REPORT_LUNS command, the returned data is either 8 or 24 bytes per LUN, and the code needs to take this into account instead of just always assuming 24 bytes per LUN. This would cause physic

[PATCH 01/19] hpsa: add new Smart Array PCI IDs (May 2014)

2014-05-08 Thread Stephen M. Cameron
From: Joe Handzik Signed-off-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Cc: sta...@vger.kernel.org --- drivers/scsi/hpsa.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 02/19] Checking for a NULL return from a kzalloc call in hpsa_get_pdisk_of_ioaccel2.

2014-05-08 Thread Stephen M. Cameron
From: Joe Handzik Signed-off-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Cc: sta...@vger.kernel.org --- drivers/scsi/hpsa.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index fda6cf1

[PATCH 03/19] hpsa: remove unused fields from struct ctlr_info

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron The fields "major", "max_outstanding", and "usage_count" of struct ctlr_info were not used for anything. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 -- drivers/scsi/hpsa.h |3 --- 2 files changed, 0 insertions(+)

[PATCH 13/19] hpsa: Rearrange start_io to avoid one unlock/lock sequence in main io path

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index ad73017..c6ed5ea 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers

[PATCH 12/19] hpsa: avoid unnecessary readl on every command submission

2014-05-08 Thread Stephen M. Cameron
From: root for controllers which support either of the ioaccel transport methods. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |7 +++ drivers/scsi/hpsa.h | 15 ++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 11/19] hpsa: use per-cpu variable for lockup_detected

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron Avoid excessive locking by using per-cpu variable for lockup_detected Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 80 ++- drivers/scsi/hpsa.h |2 + 2 files changed, 54 insertions(+), 28 deletions

[PATCH 14/19] hpsa: define extended_report_lun_entry data structure

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 21 - drivers/scsi/hpsa_cmd.h | 12 +++- 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c6ed5ea..96436bb

[PATCH 09/19] hpsa: allocate reply queues individually

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron Now that we can allocate more than 4 reply queues (up to 64) we shouldn't try to make them share the same allocation but should allocate them separately. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |

[PATCH 16/19] hpsa: fix event filtering to prevent excessive rescans with old firmware

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron CTLR_STATE_CHANGE_EVENT and CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL do not require rescans to be initiated. Current firmware filters out these events already, but some out of date firmware doesn't, so the driver needs to filter them out too. Without this chang

[PATCH 15/19] hpsa: kill annoying messages about SSD Smart Path retries

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron There's nothing the user can or should do about these messages, the commands are retried down the normal RAID path, and the messages just flood the logs and sap performance. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 10 -- 1 files ch

[PATCH 10/19] hpsa: set irq affinity hints to route MSI-X vectors across CPUs

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9c44f26..e8090e2 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH 18/19] hpsa: report check condition even if no sense data present for ioaccel2 mode

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron It shouldn't happen that we get a check condition with no sense data, but if it does, we shouldn't just drop the check condition on the floor. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |7 +-- 1 files changed, 5 insertions(+), 2

[PATCH 00/19] hpsa driver updates May 8, 2014

2014-05-08 Thread Stephen M. Cameron
Not a lot of extensive changes in this set, some new PCI IDs, some small bug fixes, quieting some noisy messages, allowing more reply queues, setting irq affinity hints, and some minor locking improvments. drivers/scsi/hpsa.c | 266 +-- drivers/sc

[PATCH 07/19] hpsa: remove dev_dbg() calls from hot paths

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron They are not completely free of cost when disabled and when enabled emitting debug output for every command submitted produces far too much output to be useful. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.h |5 - 1 files changed, 0 insertions(+), 5

[PATCH 17/19] hpsa: remove bad unlikely annotation from device list updating code

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 8359884..9d4a0bd 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -3060,7

[PATCH 08/19] hpsa: choose number of reply queues more intelligently.

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron No sense having 8 or 16 reply queues if you only have 4 cpus, and likewise no sense limiting to 8 reply queues if you have many more cpus. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 ++ drivers/scsi/hpsa_cmd.h |2 +- 2 files changed, 3

[PATCH 04/19] hpsa: allow passthru ioctls to work with bidirectional commands

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron Treat the the data direction bits as a bit mask allowing both READ and WRITE at the same time instead of testing for equality to see if it's a exclusively a READ or a WRITE. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |8 1 files chang

[PATCH 06/19] hpsa: use gcc aligned attribute instead of manually padding structs

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |3 --- drivers/scsi/hpsa_cmd.h | 33 ++--- 2 files changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 2220b32..b1ecfd8

[PATCH 05/19] hpsa: change doorbell reset delay to ten seconds

2014-05-08 Thread Stephen M. Cameron
From: Justin Lindley After 3.22 firmware, PMC firmware guys tell us the previous 5 second delay after a reset now needs to be 10 secs to avoid a PCIe error due to the driver looking at the controller too soon after the reset. Signed-off-by: Justin Lindley Signed-off-by: Stephen M. Cameron

[PATCH 19/19] hpsa: remove messages about volume status VPD inquiry page not supported

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron They are annoying and do not help anyone. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 3446b8d..2fe8705 100644 --- a

[PATCH 1/2] hpsa: fix memory leak in hpsa_hba_mode_enabled

2014-05-15 Thread Stephen M. Cameron
From: Joe Handzik And while we're at it fix a magic number Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |7 ++- drivers/scsi/hpsa.h |1 + 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 2/2] hpsa: do not ignore failure of sense controller parameters command

2014-05-15 Thread Stephen M. Cameron
From: Joe Handzik Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a0da81c..654e341 100644 --- a/drivers/scsi/hpsa.c +++ b

[PATCH 2/3] hpsa: return -ENOMEM not -1 on kzalloc failure in hpsa_get_device_id

2014-05-21 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reported-by: Dan Carpenter --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c5b24e6..af51e7d 100644 --- a/drivers/scsi/hpsa.c +++ b

[PATCH 1/3] hpsa: fix bad comparison of signed with unsigned in hpsa_update_scsi_devices

2014-05-21 Thread Stephen M. Cameron
From: Joe Handzik rescan_hba_mode was defined as a u8 so could never be less than zero: rescan_hba_mode = hpsa_hba_mode_enabled(h); if (rescan_hba_mode < 0) goto out; Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reported-by: Dan Carpen

[PATCH 3/3] hpsa: fix handling of hpsa_volume_offline return value

2014-05-21 Thread Stephen M. Cameron
From: Stephen M. Cameron Make return value an int instead of an unsigned char so that we do not lose negative error return values. Signed-off-by: Stephen M. Cameron Reported-by: Dan Carpenter --- drivers/scsi/hpsa.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 2 01/24] hpsa: add new Smart Array PCI IDs (May 2014)

2014-05-29 Thread Stephen M. Cameron
From: Joe Handzik Signed-off-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron Cc: sta...@vger.kernel.org --- drivers/scsi/hpsa.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/scsi

[PATCH 2 00/24] Resend of May 2014 patches for hpsa driver

2014-05-29 Thread Stephen M. Cameron
Not a lot of extensive changes in this set, some new PCI IDs, some small bug fixes, quieting some noisy messages, allowing more reply queues, setting irq affinity hints, and some minor locking improvments. Two patches are slightly changed since they were first sent due to reviewer comments and som

[PATCH 2 02/24] hpsa: fix missing check of kzalloc return value

2014-05-29 Thread Stephen M. Cameron
From: Joe Handzik Signed-off-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron Cc: sta...@vger.kernel.org --- drivers/scsi/hpsa.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 2 09/24] hpsa: allocate reply queues individually

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Now that we can allocate more than 4 reply queues (up to 64) we shouldn't try to make them share the same allocation but should allocate them separately. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Scott Teel --- drivers/scsi/h

[PATCH 2 08/24] hpsa: choose number of reply queues more intelligently.

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron No sense having 8 or 16 reply queues if you only have 4 cpus, and likewise no sense limiting to 8 reply queues if you have many more cpus. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Scott Teel --- drivers/scsi/hpsa.c |2

[PATCH 2 13/24] hpsa: Rearrange start_io to avoid one unlock/lock sequence in main io path

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index ad73017..c6ed5ea 100644 --- a/drivers

[PATCH 2 06/24] hpsa: use gcc aligned attribute instead of manually padding structs

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c |3 --- drivers/scsi/hpsa_cmd.h | 33 ++--- 2 files changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH 2 11/24] hpsa: use per-cpu variable for lockup_detected

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Avoid excessive locking by using per-cpu variable for lockup_detected Signed-off-by: Stephen M. Cameron Reviewed-by: Scott Teel --- drivers/scsi/hpsa.c | 80 ++- drivers/scsi/hpsa.h |2 + 2 files changed, 54

[PATCH 2 15/24] hpsa: kill annoying messages about SSD Smart Path retries

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron There's nothing the user can or should do about these messages, the commands are retried down the normal RAID path, and the messages just flood the logs and sap performance. Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik Reviewed-by: Mike M

[PATCH 2 07/24] hpsa: remove dev_dbg() calls from hot paths

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron They are not completely free of cost when disabled and when enabled emitting debug output for every command submitted produces far too much output to be useful. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Webb Scales --- drivers/scsi

[PATCH 2 03/24] hpsa: remove unused fields from struct ctlr_info

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron The fields "major", "max_outstanding", and "usage_count" of struct ctlr_info were not used for anything. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c |2 -- drivers/s

[PATCH 2 05/24] hpsa: change doorbell reset delay to ten seconds

2014-05-29 Thread Stephen M. Cameron
From: Justin Lindley After 3.22 firmware, PMC firmware guys tell us the previous 5 second delay after a reset now needs to be 10 secs to avoid a PCIe error due to the driver looking at the controller too soon after the reset. Signed-off-by: Justin Lindley Signed-off-by: Stephen M. Cameron

[PATCH 2 10/24] hpsa: set irq affinity hints to route MSI-X vectors across CPUs

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Scott Teel --- drivers/scsi/hpsa.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9c44f26..e8090e2

[PATCH 2 04/24] hpsa: allow passthru ioctls to work with bidirectional commands

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Treat the the data direction bits as a bit mask allowing both READ and WRITE at the same time instead of testing for equality to see if it's a exclusively a READ or a WRITE. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Webb S

[PATCH 2 21/24] hpsa: remove messages about volume status VPD inquiry page not supported

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron They are annoying and do not help anyone. Signed-off-by: Stephen M. Cameron Reviewed-by: Justin Lindley Reviewed-by: Mike Miller --- drivers/scsi/hpsa.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers

[PATCH 2 19/24] hpsa: fix memory leak in hpsa_hba_mode_enabled

2014-05-29 Thread Stephen M. Cameron
From: Joe Handzik And while we're at it fix a magic number Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |7 ++- drivers/scsi/hpsa.h |1 + 2 files changed, 7 insertions(+), 1 deletions(-) diff --

[PATCH 2 20/24] hpsa: do not ignore failure of sense controller parameters command

2014-05-29 Thread Stephen M. Cameron
From: Joe Handzik Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index e2f85e7..b4b745b 100644 --- a

[PATCH 2 14/24] hpsa: define extended_report_lun_entry data structure

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c | 21 - drivers/scsi/hpsa_cmd.h | 12 +++- 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c

[PATCH 2 17/24] hpsa: remove bad unlikely annotation from device list updating code

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Justin Lindley Reviewed-by: Mike Miller --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 8359884..9d4a0bd 100644 --- a

[PATCH 2 24/24] hpsa: fix handling of hpsa_volume_offline return value

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Make return value an int instead of an unsigned char so that we do not lose negative error return values. Signed-off-by: Stephen M. Cameron Reviewed-by: Webb Scales Reported-by: Dan Carpenter --- drivers/scsi/hpsa.c | 12 drivers/scsi/hpsa_cmd.h

[PATCH 2 18/24] hpsa: report check condition even if no sense data present for ioaccel2 mode

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron It shouldn't happen that we get a check condition with no sense data, but if it does, we shouldn't just drop the check condition on the floor. Signed-off-by: Stephen M. Cameron Reviewed-by: Justin Lindley Reviewed-by: Mike Miller --- drivers/scsi/hps

[PATCH 2 23/24] hpsa: return -ENOMEM not -1 on kzalloc failure in hpsa_get_device_id

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reported-by: Dan Carpenter Reviewed-by: Mike Miller --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c5b24e6..af51e7d 100644 --- a

[PATCH 2 16/24] hpsa: fix event filtering to prevent excessive rescans with old firmware

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron CTLR_STATE_CHANGE_EVENT and CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL do not require rescans to be initiated. Current firmware filters out these events already, but some out of date firmware doesn't, so the driver needs to filter them out too. Without this chang

[PATCH 2 22/24] hpsa: fix bad comparison of signed with unsigned in hpsa_update_scsi_devices

2014-05-29 Thread Stephen M. Cameron
From: Joe Handzik rescan_hba_mode was defined as a u8 so could never be less than zero: rescan_hba_mode = hpsa_hba_mode_enabled(h); if (rescan_hba_mode < 0) goto out; Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Came

[PATCH 2 12/24] hpsa: avoid unnecessary readl on every command submission

2014-05-29 Thread Stephen M. Cameron
From: Stephen M. Cameron for controllers which support either of the ioaccel transport methods. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c |7 +++ drivers/scsi/hpsa.h | 15 ++- 2 files changed, 21

[PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-03 Thread Stephen M. Cameron
From: Stephen M. Cameron Don't loop through all the devices even after finding the one we're looking for Signed-off-by: Stephen M. Cameron Reviewed-by: Robert Elliott --- drivers/scsi/scsi_error.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dr

[PATCH 0/5] hpsa a few small updates for early July 2014

2014-07-03 Thread Stephen M. Cameron
Nothing very big here, just a few small updates for now. I still have a giant ball of patches waiting in the wings, but it is unfortunately not quite ready yet. --- Robert Elliott (1): hpsa: do not unconditionally copy sense data Stephen M. Cameron (4): hpsa: remove online devices

[PATCH 1/5] hpsa: remove online devices from offline device list

2014-07-03 Thread Stephen M. Cameron
From: Stephen M. Cameron When devices come on line, they should be removed from the list of offline devices that are monitored. Signed-off-by: Stephen M. Cameron Reviewed-by: Scott Teel Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c |6 +- 1 files changed, 5 insertions(+), 1

[PATCH 2/5] hpsa: fix bad -ENOMEM return value in hpsa_big_passthru_ioctl

2014-07-03 Thread Stephen M. Cameron
From: Stephen M. Cameron When copy_from_user fails, return -EFAULT, not -ENOMEM Signed-off-by: Stephen M. Cameron Reported-by: Robert Elliott Reviewed-by: Joe Handzik Reviewed-by: Scott Teel Cc: --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 4/5] hpsa: fix 6-byte READ/WRITE with 0 length data xfer

2014-07-03 Thread Stephen M. Cameron
From: Stephen M. Cameron a 6-byte READ/WRITE CDB with a 0 block data transfer really means a 256 block data transfer. The RAID mapping code failed to handle this case. For 10/12/16 byte READ/WRITEs, 0 just means no data should be transferred, and should not trigger BUG_ON. Signed-off-by

[PATCH 5/5] hpsa: do not unconditionally copy sense data

2014-07-03 Thread Stephen M. Cameron
From: Robert Elliott Signed-off-by: Robert Elliott Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a97a7ff

[PATCH 3/5] hpsa: make hpsa_init_one return -ENOMEM if allocation of h->lockup_detected fails

2014-07-03 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 08b34e9..794d726 100644 --- a/drivers/scsi/hpsa.c +++ b

[PATCH 1/3] hpsa: Use LUN reset instead of target reset

2012-07-26 Thread Stephen M. Cameron
From: Stephen M. Cameron It turns out Smart Array logical drives do not support target reset and when the target reset fails, the logical drive will be taken off line. Symptoms look like this: hpsa :03:00.0: Abort request on C1:B0:T0:L0 hpsa :03:00.0: resetting device 1:0:0:0 hpsa

[PATCH 0/3] hpsa patches for July 2012

2012-07-26 Thread Stephen M. Cameron
have been a stupid thing to do. The other two patches are very minor. --- Stephen M. Cameron (3): hpsa: Use LUN reset instead of target reset hpsa: fix incorrect abort diagnostic message hpsa: use ioremap_nocache instead of ioremap drivers/scsi/hpsa.c |7 --- 1

[PATCH 2/3] hpsa: fix incorrect abort diagnostic message

2012-07-26 Thread Stephen M. Cameron
From: Stephen M. Cameron In the abort handler, when asked to abort a command which is not known to the driver, SUCCESS is returned, but the diagnostic message incorrectly indicates the abort failed. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1

[PATCH 3/3] hpsa: use ioremap_nocache instead of ioremap

2012-07-26 Thread Stephen M. Cameron
From: Stephen M. Cameron I think ioremap() ends up being equivalent to ioremap_nocache by default, but we should signal our intent that these mappings should be non-cacheable. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[PATCH] hpsa: fix handling of protocol error

2012-09-14 Thread Stephen M. Cameron
From: Stephen M. Cameron If a command status of CMD_PROTOCOL_ERR is received, this information should be conveyed to the SCSI mid layer, not dropped on the floor. CMD_PROTOCOL_ERR may be received from the Smart Array for any commands destined for an external RAID controller such as a P2000, or

<    1   2