lse {
> @@ -842,7 +857,7 @@ static int ufshcd_compose_upiu(struct ufs_hba *hba,
> struct ufshcd_lrb *lrbp)
> }
> break;
> case UTP_CMD_TYPE_DEV_MANAGE:
> - ufshcd_prepare_req_desc_hdr(lrbp, &upiu_flags, DMA_NONE);
> +
Hi James,
Please merge the following patches to 'misc' branch.
Thanks,
Santosh
Dolev Raviv (3):
scsi: ufs: add support for query requests
scsi: ufs: Add support for sending NOP OUT UPIU
scsi: ufs: Set fDeviceInit flag to initiate device initialization
Seungwon Jeon (4):
scsi: ufs: wrap
ific Fields) are 32 bytes
together, the rest is used to transfer extra request data (such as
descriptor in query requests). In order to accommodate the largest
descriptor in the UFS spec (256 bytes) we need to increase the UPIU
size.
Signed-off-by: Dolev Raviv
Signed-off-by: Santosh Y
diff --git a/d
From: Seungwon Jeon
Simplify operations with hiding mmio_base.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 4ddc8be..38412a6 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs
From: Seungwon Jeon
It makes interrupt setting more flexible especially
for disabling. And wrong bit mask is fixed for ver 1.0.
[17:16] is added for mask.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
From: Seungwon Jeon
There is no need to check the version to clear
the interrupt status. And the order is changed
prior to actual handling.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index
UPIU to
check the device connection path and test whether the UTP layer on the
device side is functional during initialization.
Signed-off-by: Sujit Reddy Thumma
Tested-by: Dolev Raviv
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 0c570c0
ed-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b1ac21e..0c570c0 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -33,11 +33,15 @@
* this program.
*/
+#include
+
#include "ufshcd.h&q
device initialization completion.
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 086ff03..742363d 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -107,8 +107,13 @@ enum
From: Sujit Reddy Thumma
The response UPIU length should be in DWORD and not in bytes.
Signed-off-by: Maya Erez
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 18dead4..e9dba33 100644
--- a/drivers/scsi/ufs
On Fri, May 24, 2013 at 7:52 AM, Libo Chen wrote:
>
> we should check kzalloc, avoid to hit oops
>
> Signed-off-by: Libo Chen
> ---
> drivers/scsi/megaraid.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> index
On Sun, May 26, 2013 at 4:54 PM, Akinobu Mita wrote:
> of_match_table member in struct device_driver must be terminated by
> empty slot as a sentinel.
>
> Signed-off-by: Akinobu Mita
> Cc: Vinayak Holikatti
> Cc: Santosh Y
> Cc: "James E.J. Bottomley"
&
error code from wrong
> REG_UIC_ERROR_CODE_PHY_ADAPTER_LAYER, it should be
> REG_UIC_ERROR_CODE_DATA_LINK_LAYER.
>
> Signed-off-by: Akinobu Mita
> Cc: Vinayak Holikatti
> Cc: Santosh Y
> Cc: "James E.J. Bottomley"
> Cc: linux-scsi@vger.kernel.org
> ---
>
> +/*
> + * ufshcd_wait_for_register - wait for register value to change
> + * @hba - per-adapter interface
> + * @reg - mmio register offset
> + * @mask - mask to apply to read register value
> + * @val - wait condition
> + * @interval_us - polling interval in microsecs
> + * @timeout_ms - timeout
>
> /**
> + * ufshcd_query_request() - API for issuing query request to the device.
> + * @hba: ufs driver context
> + * @query: params for query request
> + * @descriptor: buffer for sending/receiving descriptor
> + * @retries: number of times to try executing the command
> + *
> + * All n
On Sun, May 19, 2013 at 1:51 PM, Santosh Y wrote:
> Hi James,
>
> Please merge the following patches to 'misc' branch.
>
> Thanks,
> Santosh
>
> Dolev Raviv (3):
> scsi: ufs: add support for query requests
> scsi: ufs: Add support for sending NOP OUT
n SCSI
> + depends on SCSI && HAS_IOMEM
> ---help---
> This selects the support for UFS devices in Linux, say Y and make
> sure that you know the name of your UFS host adapter (the card
>
Acked-by: Santosh Y
--
~Santosh
--
To unsubscribe fro
astly, we need to relax dma_set_mask(dev, DMA_BIT_MASK(32)) error check
> for platform devices on ARM, which do not have a valid dma_mask pointer.
>
> Signed-off-by: Akinobu Mita
> Cc: Vinayak Holikatti
> Cc: Santosh Y
> Cc: "James E.J. Bottomley"
> Cc: linux-scsi@
On Sun, Jun 9, 2013 at 4:49 PM, Akinobu Mita wrote:
> Changing the device coherent dma mask to the value that currently set
> has no effect.
>
> Signed-off-by: Akinobu Mita
> Cc: Vinayak Holikatti
> Cc: Santosh Y
> Cc: "James E.J. Bottomley"
> Cc: linux-scs
On Fri, Jun 14, 2013 at 1:10 PM, Sujit Reddy Thumma
wrote:
> On 6/13/2013 10:03 AM, Sujit Reddy Thumma wrote:
>>>
>>> static struct scsi_host_template ufshcd_driver_template = {
>>> @@ -1771,8 +2064,8 @@ int ufshcd_init(struct device *dev, struct
>>> ufs_hba **hba_handle,
>>> /* Configu
On Thu, Jun 13, 2013 at 10:06 AM, Sujit Reddy Thumma
wrote:
> On 6/12/2013 11:04 AM, Santosh Y wrote:
>>>
>>>
>>> /**
>>> + * ufshcd_query_request() - API for issuing query request to the
>>> device.
>>> + * @hba: ufs
From: Sujit Reddy Thumma
The response UPIU length should be in DWORD and not in bytes.
Signed-off-by: Maya Erez
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 48a7645..2230f14 100644
--- a/drivers/scsi/ufs
From: Seungwon Jeon
It makes interrupt setting more flexible especially
for disabling. And wrong bit mask is fixed for ver 1.0.
[17:16] is added for mask.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
ed-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 2e02483..48a7645 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -33,11 +33,15 @@
* this program.
*/
+#include
+
#include "ufshcd.h&q
From: Seungwon Jeon
Simplify operations with hiding mmio_base.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c32a478..871c2f0 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs
Hi James,
Please merge the following patches to 'misc' branch.
Thanks,
Santosh
Akinobu Mita (4):
ufshcd-pltfrm: add missing empty slot in ufs_of_match[]
ufs: fix register address in UIC error interrupt handling
ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call
ufs: fix DMA m
From: Akinobu Mita
of_match_table member in struct device_driver must be terminated by
empty slot as a sentinel.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/
From: Seungwon Jeon
There is no need to check the version to clear
the interrupt status. And the order is changed
prior to actual handling.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index
From: Seungwon Jeon
This patch replaces normal calls for resource allocation with devm_*()
derivative functions. It makes resource freeing simpler.
Signed-off-by: Seungwon Jeon
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 5cb1d75
REG_UIC_ERROR_CODE_PHY_ADAPTER_LAYER, it should be
REG_UIC_ERROR_CODE_DATA_LINK_LAYER.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 255f5be..19618c6 10
From: Akinobu Mita
Changing the device coherent dma mask to the value that currently set
has no effect.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-
ave a valid dma_mask pointer.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 48be39a..64d36eb 100644
--- a/drivers/scsi/
From: Seungwon Jeon
There is no need to check the version to clear
the interrupt status. And the order is changed
prior to actual handling.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index
From: Seungwon Jeon
It makes interrupt setting more flexible especially
for disabling. And wrong bit mask is fixed for ver 1.0.
[17:16] is added for mask.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
Hi James,
Sorry for the mail-id typo :-(. Resending the patches.
Please merge the following patches to 'misc' branch.
Thanks,
Santosh
Akinobu Mita (4):
ufshcd-pltfrm: add missing empty slot in ufs_of_match[]
ufs: fix register address in UIC error interrupt handling
ufshcd-pltfrm: remove un
From: Seungwon Jeon
Simplify operations with hiding mmio_base.
Signed-off-by: Seungwon Jeon
Tested-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c32a478..871c2f0 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs
ed-by: Maya Erez
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 2e02483..48a7645 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -33,11 +33,15 @@
* this program.
*/
+#include
+
#include "ufshcd.h&q
From: Seungwon Jeon
This patch replaces normal calls for resource allocation with devm_*()
derivative functions. It makes resource freeing simpler.
Signed-off-by: Seungwon Jeon
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 5cb1d75
ave a valid dma_mask pointer.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 48be39a..64d36eb 100644
--- a/drivers/scsi/
REG_UIC_ERROR_CODE_PHY_ADAPTER_LAYER, it should be
REG_UIC_ERROR_CODE_DATA_LINK_LAYER.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 255f5be..19618c6 10
From: Akinobu Mita
of_match_table member in struct device_driver must be terminated by
empty slot as a sentinel.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/
From: Sujit Reddy Thumma
The response UPIU length should be in DWORD and not in bytes.
Signed-off-by: Maya Erez
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 48a7645..2230f14 100644
--- a/drivers/scsi/ufs
From: Akinobu Mita
Changing the device coherent dma mask to the value that currently set
has no effect.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-
On Thu, Jun 13, 2013 at 7:50 PM, Sujit Reddy Thumma
wrote:
>
> Background operations in the UFS device can be disabled by
> the host to reduce the response latency of transfer requests.
> Add support for enabling/disabling the background operations
> during runtime suspend/resume of the device.
>
On Thu, Jun 13, 2013 at 8:00 PM, Sujit Reddy Thumma
wrote:
> Currently, sending Task Management (TM) command to the card might
> be broken in some scenarios as listed below:
>
> - If there are more than 8 TM commands the implementation returns
> error to the caller.
> Fix: Wait for one of the slot
On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma
wrote:
> On 6/27/2013 4:49 PM, Santosh Y wrote:
>>>
>>> >+ spin_lock_irqsave(host->host_lock, flags);
>>> > task_req_descp = hba->utmrdl_base_addr;
>>> > task_r
> +
> +/**
> + * ufshcd_eh_device_reset_handler - device reset handler registered to
> + *scsi layer.
> + * @cmd - SCSI command pointer
> + *
> + * Returns SUCCESS/FAILED
> + */
> +static int ufshcd_eh_device_reset_handler(struct scsi_cmnd *cmd)
> +{
> + st
On Wed, Jul 3, 2013 at 9:22 PM, Sujit Reddy Thumma
wrote:
> On 7/2/2013 9:21 PM, Santosh Y wrote:
>>
>> On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma
>> wrote:
>>>
>>> On 6/27/2013 4:49 PM, Santosh Y wrote:
>>>>>
>>
> +
> +/**
> + * ufshcd_fatal_err_handler - handle fatal errors
> + * @work: pointer to work structure
> */
> static void ufshcd_fatal_err_handler(struct work_struct *work)
> {
> struct ufs_hba *hba;
> + unsigned long flags;
> + u32 err_xfer = 0;
> + u32 err_tm = 0;
>
On Thu, Jul 11, 2013 at 6:31 PM, Tanya Brokhman wrote:
> When the scheduler reports to the block layer that there is an urgent
> request pending, the device driver may decide to stop the transmission
> of the current request in order to handle the urgent one. This is done
> in order to reduce the
device initialization completion.
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 51b5e3f..50d32f1 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -40,6 +40,10 @@
#include
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 139bc06..51b5e3f 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -36,10 +36,13 @@
#ifndef _UFS_H
#define _UFS_H
+#include
+#include
+
#define MAX_CDB_SIZE 16
#define
a
Cc: Seungwon Jeon
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 57ea9dd..24d6ba7 100644
--- a/drivers/scsi/ufs/ufshcd-pci.c
+++ b/drivers/scsi/uf
Hi James,
Please apply the following patches to 'misc' branch.
Thanks,
Santosh
Akinobu Mita (3):
ufshcd-pci: release ioremapped region during removing driver
ufs: don't disable_irq() if the IRQ can be shared among devices
ufs: don't stop controller before scsi_remove_host()
Dolev Raviv (1
disabled during runtime resume
and due to continuous data transfers the runtime suspend is not
triggered, the BKOPS is enabled when the device raises a level-2
exception (outstanding operations - performance impact).
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git a/drivers/scsi
From: Sujit Reddy Thumma
Add runtime PM helpers to suspend/resume UFS controller at runtime.
Enable runtime PM by default for pci and platform drivers as the
initialized hardware can suspend if it is not used after bootup.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git
.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 24d6ba7..a823cf4 100644
--- a/drivers/scsi/ufs/ufshcd-pci.c
+++ b/dr
From: Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 13b8c5a
From: Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 34f726c..3da4252 100644
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1f2caa0..b36ca9a 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -2603,11 +2603,11 @@ EXPORT_SYMBOL(ufshcd_runtime_idle);
*/
void ufshcd_remove(stru
On Fri, Jul 26, 2013 at 7:15 PM, Seungwon Jeon wrote:
> Fatal error in OCS(overall command status) field indicates
> error conditions which is not covered by UFSHCI.
> It means that host cannot define the result of command status
> and therefore host may need to check transfer response UPIU's
> re
On Mon, Jul 29, 2013 at 11:43 PM, Sujit Reddy Thumma
wrote:
> On 7/28/2013 10:40 PM, Santosh Y wrote:
>>
>> +
>> /**
>>* ufshcd_pltfrm_probe - probe routine of the driver
>>* @pdev: pointer to Platform device handle
>> @@ -122,14 +157,20 @
On Sun, Jul 28, 2013 at 10:40 PM, Santosh Y wrote:
> Hi James,
>
> Please apply the following patches to 'misc' branch.
>
> Thanks,
> Santosh
>
> Akinobu Mita (3):
> ufshcd-pci: release ioremapped region during removing driver
> ufs: don't disable
Hi James,
Please apply the following patches to 'misc' branch.
Thanks,
Santosh
Akinobu Mita (3):
ufshcd-pci: release ioremapped region during removing driver
ufs: don't disable_irq() if the IRQ can be shared among devices
ufs: don't stop controller before scsi_remove_host()
Dolev Raviv (1
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 139bc06..51b5e3f 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -36,10 +36,13 @@
#ifndef _UFS_H
#define _UFS_H
+#include
+#include
+
#define MAX_CDB_SIZE 16
#define
device initialization completion.
Signed-off-by: Dolev Raviv
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 51b5e3f..50d32f1 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -40,6 +40,10 @@
#include
disabled during runtime resume
and due to continuous data transfers the runtime suspend is not
triggered, the BKOPS is enabled when the device raises a level-2
exception (outstanding operations - performance impact).
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git a/drivers/scsi
a
Cc: Seungwon Jeon
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 57ea9dd..24d6ba7 100644
--- a/drivers/scsi/ufs/ufshcd-pci.c
+++ b/drivers/scsi/uf
From: Sujit Reddy Thumma
Add runtime PM helpers to suspend/resume UFS controller at runtime.
Enable runtime PM by default for pci and platform drivers as the
initialized hardware can suspend if it is not used after bootup.
Signed-off-by: Sujit Reddy Thumma
Signed-off-by: Santosh Y
diff --git
.
Signed-off-by: Akinobu Mita
Cc: Vinayak Holikatti
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 24d6ba7..a823cf4 100644
--- a/drivers/scsi/ufs/ufshcd-pci.c
+++ b/dr
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1f2caa0..b36ca9a 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -2603,11 +2603,11 @@ EXPORT_SYMBOL(ufshcd_runtime_idle);
*/
void ufshcd_remove(stru
From: Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 8b4a27f
From: Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 880d19f..5e46232 100644
On Thu, Jun 27, 2013 at 10:01 AM, Seungwon Jeon wrote:
> This patch replaces normal calls for resource allocation with devm_*()
> derivative functions. It makes resource freeing simpler.
>
> Signed-off-by: Seungwon Jeon
> Signed-off-by: Santosh Y
> ---
> Change in v2:
>
On Fri, Jul 26, 2013 at 7:16 PM, Seungwon Jeon wrote:
> Except for 'GOOD' and 'CHECK CONDITION', other status value
> in Response UPIU may or may contain sense data. If a non-zero
> value is in the Data Segment Length field, it means that UPIU
> has Sense Data in the Data Segment area.
>
> Signed-
On Wed, Aug 14, 2013 at 2:41 PM, Julia Lawall wrote:
>
> From: Julia Lawall
>
> Remove unneeded error handling on the result of a call to
> platform_get_resource when the value is passed to devm_ioremap_resource.
>
> A debugging statement in the error-handling code is removed as well, as it
> doe
Hi James,
Please merge the following patches to 'misc' branch.
The patches depend on http://thread.gmane.org/gmane.linux.scsi/83565
patch series.
Thanks,
Santosh
Sujit Reddy Thumma (4):
scsi: ufs: Fix broken task management command implementation
scsi: ufs: Fix hardware race conditions whil
Thumma
Reviewed-by: Yaniv Gardi
Tested-by: Dolev Raviv
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dfa61be..a0f5ac2 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -79,6 +79,14 @@ enum {
UFSHCD_EH_IN_PROGRESS
rrupt with TASK_UNINTERRUPTIBLE
set.
Signed-off-by: Sujit Reddy Thumma
Reviewed-by: Yaniv Gardi
Tested-by: Dolev Raviv
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b36ca9a..e0810a3 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers
command is guaranteed
to be non-existent in both controller and the device.
Signed-off-by: Sujit Reddy Thumma
Reviewed-by: Yaniv Gardi
Tested-by: Dolev Raviv
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index e0810a3..24c5ab3 100644
--- a/drivers/scsi
ng in such scenario by resetting the
device and host and re-initializing them in proper manner.
Signed-off-by: Sujit Reddy Thumma
Reviewed-by: Yaniv Gardi
Tested-by: Dolev Raviv
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 24c5ab3..dfa61be 1
>
> +static int ufshcd_variant_hba_init(struct ufs_hba *hba)
> +{
> + int err = 0;
> +
> + if (!hba->vops)
> + goto out;
> +
> + if (hba->vops->init) {
> + err = hba->vops->init(hba);
> + if (err)
> + goto out;
> +
On Tue, Aug 27, 2013 at 9:48 AM, Sujit Reddy Thumma
wrote:
> UFS devices are powered by at most three external power supplies -
> - VCC - The flash memory core power supply, 2.7V to 3.6V or 1.70V to 1.95V
> - VCCQ - The controller and I/O power supply, 1.1V to 1.3V
> - VCCQ2 - Secondary controller
n due to the unnecessary address-of operator.
>
> Signed-off-by: Akinobu Mita
> Cc: Dolev Raviv
> Cc: Sujit Reddy Thumma
> Cc: Vinayak Holikatti
> Cc: Santosh Y
> Cc: James Bottomley
> Cc: linux-scsi@vger.kernel.org
> ---
> drivers/scsi/ufs/ufshcd.c | 3 +--
>
Hi James,
Please apply the following patches to 'misc' branch.
Thanks,
Santosh
Seungwon Jeon (6):
scsi: ufs: find out sense data over scsi status values
scsi: ufs: fix the setting interrupt aggregation counter
scsi: ufs: add dme configuration primitives
scsi: ufs: add unipro attribute ID
usted with possible value.
For that, existing 'ufshcd_config_int_aggr' is split into two part
[reset, configure].
Signed-off-by: Seungwon Jeon
Reviewed-by: Subhash Jadavani
Tested-by: Yaniv Gardi
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/uf
From: Seungwon Jeon
'drivers/scsi/ufs/unipro.h' is added.
Attributes in the layers of the UNIPRO stack can be
read and written via the DME.
Signed-off-by: Seungwon Jeon
Reviewed-by: Subhash Jadavani
Tested-by: Yaniv Gardi
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/
at UPIU
has Sense Data in the Data Segment area.
Signed-off-by: Seungwon Jeon
Reviewed-by: Subhash Jadavani
Tested-by: Yaniv Gardi
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index bce09a6..7210500 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers
Signed-off-by: Santosh Y
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 86d7286..03ff4da 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -285,6 +285,18 @@ static inline int ufshcd_get_uic_cmd_result(struct ufs_hba
*hba
From: Seungwon Jeon
Setting PA_PWRMode using DME_SET triggers the power mode
change. And then the result will be given by the HCS.UPMCRS.
This operation should be done atomically.
Signed-off-by: Seungwon Jeon
Reviewed-by: Subhash Jadavani
Tested-by: Yaniv Gardi
Signed-off-by: Santosh Y
From: Seungwon Jeon
UIC attributes can be set with using DME_SET command for
power mode change. For configuration the link capability
attributes are used, which is updated after successful
link startup.
Signed-off-by: Seungwon Jeon
Reviewed-by: Subhash Jadavani
Signed-off-by: Santosh Y
diff
flush_work(&hba->eh_work);
> } while (1);
>
> hba->ufshcd_state = UFSHCD_STATE_RESET;
> --
> 1.7.0.4
>
>
Acked-by: Santosh Y
--
~Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
linux-...@vger.kernel.org is for UFS filesystem.
> The API for submitting a query request is ufs_query_request() in
> ufs_core.c. This function is responsible for:
This can be part of ufshcd.c which is actually the core file, no need
to create a new core file for the function.
> +
> +#define UFS
>
> This can be done inside the following if condition i.e. if
> (hba->query.descriptor != NULL).
> and change the condition to if (!hba->query.descriptor).
>
I meant to write if (hba->query.descriptor)...:-)
--
~Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU)
> + * @hba - UFS hba
> + * @lrb - pointer to local reference block
> + */
> +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb
> *lrbp)
> +{
> + u32 upiu_flags;
> + int ret = 0;
> +
> + if (!l
> -static inline void
> -ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd)
> +static int ufshcd_send_uic_command(struct ufs_hba *hba,
> + struct uic_command *uic_cmnd, int retries)
> {
> + int err = 0;
> + unsigned long flags;
> +
> + if (un
> +
> +/**
> + * ufshcd_validate_dev_connection() - Check device connection status
> + * @hba: per-adapter instance
> + *
> + * Send NOP OUT UPIU and wait for NOP IN response to check whether the
> + * device Transport Protocol (UTP) layer is ready after a reset.
> + * If the UTP layer at the devic
On Thu, May 2, 2013 at 10:45 AM, Seungwon Jeon wrote:
> On Tuesday, April 30, 2013, Sujit Reddy Thumma wrote:
>> On 4/30/2013 12:03 PM, Seungwon Jeon wrote:
>> > On Monday, April 29, 2013, Sujit Reddy Thumma wrote:
>> >> On 4/29/2013 3:54 PM, Seungwon Jeon wrote:
>> >>> On Monday, April 29, 2013,
> +/*
> + * drivers/scsi/ufs/ufs-attrs.h
> + *
> + * Copyright (C) 2013 Samsung Electronics Co., Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; eithe
On Thu, May 2, 2013 at 1:36 PM, Santosh Y wrote:
>> +/*
>> + * drivers/scsi/ufs/ufs-attrs.h
>> + *
>> + * Copyright (C) 2013 Samsung Electronics Co., Ltd.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under t
1 - 100 of 131 matches
Mail list logo
