[PATCH] drivers/scsi/53c7xx.c error handling and cleanup (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I hope I haven't missed any relevant lists :) ) The following patch makes drivers/scsi/53c7xx.c check the return code of request_region and release the irq properly in the error path. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/53c7xx.c Su

[PATCH] drivers/scsi/aha1740.c: check request_region return code (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I have not been able to determine a probable maintainer for this code.) The following patch makes drivers/scsi/aha1740.c use the return code of request_region instead of check_region. The change necessitated some changes to the folllowing error paths so I changed those to be forwards gotos.

[PATCH] general cleanup of drivers/scsi/NCR53c406a.c (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I hope you are the NCR53c406a maintainer. If not, I apologize for the inconvenience and hope you can redirect me.) The following patch makes drivers/scsi/NCR53c406a.c use the return code of request_region instead of check_region and makes it release the proper resources in its error paths.

[PATCH] drives/scsi/tmscsim.c: check_region -> request_region (241p9)

2001-01-23 Thread Rasmus Andersen
(Forgot to cc lk. If anyone have comments please cc [EMAIL PROTECTED] Thanks.) - Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> - Hi. The following patch makes drives/scsi/tmscsim.c use request_region instead of check_region+request_region. It applies cleanly agains

[PATCH] drivers/scsi/u14-35f.c: check_region -> request_region (241p9)

2001-01-23 Thread Rasmus Andersen
(Too fast again and forgot to cc the lists. If anyone replies to this mail, please cc [EMAIL PROTECTED] Thanks.) - Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> - Hi. The following patch makes drivers/scsi/u14-35f.c drop check_region in favour of checking the retur

[PATCH] drivers/scsi/aic7xxx.c: check_region -> request_region (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/aic7xxx.c use the return code of request_region instead of check_region. Since this touched a lot of error paths I converted them to forward gotos while I was there anyway. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/dri

[PATCH] make drivers/scsi/megaraid.c check ioremaps return code (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/megaraid.c check the return code of ioremap and converts the affected code paths to forward gotos error handling. It applies cleanly against ac10 and with a little fuzz against 241p9. Please comment. --- linux-ac10-clean/drivers/scsi/megaraid.cSat

[PATCH] drivers/scsi/inia100.c cleanup (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/inia100.c refrain from calling panic(), makes it check the return code of request_region and makes it release a lot of resources on error. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/inia100.c Sun Nov 1

[PATCH] drivers/scsi/fd_mcs.c cleanup (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I am guessing you as maintainer of this code. If you are not, I apologise.) The following patch makes drivers/scsi/fd_mcs.c use the return code of request_region instead of check_region. It also makes the driver release the irq on error. It applies cleanly against ac10 and 241p9. Comments?

[PATCH] drivers/scsi/cpqfcTSinit.c cleanup (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/cpqfcTSinit.c check the return code of ioremap, makes it use the return code of request_region instead of check_region and converts the touched code to use forward gotos on error paths. It applies cleanly against ac10 and 241p9. Comments? --- linux-

[PATCH] drivers/scsi/g_NCR5380.c: check_*_region -> request_*_region (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I have not been able to find a maintainer for this code.) The following patch makes drivers/scsi/g_NCR5380.c check the return code of request_region instead of using check_region. Ditto for request_mem_region. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/dri

[PATCH] make drivers/scsi/hosts.c check kmalloc return codes (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/hosts.c check kmalloc's return code, drops some gratitious zero initializations and makes it a little less panicky. It applies cleanly against ac10 and 241p9. Please comment. --- linux-ac10-clean/drivers/scsi/hosts.c Mon Oct 30 23:44:29 2000 ++

[PATCH] drivers/scsi/wd7000.c: check_region -> request_region (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/wd7000.c use request_region instead of check_region+request_region. It also drops a panic() and changes error paths to be forward gotos (in part necessary by the request_region change). It applies cleanly against ac10 and 241p9. Comments? --- linux-

Re: [PATCH] make drivers/scsi/megaraid.c check ioremaps return code (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:45:20AM +0100, Rasmus Andersen wrote: (This is another updated patch with the comments from the earlier mail still valid.) --- linux-ac10-clean/drivers/scsi/megaraid.cSat Jan 20 15:17:13 2001 +++ linux-ac10/drivers/scsi/megaraid.c Tue Jan 23 23:06:14 2001

Re: [PATCH] drivers/scsi/g_NCR5380.c: check_*_region -> request_*_region (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:40:26AM +0100, Rasmus Andersen wrote: (This is another updated patch with the comments from the earlier mail still valid.) --- linux-ac10-clean/drivers/scsi/g_NCR5380.c Sat Jan 20 15:17:13 2001 +++ linux-ac10/drivers/scsi/g_NCR5380.c Tue Jan 23 21:05:44 2001

Re: [PATCH] drivers/scsi/inia100.c cleanup (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:42:42AM +0100, Rasmus Andersen wrote: (This is another updated patch with the comments from my earlier mail still valid.) --- linux-ac10-clean/drivers/scsi/inia100.c Sun Nov 12 04:01:11 2000 +++ linux-ac10/drivers/scsi/inia100.c Tue Jan 23 21:23:47 2001

[PATCH] drivers/scsi/ips.c check_region -> request_region (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/ips.c use the return code of request_region instead of calling check_region. It also moves some resource freeing to ips_free since that made my error path cleaner. It applies cleanly against ac10 and 241p9. Please comment. --- linux-ac10-clean/driver

[PATCH] drivers/scsi/qla1280.c check_region -> request->region (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/qla1280.c use the return code of request_region instead of a call to check_region. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/qla1280.c Wed Dec 6 21:06:18 2000 +++ linux-ac10/drivers/scsi/qla1280.c Sa

[PATCH] drivers/scsi/qlogicfas.c: check_region -> request_region + cleanup (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. (I have not been able to find a probable maintainer for this code.) The follow patch makes drivers/scsi/qlogicfas.c use the return code from request_region instead of a call to check_region. It also adds a missing free_irq on an error path and makes us check the return from scsi_register. I

[PATCH] make drivers/scsi/qlogicfc.c check_region -> request_region + cleanup (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. (I am guessing you as the maintainer of this code. If you are not, I apologize for your inconvenience.) The following patch makes drivers/scsi/qlogicfc.c check the return code of scsi_register, adds a missing pci64_free_consistent on an error path and makes it use request_region exclusively

[PATCH] drivers/scsi/qlogicisp.c: return code from scsi_register (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. The following patch adds a check for scsi_register's return code to drivers/scsi/qlogicisp.c. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/qlogicisp.c Sat Jan 20 15:17:13 2001 +++ linux-ac10/drivers/scsi/qlogicisp.c Sat Jan 20 23:05:47 2001 @@ -6

Re: [PATCH] drivers/scsi/53c7xx.c error handling and cleanup (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:27:36AM +0100, Rasmus Andersen wrote: Hi again. I completely messed up a large part of the patches posted yesterday due to lack of sleep and being clinically braindead (the compile test was run in the wrong tree...). So I'll be posting some new patches that act

Re: [PATCH] general cleanup of drivers/scsi/NCR53c406a.c (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:29:54AM +0100, Rasmus Andersen wrote: (This is another updated patch with the comments from the earlier mail still valid.) --- linux-ac10-clean/drivers/scsi/NCR53c406a.c Mon Sep 18 22:36:24 2000 +++ linux-ac10/drivers/scsi/NCR53c406a.cTue Jan 23 21:09:09

Re: [PATCH] make drivers/scsi/AM53C974.c check scsi_register return (241p9)

2001-01-24 Thread Rasmus Andersen
On Wed, Jan 24, 2001 at 06:59:08AM -0800, rakesh rakesh wrote: > Hi, > > This really sounds good.And I think that this patch > should be applied to qla1280.c driver too.In addition > to the previous patch regarding request_region. > You are right. I must have missed that one in my trawling for

Re: [PATCH] make drivers/scsi/AM53C974.c check scsi_register return (241p9)

2001-01-25 Thread Rasmus Andersen
On Thu, Jan 25, 2001 at 11:15:50AM -0800, rakesh rakesh wrote: > I think it will be more appropriate to add a printk > statement,just to be more informative. You are right. Patch as follows: --- linux-ac11-clean/drivers/scsi/qla1280.c Wed Dec 6 21:06:18 2000 +++ linux-ac11/drivers/scsi/qla1

make drivers/scsi/seagate.c use ioremap instead of isa_{read,write} (242p4)

2001-02-20 Thread Rasmus Andersen
Hi. (I have not been able to find a probable current maintainer for this code.) The following patch makes drivers/scsi/seagate.c use ioremap instead of isa_{read, write} (I have not been able to find a fitting place to put an iounmap since the driver does not have a release function). The patch

[PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)

2001-02-25 Thread Rasmus Andersen
Hi. (Does anybody know who the maintainer for this code is?) The patch below moves drivers/scsi/g_NCR5380.c from using isa_{read, write, memcpy} to ioremap and the equivalent non-isa functions. It also fixes an 'unused variable' warning and exchanges check_region for request_region (and fixes a

Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)

2001-02-25 Thread Rasmus Andersen
On Sun, Feb 25, 2001 at 02:05:42PM +, Alan Cox wrote: [...] > > (An indication of how often this code path is used can be found in > > the fact that the previous define of NCR5380_write had its payload > > and address mixed up, probably making for wierd results should > > the code ever be exec

Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)

2001-02-25 Thread Rasmus Andersen
> > Im running PIO. However while I agree with that one Im dubious about the > inverts on the memcpy_*io bits > I am sorry but have I inverted the arguments to the memcpy_*io calls? Or are you referring to something other than the arguments here? -- Rasmus([EMAIL PROTECTED]) "Science

Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)

2001-02-25 Thread Rasmus Andersen
On Sun, Feb 25, 2001 at 02:46:15PM +, Alan Cox wrote: > > I am sorry but have I inverted the arguments to the memcpy_*io calls? > > Or are you referring to something other than the arguments here? > > You seem to have swapped the source/dest over in memcpy_toio cases and I need > to convince

Re: [NEW SCSI DRIVER] for 53c700 chip and NCR_D700 card against 2.4.4

2001-05-14 Thread Rasmus Andersen
Disclaimer: I know nothing of this device/hw, the scsi protocol or anything remotely applicable the functioning of this driver. The stuff below is just nit-picking and PITA-ing :) Pro-active kernel janitoring, if you like. On Sat, May 12, 2001 at 11:43:04AM -0500, James Bottomley wrote: [...] > +

[PATCH] add missing spin_unlock_irqrestore to qla1280.c (245ac1)

2001-05-27 Thread Rasmus Andersen
Hi. The following patch adds a missing spin_unlock_irqrestore to an exit path for qla1280.c as per the stanford team's report a while back. Applies against 245ac1. --- linux-251-ac1-clean/drivers/scsi/qla1280.c Sat May 19 21:00:13 2001 +++ linux-251-ac1/drivers/scsi/qla1280.cSun May 27

[PATCH] missing restore_flags in eata_dma.c (244ac18)

2001-05-27 Thread Rasmus Andersen
Hi. The following patch fixes an interrupt flag bug in eata_dma as per the stanford team's report from a way back. It applies against 244-ac18. --- linux-244-ac18-clean/drivers/scsi/eata_dma.cSat May 19 20:58:36 2001 +++ linux-244-ac18/drivers/scsi/eata_dma.c Sun May 27 00:19:57 2

[PATCH] kmalloc check in drivers/scsi/sr.c (245-ac16)

2001-06-23 Thread Rasmus Andersen
Hi. The following patch adds a check for the return code of kmalloc to get_capabilities() in drivers/scsi/sr.c. If this is not needed due to some cleverness I would like to be told so. It applies against 245-ac16 and 246p6. (This dereference was reported by the stanford team a while back.) ---

[PATCH] (revised) kmalloc check in drivers/scsi/sr.c (245-ac16)

2001-06-24 Thread Rasmus Andersen
Hi. I have been made aware of a slip-of-the-fingers wrt. brace placement in the patch I posted yesterday by Rogier Wolff. The patch below places the brace right. --- linux-245-ac16-clean/drivers/scsi/sr.c Thu Jun 21 21:26:18 2001 +++ linux-245-ac16/drivers/scsi/sr.cSat Jun 23 15:43:14

[PATCH] make gdth.c check scsi_allocate_device return code (246ac5)

2001-07-19 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/gdth.c check the return code of scsi_allocate_device(). It applies against 246ac5 and was raised in a posting from the Stanford team a while ago. --- linux-246-ac5-clean/drivers/scsi/gdth.c Wed Jun 20 20:19:02 2001 +++ linux-246-ac5/drivers/scsi/gd

[PATCH] make gdth_proc.c check scsi_allocate_device return code (246ac5)

2001-07-19 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/gdth_proc.c check the return code of scsi_allocate_device(). It applies against 246ac5 and was raised in a posting from the Stanford team a while ago. --- linux-246-ac5-clean/drivers/scsi/gdth_proc.cSun May 20 02:43:06 2001 +++ linux-246-ac5