Regression in v4.6-rc due to SCSI multipath change

2016-05-03 Thread Paul Mackerras
Current upstream kernels fail to boot on my POWER8 server with multipath SCSI disks and IPR host bus adapters. What happens is that the system finds each disk twice (as normal) and then prints messages like this: [2.827761] sd 1:2:4:0: alua: supports implicit TPGS [2.827875] sd 1:2:4:0: a

[PATCH] scsi: Make scsi_vpd_lun_id() able to use T10 vendor ID based designators

2016-05-04 Thread Paul Mackerras
t alua can only be used on disks for which scsi_vpd_lun_id() can produce an identifying string. Signed-off-by: Paul Mackerras --- drivers/scsi/scsi_lib.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 8106515..f4f69

Re: [PATCH] scsi: Make scsi_vpd_lun_id() able to use T10 vendor ID based designators

2016-05-04 Thread Paul Mackerras
On Wed, May 04, 2016 at 12:04:16PM +0200, Hannes Reinecke wrote: > On 05/04/2016 08:58 AM, Paul Mackerras wrote: > > This adds code to scsi_vpd_lun_id() to enable it to use T10 vendor ID > > based designators. This is needed to allow alua to work on disks that > > don'

Re: [PATCH] scsi: Make scsi_vpd_lun_id() able to use T10 vendor ID based designators

2016-05-05 Thread Paul Mackerras
On Thu, May 05, 2016 at 10:01:13AM +0200, Hannes Reinecke wrote: > On 05/05/2016 05:50 AM, Paul Mackerras wrote: > > On Wed, May 04, 2016 at 12:04:16PM +0200, Hannes Reinecke wrote: ... > >> Nearly. > >> The thing is, a T-10 vendor specific ID is _supposed_ to be a

Re: [PATCH] scsi_lib: Decode T-10 vendor IDs

2016-05-08 Thread Paul Mackerras
On Fri, May 06, 2016 at 10:35:07AM +0200, Hannes Reinecke wrote: > Some arrays / HBAs will only present T-10 vendor IDs, so we > should be decoding them, too. > > Suggested-by: Paul Mackerras > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_lib.c | 16 +

Re: [PATCH] scsi_dh_alua: do not fail for unknown VPD identification

2016-05-08 Thread Paul Mackerras
vice handler to each devices. > > Reported-by: Paul Mackerras > Signed-off-by: Hannes Reinecke Tested-by: Paul Mackerras -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Bugs in multipath scsi in 4.3-rc2

2015-09-25 Thread Paul Mackerras
I recently tried v4.3-rc2 on a test machine I have which is a POWER8 server with multipath SCSI disks. It failed to boot because it didn't find its disks. Two things were evident in the logs: first, we're hitting a WARN_ON_ONCE in the module code: [1.953020] WARNING: at /home/paulus/kernel/k

[PATCH] scsi_dh: Use the correct module name when loading device handler

2015-09-25 Thread Paul Mackerras
) to prepend "scsi_dh_" to the name, just like the old code in drivers/md/dm-mpath.c:parse_hw_handler() used to do. Fixes: 566079c849cf Signed-off-by: Paul Mackerras --- drivers/scsi/scsi_dh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_dh.c b/

Re: Bugs in multipath scsi in 4.3-rc2

2015-09-30 Thread Paul Mackerras
On Wed, Sep 30, 2015 at 05:14:49PM +0200, Christoph Hellwig wrote: > > Paul, can you try the trivial one liner below? > > diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c > index edb044a..fbc9502 100644 > --- a/drivers/scsi/scsi_dh.c > +++ b/drivers/scsi/scsi_dh.c > @@ -391,7 +391,7 @

Re: Bugs in multipath scsi in 4.3-rc2

2015-10-07 Thread Paul Mackerras
On Fri, Oct 02, 2015 at 02:52:24PM +0200, Christoph Hellwig wrote: > On Thu, Oct 01, 2015 at 02:34:54PM +1000, Paul Mackerras wrote: > > I still get the warning: > > Ok, I sent you the wrong patch. scsi_dh_add_device is the function that > needs to switch to use __scsi_dh_lo

Re: [patch 0/6] PS3 Storage Drivers for 2.6.23, take 4

2007-07-10 Thread Paul Mackerras
Jens Axboe writes: > I have no objections to the block bits, however I feel uneasy merging > the full patchset unless patch #1 has been acked by the platform person. I have the first 3 patches in my queue, so yes I've acked it. It's probably easiest if the remaining 3 go through my queue once th

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Paul Mackerras
Andy Whitcroft writes: > Ok, this is something we need to decide on. Currently we only ask for > consistent spacing on all the mathematic operators. This is mostly as > we do see a large number of non-spaced uses in defines and the like. > > I am happy to expand these tests so they are always s

[PATCH v3] Fix ibmvscsi client for multiplatform iSeries+pSeries kernel

2007-09-21 Thread Paul Mackerras
f-by: David Woodhouse <[EMAIL PROTECTED]> Acked by: Brian King <[EMAIL PROTECTED]> Signed-off-by: Paul Mackerras <[EMAIL PROTECTED]> --- This is being submitted for inclusion in 2.6.24. --- diff --git a/drivers/scsi/ibmvscsi/rpa_vscsi.c b/drivers/scsi/ibmvscsi/rpa_vscsi.c index

Re: [PATCH v3] Fix ibmvscsi client for multiplatform iSeries+pSeries kernel

2007-09-25 Thread Paul Mackerras
James Bottomley writes: > On Mon, 2007-09-24 at 08:34 -0500, Brian King wrote: > > Paul, > > > > It looks like there is a bunch of unrelated arch powerpc bits at the end > > of this patch. Oops... blush. > It's actually a whole email at the bottom ... don't worry; I stripped > it. Several ema

Recent kernels fail to boot on POWER8 with multipath SCSI

2018-03-29 Thread Paul Mackerras
Since commit 8d47e65948dd ("dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks", 2018-03-05), upstream kernels fail to boot on my POWER8 box which has multipath SCSI disks. The host adapters are IPR and the userspace is CentOS 7. Before that commit, the system booted fine. Af

Re: [PATCH 7/9] mac53c94: remove DISABLE_CLUSTERING

2018-12-06 Thread Paul Mackerras
On Thu, Dec 06, 2018 at 07:52:56AM -0800, Christoph Hellwig wrote: > mac53c94 has no limitations on crossing pages for segments. Just make > the 65535 byte segment size limit explicit, even if it matches the > current block layer limit. > > Signed-off-by: Christoph Hellwig

Re: [PATCH 6/9] mesh: remove DISABLE_CLUSTERING

2018-12-06 Thread Paul Mackerras
On Thu, Dec 06, 2018 at 07:52:55AM -0800, Christoph Hellwig wrote: > mesh has no limitations on crossing pages for segments. Just make > the 65535 byte segment size limit explicit, even if it matches the > current block layer limit. > > Signed-off-by: Christoph Hellwig