On Fri, Oct 21, 2016 at 05:43:35PM +0530, Kashyap Desai wrote:
> Hi -
>
> I found below conversation and it is on the same line as I wanted some
> input from mailing list.
>
> http://marc.info/?l=linux-kernel&m=147569860526197&w=2
>
> I can do testing on any WIP item as Omar mentioned in above d
On Mon, Oct 24, 2016 at 06:35:01PM +0530, Kashyap Desai wrote:
> >
> > On Fri, Oct 21, 2016 at 05:43:35PM +0530, Kashyap Desai wrote:
> > > Hi -
> > >
> > > I found below conversation and it is on the same line as I wanted some
> > > input from mailing list.
> > >
> > > http://marc.info/?l=linux-ke
On Tue, Oct 25, 2016 at 12:24:24AM +0530, Kashyap Desai wrote:
> > -Original Message-
> > From: Omar Sandoval [mailto:osan...@osandov.com]
> > Sent: Monday, October 24, 2016 9:11 PM
> > To: Kashyap Desai
> > Cc: linux-scsi@vger.kernel.org; linux-ker...@
From: Omar Sandoval
Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
specific values. No functional change.
Signed-off-by: Omar Sandoval
---
Hi, Jens,
Some more trivial cleanup, feel free to apply or not if it's too intrusive.
drivers/nvme/host/core.c | 4 ++-
From: Omar Sandoval
Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
specific values. No functional change.
Signed-off-by: Omar Sandoval
---
drivers/nvme/host/core.c | 4 ++--
drivers/nvme/host/pci.c| 8
drivers/nvme/host/rdma.c | 2 +-
drivers/nvme/t
From: Omar Sandoval
Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
specific values. No functional change.
Signed-off-by: Omar Sandoval
---
drivers/scsi/scsi_lib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/dr
for the quick reproducer script [2]. This patch survives
> > where an unmodified kernel fails in a few seconds.
> >
> > [1]: https://marc.info/?l=linux-scsi&m=147116857810716&w=4
> > [2]: http://marc.info/?l=linux-block&m=148554717109098&w=2
> >
>
t; device_add_disk(), and unregister the bdi, blk_cleanup_queue().
>
> Thanks to Omar for the quick reproducer script [2]. This patch survives
> where an unmodified kernel fails in a few seconds.
>
> [1]: https://marc.info/?l=linux-scsi&m=147116857810716&w=4
> [2]: http://m
Hi, everyone,
As per $SUBJECT, I can cause a crash on v4.10-rc8, Jens' block/for-next,
and Jan's bdi branch [1] by doing this:
# lsscsi
[0:0:0:0]diskQEMU QEMU HARDDISK2.5+ /dev/sda
# echo 0:0:0:0 > /sys/bus/scsi/drivers/sd/unbind
# echo 0:0:0:0 > /sys/bus/scsi/drivers/sd/bind
Th
On Fri, Feb 17, 2017 at 04:43:56PM -0800, James Bottomley wrote:
> This seems to be related to a 0day test we got on the block tree,
> details here:
>
> http://marc.info/?t=14862406881
>
> I root caused the above to something not being released when it should
> be, so it looks like you have t
I'm seeing this while testing on Linus' current master:
[ 427.814466] WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:149
__handle_irq_event_percpu+0x187/0x190
[ 427.832552] irq 116 handler _base_interrupt+0x0/0x9e0 [mpt3sas] enabled
interrupts
I tracked it down to commit 669f044170d8 ("scsi: s
On Wed, Mar 01, 2017 at 01:07:12AM +, Bart Van Assche wrote:
> On Tue, 2017-02-28 at 16:25 -0800, Omar Sandoval wrote:
> > I'm seeing this while testing on Linus' current master:
> >
> > [ 427.814466] WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:149
>
:
>
> _base_interrupt()
> -> _base_async_event()
>-> mpt3sas_scsih_event_callback()
> -> _scsih_check_topo_delete_events()
> -> _scsih_block_io_to_children_attached_directly()
> -> _scsih_block_io_device()
>-> _scsih_internal_device_bl
On Wed, Mar 01, 2017 at 05:09:48PM +, Bart Van Assche wrote:
> On Wed, 2017-03-01 at 09:04 -0800, Omar Sandoval wrote:
> > Thanks, Bart, you can add
> >
> > Tested-by: Omar Sandoval
>
> Hello Omar,
>
> Have you been able to test both code paths - scsi-
On Wed, Feb 13, 2019 at 10:11:14AM -0800, Bart Van Assche wrote:
> On Wed, 2019-02-06 at 05:21 +, Chaitanya Kulkarni wrote:
> > For storage track, we would like to propose a session dedicated to
> > blktests. It is a great
> > opportunity for the storage developers to gather and have a discuss
On Wed, Feb 13, 2019 at 10:54:04AM -0800, Bart Van Assche wrote:
> On Wed, 2019-02-13 at 10:43 -0800, Omar Sandoval wrote:
> > On Wed, Feb 13, 2019 at 10:11:14AM -0800, Bart Van Assche wrote:
> > > - Is it acceptable that patches get accepted in the blktests repository
> &
d/soft lockup, which is easily done with blk_mq, so not necessary
> to reinvent wheels for solving the problem.
>
> [2] https://marc.info/?t=15160185141&r=1&w=2
>
> Sovling the above issues for non-MQ path may not be easy, or introduce
> unnecessary work, especially
the performance
> data is provided, no obvious performance loss is observed when the whole
> hw queue depth is same.
>
> Cc: Hannes Reinecke
> Cc: Arun Easi
> Cc: Omar Sandoval ,
> Cc: "Martin K. Petersen" ,
> Cc: James Bottomley ,
> Cc: Christoph Hellwig ,
>
; Reviewed-by: Hannes Reinecke
Assuming it builds :)
Reviewed-by: Omar Sandoval
> Cc: Mike Snitzer
> Cc: Christoph Hellwig
> Signed-off-by: Ming Lei
> ---
> block/bfq-iosched.c| 4 ++--
> block/blk-mq-debugfs.c | 10 +-
> block/blk-mq-tag.c | 48 +
--name=nullb0 --filename=/dev/nullb0 --name=nullb1 --filename=/dev/nullb1
> --name=nullb2 --filename=/dev/nullb2 --name=nullb3 --filename=/dev/nullb3
>
> 1M IOPS can be reached in both above tests which is done in one VM.
>
> Cc: Arun Easi
> Cc: Omar Sandoval ,
> Cc: &quo
On Fri, May 19, 2017 at 03:55:28PM +0200, Johannes Thumshirn wrote:
> Add a test group for the SCSI generic driver and one syzcaller
> reproducer for this group.
>
> The reprodcuer is distributed as a C program, so the makefile is
> amended to build C files to be used in the test.
>
> Changes to
On Thu, Jul 06, 2017 at 02:09:21PM +0200, Johannes Thumshirn wrote:
> Add a regression test for the patch titled "scsi: sg: fix
> SG_DXFER_FROM_DEV transfers" which reassembles the syscalls done by Nero
> Burning ROM to discover CD and DVD burners.
Fixed up a few things below and applied, thanks!
On Wed, Aug 09, 2017 at 12:50:05PM +0200, Hannes Reinecke wrote:
> Add a test group for tests of the SCSI midlayer.
>
> Signed-off-by: Hannes Reinecke
> ---
> tests/scsi/group | 26 ++
> 1 file changed, 26 insertions(+)
> create mode 100644 tests/scsi/group
>
> diff --g
On Wed, Aug 09, 2017 at 12:50:06PM +0200, Hannes Reinecke wrote:
> SCSI device blacklisting seems to be a tricky subject, with
> lots of potential for messing up the selection algorithm.
> This adds a test for catching regressions here.
I'm waiting to see how the patches end up before applying thi
On Sun, Sep 09, 2018 at 10:03:35AM +0200, Klaus Kusche wrote:
>
> Hello,
>
> Which subsystem could be responsible for
>
> https://bugzilla.kernel.org/show_bug.cgi?id=200857
>
> ("4.18 regression: /proc/diskstats: I/O busy time not updated correctly")?
>
> This is for AHCI SATA disks (/dev/sda,
On Wed, Oct 31, 2018 at 11:59:01AM -0600, Jens Axboe wrote:
> Cc: linux-scsi@vger.kernel.org
> Acked-by: Himanshu Madhani
> Reviewed-by: Hannes Reinecke
> Signed-off-by: Jens Axboe
A bunch of really trivial nitpicks below, only to prove that I read the
thing ;)
Reviewed-by: O
179 +-
> include/linux/bsg-lib.h|6 +-
> include/linux/elevator.h | 90 +-
> include/linux/ide.h| 13 +-
> include/linux/init.h |1 -
> include/scsi/scsi_host.h | 18 +-
> include/scsi/scsi_tcq.h| 14 +-
> init/do_mounts_initrd.c|3 -
> init/initramfs.c |6 -
> init/main.c| 12 -
> 77 files changed, 837 insertions(+), 10733 deletions(-)
Beautiful. For the series:
Reviewed-by: Omar Sandoval
On Wed, Oct 31, 2018 at 11:59:13AM -0600, Jens Axboe wrote:
> This removes a bunch of core and elevator related code. On the core
> front, we remove anything related to queue running, draining,
> initialization, plugging, and congestions. We also kill anything
> related to request allocation, mergi
On Wed, Mar 08, 2017 at 05:48:30PM +0100, Jan Kara wrote:
> Hi!
>
> patches in this series fix the most urgent bugs that were introduced by commit
> 165a5e22fafb "block: Move bdi_unregister() to del_gendisk()" and by
> 0dba1314d4f8 "scsi, block: fix duplicate bdi name registration crashes".
> In f
On Wed, Mar 08, 2017 at 08:50:51AM -0800, Omar Sandoval wrote:
> On Wed, Mar 08, 2017 at 05:48:30PM +0100, Jan Kara wrote:
> > Hi!
> >
> > patches in this series fix the most urgent bugs that were introduced by
> > commit
> > 165a5e22fafb "block: Move bdi
On Tue, Apr 04, 2017 at 02:07:43PM +0200, Hannes Reinecke wrote:
> Hi all,
>
> as discussed recently most existing HBAs have a host-wide tagset which
> does not map easily onto the per-queue tagset model of block mq.
> This patchset implements a flag BLK_MQ_F_GLOBAL_TAGS for block-mq, which
> enab
On Mon, Apr 24, 2017 at 07:19:50PM -0400, Martin K. Petersen wrote:
>
> Bart,
>
> > SCSI tracing has to be enabled before a test is started, produces a
> > huge amount of data, and deriving state information from a huge trace
> > is far from easy. The information in debugfs provides an easy to re
meaningful number. For the sake of this not getting
bike-shedded to death,
Reviewed-by: Omar Sandoval
> Signed-off-by: Bart Van Assche
> Cc: Martin K. Petersen
> Cc: James Bottomley
> Cc: Omar Sandoval
> Cc: Hannes Reinecke
> Cc:
> ---
> drivers/scsi/Ma
On Thu, May 18, 2017 at 02:13:07PM +0200, Johannes Thumshirn wrote:
> Add a test group for tests of the SCSI generic driver and and
> functions common to the SCSI generic driver and it's test cases.
>
> Signed-off-by: Johannes Thumshirn
> ---
> common/sg | 22 ++
> tests
On Thu, May 18, 2017 at 02:13:08PM +0200, Johannes Thumshirn wrote:
> Add a regression test for commit 48ae8484e9fc ("scsi: sg: don't return
> bogus Sg_requests"). This is a general protection fault triggered by
> syzcaller.
>
> Signed-off-by: Johannes Thumshirn
> ---
> tests/sg/001 | 48 +++
On Thu, May 18, 2017 at 02:06:20PM -0700, Omar Sandoval wrote:
> On Thu, May 18, 2017 at 02:13:07PM +0200, Johannes Thumshirn wrote:
> > Add a test group for tests of the SCSI generic driver and and
> > functions common to the SCSI generic driver and it's test cases.
&g
On Thu, May 18, 2017 at 03:29:45PM +0200, Johannes Thumshirn wrote:
> On 05/18/2017 03:19 PM, Christoph Hellwig wrote:
> > All SG_IO test should also apply to block device nodes that support
> > the ioctl..
> >
>
> But these are not necessarily SG_IO tests, are they?
>
> The test included is doe
On Fri, May 19, 2017 at 03:55:31PM +0200, Johannes Thumshirn wrote:
> Add a regression test for commit 48ae8484e9fc ("scsi: sg: don't return
> bogus Sg_requests"). This is a general protection fault triggered by
> syzcaller via issuing bogus read(2)s on the /dev/sg devices.
>
> Signed-off-by: Joha
On Tue, Apr 17, 2018 at 11:03:37AM +0200, Steffen Maier wrote:
> Signed-off-by: Steffen Maier
> ---
> tests/scsi/004 | 59
>
> tests/scsi/004.out |3 ++
> 2 files changed, 62 insertions(+), 0 deletions(-)
> create mode 100755 tests/
On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote:
> Thanks for the test! Applied.
Side note, it's unfortunate that this test takes 180 seconds to run only
because we have to wait for the command timeout. We should be able to
export request_queue->rq_timeout writeable in s
On Thu, Apr 19, 2018 at 01:44:41PM -0600, Jens Axboe wrote:
> On 4/19/18 1:41 PM, Bart Van Assche wrote:
> > On Thu, 2018-04-19 at 12:13 -0700, Omar Sandoval wrote:
> >> On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote:
> >>> Thanks for the test! Appl
On Mon, Apr 23, 2018 at 02:25:03PM +0200, Steffen Maier wrote:
>
> On 04/19/2018 10:18 PM, Omar Sandoval wrote:
> > On Thu, Apr 19, 2018 at 01:44:41PM -0600, Jens Axboe wrote:
> >> On 4/19/18 1:41 PM, Bart Van Assche wrote:
> >>> On Thu, 2018-04-19 at 12:13 -070
On Wed, Dec 13, 2017 at 01:29:39AM -0800, Omar Sandoval wrote:
> On Tue, Aug 15, 2017 at 11:00:49PM -0700, Omar Sandoval wrote:
> > On Wed, Aug 09, 2017 at 12:50:06PM +0200, Hannes Reinecke wrote:
> > > SCSI device blacklisting seems to be a tricky subject, with
> > > lo
, ...) when mq-deadline/kyber
> is used by not taking requests if hw queue is busy.
>
> Reviewed-by: Bart Van Assche
> Reviewed-by: Christoph Hellwig
Reviewed-by: Omar Sandoval
> Signed-off-by: Ming Lei
> ---
> block/blk-mq-sched.c | 12 ++--
> 1 file changed, 6
On Mon, Oct 09, 2017 at 07:24:22PM +0800, Ming Lei wrote:
> We need to iterate ctx starting from any ctx in round robin
> way, so introduce this helper.
>
> Cc: Omar Sandoval
Reviewed-by: Omar Sandoval
> Signed-off-by: Ming Lei
> ---
> include
.
This still didn't address Jens' concern about using q->queue_depth as
the heuristic for whether to do the full sw queue flush or one-by-one
dispatch. The EWMA approach is a bit too complex for now, can you please
try the heuristic of whether the driver ever returned BLK_STS_RESOURCE?
ake sure that request isn't dequeued until ->dispatch is
> flushed.
>
> Reviewed-by: Bart Van Assche
> Reviewed-by: Christoph Hellwig
I think this will do for now.
Reviewed-by: Omar Sandoval
> Signed-off-by: Ming Lei
> ---
&
On Tue, Aug 15, 2017 at 11:00:49PM -0700, Omar Sandoval wrote:
> On Wed, Aug 09, 2017 at 12:50:06PM +0200, Hannes Reinecke wrote:
> > SCSI device blacklisting seems to be a tricky subject, with
> > lots of potential for messing up the selection algorithm.
> > This add
48 matches
Mail list logo
