Re: [PATCH 01/15] block: rework flush sequencing for blk-mq

2014-02-05 Thread Muthu Kumar
On Wed, Feb 5, 2014 at 4:41 AM, Christoph Hellwig wrote: > Switch to using a preallocated flush_rq for blk-mq similar to what's done > with the old request path. This allows us to set up the request properly > with a tag from the actually allowed range and ->rq_disk as needed by > some drivers.

Re: [PATCH 02/15] blk-mq: support at_head inserations for blk_execute_rq

2014-02-05 Thread Muthu Kumar
> diff --git a/block/blk-mq.h b/block/blk-mq.h > index b771080..88a2366 100644 > --- a/block/blk-mq.h > +++ b/block/blk-mq.h > @@ -30,6 +30,8 @@ void blk_mq_init_flush(struct request_queue *q); > void blk_mq_drain_queue(struct request_queue *q); > void blk_mq_free_queue(struct request_queue *q);

Re: [PATCH 02/15] blk-mq: support at_head inserations for blk_execute_rq

2014-02-06 Thread Muthu Kumar
On Thu, Feb 6, 2014 at 8:17 AM, Christoph Hellwig wrote: > On Wed, Feb 05, 2014 at 06:27:38PM -0800, Muthu Kumar wrote: >> Currently its not used by any drivers. Are we sure we don't need it >> public? If sure, please remove the EXPORT_SYMBOL() for it. > > Drivers sh

Re: loading scsi_debug with data integrity hits BUG_ON

2014-02-24 Thread Muthu Kumar
NAB, On Thu, Feb 20, 2014 at 11:28 AM, Nicholas A. Bellinger wrote: > On Thu, 2014-02-20 at 14:16 -0500, Martin K. Petersen wrote: >> > "nab" == Nicholas A Bellinger writes: >> >> nab> Given that there is no (easy) way to ascertain what the original >> nab> value of bio_integrity->bip_iter.b

Re: loading scsi_debug with data integrity hits BUG_ON

2014-02-24 Thread Muthu Kumar
yep... silly me ;) On Mon, Feb 24, 2014 at 2:37 PM, Jens Axboe wrote: > On 2014-02-24 14:15, Muthu Kumar wrote: >> >> NAB, >> >> On Thu, Feb 20, 2014 at 11:28 AM, Nicholas A. Bellinger >> wrote: >>> >>> On Thu, 2014-02-20 at 14:16 -0500,

[RFC] SCSI: drivers: Remove unnecessary assignment of scsi_done in driver queuecommand

2012-07-08 Thread Muthu Kumar
[ CCing signed-off, acked-by of original patch - let me know if anyone else needs to be added ] Jeff, James, In the following commit: -- commit f281233d3eba15fb225d21ae2e228fd4553d824a Author: Jeff Garzik Date: Tue Nov 16 02:10:29 2010 -0500 SCSI host lock push-down - que