[PATCH] qla2xxx: Get mutex lock before checking optrom_state

functions to get the mutex_lock before checking ha->optrom_state to avoid similar crashes. The patch was applied and tested and same crashes were no longer observed again. Tested-by: Milan P. Gandhi Signed-off-by: Milan P. Gandhi --- drivers/scsi/qla2xxx/qla_attr.c | 18

[PATCH] Minor fix for comment section

Corrected a small alignment issue with comment. Signed-off-by: Milan P. Gandhi --- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index 17d42658ad9a..9bd41b5fc279 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b

[PATCH] Fix for a small typo

Signed-off-by: Milan P. Gandhi --- drivers/scsi/qla2xxx/qla_bsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index 17d42658ad9a..f2b95f11a71c 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi

Re: [PATCH] Fix for a small typo

On 3/12/19 4:46 PM, Dan Carpenter wrote: > 1) Subject > 2) No patch description. (What type did you fix?) > 3) CC list. > Hi Dan, Julia, Thanks for pointing it out. Let me fix it quickly. regards, Milan.

[PATCH] Fix few small typos in fcoe.c

This patch does a cleanup and fixes few small typos in fcoe.c Signed-off-by: Milan P. Gandhi --- drivers/scsi/fcoe/fcoe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 90939f6..7b960d3 100644 --- a/drivers

[PATCH] Remove an extra out label in _fcoe_create function

This patch removes an extra out label in _fcoe_create function where we return if creation of FCOE interface is failed. Signed-off-by: Milan P. Gandhi --- drivers/scsi/fcoe/fcoe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi

[PATCH] Eliminate extra 'out_free' label from fcoe_init function

Simplify the check for return code of fcoe_if_init routine in fcoe_init function such that we could eliminate need for extra 'out_free' label. Signed-off-by: Milan P. Gandhi --- drivers/scsi/fcoe/fcoe.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/dr

Re: [PATCH] Eliminate extra 'out_free' label from fcoe_init function

On 06/01/2017 08:32 PM, Dan Carpenter wrote: > On Thu, Jun 01, 2017 at 05:41:06PM +0530, Milan P. Gandhi wrote: >> Simplify the check for return code of fcoe_if_init routine >> in fcoe_init function such that we could eliminate need for >> extra 'out_free' labe

Re: [PATCH] Eliminate extra 'out_free' label from fcoe_init function

On 06/02/2017 11:19 AM, Julia Lawall wrote: > > > On Fri, 2 Jun 2017, Milan P. Gandhi wrote: > >> On 06/01/2017 08:32 PM, Dan Carpenter wrote: >>> On Thu, Jun 01, 2017 at 05:41:06PM +0530, Milan P. Gandhi wrote: >>>> Simplify the check for return code of

[PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function

Simplify the check for return code of fcoe_if_init routine in fcoe_init function such that we could eliminate need for extra 'out_free' label and duplicate mutex_unlock statement. Signed-off-by: Milan P. Gandhi --- drivers/scsi/fcoe/fcoe.c | 7 +++ 1 file changed, 3 insert

Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function

On 06/03/2017 08:04 AM, Dan Carpenter wrote: > I'm fine with this version... > > regards, > dan carpenter > Thanks everyone for the review and suggestions!! Regards, Milan.

[PATCH] Remove white spaces from fcoe.h

Remove the white spaces in do/while loop used for checking fcoe debug logging Signed-off-by: Milan P. Gandhi --- drivers/scsi/fcoe/fcoe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fcoe/fcoe.h b/drivers/scsi/fcoe/fcoe.h index 6aa4820..7406376 100644 --- a

Re: [PATCH] Remove white spaces from fcoe.h

On 06/05/2017 02:48 PM, Julia Lawall wrote: > > > On Mon, 5 Jun 2017, Milan P. Gandhi wrote: > >> Remove the white spaces in do/while loop used for checking fcoe >> debug logging > > Is it converting spaces to tabs? If so, saying that would be clearer. yeah, i

[PATCH] Fix few small typos in lpfc_scsi.c

This patch does a cleanup and fixes few small typos in lpfc_scsi.c Signed-off-by: Milan P. Gandhi --- drivers/scsi/lpfc/lpfc_scsi.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index

[PATCH] Remove extra goto label from nvmet_ns_enable

initializes ret variable to 0, so there is no need to again initialize it to 0 before out_unlock, hence removing it. Signed-off-by: Milan P. Gandhi --- drivers/nvme/target/core.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/nvme/target/core.c b/drivers

[PATCH] Simplify nvmet_init to remove extra out label

The out label at end could easily be removed by returning an error upon receiving non-zero error return code from nvmet_init_discovery. This would avoid need for 2nd out label. Signed-off-by: Milan P. Gandhi --- drivers/nvme/target/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

Re: [PATCH] Simplify nvmet_init to remove extra out label

Thank you Johannes, I will send it on linux-n...@lists.infradead.org On Thu, Aug 09, 2018 at 01:51:18PM +0200, Johannes Thumshirn wrote: > please send this patch to the correct mailing list > (linux-n...@lists.infradead.org) > > -- > Johannes Thumshirn St